admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-11-03 18:47:54 +09:00
Code Issues Packages Projects Releases Wiki Activity
14,135 Commits 61 Branches 85 Tags
5dcda9f6701ac759ef6c4dfdcf1870469b3e9976
Commit Graph
86 Commits
Author SHA1 Message Date
TheWitness 1aa72d24c9 QA: Update Copyright to 2024 2024-02-03 14:18:57 -05:00
TheWitness fe9f8caa4a Fixing #5434 - Data Source Debug Lingers 
When deleting a single Data Source the table data_debug is not purged
 2023-10-14 18:13:19 -04:00
TheWitness e1bdb612a0 Issue #4811 - Update for Device, Graph and Data Source Removal 
These are untested, but should follow the rules.
 2023-10-14 17:51:22 -04:00
TheWitness 08499d1d7a Fixing #5460 - Duplicate Data Template errors 
When duplicating a Data Template errors can appear in the Cacti log
 2023-08-19 20:20:12 -04:00
TheWitness 90d4dc9605 QA: Invalid variable name 2023-08-19 15:26:29 -04:00
TheWitness a48f32a2fc QA: Move data_input API functions to lib/data_source.php 2023-08-19 09:49:57 -04:00
TheWitness 8bb868f920 QA: Related to #5447 - Duplicating Device Templates 
Moving one function into lib/api_data_source.php and making sure it returns either false of the new data_input_method.
 2023-08-14 21:29:06 -04:00
TheWitness 4a6fa95cb4 Fixing #5446 - Duplication Return Value 
Duplication functions for Graph/Template and Data Source/Template do not return an id
 2023-08-12 07:40:02 -04:00
TheWitness 03ebbadb6d Fixing #5215 - Caching Data Source Statics Commands 
Saving on CPU cycles and Database I/O for every DSStats pass.
 2023-04-02 16:46:36 -04:00
Mark Brugnoli-Vinten 32ba2f19f4 Update copyright year for 2023 2023-01-03 20:34:26 +00:00
Mark Brugnoli-Vinten 8b29d12cc9 Define cacti system paths as constants for better code checking (#5120) 
This also provides a full run of src-fixer against all files to
ensure all code is now in alignment.

Closes #5120
 2023-01-01 01:03:15 +00:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code 
* Some insances in the vendor directory have not been handled to maintain pedigree.
 2020-10-21 08:27:42 -04:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
ddb4github dfc6b64595 Fixed: Resolved some PHP NOTICE about undefined variables #2650 (#2651) 
* Fixed: Resolved some PHP NOTICE about undefined variables.

* Fixd previous fixing. Should add 'global $l10n' only

* Fixed: typo miss '$'

* Minor change
 2019-04-27 21:26:17 +06:00
cigamit 88aafbd43c Resolving Issue #2547 
Trailing spaces: Complaining about Max values in RRD without reason
 2019-03-23 19:41:31 -05:00
cigamit 6e5549b368 Resolving Issue #2499 
Data Source reapply names does not update name from data query or template
 2019-03-12 22:21:19 -05:00
cigamit 4ad7ef22d3 Add Tracing for #2364 2019-02-10 02:33:16 -06:00
cigamit e34d4aff73 Resolving Issue #2362 
No way to default an interface speed when ifSpeed and ifHighSpeed come
back as zero
 2019-02-04 20:35:26 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit 88b13570d6 Debug stats not removed when Data Source is removed 2018-12-17 20:55:54 -06:00
cigamit cbf6f818cd Resolving Issue #2173 
- Resolving issue 3) of the issues as best as can be done.
-Additionally, making the graph_template_id multiselect common for all
pages and resolving additional QA issues in all areas that were impacted
by multiselect issues.
- Lastly, resolving issues in Reports that cause excessive queries and a
bad user experience.
- There will be likely one more commit on this bug as more QA needs to
be performend on Data Source orphan API introduced.
 2018-11-21 13:49:08 -06:00
cigamit 44dc17d73f Related to issue #2070 Change Device for Data Sources 2018-10-14 14:50:34 -05:00
cigamit 6366577687 More testing on enable/disable data source 2018-10-14 14:31:29 -05:00
cigamit b1ceea271b Code cleanup relatedd to issue #2070 
The code before had lot's of duplicate sql calls and would result in a
higher probability of bugs.
 2018-10-14 07:13:20 -05:00
cigamit 52a6048852 Make Travis Happy & Resolve Issue #2070 2018-10-13 21:06:36 -05:00
cigamit e4e8e4cf07 More resolution to Issue #2070 
The only thing left is to ensure that automation is run when you are
running re-index from the main Cacti web site.  Also, to determine how
automation should run in batch mode since the re-indexing is not
preforming this in the background on the remote data collectors.
 2018-10-13 17:26:51 -05:00
cigamit d8966bbf9f The db_close() function is causing errors 2018-10-13 14:11:16 -05:00
cigamit 10248cd012 The variable $cnn_id is dangerous due to legacy behavior 2018-10-13 13:54:33 -05:00
cigamit 5c7a3fbb2f Resolving Issues #2068 and #2058 
- [1.2.0 Beta 1] When saving, modifying, removing devices and graphs,
sync this data automatically
- [1.2.0 Beta 1] New CLI Script remove_device.php Orphans Graphs and
Data Sources
 2018-10-13 13:36:22 -05:00
cigamit fbdbcaef29 Resolving Issue #2042 and #1981 
This should fix the issues.  Consolidated logic here as well as the
graph and data source suggested names were using different code paths
 2018-10-10 03:32:59 -05:00
cigamit 0b991958fd Resolving Issue #1982 
Certain hooks should occur within api functions rather than UI functions
 2018-09-28 04:49:59 -05:00
cigamit cfe111d83f Minor query cleanup as a result of audit 2018-09-28 04:26:39 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922) 
* Resolving issue #1920

* Minor QA issue
 2018-09-14 20:59:52 -05:00
cigamit 1012537828 feature: Make Graph and Data Source suggested naming more efficient 2018-01-21 11:28:03 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Patrick 4bc2f4c0bc Various updates (#1073) 
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
 2017-11-11 05:45:12 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038) 
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
 2017-10-16 11:32:05 -04:00
cigamit e51c54ee59 Alter format for readability. No changes 2017-06-11 18:08:48 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
patrick cc1cc7eab2 PHP7.2 changes: 
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
 2017-04-15 18:00:13 +02:00
cigamit 7074043d8f Resolving #125 
https://github.com/Cacti/cacti/issues/125
 2017-01-02 15:29:55 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 7269cbfd88 Committing prototype of replication api for team review 
Part of multiple polling is to support either MySQL replication, or to
replicate tables requred for remote data collection.  These changes will
enable the later method, but are not complete.

The replicate_tables in lib/poller.php function is designed to handle
each of the table replecation types.  When complete, it will handle all
table replication based upon poller state.

There may be additional table schema changes to increase performance,
but those changes have not been validated yet.
 2016-12-19 21:44:34 -06:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote 
this is required for preparation of magic_quotes_gpc.
 2016-08-28 15:27:48 -05:00
Micke2k a637b7f709 Attempt at fixing rebuild poller cache sql error 
Throws an sql error. Replace into cannot take a where statement.

05/13/2016 10:18:41 PM - CMDPHP SQL Backtrace: (/utilities.php: 38 repopulate_poller_cache)(/lib/utility.php: 53 api_data_source_cache_crc_update)(/lib/api_data_source.php: 31 db_execute_prepared)(/lib/database.php: 158 cacti_debug_backtrace)
05/13/2016 10:18:41 PM - CMDPHP ERROR: A DB Exec Failed!, Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE name='data_source_cache_crc_0'' at line 1
05/13/2016 10:18:41 PM - CMDPHP ERROR: A DB Exec Failed!, Error:1064, SQL:"REPLACE INTO settings SET value = ? WHERE name='data_source_cache_crc_0''
 2016-05-13 22:28:15 +04:00
cigamit 3a1416e2f5 restructuring lib/utility.php adding mysql recommendations to install 2016-05-11 19:52:50 -05:00
cigamit db89bdc185 add crc functions to inform remote pollers of changes 2016-05-10 21:30:42 -05:00
cigamit fbfc426318 double to single quotes and prepared statements 2016-03-20 10:48:49 -05:00