Commit Graph
391 Commits
Author SHA1 Message Date
Thomas VincentandTheWitness d2dcf29446 fix: extend remote_agent_timeout dropdown to 30 and 60 seconds (#6661)
* fix: extend remote_agent_timeout dropdown to 30 and 60 seconds

Large environments with slow remote pollers or heavy reindex
operations can exceed the current 20-second maximum. The default
remains 5 seconds; this only adds options for sites that need them.

Ref #6545

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix: add changelog entry for #6545 and fix array bracket indentation

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2026-02-26 20:01:56 -05:00
TheWitness 7919efd137 Issues found in testing (#6595)
* QA: Add database session clear out to change password

* QA: Can not determine average fully loaded

* QA: Synchornize Spikekill with 1.2.x

* Removing Variance as it's not mathmatically correct

* Removing Variance as it's not mathmatically correct

* Properly re-draw graph
2026-02-03 12:02:39 -05:00
TheWitness 27919c50d7 Updating Copyrights to 2026 (#6578) 2026-01-28 16:11:10 -05:00
TheWitnessandCopilot b993471579 Fix #6539 - Allow Standard Cacti Log Files to be Rotated on Demand,PHPdoc, and Typing (#6540)
* Fix #6539 - Allow Standard Cacti Log Files to be Rotated on Demand from the Cacti UI

* QA: php-cs-fixer updates and documentation for lib/database.php

* QA: Update .gitignore for composer files

* QA: Update .gitignore for composer files

* QA: Back off .gitignore change its duplicated

* QA: Fix typing of db_has_permissions

* QA: Fixing typing issue in db_format_index_create

* Update lib/clog_webapi.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* QA: Fix additional code issues

* QA: Applying more defaults to add device

* QA: Fix at the database layer

* QA: Fixes based upon automated testing

* QA: Fix at the database layer

* QA: After new SQL checking

* QA: Skip MacTrack oui database download warnings

* QA: Fixing type issue

* QA: Recommendation from Copilot

* QA: Recommendation from Copilot

* QA: Recommendation from Copilot

* QA: Recommendation from Copilot

* QA: Some minor changes to avoid errors in testing

* QA: Unused variable

* QA: Recommendation from Copilot

* QA: Recommendation from Copilot

* QA: Recommendation from Copilot

* QA: Minor introduced code defect

* QA: Adding some unifying space around concatination

* QA: Consistent comments and new function alias'

* QA: Multi-line comment corrections

* QA: Fix SQL Style

* QA: Missed one function alias

* QA: PHPStan Level 2 and PHPDoc fixes

* QA: PHPStan Level 2 and PHPDoc Fixes

* QA: PHPStan Level 6 Fixes

* QA: Fix lib/xml.php to PHPStan Level 6

* QA: Wrong grep -v

* PHPStan Level 6 for lib/vdef.php

* PHPStan Level 8 for lib/time.php

* QA: Raise PHPStan to Level 6 for lib/database.php

* QA: Remove @deprecated tag from grv()

* QA: Switch to htmle() alias over html_escape()

* QA: More addressing PHPStan issues at Level 6

* QA: Change recommended by Copilot for Readability

* QA: More PHPStan fixes

* QA: More PHPStan fixes

* QA: More PHPStan fixes for lib/utility.php

* QA: More PHPStan fixes at Level 6

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: More PHPStan fixes at Level 6

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: More PHPStan fixes at Level 6

* QA: More PHPStan fixes at Level 6

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: More PHPStan fixes at Level 6

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: More PHPStan fixes at Level 6

* QA: Raise PHPStan to Level 6 More Functions

* QA: Raise PHPStan to Level 6 More Functions

* QA: More PHPStan fixes at Level 6

* QA: More PHPStan fixes at Level 6

* QA: More PHPStan fixes at Level 6

* QA: Raise PHPStan to Level 6 More Functions

* QA: More PHPStan fixes at Level 6

* QA: Some phpseclib3 fixups to update to latest

* QA: More fixups for graphing for magic strings

* QA: More PHPStan fixes at Level 6

* QA: Fixing order string type on get_allowed_graphs()

* QA: Fixing improper use of print

* QA: Optimization of color_templates

* QA: Copilot recommendation

* QA: Copilot recommendation

* QA: Copilot recommendation

* QA: Copilot recommendation

* QA: Copilot recommendation

* QA: Copilot recommendation

* QA: Copilot recommendation

* QA: Copilot recommendation

* QA: Raise PHPStan to Level 6 More Functions

* QA: Issues insalling Cacti

* QA: Issues insalling Cacti

* QA: Issues insalling Cacti

* QA: Issues insalling Cacti

* QA: Issues insalling Cacti

* QA: Issues testing Cacti

* QA: Copilot recommendation

* QA: More PHPStan fixes at Level 6

* QA: More PHPStan fixes at Level 6

* QA: More PHPStan fixes at Level 6

* QA: More PHPStan fixes at Level 6

* QA: More PHPStan fixes at Level 6

* QA: Installer failing

* Undo ownership changes to remove tar errors

* QA: Updates after php-cs-fixer

* QA: Adding code checks to syntax checking

* QA Change syntax flow language

* QA: Reduce the number of cures

* QA: Use sequentional option

* Change runner to self-hosted for check job

* Fix typo in OS version in workflow file

* Add Git installation step in workflow

Added step to install Git if not already installed.

* Add '-y' flag to apt-get install and update commands

Updated apt-get commands to include '-y' for automatic confirmation.

* Change workflow OS version to 'ubuntu-latest'

Updated the workflow to use 'ubuntu-latest' instead of 'ubuntu:latest' and modified the 'runs-on' configuration.

* Remove sequential option from phpcsfixer script

* Remove PHPCS fixer step from workflow

Removed PHP coding standards check from workflow.

* Move code checks to before plugins

Moving these core checks to before the plugins are installed as we really want to check only the base Cacti here.

* Add Composer validation and caching to start of workflow

* QA: Addressing PHPStan additional

* QA: Restore composer lock file

* QA: Addressing PHPStan additional

* QA: Addressing PHPStan additional

* QA: Complete LDAP Project

* QA: php-cs-fixer doing it's thing

* QA: Syntax is already happening in PHPStan

* QA: The md5 function no longer exists

* QA: Update after ldap changes

* QA: Undo that last password hack

* QA: Attempting to switch to MariaDB 11.8

* QA: Attempting to switch to MariaDB 11.8

* QA: Resolving some issues with PHP8.4

* QA: Resolving some issues with PHP8.4

* QA: Add PHP8.5 to the matrix

* QA: Removing PHP8.5 due to dependency issues

* QA: Add the DB version to the testing output

* QA: Switch back to MySQL for the moment

* QA: More fidelity in reporting

* QA: The pipe must be mixed

* QA: Moving audit_schema.php changes from 1.2.x

* QA: Moving audit_schema.php changes from 1.2.x

* QA: Restore mysql monitoring

* QA: php-cs-fixer issues

* QA: Attempt to roll back to MariaDB 10.6

* QA: Attempt to fix check_all_pages.sh

* QA: Make installer functional again

* QA: Fix installer php-cs-fixer issues

* QA: Type to a string

* QA: Get the database version correctly

* QA: Fix issue with reports in check_all_pages.sh

* QA: Check the server version in the right place

* Feature: Support SHA256 as a new hash for passwords

* QA: Function definition and return typing audit

* QA: Refinement of form types

* QA: Refinement of form types

* QA: Consistency of comments

* QA: Issues with php-cs-fixer and more comments

* QA: More typing issues

* QA: php-cs-fixer on merge conflict resolution

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-01-25 10:13:56 -05:00
TheWitness b9334a15d9 QA: Updates for files for php-cs-fixer and some php-doc changes 2025-11-18 21:01:15 -05:00
TheWitness ea6d1b0c87 QA: Fix: #6258 - Rename 'Data' to 'Data/Statistics' 2025-06-15 15:23:56 -04:00
Petr Macek 359163ae0c OAuth2 - fix settings redirect_uri, it is empty after installation (#6205)
* fix URL, it is empty after installation

* update
2025-04-10 21:00:14 -04:00
TheWitness e5c4015e0e QA: Remove most references to $config
This removes most entries to $config in the base code.  A few new constants were defined to achieve this:

* CACTI_CONNECTION - The status of the current connection
* CACTI_CSRF_SECRET - The path to the csrf secret file
* CACTI_PHP_SNMP - True if php-snmp is installed
* CACTI_WHITELIST - The path to the Cacti Whitelist file if defined

I also moved several $config['poller_id'] to the existing POLLER_ID and move a number of $config['is_web'] to the existing CACTI_WEB constants.

There remain a few artifacts in the code.  They will be handled in a separate commit.
2025-03-22 16:48:59 -04:00
TheWitness 2c779273f9 Copyright Updates and PHP-CS-Fixer updates 2025-03-09 14:34:19 -04:00
Petr Macek e7af33b436 oauth2 completion (#6140)
* I got token, problem with send test message remains

* remove comments

* formatting
2025-03-03 19:34:42 -05:00
TheWitness e43e32321d QA: Merge changes from #6024 - Oauth2
* This merges @xmacan's changes and performs additional functions.
* Adds composer.json and composer.lock to include folder
* Places the flag-icons and phpmailer into that file
* Updates flag-icons and phpmailer to latest
* Adds the autoloader.php to global.php
2025-01-08 09:30:07 -05:00
TheWitness b98323c966 feature: Remove old Lotus Notes Attachment Types from Reports
* There is no longer a reason to have Lotus Notes Attachment Types
2025-01-05 14:01:26 -05:00
TheWitness 3fdde5b523 QA: Move Around Settings for Scheduler 2024-12-31 14:46:09 -05:00
TheWitness a3010e82d4 QA: More word smithing 2024-12-28 09:11:44 -05:00
TheWitness 4228961b47 QA: Runtime Limit Threshold Wordsmithing
* We only log in English by policy.
* Friendly Names use Title Case.
* Convert the poller_warning_1h_count to a drop_array.
* Add 'Disabled' for the 0 setting in the array.
2024-12-28 08:54:56 -05:00
TheWitness 26abeaae79 QA: #1773 - Light Redesign to Allow All Primary Admin Logins 2024-12-27 13:40:11 -05:00
TheWitness 877d8c13bf QA: Remove the _2 from the variable. It's confusing 2024-12-23 12:35:36 -05:00
TheWitness ee56a277c9 QA: Tree and Preview Filter default handling and callback
* Change the global default for preview rows per page
* Change the gathering function for the -1 value
* Change the save function for a -1 value
* Change the way button callbacks work
* Restore the 'Save' function for Tree View after Filter Class light re-design.
2024-12-23 08:22:46 -05:00
TheWitness 162f17bec5 QA: Fix: #5999 - Cookie lifetime and reasonable values
* Having a token lifetime less than a day is not a good thing.  Make the minimum time 1 day for the 2FA token.  Set the cookie correctly as well.
2024-12-22 09:44:46 -05:00
TheWitness aabe87b24f QA: Fix# 5992 - 2FA Settings Change 2024-12-22 09:23:30 -05:00
Linegod 43884a5be1 reword Account Email Notification 2024-12-14 15:41:49 -06:00
Linegod 9c01950787 typos 2024-12-14 11:18:31 -06:00
TheWitness a4d20c7f0e QA: Move around business hours color and opacity 2024-12-12 16:22:45 -05:00
TheWitness fe06476e74 Fix: #5971 - Show Unknown Data Globally
* Fixing the display of unknown data as a global setting
* Re-arrange some RRDtool options such as business hours to be more prominent in both global and user settings.
* Convert colors to drop-color objects
* Add Business Hours as a Checkbox on Graphs Pages
* Make a filter function for both Thumbnails and Business Hours
2024-12-11 21:37:51 -05:00
TheWitness 4cc779b26d QA: #5965 - More Package Defaults
* Defaults for replace_svalues, remove_orphans, and package_location
* Make trust signature work between repo and local files
* Move some functions into core import functions
* Accept trusted tokens from different sources
2024-12-11 15:51:52 -05:00
TheWitness abc419deb0 QA: Fix: #5980 - Wrong Tooltip Text 2024-12-11 09:13:47 -05:00
TheWitness b9e9bfe705 QA: Fix: #5972 - Due to empty snmp_options variable
* Resolved by adding debug logic to the installer.
2024-12-09 13:51:23 -05:00
Petr MacekandTheWitness feb19c6e7e Feat 5389 - When a new account is created or admin har reset password send email to user (#5956)
* setting for new emails

* feature 5389

* update

* add table for password reset hashes

* add new table for hashes

* changing to resetlink

* prepare for hashes

* preparing reset forms

* reset password done

* formatting

* add resetpassword utility

* Update global_settings.php

Making some wording changes.

* Update auth_resetpassword.php

Minor LPSR (Larry PSR)

* change reset link validity

* change hour->min

---------

Co-authored-by: TheWitness <thewitness@cacti.net>
2024-12-09 13:18:57 -05:00
TheWitness c201ab8520 Fix: #5965 - Add Relevant MetaData to Device Templates
* In support of the packaging plugin, we need to add some columns to the host_template table including:
  - version
  - author
  - email
  - copyright
  - tags
  - installation

We also create new General Settings for Default Author information.
2024-12-09 12:00:02 -05:00
TheWitness 0276ca0e0b Fix: #2429 - Device SNMP Options Templating
* Allow Device SNMP Options to be Templated
2024-12-05 21:53:09 -05:00
TheWitness 66a665fa69 Fix: #5959 - Debounce Poller Output Emails
* Debounce the Poller Output Not Empty Warning
2024-12-05 08:27:11 -05:00
TheWitness b60e1a9d01 QA on #5690 - Missed the default value 2024-12-03 15:25:32 -05:00
TheWitness c2e84a6f49 Fix: #5640 - Boost Logging Enhanements
* Boost log file visibility and rotation not as expected
* New Requirement is that the boost log must also be in the Cacti log file, error will be displayed otherwise.
* Also, the Boost Log path moved to the "Paths" section and what remains in the Boost section is a new toggle to Enable Boost Debug logging.
2024-12-03 15:23:00 -05:00
TheWitness 9f59d58f35 QA: Minor change to accommodate #2437
* Change the header to let people know this is where proxy settings below.
2024-11-28 10:05:37 -05:00
TheWitness 595777f04b Fix #2437 - Proxy Settings for Plugins
* This was already in the changelog, but I could not find the settings.  So, adding them now.
2024-11-28 09:53:41 -05:00
TheWitness 00ac4663dd QA: Add warning to tool tip for boost debug 2024-11-11 09:56:21 -05:00
TheWitness 330fbf62b8 QA: Title Case change and slight wording change 2024-11-11 09:51:19 -05:00
TheWitness cf9d3bca98 QA: #1987 - Setting for Unsafe Plugin Installs 2024-11-06 23:00:08 -05:00
TheWitness 0156fac22f Feature #1987 - Allowing for alternate repositories
More work on this feature.  Still have a long way to go.

* Feature: Allow alternate repositories and users
* Feature: Set the last published date as the pushed_at date for develop
* Feature: More logging.
* NOTE: The variable for the personal access token has changed
2024-11-02 11:24:17 -04:00
TheWitness 0aa28c852f QA: Allow storing of GitHub personal access tokens
* Going to use this for future plugin magic
2024-11-01 15:27:32 -04:00
TheWitness b85ce246f9 Fixing #5538: Reduce the number of automation log events
* Reduce the number of default log events from automation
2024-10-13 18:34:35 -04:00
TheWitness c1b2ba7f6b Fixing #5849 - Move logging to it's own settings tab
* Separate Logging related settings to a new settings tab
2024-10-13 16:45:39 -04:00
TheWitness 1aa72d24c9 QA: Update Copyright to 2024 2024-02-03 14:18:57 -05:00
Linegod 4041eb42af Sunady typo 2024-01-10 23:15:56 -06:00
Linegod f2d64b2075 typos 2023-11-30 22:29:13 -06:00
TheWitness ed69ff0abb QA: #5583 - Missed on file - adding more logging 2023-11-24 13:38:12 -05:00
Petr Macek 7850924e08 RRDChecker is started very often (#5570)
* RRDChecker is started very often

* update

* change format

* change format
2023-11-15 20:19:21 -05:00
TheWitness 6680c2a333 QA: Light capitalization issue 2023-11-12 21:31:57 -05:00
TheWitness b39a19f55c Fixing #5517 - Remember me in https only
1.3.0 QA: Cacti should issue warning when attempting to use remember me over http
2023-10-03 22:18:06 -04:00
TheWitness d395e6a9cf Fixing #5475 - Issue with ss_fping.php and PHP8 strict typing (#5477)
* QA: Broken Function

* QA: Two additional QA Items

- Do a check for IP address as dns_get_records() does not have a timeout and I don't use DNS
- Properly display information about MariaDB 11.

* Fixing #5475 - Ping Issues with Advanced Ping an PHP8

PHP 8.x error - Unsupported operand types: float + string

* QA: Fix two typos
2023-09-06 19:46:49 -04:00