admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-11-09 14:02:54 +09:00
Code Issues Packages Projects Releases Wiki Activity
7,203 Commits 81 Branches 85 Tags
7617cb700faeb9eeba5af2a85bd64141663304c5
Commit Graph
508 Commits
Author SHA1 Message Date
cigamit 190b8c4abd Audit of ping methods tcp, udp, and icmp. Better support for IPv6 
The udp and tcp ping method should start working for PHP 5.5.4+, but
this has not been confirmed yet.
 2017-08-26 09:56:29 -05:00
cigamit 7a63e0127c Correct undefined variable warning 2017-08-11 23:25:20 -05:00
cigamit 12cb7abc65 Resolving Issue #673 
Downtime/Recovery time/date is set incorrectly
 2017-08-09 10:15:30 -05:00
cigamit cc45ede3ef Resolving Issue #819 
Allow saving customized timespan for Graph page.  This functionality was
removed accidentally from Cacti 1.x.  For people who have upgraded
already, there is a function that finds what is the best timespan.  If
this is not acceptable, and the Data Source Profiles are Read only, you
may have to hand alter the tables to enter the 'preferred' Timespan.
 2017-08-05 15:41:09 -05:00
cigamit 63fd0feb24 Resolving Iissue #880 
Device drop down is limited to 20 devices and lacks a scroll bar
 2017-07-29 13:30:11 -05:00
Tomasz Chilinski e4073284ae allow to send single part plain text mails 
(cherry picked from commit 172485853e)
 2017-07-23 20:10:36 -04:00
cigamit b9f558a675 Add additional checks on Linux versions that avoid the use of True Type Font functions 2017-07-11 07:43:48 -05:00
cigamit f617c7121c Introduce new DATE_TIME_FORMAT constant resolving issue #829 
Addresses issues with 500 messages when in developer debug mode.  Also,
make certain that the navigation variables exist before using them.
 2017-06-29 17:37:32 -05:00
cigamit 5594afbdf9 Resolving Issue #779 2017-06-28 07:12:44 -05:00
patrick 90e1a468e8 issue: Fix date separator character 2017-06-14 17:45:44 +02:00
cigamit d155a03aee Resolve potential corner case around time in state and lack of snmp support. 2017-06-11 18:12:22 -05:00
cigamit 37a5a7791a Resolving Issue #779 
- Resolve randome apache segfault due to recursion.
- Also, remove additional references to export user
- Change the way the guest_account id is gathered.
- Change elseif format
- Remove trailing white-spaces
 2017-06-08 07:42:22 -05:00
Tony Roman e7174c4046 Fix issue#788 
- Fixed up invalid function call
 - Added default operator to cacti_version_compare function
 2017-06-04 23:24:43 -04:00
Tony Roman ca8c8cd123 Move cacti_version_compare into main functions lib to be used 
in non-install code
 2017-06-04 21:33:15 -04:00
cigamit 27f30f498f Resolve upgrade issues from Cacti 0.8.7 
If the plugin architecture does not exist, install will fail.  Also
found php function version_compare not working in PHP 5.3.x.

There were additionally issues with the upgrade functions as well.
Resolving those too.
 2017-06-04 19:56:52 -05:00
Patrick 031598f56b Fix for #757 2017-06-01 20:54:27 +02:00
Patrick ae9acfd0f9 CLOG Enhancements 
-Fixed CLOG paginator
-Fixed automatic page refresh
-Logfile writes rows with preferred timestamp
 2017-05-30 10:20:05 +02:00
patrick ef69094b5e CLOG Enhancements 
-feature: CLOG timestamp is now formatted as defined in settings
-feature: CLOG can show loginformation from rotated logfiles
-Added GDC_DOT to global_constants.php and global_arrays.php, and refactored the usage of global $datechar
 2017-05-29 13:44:31 +02:00
cigamit f6699ed23d feature: add function to obtain the current execution user 2017-05-23 07:52:05 -05:00
cigamit 622f180cb6 Resolving Issue #662 
Sending test Email should optionly bypass ping
 2017-05-17 22:44:58 -05:00
Jimmy Conner aea8ddc7bd Merge pull request #702 from reboot1983/strlen 
Cool stuff
 2017-05-17 22:13:11 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
Patrick 56e02d75f2 Optimisations 
- Optimisations of query calls and function calls in loops
- Removed unused function calls and variables
- Refactored large if statements into switch statements
- Applied early return
- Fixed alignments and removed unnecessary parentheses
 2017-05-16 11:33:23 +02:00
cigamit 1a14cbb440 Introduce new get_cacti_version function to reduce database calls on pages 2017-05-14 12:29:30 -05:00
cigamit 8a695b113c Resolving Issue #658 
Scheduled Reports (type "tree") not working.
 2017-05-14 11:15:11 -05:00
cigamit c862851b7e Optimizations around data input methods 
No functional changes
 2017-05-13 11:08:34 -05:00
Patrick 40baee32b0 Bugfix for issue#680 
- Fixed sorting; is now same as in data_source_profiles.php?action=edit
 2017-05-13 00:18:47 +02:00
cigamit 7f9a808e56 Resolving Issue #657 
Error in log when host is dow, using icmp ping and using cmd.php on
FreeBSD
 2017-05-07 16:50:10 -05:00
Patrick f435138f44 Merge remote-tracking branch 'upstream/develop' into CLOGFix_651_Unable_to_view_cacti_log 
# Conflicts:
#	install/upgrades/1_1_6.php
 2017-05-07 18:06:01 +02:00
Patrick 23c95d0808 - Feature#106 Paginated CLOG and log administration 
- Added missing docblock to new function
- Added configurable max_display_rows to settings panel
- Applied max_display_rows to code instead of MAX_DISPLAY_ROWS
- Removed define MAX_DISPLAY_ROWS
 2017-05-07 18:00:21 +02:00
Patrick c18e032b03 - Feature#106 Paginated CLOG and log administration 
- CLOG is now paginated
- System Utilities - Log administration is now paginated
- Bugfix in classic template paginator; when previous option appears, the paginator grows in height
 2017-05-07 13:48:18 +02:00
Jimmy Conner 4c676b95ba Merge pull request #660 from reboot1983/CLOGFix_651_Unable_to_view_cacti_log 
Fix for Issue#651: Unable to view cacti log (because of allowed memory size exhausted)
 2017-05-06 06:54:36 -05:00
Jimmy Conner faf9d84eee Merge pull request #648 from reboot1983/RRDOptimisations 
Thank goodness for weekends.  Okay, upon further review, perfect.
 2017-05-06 05:10:44 -05:00
Patrick 01ed0fc5bd Issue#651: Unable to view cacti log (because of allowed memory size exhausted) 
- Fixes memory usage; in the past the whole logfile would be read, now only the needed amount of rows
- Removed some unused variables
- Small optimisations in showing CLOG
 2017-05-06 12:05:13 +02:00
cigamit 0204a2b0bd issue: FILTER_VALIDATE_MAC not defined on PHP less than 5.5 
Causes cmd.php to throw errors.  Additionally, changing braketing style
for else, and elseif.
 2017-05-05 06:19:01 -05:00
cigamit 7e966b98cb Create new function to gather color hex values 2017-05-04 19:10:04 -05:00
patrick d000013aff RRD optimisations 
- Added missing globals
- Removed unused globals
- Optimised rrdtool_function_create()
 2017-05-02 10:20:20 +02:00
Tony Roman 27045ea52d Fixup install process to streamline releases 
- Added and moved code to CACTI_VERSION constant
 - Merged cacti versions and hash codes array to have one place to add versions
 - Moved cacti version to file to facitate automation needs
 - Cleaned up cli database upgrade script
 2017-05-01 08:58:29 -04:00
cigamit a6eb1c735e wc3 Validation on select files 2017-04-30 19:28:09 -05:00
Patrick b154c3e89e Optimisations for tree view 
lib/auth.php:
- is_device_allowed()
  - removed unused parameter $user
- get_allowed_tree_level()
  - removed unused parameter $user
- get_allowed_tree_content()
  - removed unused paramters $sql_where, $order_by, $limit, $total_rows and $user
  - refactored the code to apply for these unused parameters
- get_allowed_tree_header_graphs()
  - removed unused parameters $order_by, $limit, $total_rows and $user
  - refactored the code to apply for these unused parameters
- get_allowed_trees()
  - removed unused parameters $edit, $sql_where, $limit, $total_rows and $user
  - refactored the code to apply for these unused parameters

lib/functions.php:
- removed get_graph_tree_array() because it's unused after refactor

lib/html_tree.php
- draw_dhtml_tree_level():
  - removed unused parameter $graphing
  - removed unused global $config
- create_dhtml_tree()
  - removed unused global $config
  - refactored get_graph_tree_array() to alias: get_allowed_trees()

auth_profile.php:
  - refactored get_graph_tree_array(true) to alias: get_allowed_trees(true)
 2017-04-28 18:16:46 +02:00
Patrick 11d801cbfa HTML Fix: 
-issue#592: Incorrectly formatted HTML
 2017-04-25 09:51:22 +02:00
cigamit 49e83d7fa1 Resolving Issued #580, #606, #608, #609 
- Data collection warnings when using cmd.php
- Replace <path_php_binary> in data input methods
- Spaces adjacent to double quotes are eliminated durate data input
method import
- Horor the column setting in graph tree view mode
 2017-04-24 20:40:05 -05:00
cigamit 53c91d7173 Resolving Issue #604 
Don't show the regex errors when validating.
 2017-04-23 08:18:16 -05:00
cigamit b28f44a9d9 Add escaping to filter values prior to request. 
Handles the sepecial case of a pound sign causing issues.
 2017-04-23 07:35:01 -05:00
Jimmy Conner 6c689b5f95 Merge pull request #597 from reboot1983/Optimisations 
Optimisations
 2017-04-22 08:58:16 -05:00
cigamit e2243f62d2 feature: Make Cacti more tolerant of empty PHP_SELF on some web servers 2017-04-22 08:22:01 -05:00
Patrick 2424f6ddb8 Merge remote-tracking branch 'upstream/develop' into Optimisations 
# Conflicts:
#	host.php
 2017-04-22 12:26:55 +02:00
Patrick 7386d2296b Small optimisations for poller 2017-04-22 11:18:00 +02:00
cigamit 6b8b210173 Resolving Issue #524 
Reporting not working when Tree branch is device
 2017-04-21 21:34:24 -05:00
Jimmy Conner c97f2b133d Merge pull request #578 from reboot1983/PHP7.2_compatibility_fixes 
Great work!
 2017-04-18 07:51:18 -05:00