Commit Graph
136 Commits
Author SHA1 Message Date
cigamit 8dd622e5f9 Resolving Issue #2680
PHP 7.2 supporting to remove deprecated $php_errormsg
2019-05-11 09:13:36 -05:00
cigamit 9de596b953 -issue: Multiple sort not working properly using functions and not reseting 2019-02-27 19:53:47 -06:00
cigamit d30c63ba73 Minor format cleanup 2019-01-26 08:26:17 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit d7e22b5bbd -issue: Don not display form hint icon if there is no hint 2019-01-12 13:31:31 -06:00
ddb4github 18959d855c Fixed: #2297 (#2300)
Optimize nav bar display method.
2019-01-11 09:46:17 +00:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit 017d0cf35f Resolving Issue #1953 and Update Changelog for #454
Cacti Re-Index does not resolve index changes properly during re-index
2018-10-11 17:28:32 -05:00
cigamit a45f33ce5f Resolving Issue #2052
[1.2.0 Beta 1] Issue with Realtime on new login
2018-10-11 06:51:26 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
Mark Brugnoli-Vinten ef7a318ef1 Feature #1692 - Separate option for logging Input Validation issues (#1696)
* Feature #1692 - Separate option for logging Input Validation issues

This commit adds a separate option for feature #1692 to enable logging Input Validation issues even when developer mode is turned off

* Finalise renaming of developer_mode to log_validation for cleaner understanding

* Remove log_validation from legacy location
2018-07-21 11:44:06 -04:00
Mark Brugnoli-Vinten cab3863f2b PR for issues #1282 and #1700 (#1701)
* PR for issues Â#1282 and #1700

This pull request adds additional functionality for #1282 allowing network discovery to email upon completion and also corrects issues found during #1700 with unauthenticated mail causing errors to appear.

* Fix settings QA issue
2018-07-14 10:49:15 -05:00
cigamit 35d9d3df75 More uQueryUI classes and form QA 2018-05-09 21:59:08 -05:00
Mark Brugnoli-Vinten ae18fe7736 Fix for Issue #1537: Numeric validation not ignoring blank elements (#1538)
* Issue #1537: Numeric validation not ignoring blank elements

* Fix second instance of numeric_list issue
2018-04-14 06:40:37 -05:00
cigamit 0730ce3873 Add additional escaping #1457
These discoveries were made during testing.
2018-03-18 09:02:03 -05:00
cigamit e9df31502e Resolving Issue #1386
form_selectable_cell() ignores width if no style_or_class is passed
2018-02-21 19:37:59 -06:00
cigamit c2216f3ff3 Resolving Issue #1339
First graph of page change does not render.
2018-02-14 07:10:17 -06:00
netniV 6039e847fc Fix for Issue #1256 / #1268 - RFILTER and display corrections (#1269)
* Fix for Issue #1256 and #1268
This patch fixes issues with both the display of the error messages and with RFILTER variables not properly being primed as discussed on issue #1256 and issue #1268

* Update CHANGELOG

* Fix issue number
2018-01-26 17:56:24 -07:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit c7c432bb94 Resolving Issue #1161
Graph View regex's are not preserved during automatic page refresh
2018-01-02 19:24:37 -06:00
Tony Roman f3673b4686 New Graph pagenation and filter reset 2017-11-22 12:32:48 -05:00
Patrick 928ae7de82 Various updates (#1075)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations

* fixed parameter typo in query_debug_timer_stop()

* fixed typo $_SESSION

* MibCache->install() uses MibParser->oids, but MibCache->oids has protected access instead of public

* Updated of PHPMailer to version 5.2.26
- Minor security backport from 6.0 - set Debugoutput in constructor according to SAPI in use, avoiding potential XSS in default debug output. Thanks to Bankde Eakasit for spotting it.

* Remove old autoLoad method
2017-11-12 09:39:55 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Patrick 4617c60a02 Various updates (#1016)
* Updated Dutch translations
- 1007 translations remaining (70% translated)
- Typo fixes

* Fix for #1005

* Schema changes
- Examined queries without key usage and added/changed some keys

* Fixed some missing i18n
2017-10-07 13:05:12 -04:00
cigamit fd97229824 Minor alignment issue on some tables 2017-08-28 07:30:41 -05:00
cigamit 84015d917b Resolving Multiple Issues - Remember to clear your browser cache
-issue#920: Issue with scrollbars after update to 1.1.19 related to #902
-issue#921: Tree Mode no longer expands to accomodate full tree item
names
-issue#929: Overlapping frames on certain themes
2017-08-26 07:10:09 -05:00
cigamit 166950b95e issue: Design of Sunrise requires all checkboxes have their css updated, and include labels. 2017-08-06 14:20:05 -05:00
cigamit 49143d2d99 issue: Address additional corner cases around get_order_string usage
These result in SQL errors from time to time.
2017-07-25 17:13:02 -05:00
cigamit 98365400d1 Additional testing on get_order_string() function changes 2017-07-22 13:00:45 -05:00
cigamit a1b06f3ac6 Additional testing with get_order_string() function change 2017-07-22 12:58:57 -05:00
cigamit e5ae07708b issue: The function get_order_string() can fail when encountering reserved word columns 2017-07-22 12:56:19 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit 3237fb14e2 Resolving Issue #800
Unchecked loop in lib/html_utility.php causing race condition.
2017-06-07 18:23:53 -05:00
cigamit 27f30f498f Resolve upgrade issues from Cacti 0.8.7
If the plugin architecture does not exist, install will fail.  Also
found php function version_compare not working in PHP 5.3.x.

There were additionally issues with the upgrade functions as well.
Resolving those too.
2017-06-04 19:56:52 -05:00
patrick 99af12b411 Selected and Not Selected are now being translated 2017-05-20 22:11:18 +02:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit 58e0fb19a2 Add ability to prune the order string based upon a column 2017-05-03 21:14:27 -05:00
cigamit 494eb5bf60 More responsive work
1) Make forms responsive.  Work on mobile
2) Add a new header option to not hide specific columns
3) Resize textareas and text during resize to match window size
4) Change the responsive viewport media size for going responve
5) Make classic more responvie
6) Hide tabs fully in responive mode: todo: Generalized Elipsis
2017-04-29 16:06:10 -05:00
patrick 1ca2ec43bf Removed unnecessary lines en applied some small optimisation and layout changes 2017-04-28 22:43:02 +02:00
cigamit 53c91d7173 Resolving Issue #604
Don't show the regex errors when validating.
2017-04-23 08:18:16 -05:00
cigamit b28f44a9d9 Add escaping to filter values prior to request.
Handles the sepecial case of a pound sign causing issues.
2017-04-23 07:35:01 -05:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
patrick d3012868fe More optimisations:
auth.php:
- get_auth_realms() small refactor
- is_graph_allowed() unused variable $graph and unnecessary if-statement
- auth_check_perms() one count of $objects instead of multiple
- is_device_allowed()unused variable $host and unnecessary if-statement
- is_graph_template_allowed()unused variable $template and unnecessary if-statement
- is_view_allowed() unnecessary if-statement

html_tree.php:
- 2x query refactor for use of index reference instead use of function
- deleted unused select statement

html_utility.php:
- isset_request_var() unnecessary if-statement
2017-04-03 20:57:36 +02:00
cigamit 8f59393862 Taking the unfilted values since its only an index 2017-03-18 13:31:55 -05:00
cigamit d720d2bcd6 Minor update to multiple sort logic 2017-03-17 20:55:06 -05:00
cigamit f22c9694e4 Add multiple column sort and glyph API's
Convert all core pages to use multiple column sort.  There may still be
some pages around automation that are required to be migrated.  However,
they will continue to operate as is.
2017-03-17 17:19:03 -05:00
cigamit 9d5a486657 Atempt to resolve issue #190 2017-01-10 17:59:43 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit e564351c2d Resolving https://github.com/Cacti/cacti/issues/100 2016-12-28 08:24:44 -06:00