Commit Graph
199 Commits
Author SHA1 Message Date
cigamit b87747c38b Resolving Issue #2839
Non regular expression search filters don't support international characters
2019-07-24 18:05:17 -05:00
cigamit 00d47b4e45 Resolving a number of validation errors 2019-05-22 17:39:34 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 9ff093d92f - right align the type for readability 2019-01-18 18:04:21 -06:00
cigamit efc061578c More "No XXX Found" format issues 2019-01-12 10:26:25 -06:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
netniV a96f06067b Resolving issue #2138 2018-11-01 09:05:32 +00:00
cigamit f18860f3cd Alphabetize includes add missing lib/poller.php where applicable
This is required for properly having data follow devices, graphs, and
data sources on change.
2018-10-13 13:03:22 -05:00
cigamit 44190227f4 Resolving Issue #1926
This is easy enough.  Not a major change actually.
Some line ending fixes as well
2018-09-24 20:52:19 -05:00
cigamit 3f2076ee51 Missed cacti_count(*) in SQL 2018-09-23 15:43:06 -05:00
Mark Brugnoli-Vinten c011c0154c QA Language Corrections (#1960)
* QA Language Corrections

* Updated POT files/script
2018-09-22 04:07:12 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
cigamit ee60aa600a Resolving Issue #614
Duplicate Data Input Methods
2018-08-19 21:36:10 -05:00
cigamit e1e59ce125 Resolving Issue #1184
Improve Data Input Methods editability and message handling
2018-08-06 19:56:08 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit 6a854437dc Resolving Issue #1561
If someone has not enabled whitelisting, don't generate warnings.
2018-04-23 07:32:25 -05:00
cigamit 96f62fe610 Resolve Issue #1527
Update Fontawesome from 4.7 to 5.0.10
2018-04-22 09:24:27 -05:00
cigamit a705f9d80b Resolving Issue #1539
Web Crawler found undefined index
2018-04-14 06:43:24 -05:00
cigamit a36eaf7e3b Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-03-04 14:24:35 -06:00
cigamit dc05a57dfb Resolving Issue #1432
- Delete confirmation does not disappear
- Some additional format changes for readability
2018-03-04 09:08:44 -06:00
netniV 436394f54a Feature: Adds automatic select of next input field and duplication warning (#1433)
* feature#1422: Automatically select the next unused data input field when clicking add on data input method

* Reverting the custom_error component.

The function display_output_messages() now deals with a message that is not an array.
2018-03-03 13:06:05 -06:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 8b5d789213 Resolve issues with messaging
- Discovered in QA
- Secpass password verification does not return meaningful error
messages
- Missing some i18n in login verification process
- Return missing function
- Correct customer error message instances to new display output
- Minor audit of functions for readability
2018-02-24 23:25:57 -06:00
cigamit 10a8e523f7 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	cacti.sql
#	data_sources.php
#	docs/CHANGELOG
#	graphs.php
#	host.php
2018-01-26 19:31:47 -06:00
netniV 6039e847fc Fix for Issue #1256 / #1268 - RFILTER and display corrections (#1269)
* Fix for Issue #1256 and #1268
This patch fixes issues with both the display of the error messages and with RFILTER variables not properly being primed as discussed on issue #1256 and issue #1268

* Update CHANGELOG

* Fix issue number
2018-01-26 17:56:24 -07:00
cigamit 5fada91ed4 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-19 07:59:03 -06:00
netniV 4a73589301 Issue #1217 Allow drill down to non-system data_input's from data_template (#1218)
issue#1217 - Allow drill down to non-system data_input's from data_template
2018-01-16 07:39:57 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 14be99a33b Final fix for Issue #1072
This commit adds a new function to validate input string from the hash
value.  Should resolve the last outstanding issue.
2017-12-02 12:16:27 -06:00
Tony Roman af4f440ec9 Update input whitelisting to require defining configuration variable 2017-11-22 07:58:41 -05:00
Tony Roman 59e8199101 Update data input whitelist feature 2017-11-21 20:35:44 -05:00
cigamit 365730d442 Resolving Issue #1072
Correcting CVE-2009-4112.  This CVE correction will provide some level
of protection to Cacti when unauthorized changes are made to a Data
Input Method.
2017-11-21 17:16:34 -06:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
cigamit 7020f4ffbb Resolving Issue #1045
Issues with confirmation dialogs.
Also adding spurious html_escape() function over the use of
htmlspecialchars()
2017-10-26 21:52:53 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 30bbf226f5 More changes for issue #861
Filters not working properly for i18n
2017-07-20 18:55:33 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit f850e57629 Freshed core filter html
In preparation for responsive filters phase II
2017-07-05 17:13:10 -05:00
cigamit 16a758d7fe issue: Remove Field Order on Data Input output data as it's not required 2017-07-02 13:21:10 -05:00
cigamit 10e292f276 Resolving Issue #728
Resolve issues with jQueryUI empty dialogs
2017-05-27 08:20:08 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
cigamit 8480d98621 Don't generate warnins when saving data input methods. 2017-05-13 11:09:08 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit a00c967b2c wc3 Validation fixes
This is ajust about everything.  Deprecated removed.  There are still
some warnings that are unresolved due to the movement to div based
forms, but they are soft warnings.
2017-04-30 21:01:10 -05:00
cigamit ff125d01cb Update all pages to include div based forms
This requires a CSS change which is going to be committed next and
separately to call out the changes required there.
2017-04-30 13:15:58 -05:00
cigamit b28f44a9d9 Add escaping to filter values prior to request.
Handles the sepecial case of a pound sign causing issues.
2017-04-23 07:35:01 -05:00
patrick d2185c98b1 PHP7.2 changes:
- Replaced deprecated each() for foreach()
2017-04-21 22:12:55 +02:00
cigamit b9ab5994a2 Adjust number format, add hyperlinks, use standardized titles 2017-03-26 09:37:31 -05:00