Commit Graph
1829 Commits
Author SHA1 Message Date
cigamit 112c7494da Update audit information for 1.2.2 2019-02-23 16:23:30 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit daee354bad Resolving Issue #2281
Database audit cli giving incorrect results
2019-01-12 16:12:19 -06:00
Tony Roman 4ddd5ae745 Add Support Menu Item
- Add external link support in menu (probably need more work)
 - Added Support -> Documentation menu item
 - Added Support -> Users Community menu item
 - Made documentation loading dynamic, if release documentation is
   not included it will redirect to Github documenation
2018-10-01 00:34:04 -04:00
Tony Roman eda4404f27 Moving to documentation to documentation repository 2018-09-09 16:10:43 -04:00
Tony Roman cc3726842c Move Changelog to more appropriate location 2018-09-02 10:20:56 -04:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
cigamit a0c1080634 Resolving Issue #1852
Reports Preview/Mails show no graphs
2018-08-30 07:15:26 -05:00
cigamit 36387fd92f Small feature enhancement
Don't allow removal of Data Sources from Data Template once its in use
2018-08-26 14:34:03 -05:00
cigamit ee60aa600a Resolving Issue #614
Duplicate Data Input Methods
2018-08-19 21:36:10 -05:00
cigamit d800ac2595 Resolving Issue #948
Every time when creating new graph Cacti creates new datasource
2018-08-19 20:57:22 -05:00
cigamit 5eee727f78 Resolving Issue #553
Aggregated graph does not belong to host
2018-08-19 20:13:34 -05:00
cigamit ccdc937d72 Allow adding a Non-Existing Data Source to an Existing Graph when the Template is Updated 2018-08-19 19:22:22 -05:00
cigamit 4870172951 Resolving Issue #1671
Duplicate Graph Template does not duplicate Data Query Graph Template
Mappings
2018-08-19 18:37:08 -05:00
cigamit 632cdf7115 Resolving Issue #1849
SNMPAgent not sending traps
2018-08-19 13:40:01 -05:00
cigamit 874130296f feature: Allow drill down from Graphs to Data Queries or Templates
Includes massive performance improvement when opening Data Query Graph
Mappings
2018-08-18 14:43:28 -05:00
cigamit 4db6d4638b Feature: Remove confusion when dealing with snmp get
- Do not allow second data source to be added to an SNMP Get data
- Additionally clean up some messy code
- Do data source rra removal through callback
2018-08-18 09:11:44 -05:00
cigamit 155cb97054 Resolving Issue #1841
Data Source Stats table not properly migrated from pre 1.x Cacti plugin
2018-08-18 08:12:10 -05:00
cigamit 78631e4d0b Resolving Issue #1839
Dummy cosmetic bug on down device selection option
2018-08-15 18:29:17 -05:00
cigamit a167d89183 Resolving Issue #1819
Removing Graphs using CLI
2018-08-14 20:57:43 -05:00
cigamit a509b3d480 Resolving Issue #187
Remove the use of jQuery Migrate plugin
2018-08-09 17:10:37 -05:00
cigamit d739e8cf48 Resolving Issue #1494
Unable to Deep Link/Bookmark Trees
2018-08-09 17:08:46 -05:00
cigamit 923e0b6c38 Add Graphs and Data Sources hyperlinks on Device page
Additionally, convert styles to classes
2018-08-07 19:46:39 -05:00
cigamit 93c27bb0be Resolving Issue #1810
Correct SQL errors with authentication set to no authentication
2018-08-07 07:33:04 -05:00
Mark Brugnoli-Vinten 147c152eb7 Feature #1806 - Control of low level debug (#1807)
This patch adds functionality to control the debugging of low level routines
via defines within the config.php file.  In order to allow flexibility, if
these are defined, variables within the $config array are primed as true,
otherwise false.

These elements within the $config array are defined in uppercase to highlight
the difference between these are other ordinary configuration optios.

Should a function or program need to enable debugging of these various
options, simply setting the value to true in the $config array will enable
logging from that point.  Inversely, setting it to false will stop logging
from that point.

The only option that is of limited use is DEBUG_READ_CONFIG_OPTION_DB_OPEN
that will only work up to the database being open.  Setting this to true
after the database has already been opened will not automatic turn off the
companion option DEBUG_READ_CONFIG_OPTION since the db_connect_real() will
not be called again.

The list of options and their functionality are:

- DEBUG_READ_CONFIG_OPTION : record use of read_config_option()
  to cacti-option.log in the system temporary folder

- DEBUG_READ_CONFIG_OPTION_DB_OPEN : Once the database has been
  successfully opened, disable DEBUG_READ_CONFIG_OPTION

- DEBUG_SQL_CMD : Always write a copy of the SQL being requested
  to the cacti-sql.log file in the system temporary folder

- DEBUG_SQL_FLOW : Write flow of db_xxx calls to the cacti-sql.log
  in the system temporary folder.

The system temporary folder is normally set to one of the following:

- Linux, CLI: /tmp/
- Linux, WEB: Apache/Ngix's temporary folder
- Windows, CLI: %TEMP%
- Windows, WEB: Temp folder of web user or %WINDIR%\TEMP
2018-08-07 07:18:20 -05:00
cigamit 5f22e34020 Resolving Issue #1604
Failed to connect to remote collector
2018-08-06 21:14:31 -05:00
cigamit e1e59ce125 Resolving Issue #1184
Improve Data Input Methods editability and message handling
2018-08-06 19:56:08 -05:00
cigamit 7c9a1ef8d2 Resolving Issue #1799
Default User log sort should be date descending
2018-08-06 18:01:03 -05:00
Tom Yearke efc6b83466 Import: Fixed handling of references to objects not included in file (#1796)
* Import: Fixed handling of references to objects not included in file

When exporting an object with the "Include Dependencies" option disabled and then importing the resulting file, the import process will not complete successfully. This is because the mapping of object hashes to object IDs only tracks objects that have been included in the file.

This commit resolves the issue by first loading the mapping with all existing hashes and IDs before processing the file's objects. This results in the expected behavior when a referenced object is not in the file but is already loaded into the Cacti installation.

* Revised #1787 based on review from @cigamit

- Removed unnecessary double quotes
- Encapsulated `foreach` on possibly-empty array with size check
- Added whitespace

* Updated CHANGELOG to include #1796
2018-08-06 07:43:18 -05:00
Mark Brugnoli-Vinten db78fc050c Resolving issue #1651 (#1786)
This PR corrects an issue with the template import functionality where
browsers will appear to be attempting to upload a file but Cacti never
receives the variables to know that a file was attempted.

System temporary folder must be writable to upload a file so Cacti will
now error should the temporary folder be unwritable.
2018-08-05 10:10:05 -05:00
cigamit 3d5f77d213 Resolving Isuse #1783
Browser Back button still does not working
2018-08-02 21:10:13 -05:00
Mark Brugnoli-Vinten 51ee26ce1a Resolving issue #1689 (#1779)
* Resolving issue #1689

As noted in issue #1689 (Technical Support's RRDTool version should show
detected RRD version) the version of the RRDTool is never actually displayed.
The code has now been updated to properly handle versioning and displays both
the configured and installed versions.

The setting for rrdtool_version has been updated to a proper minimum version
number so that the cacti_version_compare() function may be effectively used.
This means that the constant values of RRDTOOL_VERSION_1_3 through
RRDTOOL_VERSION_7 have now been removed from the system.

* Some QA updates

* Further QA fixes
2018-08-02 18:01:25 -05:00
cigamit 75189c61f9 Resolving Issue #1761
- Graph management shows bogus template names
- Additionally, allow Multi-selects to have a reasonable width
- For Non-Templated and Template Not Found, properly show those things
as select items in the filter.
2018-07-30 20:43:18 -05:00
cigamit 9ef4d3f137 Resolving Issue #1763
Automatic refresh for Time Graph View - Enhancement
2018-07-29 14:29:01 -05:00
cigamit 8d7ecfe39d Resolving Issue #1708
Automation: Email settings should have network level overrides
2018-07-27 17:46:01 -05:00
cigamit 9a5cf5ae54 Inform the primary Cacti administrator of problems by Email 2018-07-27 17:31:22 -05:00
Mark Brugnoli-Vinten 33aa71448e Feature 1734 - Visual enhancements to RRD error message when file not found (#1755)
* Remove unnecessary issues

* Feature #1734 - Visual enhancements to RRD error message when file not found

This commit adds a visual enhancement to the RRDTool's file not found error.

* Further improvements
2018-07-26 21:32:54 -04:00
Mark Brugnoli-Vinten 8ea17f0093 Resolving Issue #1350 (#1753)
* Ensure previously selected field isn't wiped when ediing automation rule item

* Resolving Issue#1350

As per #1350, when switching an Automation Tree Rule's leaf type, remove invalid Automation Rule Items (Object Selection and Tree Creation criteria)
2018-07-26 08:36:21 -04:00
cigamit e339917955 Resolving Issue #1746
Poller with no hosts does not exit until timeout is reached
2018-07-25 20:02:58 -05:00
Mark Brugnoli-Vinten ed57331dfd Fixes for Issue 1729 and 1730 (#1747)
* Fixes QA issues with upgrades from older versions

* Redirect install/index.php to install/install.php

* Further QA fixes

* Ensure upgrade matches new password field length

* Add 'Installation In Progress' message

* Fix QA issues
2018-07-25 08:45:41 -04:00
Mark Brugnoli-Vinten 7dfde35c18 Remove unnecessary issues (#1742) 2018-07-23 19:52:20 -04:00
Mark Brugnoli-Vinten 68d0b56049 Fix for issue #1738 (#1740)
* Fix for issue #1739

* Update CHANGELOG
2018-07-23 08:25:46 -04:00
Mark Brugnoli-Vinten 1a806f1a4d Fix for issue #1736 (#1739) 2018-07-23 08:22:58 -04:00
Mark Brugnoli-Vinten 237e9a70ff Fix for issue #1732 (#1737) 2018-07-23 08:21:47 -04:00
cigamit 487d9fa8e1 Resolve Issues #1731 & #1672
Warn a user if they are going off page and there are unsaved changes
2018-07-22 11:02:51 -05:00
Mark Brugnoli-Vinten 2b61c1bba3 Further fix for Issue 1723 (#1728)
* Issue #1723 - die() messages should include \n for better logging

This corrects issue #1723 where die() messages appear in log files without a new line character causing logs to appear corrupted.

* Replace \n with PHP_EOF to be platform independant.
2018-07-21 15:17:14 -04:00
cigamit 377dfb708f Resolving Issue #1726
Poor page performance editing a Graphs Graph Items
2018-07-21 13:51:59 -05:00
Mark Brugnoli-Vinten dd24dce799 Feature #1670: Improve Graph Management to show type of source for a graph (#1725)
* Feature#1670: Improve Graph Management to show type of source for a graph

This commit adds functionality as requested in #1670 by adding an extra column to the graph management page to display the source type of a graph ('None', 'Data Query', 'Template')

* Minor update to make column sortable
2018-07-21 14:37:57 -04:00
Mark Brugnoli-Vinten da8b5169b7 Feature #1588: Check that PHP can run a test file (#1722)
* Feature #1588: Check that PHP can run a test file

* Feature #1628 - Allow the User to define a initial Network Discovery during Setup

* Fix QA issue with PHP 5.4

* Replace \n with PHP_EOL

* Minor changes to tabs vs. space and PHP_EOL

Will have to update packages based upon this too.

* Another minor pull where PHP_EOL was removed
2018-07-21 12:12:25 -04:00
Mark Brugnoli-Vinten ef7a318ef1 Feature #1692 - Separate option for logging Input Validation issues (#1696)
* Feature #1692 - Separate option for logging Input Validation issues

This commit adds a separate option for feature #1692 to enable logging Input Validation issues even when developer mode is turned off

* Finalise renaming of developer_mode to log_validation for cleaner understanding

* Remove log_validation from legacy location
2018-07-21 11:44:06 -04:00