Commit Graph
395 Commits
Author SHA1 Message Date
cigamit 5a13e98ed6 Resolving Issue #2869
Creating Aggregates from Graphs pages not fully functional due to JavaScript issues
2019-08-11 15:30:20 -05:00
cigamit 2e65c727a7 Resolving Issue #2794
Graph template not saved on graph edit
2019-07-24 19:16:33 -05:00
cigamit 3e7e8e5f09 Missed update to graphs.php
This was supposed to be committed as a part of the empty graph remediation but somehow missed.
2019-06-29 08:30:31 -05:00
cigamit 89f344e143 Resolving Issue #2754
Allow Devices, Graphs and Data Sources to be searched by ID
2019-06-23 18:32:57 -05:00
cigamit 8a6d100dd9 Resolved Issue #2741
Resolve a number of QA issues in various files
One additional fix for data debug as to default debug state
2019-06-22 09:23:29 -05:00
sysres-dev e7b54490b5 Resolving issues 2538,2539,2540 (#2552)
* Fix CHANGELOG (#2533)

* Update Travis information

* Resolving issue #2532

Ensure Graph ListView table is displayed in line with Management -> Graphs

* Add missing lib/graphs.php

* Improve performance on graph_view's tree_content action by reducing the number of SQL queries executed

* Resolving issues 2538,2539,2540

This commit is related to features requests 2538,2539,2540 :
2538 : new setting to change datasource behaviour when deleting graph
2539 : new setting to add permanent unlock of graphs
2540 : new setting to forget graph tree history on tab close

* tree_history description

changed description for tree_history

* Minor Cacti PSR Update

* Minor Cacti PSR Change

* Minor Cacti PSR Change

* Relocate setting and change gramar

* Minor language change

* Minor format change
2019-04-23 07:57:58 +06:00
cigamit 856f595b0b Resolving Issue #2463
* This should help resulve the issue experienced in #2463
* Fix two i18n issues
* Fix some filter hints
2019-03-23 11:08:07 -05:00
netniV 49cb30e5b0 Resolving issue #2532
Ensure Graph ListView table is displayed in line with Management -> Graphs
2019-03-18 14:16:43 +00:00
cigamit e662582ab5 Resolving Issue #2463
Zombie data sources without graphs
2019-03-12 22:21:19 -05:00
cigamit cd14f260dd Resolving Issues #599 and #2365
This is a major bug fix to Aggregate.  Also found a bug in rrdtool that
we will have to work around.
The upside of the bug fix for #2365 is that it appears to have fixed
#599 and also an issue with legend alignment.  Legends should always
align nicely now.
2019-02-01 18:22:28 -06:00
cigamit 1f8f8898dc Resolving Issue #2365 and multipl Aggregate issues
- Graphs included in aggregate that are removed are not managed properly
- The associate and disassociate functions were not following proper API
rules, they were leveraging request variables and redirecting using
header().
- Aggregate was not properly handling nth percentile.  It's now handling
that correctly, though still has an issue with the actual value.  This
will be fixed separately.
- Adding new convert to stacked line options for graph readability
- Totalling when using Print showing legend items was also showing graph
items, which is not correct.
- When totalling, Aggregate was attempting to show a blank line, but due
to an SQL format error, no blank line was displayed.
- Typo in one aggregate function was not properly handling the GPRINT
MIN graph item type
2019-01-31 07:39:09 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit e1dad073ba Properly display "No XXX Found" rows 2019-01-12 09:48:29 -06:00
cigamit be2bcb5cb5 When going to the graphs.php page, SQL errors can occur 2019-01-10 17:30:39 -06:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit 27f6882d7b One additonal fixup for Orphan detection 2018-11-22 12:13:34 -06:00
cigamit 543a2e3f47 Resolving Issue #2173
The orphan identification issue is not resolved at both the Graphs and
Data Sources level.
2018-11-21 14:10:02 -06:00
cigamit cbf6f818cd Resolving Issue #2173
- Resolving issue 3) of the issues as best as can be done.
-Additionally, making the graph_template_id multiselect common for all
pages and resolving additional QA issues in all areas that were impacted
by multiselect issues.
- Lastly, resolving issues in Reports that cause excessive queries and a
bad user experience.
- There will be likely one more commit on this bug as more QA needs to
be performend on Data Source orphan API introduced.
2018-11-21 13:49:08 -06:00
cigamit 2ceb063dc2 Resolve 4 translation issues 2018-11-17 11:48:14 -06:00
cigamit f18860f3cd Alphabetize includes add missing lib/poller.php where applicable
This is required for properly having data follow devices, graphs, and
data sources on change.
2018-10-13 13:03:22 -05:00
cigamit c6a7ed4ed6 Resolving Issue #2050
[1.2.0 Beta 1] Search in Graphs with error
2018-10-11 06:27:47 -05:00
cigamit 39111cb0e4 Make it easy to find Data Query based graphs that have lost indexes 2018-10-10 07:19:07 -05:00
cigamit 0b991958fd Resolving Issue #1982
Certain hooks should occur within api functions rather than UI functions
2018-09-28 04:49:59 -05:00
cigamit 44190227f4 Resolving Issue #1926
This is easy enough.  Not a major change actually.
Some line ending fixes as well
2018-09-24 20:52:19 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 3aa1f33cdb Add a few additional hooks and alter one 2018-09-08 14:53:41 -05:00
cigamit 63a281012c Resolving Issue #1840
Attempt to resolve. [1.2.0] Error after upgrade
2018-08-24 17:54:48 -05:00
cigamit 9cdd347e58 Moving some functions into api calls
This will help resolve and issue that was raised during the resolution
of issue #948.
2018-08-20 19:06:06 -05:00
cigamit d800ac2595 Resolving Issue #948
Every time when creating new graph Cacti creates new datasource
2018-08-19 20:57:22 -05:00
cigamit 88d92cc9ad [1.2.0] Adding reports items from graphs page broken
There was also an issue with undefined variable $config
2018-08-19 08:08:20 -05:00
cigamit 874130296f feature: Allow drill down from Graphs to Data Queries or Templates
Includes massive performance improvement when opening Data Query Graph
Mappings
2018-08-18 14:43:28 -05:00
cigamit 6ea9203fe6 Resolving Issue #1761
You will have to reforce the upgrade if you are running the current
development.
2018-08-18 12:09:24 -05:00
cigamit 53789688f3 Resolving Issue #1761
Graph Templates can be bogus from time to time
2018-08-16 18:37:51 -05:00
Mark Brugnoli-Vinten 51ee26ce1a Resolving issue #1689 (#1779)
* Resolving issue #1689

As noted in issue #1689 (Technical Support's RRDTool version should show
detected RRD version) the version of the RRDTool is never actually displayed.
The code has now been updated to properly handle versioning and displays both
the configured and installed versions.

The setting for rrdtool_version has been updated to a proper minimum version
number so that the cacti_version_compare() function may be effectively used.
This means that the constant values of RRDTOOL_VERSION_1_3 through
RRDTOOL_VERSION_7 have now been removed from the system.

* Some QA updates

* Further QA fixes
2018-08-02 18:01:25 -05:00
cigamit 75189c61f9 Resolving Issue #1761
- Graph management shows bogus template names
- Additionally, allow Multi-selects to have a reasonable width
- For Non-Templated and Template Not Found, properly show those things
as select items in the filter.
2018-07-30 20:43:18 -05:00
cigamit 026e63bb00 Resolving Issue #1726
Slow graph editing performance and breaking templates when attempting to
edit.
2018-07-25 20:39:21 -05:00
cigamit 18c8d916fb Minor tweaks to pull request #1670
Change alignment, add some i18n
2018-07-21 14:14:41 -05:00
cigamit 377dfb708f Resolving Issue #1726
Poor page performance editing a Graphs Graph Items
2018-07-21 13:51:59 -05:00
Mark Brugnoli-Vinten dd24dce799 Feature #1670: Improve Graph Management to show type of source for a graph (#1725)
* Feature#1670: Improve Graph Management to show type of source for a graph

This commit adds functionality as requested in #1670 by adding an extra column to the graph management page to display the source type of a graph ('None', 'Data Query', 'Template')

* Minor update to make column sortable
2018-07-21 14:37:57 -04:00
cigamit efb3101cfd Resolving Issue #1658
Devices drop down should be filtered by Site
2018-06-17 13:40:21 -05:00
cigamit 3b1a25f56e Minor format changes and change for site host lists 2018-06-17 09:25:25 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit a04a6be54b Resolving Issue #1581
This first commit handles some of the API and adding from the Console >
Graphs page.  Another commit coming on this issue.
2018-04-28 20:39:05 -05:00
cigamit 96f62fe610 Resolve Issue #1527
Update Fontawesome from 4.7 to 5.0.10
2018-04-22 09:24:27 -05:00
cigamit 85ecf7f57b Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	lib/utility.php
2018-02-26 21:24:43 -06:00
cigamit e38a874bab Minor alignment issue 2018-02-26 21:22:09 -06:00
cigamit 10a8e523f7 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	cacti.sql
#	data_sources.php
#	docs/CHANGELOG
#	graphs.php
#	host.php
2018-01-26 19:31:47 -06:00
netniV 6039e847fc Fix for Issue #1256 / #1268 - RFILTER and display corrections (#1269)
* Fix for Issue #1256 and #1268
This patch fixes issues with both the display of the error messages and with RFILTER variables not properly being primed as discussed on issue #1256 and issue #1268

* Update CHANGELOG

* Fix issue number
2018-01-26 17:56:24 -07:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00