Commit Graph
165 Commits
Author SHA1 Message Date
netniV ef271a16ef When URL_PATH is blank, it should assume that it is '/'
Closes #2908
2019-08-22 11:30:47 +00:00
cigamit 24145c5e53 Resolving Issue #2878
PHP 7.4 Function get_magic_quotes_gpc() is deprecated
2019-08-11 13:39:45 -05:00
netniV e95eb61cef When testing remote poller connections during install, undefined variable warning can occur
Closes #2860
2019-08-01 12:45:02 +00:00
netniV 900c747ffa Further resolve #2638 2019-04-28 18:57:20 +00:00
Matthew Horan 59b58671aa Support disabling PHP SNMP extension (#2638)
Re-purpose the existing php_snmp_support config value to allow
administrators to disable the built-in SNMP extension.

It can be desirable to force use of the Net-SNMP in some configurations,
particularly when IPv6 is in use. This allows the administrator to set
$php_snmp_support = false in config.php, which will then force use of
the Net-SNMP binaries tools.
2019-04-23 07:58:40 +06:00
netniV 6c7b2ab95e Missing configuration defaults prevent installations/upgrades without showing reason
Closes #2555
2019-03-23 11:04:57 +00:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
netniV 89f0a06216 Resolving issue #2304 and #2311
This commit corrects a previous unseen issue where the PHP environment at command line level is being populated with environment variables normally only seen when called from a web server.

issue#2304: Installation progress stays at 0%
issue#2311: Unable to update PHP location during installation due to incorrect CLI environment

The new check uses the php_sapi_name() function to verify that we are indeed at 'cli' level.  All other values returned by php_sapi_name are considered non-cli including 'cli-server' which is for client/server scenarios.

Most checks have now been replaced by a single defintion ('CACTI_CLI') to define whether in CLI mode.  If a script is only to be called from CLI it must either defined 'CACTI_CLI_ONLY' or include include/cli_check.php instead of include/global.php.
2019-01-15 13:57:50 +00:00
netniV 27e7674f7b Remove and reset BETA versioning number 2019-01-03 02:10:03 +00:00
cigamit 5c8ebf0a6a Preparing Beta4 2018-11-26 05:48:31 -06:00
cigamit a309034c57 Resolving Issue #2134
[1.2.0 Beta 2] cacti log rotation should keep file ownership and
permissions
2018-11-18 11:12:00 -06:00
cigamit 06ff974c59 Readying beta3 2018-11-18 10:38:18 -06:00
cigamit 7f1ff7db5d Ready for Beta2 2018-10-21 08:42:08 -05:00
Tony Roman 4ddd5ae745 Add Support Menu Item
- Add external link support in menu (probably need more work)
 - Added Support -> Documentation menu item
 - Added Support -> Users Community menu item
 - Made documentation loading dynamic, if release documentation is
   not included it will redirect to Github documenation
2018-10-01 00:34:04 -04:00
cigamit 8d0079f406 Preparing for Beta1 2018-09-30 12:37:35 -05:00
Mark Brugnoli-Vinten 4c2bb0703d QA fixes (#1967) 2018-09-24 05:36:24 -05:00
cigamit f64784596c Fix on Issue in Remote Installer
The remote data collector installer is broken at the moment.  This patch
is needed to at least begin the install process.
2018-09-23 15:00:33 -05:00
cigamit e845fbb20c Resolving Issue #1060
- Design Enhancement for Large scale Cacti Implementations
- Spine changes still required
- Testing still required
2018-09-22 23:17:19 -05:00
Mark Brugnoli-Vinten e48f788d92 Resolving issue #1870 (#1917) 2018-09-12 20:01:18 -05:00
Mark Brugnoli-Vinten 0fb4f53809 Resolving issue #1897 (#1898)
* Resolving issue #1897

* Resolving issue #1899

* Further Resolving Issue #1899
2018-09-06 21:24:51 -05:00
cigamit 637c436182 Introduce Cacti Beta Constant
This will make it clear to users that they are running a beta version of
Cacti
2018-09-02 09:43:46 -05:00
Mark Brugnoli-Vinten 147c152eb7 Feature #1806 - Control of low level debug (#1807)
This patch adds functionality to control the debugging of low level routines
via defines within the config.php file.  In order to allow flexibility, if
these are defined, variables within the $config array are primed as true,
otherwise false.

These elements within the $config array are defined in uppercase to highlight
the difference between these are other ordinary configuration optios.

Should a function or program need to enable debugging of these various
options, simply setting the value to true in the $config array will enable
logging from that point.  Inversely, setting it to false will stop logging
from that point.

The only option that is of limited use is DEBUG_READ_CONFIG_OPTION_DB_OPEN
that will only work up to the database being open.  Setting this to true
after the database has already been opened will not automatic turn off the
companion option DEBUG_READ_CONFIG_OPTION since the db_connect_real() will
not be called again.

The list of options and their functionality are:

- DEBUG_READ_CONFIG_OPTION : record use of read_config_option()
  to cacti-option.log in the system temporary folder

- DEBUG_READ_CONFIG_OPTION_DB_OPEN : Once the database has been
  successfully opened, disable DEBUG_READ_CONFIG_OPTION

- DEBUG_SQL_CMD : Always write a copy of the SQL being requested
  to the cacti-sql.log file in the system temporary folder

- DEBUG_SQL_FLOW : Write flow of db_xxx calls to the cacti-sql.log
  in the system temporary folder.

The system temporary folder is normally set to one of the following:

- Linux, CLI: /tmp/
- Linux, WEB: Apache/Ngix's temporary folder
- Windows, CLI: %TEMP%
- Windows, WEB: Temp folder of web user or %WINDIR%\TEMP
2018-08-07 07:18:20 -05:00
Mark Brugnoli-Vinten 6e1b8431b7 Fixes for Issues 1781, 1782 and 1784 (#1785)
* Fixes for Issues 1781, 1782 and 1784

This patch corrects the following issues:

- #1782 During Install, changing the Theme from Modern to another theme has no
        effect
- #1784 During Install, changing the Language from one to another has no
        effect
- #1781 Installer does not warn when mysql optimizations not set

As part of #1781's fixes, a new warning icon is displayed instead of a thumbs
up or down.  Additionally, recommendations have been revamped so that the ones
which are optionally (and some even state can be ignored) are now optional!

Also, introduced the correct calculation for innodb instances by taking the
buffer size during a previous recommendation and calculating from that.  If
the buffer size is never found or the calcuation finds less than 1 instances
are recommended, a minimum of 1 is set.

The main reason for #1782 and #1784's issues were caused by renaming index.php
to install.php as part of the recent security update (see PR #1747).  Updated
the javascript to use the correct install.php and then removed some extra data
that was being returned outside of StepData unnecessarily.

* Further fixes

This update corrects a number of issues with the database upgrading code, adds
the 'debug' plugin from cigamit, improves database functions to be more
consistent with errors across all functions and various installer based fixes
for the display and update of database upgrades.

It also brings a more visual response to the cli/upgrade_database.php so that
end users are not left wondering if something is happening.  Also, reviewed
all upgrade scripts to ensure that an upgrade from 0.8.8 through to 1.2.0 is
possible even if a previous database upgrade have been done.

* Fix QA issue with 'path_cactilog'

Due to some code reshuffle and testing, found that the above setting was being
read via read_config_option() before there was a database open so no path was
ever detected unless the force option was used.
2018-08-05 10:43:01 -05:00
Mark Brugnoli-Vinten 2b61c1bba3 Further fix for Issue 1723 (#1728)
* Issue #1723 - die() messages should include \n for better logging

This corrects issue #1723 where die() messages appear in log files without a new line character causing logs to appear corrupted.

* Replace \n with PHP_EOF to be platform independant.
2018-07-21 15:17:14 -04:00
Mark Brugnoli-Vinten fde08a533f Issue #1723 - die() messages should include \n for better logging (#1724)
This corrects issue #1723 where die() messages appear in log files without a new line character causing logs to appear corrupted.
2018-07-21 08:31:57 -04:00
Mark Brugnoli-Vinten 6bb5b36b64 PR for Issue #1716 and #1718 (#1720)
* Fixes for issues #1716 and #1718

* Add changelog details

* issue#1721 - Console Side Bar not correct on first login
2018-07-19 06:54:33 -04:00
cigamit 179cd07b73 Resolving Issue #1711
Support specifying MySQL SSL file paths in the database API
2018-07-14 14:53:46 -05:00
Mark Brugnoli-Vinten d3ee9512bf Fix for issue #1298 (#1702)
* Fix for issue #1298

* Minor QA fix
2018-07-11 04:39:09 -05:00
cigamit 6fd2cc9ee2 Improve handling of CSRF timeouts
Now page will automatically refresh.
2018-05-14 18:26:18 -05:00
cigamit 37bcdd0c31 Resolving Issue #1383
CSRF Timeout does not obey session timeout
2018-05-10 20:39:17 -05:00
cigamit 012ea39653 -feature: Add Timezone support for Remote Data Collectors 2018-04-03 20:42:19 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
cigamit 93b4a7673c Correct one security resolution blocking graphs
This is related to issue #1457
2018-03-18 12:10:31 -05:00
cigamit 29e5621bd9 Add Session Security as a result of #1457
These were suggestions in the security report, though low in nature.
2018-03-18 08:58:23 -05:00
netniV cda6a03e56 1.2.x - issue #1347 - Update automation logging to work better (#1410)
* issue #1347 - Update automation logging to work better

* Remove debug code from lib/clog_webapi.php

* Further automation updates to include PID for diagnoses/filtering

* Ensure we have rows before attempting to loop through them

* Fix CI error

* update chines po file (#1403)

Signed-off-by: snsupersharp <snsupersharp@163.com>

* Typo in layout.js
2018-02-26 21:21:09 -06:00
cigamit 7e70e27940 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	include/themes/modern/main.css
#	tree.php
2018-02-18 16:26:26 -06:00
cigamit c2d08a1b25 Resolving Issue #1353
New install with missing config.php silently throws errors
2018-02-14 20:48:16 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 251a22ecff Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
Updating feature 1.2 branch from Develop
2017-12-03 08:02:58 -06:00
cigamit a47d713d7b Resolving Issue #1104
Different Timestamps in Cacti log when in Developer Debug
2017-12-02 11:16:14 -06:00
cigamit 365730d442 Resolving Issue #1072
Correcting CVE-2009-4112.  This CVE correction will provide some level
of protection to Cacti when unauthorized changes are made to a Data
Input Method.
2017-11-21 17:16:34 -06:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
Tony Roman 51c978bd0a Move csrf to include/vendor 2017-11-18 09:31:28 -05:00
cigamit 083c59cd74 Resolving Issue #1085
Call to undefined function html_log_input_error in debug mode
2017-11-17 07:43:18 -06:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit c6b409603a Remove reference to poller_export.php as it's a plugin file. 2017-09-01 10:24:34 -05:00
cigamit f617c7121c Introduce new DATE_TIME_FORMAT constant resolving issue #829
Addresses issues with 500 messages when in developer debug mode.  Also,
make certain that the navigation variables exist before using them.
2017-06-29 17:37:32 -05:00
cigamit 27f30f498f Resolve upgrade issues from Cacti 0.8.7
If the plugin architecture does not exist, install will fail.  Also
found php function version_compare not working in PHP 5.3.x.

There were additionally issues with the upgrade functions as well.
Resolving those too.
2017-06-04 19:56:52 -05:00