Commit Graph
73 Commits
Author SHA1 Message Date
netniV 154418a5c2 Another fix for #2907 2019-08-22 11:57:02 +00:00
netniV 79ffee4ead Installation wizard does not detect RRDtool version correctly
Closes #2282
2019-07-10 22:28:49 +00:00
cigamit 87e3dada44 Fix two regressions
* Properly repair automation during install
* Don't allow a blank default Cacti logfile.
2019-06-30 13:57:59 -05:00
cigamit 0a7492b61b Resolving Issue #2779
Correct one typo found during testing.
2019-06-29 13:47:26 -05:00
cigamit a6e669006d Resolving Issue #2779
On new Cacti installs, automation rules for Interface Graphs broken
2019-06-29 09:37:10 -05:00
cigamit 1ee746965d Resolving Issue #2742
Resolve a number of QA issues in various files
2019-06-22 09:04:37 -05:00
cigamit 29f00f8c46 Resolving Issue #2672
Cacti Install on Windows Fails
2019-05-07 22:30:41 -05:00
cigamit c079fbc421 Fix Graph Rules
The order of import impacts the automation rules.
2019-03-16 17:53:27 -05:00
cigamit 554a4c66a8 Add Cacti Stats package
* Shorten names on Data Query Graph Templates
* Add Cacti Stats to the list of avail packages
2019-03-14 20:45:31 -05:00
netniV 79c5b4b83a Resolving issue #2413 2019-02-14 14:49:17 +00:00
cigamit aa945bd8ba More debug on issue #2337
Installer issues when updrading now resolved.
2019-01-27 12:28:30 -06:00
cigamit 2584a519c7 Resolving Issue #2337
After updating the previous path of the log file is changed
2019-01-27 11:56:42 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
netniV f9ba429e49 Resolving issue #2315
The code will now spawn a background command to attempt to verify the environment at CLI level before adding the Web enviornment into the returned array, before returning the combination.
2019-01-16 19:55:44 +00:00
netniV 955f4903b0 Allow SSL cert settings for remote pollers 2018-10-14 10:02:34 +00:00
netniV 4357005d49 Resolving issue #2046 2018-10-11 21:41:46 +00:00
netniV 8d888aa580 Resolving issue #2025 2018-10-10 13:18:22 +00:00
Mark Brugnoli-Vinten e09759f918 Resolving issue #2024 (#2027) 2018-10-07 03:43:37 -05:00
Mark Brugnoli-Vinten a3ce9918a3 Latest QA fixes (#1992)
* Sort required modules for easier reading during installation

* QA fix for template package details

* Correct issue with plugin hooks SQL failing

* Rejig some the layout of Installer class and add some comments

* Some minor QA fixes

* Correct typo with com_dotnet module

* Add more information about collation change
2018-09-29 06:28:15 -05:00
cigamit 76ae351222 Resolving Issue #1936
[1.2.0] Upgrade fails to import templates properly
2018-09-25 18:11:58 -05:00
Mark Brugnoli-Vinten 8f37075039 More QA fixes for the installer (#1965) 2018-09-23 17:57:35 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
Mark Brugnoli-Vinten e48f788d92 Resolving issue #1870 (#1917) 2018-09-12 20:01:18 -05:00
Mark Brugnoli-Vinten c4d6a6b5b9 Some QA fixes on latest Installer (#1913)
* Some QA fixes on latest Installer

* Correct Typo in CsrfMagic usage
2018-09-10 17:56:41 -05:00
Mark Brugnoli-Vinten 439668519a Add CLI-based installer, fix 100+ table issue (#1912) 2018-09-10 00:39:40 -05:00
cigamit 110e5af074 Correct two issues wiht upgrade from 0.8.8 2018-09-08 15:48:33 -05:00
Mark Brugnoli-Vinten d3821d8f54 Installer Updates (#1890)
* Resolving Issue #1850

* Further updates, correct i18n language selection

* Another round of updates for #1850
2018-09-04 07:07:04 -05:00
cigamit 67543ed64d Make a few enhancements to the installer
- Use the standard Cacti form logic
- Set sendmail path if it's available

Sendmail is optional, but we want to set it if it's available.  So, it's
not entirely critical, but it could be.  So, moving into the section of
the installer.  Doing this also partially corrects an open issue as
well.
2018-08-18 10:32:55 -05:00
Jimmy Conner da5f5a11b4 Fix undefined variable error in Installer 2018-08-10 08:33:07 -05:00
cigamit 7ef666c562 Resolving Issues #1804 and #1805
Do not create 64bit graphs on Windows devices
Pre-populate the settings database with defaults
One minor wording change in Automation
2018-08-06 17:30:48 -05:00
Mark Brugnoli-Vinten 6e1b8431b7 Fixes for Issues 1781, 1782 and 1784 (#1785)
* Fixes for Issues 1781, 1782 and 1784

This patch corrects the following issues:

- #1782 During Install, changing the Theme from Modern to another theme has no
        effect
- #1784 During Install, changing the Language from one to another has no
        effect
- #1781 Installer does not warn when mysql optimizations not set

As part of #1781's fixes, a new warning icon is displayed instead of a thumbs
up or down.  Additionally, recommendations have been revamped so that the ones
which are optionally (and some even state can be ignored) are now optional!

Also, introduced the correct calculation for innodb instances by taking the
buffer size during a previous recommendation and calculating from that.  If
the buffer size is never found or the calcuation finds less than 1 instances
are recommended, a minimum of 1 is set.

The main reason for #1782 and #1784's issues were caused by renaming index.php
to install.php as part of the recent security update (see PR #1747).  Updated
the javascript to use the correct install.php and then removed some extra data
that was being returned outside of StepData unnecessarily.

* Further fixes

This update corrects a number of issues with the database upgrading code, adds
the 'debug' plugin from cigamit, improves database functions to be more
consistent with errors across all functions and various installer based fixes
for the display and update of database upgrades.

It also brings a more visual response to the cli/upgrade_database.php so that
end users are not left wondering if something is happening.  Also, reviewed
all upgrade scripts to ensure that an upgrade from 0.8.8 through to 1.2.0 is
possible even if a previous database upgrade have been done.

* Fix QA issue with 'path_cactilog'

Due to some code reshuffle and testing, found that the above setting was being
read via read_config_option() before there was a database open so no path was
ever detected unless the force option was used.
2018-08-05 10:43:01 -05:00
Mark Brugnoli-Vinten 51ee26ce1a Resolving issue #1689 (#1779)
* Resolving issue #1689

As noted in issue #1689 (Technical Support's RRDTool version should show
detected RRD version) the version of the RRDTool is never actually displayed.
The code has now been updated to properly handle versioning and displays both
the configured and installed versions.

The setting for rrdtool_version has been updated to a proper minimum version
number so that the cacti_version_compare() function may be effectively used.
This means that the constant values of RRDTOOL_VERSION_1_3 through
RRDTOOL_VERSION_7 have now been removed from the system.

* Some QA updates

* Further QA fixes
2018-08-02 18:01:25 -05:00
Mark Brugnoli-Vinten da8b5169b7 Feature #1588: Check that PHP can run a test file (#1722)
* Feature #1588: Check that PHP can run a test file

* Feature #1628 - Allow the User to define a initial Network Discovery during Setup

* Fix QA issue with PHP 5.4

* Replace \n with PHP_EOL

* Minor changes to tabs vs. space and PHP_EOL

Will have to update packages based upon this too.

* Another minor pull where PHP_EOL was removed
2018-07-21 12:12:25 -04:00
Mark Brugnoli-Vinten 5d075f62fc Feature #1034: Ensure tables are UTF8 (#1635)
* Feature #1034: Ensure tables are UTF8

* Make PHP 5.4 happy
2018-05-12 15:35:50 -05:00
Mark Brugnoli-Vinten ddddaec6ae Ajax Installer (#1586)
* Beginning of Install via AJAX calls

* Added steps 3 & 4 to the installer system

* Add background update procedure.  Still needs more upgrade code adding, like upgrading the DB

* Minor fixup during QA

* Remove debug code from lib/functions.php

* More QA fixes, add slight delay to index.php initialisation to see javascript warning (should be removed)

* beta3 - added data source profiles

* beta4 - fix some issues found in QA

* beta5 - upgrade databsae routines added, error results screen styled

* Add some colour to the thumb icons

* QA fix to remove unneeded option

* Fix for PHP 5.4 travis failure
2018-04-29 10:05:32 -05:00
cigamit 4374b85e1c Resolve Issue #1474
Check possibility for creation of temporary tables on install
2018-03-24 10:37:42 -05:00
Tony Roman 9a8b308642 Make PHP minimum version supported to 5.4.0 2018-03-18 20:14:17 -04:00
cigamit 323e041146 Missing i18n 2018-03-18 12:23:46 -05:00
Lucien Perregaux 40237611bf Incorrect default found path of spine (#1446)
* Remove default incorrect Spine binary path

When installating Cacti for the first time, with spine installed, the found path is (in my case) "/usr/local/spine/bin/spine/spine" instead of "/usr/local/spine/bin/spine".

* Update CHANGELOG
2018-03-05 18:10:43 -06:00
cigamit 14fd9c4511 Ensure compression for package extraction is correct
This is for the initial import case.  Based upon QA, we have found that
if the php base level compression is different than the way the package
were created in the first place, that they are unreadable.  Therefore,
this change ensures that all compression settings are consistent across
all operations including the yet unpublished package plugin.
2018-02-11 06:53:56 -06:00
cigamit 8411dc6e2b Resolving Color Import Issue
issue: Named colors were not importing on install/upgrade.
2018-01-14 21:40:23 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
Patrick 4617c60a02 Various updates (#1016)
* Updated Dutch translations
- 1007 translations remaining (70% translated)
- Typo fixes

* Fix for #1005

* Schema changes
- Examined queries without key usage and added/changed some keys

* Fixed some missing i18n
2017-10-07 13:05:12 -04:00
Tony Roman ca8c8cd123 Move cacti_version_compare into main functions lib to be used
in non-install code
2017-06-04 21:33:15 -04:00
cigamit 27f30f498f Resolve upgrade issues from Cacti 0.8.7
If the plugin architecture does not exist, install will fail.  Also
found php function version_compare not working in PHP 5.3.x.

There were additionally issues with the upgrade functions as well.
Resolving those too.
2017-06-04 19:56:52 -05:00
cigamit d6f4538b46 Resolving issue #753
Preliminary support for rrdtool 1.7
2017-05-29 18:06:44 -05:00
Tony Roman 9ec2787615 Fixups to installation web and cli
- Fixed issue were version was not showing on results of upgrades steps
 - Update CLI script to show successful results when debug enabled
 - Removed empty install upgrades
 - Attempted to resolve issue #671
2017-05-13 19:40:15 -04:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00