Commit Graph
242 Commits
Author SHA1 Message Date
netniV 97dc663fe6 PHP recommendations can generate a warning causing json issues
Closes #2903
2019-08-19 10:51:05 +00:00
cigamit 348962b6a0 Partial Fix to #2836
Upgrader to raise error condition when innodb_large_prefix is not set
2019-07-24 18:26:21 -05:00
cigamit 87b6cb105b Resolving Issue #2825
"innodb_doublewrite = off" possibly dangerous recommendation
2019-07-19 07:55:31 -05:00
cigamit 393e5860ee Resolving Issue #2814
Anchor Tags Escaped on Utilities Page
2019-07-09 07:01:13 -05:00
netniV 51a01bb947 When the path_php_binary location is invalid, this should be notified during installation when checking modules
Closes #2748
2019-07-01 21:47:09 +00:00
netniV 7f2a94b8d3 Undefined variable message raised by push_out_host() in lib/utility.php
Closes #2723
2019-06-09 12:51:53 +00:00
cigamit af945e0706 Resolved two corners cases related to #2690
Thse two issues were discovered by user new to Cacti.
2019-05-19 07:49:06 -05:00
cigamit 29f00f8c46 Resolving Issue #2672
Cacti Install on Windows Fails
2019-05-07 22:30:41 -05:00
netniV a0950bf10e Revert "Honor php.ini when php is used in exec() and shell_exec() calls (#2652)"
This reverts commit 33641a9abb.
2019-04-29 12:45:02 +00:00
netniV 1c6139f667 Revert "Correct a few misqueues on #2652"
This reverts commit 3e3ba86f23.
2019-04-29 12:44:53 +00:00
netniV a2d3fd8776 Revert "WIP: php argument composition (#2653)"
This reverts commit 8a23ca33e3.
2019-04-29 12:43:03 +00:00
David Runge 8a23ca33e3 WIP: php argument composition (#2653)
* Moving all argument composition for backgrounded calls of php to 'assemble_php_args()' in /lib/functions.php.

* lib/functions.php: Explicitely prepending all assembled arguments.

* lib/functions.php: Removing an accidental appending of the initial args in assemble_php_args().
2019-04-29 13:38:17 +01:00
cigamit 3e3ba86f23 Correct a few misqueues on #2652 2019-04-27 11:48:57 -05:00
David Runge 33641a9abb Honor php.ini when php is used in exec() and shell_exec() calls (#2652)
* Introducing the prepending of the current php.ini file, if any, to the extra arguments of backgrounded php calls (used with exec_background).
This enables the backgrounded process to stay in the same environment as the main one and not default back to a system wide default configuration file (which might or might not have configurations setup properly).

* Prepending the current php.ini in use (if any) to any exec() or shell_exec() call, that is doing a backgrounded call of the php executable.

* graph_realtime.php: Fixing missing whitespace between executable and first argument.
2019-04-27 21:32:32 +06:00
netniV b8322d4d6a Resolving issue #2551
When checking MySQL configuration values, consider ON/OFF to be equal to 1/0.

Closes #2551
2019-03-21 10:33:30 +00:00
cigamit 805ec48f74 Update recommendations for MySQL/MariaDB
These recommendations are for utf8mb4 to support larger indexes that some users have in their plugins.
2019-03-17 09:40:12 -05:00
cigamit 5cf7d42dfe Resolving Issue #2509
Installer is not consistent between MySQL Settings checking and final step Warning
2019-03-16 15:08:49 -05:00
netniV 5c70c32eed Make gettext an optional module 2019-03-15 00:12:06 +00:00
cigamit da6df4c060 Update recommendations for flash/ssd 2019-03-10 12:25:24 -05:00
cigamit e370a83cb9 Resolving Issue #2434
Enable/disable Data Source generates warnings when snmp_index is bad
(blank).
2019-02-20 21:52:35 -06:00
cigamit 7698645e8f Resolving Issue #2436
Unknown column 'dl.snmp_index' in 'where clause'
2019-02-20 21:42:12 -06:00
netniV d6f6ea2e16 Allow CLI checker to self-increase memory without affecting utility's detection of memory limit 2019-02-15 17:19:21 +00:00
cigamit bdc4ed9c05 Resolving Issue #2357
- Poller issuing WARNING with little way to diagnose
- This change will remove bad items first from the poller cache
- It adds a new option to filter Data Sources with a Status of Bad Index
- It issues a waring every few hours of the prescense of Bad Index in
the system.

The warning threshold may be excessive.  Will have to see as in large
installs indexes can get bad all the time.
2019-02-02 11:49:04 -06:00
cigamit edc736d871 Additional fixes for Issue #2326
This allows the row format to be dynamic only when the
innodb_file_format is Barracuda, and corrects a bug in detecting MySQL
vs. MariaDB in the version string.
2019-01-26 09:42:37 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
netniV 00524d4a10 Further resolve #2315
Correct a couple of minor issues, now make PHP version limit an error.
2019-01-16 20:15:10 +00:00
netniV f9ba429e49 Resolving issue #2315
The code will now spawn a background command to attempt to verify the environment at CLI level before adding the Web enviornment into the returned array, before returning the combination.
2019-01-16 19:55:44 +00:00
cigamit 77056a9888 Minor formatting updates. 2018-11-18 09:07:56 -06:00
cigamit 2ceb063dc2 Resolve 4 translation issues 2018-11-17 11:48:14 -06:00
netniV 7ed42a37f4 Resolving issue #2142 2018-11-05 22:28:08 +00:00
cigamit 2e97a453c7 Resolving Issue #2101
[1.2.0 Beta 1] Installer innodb_buffer_pool_instances calculation
2018-10-20 23:11:19 -05:00
cigamit b1ceea271b Code cleanup relatedd to issue #2070
The code before had lot's of duplicate sql calls and would result in a
higher probability of bugs.
2018-10-14 07:13:20 -05:00
cigamit e4e8e4cf07 More resolution to Issue #2070
The only thing left is to ensure that automation is run when you are
running re-index from the main Cacti web site.  Also, to determine how
automation should run in batch mode since the re-indexing is not
preforming this in the background on the remote data collectors.
2018-10-13 17:26:51 -05:00
cigamit d8966bbf9f The db_close() function is causing errors 2018-10-13 14:11:16 -05:00
cigamit 10248cd012 The variable $cnn_id is dangerous due to legacy behavior 2018-10-13 13:54:33 -05:00
cigamit 5c7a3fbb2f Resolving Issues #2068 and #2058
- [1.2.0 Beta 1] When saving, modifying, removing devices and graphs,
sync this data automatically
- [1.2.0 Beta 1] New CLI Script remove_device.php Orphans Graphs and
Data Sources
2018-10-13 13:36:22 -05:00
netniV 9d1c1b9dbd Updated MySQL/MariaDB recommendations 2018-10-09 14:42:45 +00:00
cigamit 709c532637 Resolving Issue #454
Do not test this on a production box.  It is functional, but looking for
someone to test the re-index behavior when a sort field changes.
2018-09-26 21:12:46 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
Mark Brugnoli-Vinten 6e1b8431b7 Fixes for Issues 1781, 1782 and 1784 (#1785)
* Fixes for Issues 1781, 1782 and 1784

This patch corrects the following issues:

- #1782 During Install, changing the Theme from Modern to another theme has no
        effect
- #1784 During Install, changing the Language from one to another has no
        effect
- #1781 Installer does not warn when mysql optimizations not set

As part of #1781's fixes, a new warning icon is displayed instead of a thumbs
up or down.  Additionally, recommendations have been revamped so that the ones
which are optionally (and some even state can be ignored) are now optional!

Also, introduced the correct calculation for innodb instances by taking the
buffer size during a previous recommendation and calculating from that.  If
the buffer size is never found or the calcuation finds less than 1 instances
are recommended, a minimum of 1 is set.

The main reason for #1782 and #1784's issues were caused by renaming index.php
to install.php as part of the recent security update (see PR #1747).  Updated
the javascript to use the correct install.php and then removed some extra data
that was being returned outside of StepData unnecessarily.

* Further fixes

This update corrects a number of issues with the database upgrading code, adds
the 'debug' plugin from cigamit, improves database functions to be more
consistent with errors across all functions and various installer based fixes
for the display and update of database upgrades.

It also brings a more visual response to the cli/upgrade_database.php so that
end users are not left wondering if something is happening.  Also, reviewed
all upgrade scripts to ensure that an upgrade from 0.8.8 through to 1.2.0 is
possible even if a previous database upgrade have been done.

* Fix QA issue with 'path_cactilog'

Due to some code reshuffle and testing, found that the above setting was being
read via read_config_option() before there was a database open so no path was
ever detected unless the force option was used.
2018-08-05 10:43:01 -05:00
cigamit 292aa3b75a Resolving Issue #1528
Saving a device can result in WARNINGS related to string vs. array
handling
2018-04-21 18:49:59 -05:00
Mark Brugnoli-Vinten b1793d18df Corrects #1546 - sizeof() issue with 1.2 (#1549)
* Issue #1537: Numeric validation not ignoring blank elements

* Fix second instance of numeric_list issue

* Fix incorrect use of sizeof()
2018-04-19 07:14:12 -05:00
cigamit 85ecf7f57b Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	lib/utility.php
2018-02-26 21:24:43 -06:00
Patrick 697dda8779 Updated translations (#1411)
* Updated Dutch Translations

* Updated Dutch Translations

Merge conflict, needed to re-compile the .mo

* Updated Dutch Translations with latest Cacti.pot

* Fixed some inconsistencies

* Fixed obsolete code

* Updated Dutch Translations

* Fixed typo

* layout changes only

* Updated Dutch translations

* Updated changelog

* Updated changelog
2018-02-26 21:20:20 -06:00
cigamit 7b60a000a8 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	lib/api_automation.php
2018-02-03 13:36:09 -06:00
netniV 27e858e089 issue#1040: Correct sizeof() issues with get_data_query_array() and get_graph_group() results (#1299) 2018-02-03 06:59:20 -07:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit cd8618f5fd More updates for issue #1072
- Moving the json_decode to associative arrays.
- Add update poller cache validation check that was previously missed
- Minor reformating of function calls, database calls, etc.
2017-11-23 08:30:08 -06:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00