Commit Graph
307 Commits
Author SHA1 Message Date
cigamit 504631343e Additional QA and Fixes for Issue #1060
- Add full sync cli tool
- Add force full sync option under settings
- Display last sync time from the Data Collectors page
- Upgrade script to add new poller column
2018-09-23 00:25:06 -05:00
cigamit 66f070acb5 Support both plugin and non-plugin table logic 2018-09-20 05:46:58 -05:00
cigamit f672020c57 Table create syntax not accurate 2018-09-18 04:26:54 -05:00
Mark Brugnoli-Vinten 07150a3643 Resolving issue #1927 (#1929) 2018-09-15 08:47:00 -04:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
Mark Brugnoli-Vinten e48f788d92 Resolving issue #1870 (#1917) 2018-09-12 20:01:18 -05:00
Mark Brugnoli-Vinten 0fb4f53809 Resolving issue #1897 (#1898)
* Resolving issue #1897

* Resolving issue #1899

* Further Resolving Issue #1899
2018-09-06 21:24:51 -05:00
cigamit 9c39f0f664 Add missing includes 2018-09-02 11:22:17 -05:00
cigamit 4cad68bf94 Protect against plugins including core files 2018-08-28 18:47:53 -05:00
Mark Brugnoli-Vinten 00ada9a130 Adding new script 'splice_rra' (#1875)
* Adding new script 'splice_rra'

* Correct QA issues

* Add missing copyright
2018-08-25 12:08:24 -05:00
cigamit bb42e5c7b8 Add lib/template.php to require 2018-08-21 17:39:35 -05:00
cigamit 5f31ca3137 Modify audit database to handle uft8mb4 2018-08-18 16:22:07 -05:00
cigamit e70e1ca956 Update audit database for 1.2
This does not include the utf8mb4 corrections
2018-08-18 16:12:08 -05:00
Mark Brugnoli-Vinten 826cbcb1b2 Resolving issue #1843 (#1844)
* Resolving issue #1843

* Added version-test.sh script used to test the programs

* Add header check, exit with errorlevels, skip index.php
2018-08-18 07:20:30 -05:00
cigamit a8c386bed4 Resolving Issue #1843
[1.2.0] Version Check against CLI scripts is failing
2018-08-17 20:59:13 -05:00
cigamit c32da7ad3b Remove debug code and fix add_graphs.php 2018-08-15 18:06:02 -05:00
cigamit 4b82fe44e0 Change syntax slightly fix some issues
To specify multiple host-ids, you need to repeat the parameter.  Regex
logic is OR logic.
2018-08-15 07:47:38 -05:00
cigamit a167d89183 Resolving Issue #1819
Removing Graphs using CLI
2018-08-14 20:57:43 -05:00
cigamit c2e4a5e16e Resolving syntax error 2018-08-11 12:35:09 -05:00
cigamit 5a17a9cecc PSR echo to print and proper return code 2018-08-11 11:54:43 -05:00
cigamit f3de95b5f8 Exit with 1 if there are parameter errors and PSR standards
Replace "echo" with "print" for PSR
2018-08-11 11:54:23 -05:00
cigamit a956da1301 Add missing include/cli_check.php script and additional fixups
- Remove the script data_template_associate_rra.php as it is not
compatible with Cacti 1.x
- Change all initial include() and include_once() to require
- Make sure --version returns correct version
- Pass 1 of ensuring bad parameters exit(1) more to come
2018-08-11 11:41:34 -05:00
Mark Brugnoli-Vinten 29bed92dc3 Resolving Issue #1824 (#1825)
* Resolving issue #1824

* Fix more fixes for REMOTE_ADDR
2018-08-11 11:08:27 -05:00
Mark Brugnoli-Vinten 6e1b8431b7 Fixes for Issues 1781, 1782 and 1784 (#1785)
* Fixes for Issues 1781, 1782 and 1784

This patch corrects the following issues:

- #1782 During Install, changing the Theme from Modern to another theme has no
        effect
- #1784 During Install, changing the Language from one to another has no
        effect
- #1781 Installer does not warn when mysql optimizations not set

As part of #1781's fixes, a new warning icon is displayed instead of a thumbs
up or down.  Additionally, recommendations have been revamped so that the ones
which are optionally (and some even state can be ignored) are now optional!

Also, introduced the correct calculation for innodb instances by taking the
buffer size during a previous recommendation and calculating from that.  If
the buffer size is never found or the calcuation finds less than 1 instances
are recommended, a minimum of 1 is set.

The main reason for #1782 and #1784's issues were caused by renaming index.php
to install.php as part of the recent security update (see PR #1747).  Updated
the javascript to use the correct install.php and then removed some extra data
that was being returned outside of StepData unnecessarily.

* Further fixes

This update corrects a number of issues with the database upgrading code, adds
the 'debug' plugin from cigamit, improves database functions to be more
consistent with errors across all functions and various installer based fixes
for the display and update of database upgrades.

It also brings a more visual response to the cli/upgrade_database.php so that
end users are not left wondering if something is happening.  Also, reviewed
all upgrade scripts to ensure that an upgrade from 0.8.8 through to 1.2.0 is
possible even if a previous database upgrade have been done.

* Fix QA issue with 'path_cactilog'

Due to some code reshuffle and testing, found that the above setting was being
read via read_config_option() before there was a database open so no path was
ever detected unless the force option was used.
2018-08-05 10:43:01 -05:00
cigamit 993d34ef95 Add Data Source should have correct help 2018-07-30 20:54:19 -05:00
cigamit 7e9c1b73c2 Correct syntax error in convert_tables.php 2018-07-28 18:58:26 -05:00
cigamit aec6e1ae6d Increase max table count to 1e06, and add --skip-innodb option
This will allow users or plugin developers to selectively skip
converting tables to InnoDB storage engine.
2018-07-28 18:29:34 -05:00
cigamit bbf40bc253 Stop convert tables from converting memory tables
This change will stop memory tables from being converted to InnoDB.
2018-07-27 17:24:43 -05:00
Mark Brugnoli-Vinten 2b61c1bba3 Further fix for Issue 1723 (#1728)
* Issue #1723 - die() messages should include \n for better logging

This corrects issue #1723 where die() messages appear in log files without a new line character causing logs to appear corrupted.

* Replace \n with PHP_EOF to be platform independant.
2018-07-21 15:17:14 -04:00
Mark Brugnoli-Vinten 5d075f62fc Feature #1034: Ensure tables are UTF8 (#1635)
* Feature #1034: Ensure tables are UTF8

* Make PHP 5.4 happy
2018-05-12 15:35:50 -05:00
cigamit fc32222f2e Minor logging changes per standard logging interpretation 2018-05-12 09:37:23 -05:00
cigamit 4e05e305aa Update audit_dataabse.php for latest schema 2018-05-08 20:52:27 -05:00
cigamit 4cac38344f Minor format changes 2018-05-06 13:08:19 -05:00
cigamit 801988f1be Resolving Issue #1602
PHP ERROR: Call to undefined function api_data_source_cache_crc_update()
2018-05-06 13:08:03 -05:00
cigamit 79c809a661 Undefined variable $displaySites 2018-03-30 11:06:51 -05:00
Dmitry e970396153 Resolving Issue #1491 (#1499)
* Resolving Issue #1491

* Fix description in help

* cli/add_datasource.php: "creating"->"adding"

* Different style fixes

* Remove --help
2018-03-29 17:27:12 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
cigamit a35411aa7b Resolving Issue #1468
Increase max length of host.snmp_sysObjectID column
2018-03-24 09:20:42 -05:00
netniV efa0495d7b Issue #1447: Cli audit_database.php not detecting database name (#1448)
Issue #1447: Cli audit_database.php not detecting database name, and failed to create audit tables when run from fresh due to invalid indxees.

MySQL was complaining about the key not all being NOT NULL for a PRIMARY key as opposed to being UNIQUE
2018-03-05 18:13:33 -06:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 0129b317c6 Add a default Device Template to the available presets
Saves time.  It seems jQueryUI does not allow typing into selecmenu's as
the normal select's work in most browsers.
2018-02-24 21:14:24 -06:00
cigamit 7e70e27940 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	include/themes/modern/main.css
#	tree.php
2018-02-18 16:26:26 -06:00
cigamit e244b9c324 Resolving Issue #1336
Set the zlib compression earlier in output stream for import_package.php
and remove from the import library
2018-02-14 17:34:29 -06:00
cigamit dcf2d312f8 Validate regular expressions if specified in add_graphs.php 2018-02-08 18:51:57 -06:00
cigamit d12cada232 Validate regular expressions if specified in add_graphs.php 2018-02-07 18:46:38 -06:00
cigamit 55f1eb8332 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	lib/html_tree.php
2018-02-06 20:44:28 -06:00
netniV aa0d248408 Fix for issue #1306 where multi-value args are not parsing correctly (#1313)
* Fix issue #1306 where multi-value args are not parsing correctly

* Fix up error reporting of multi-values
2018-02-06 17:44:03 -07:00
cigamit b25896415a Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-02-06 08:08:43 -06:00
cigamit 703ddcdbb4 Minor format changes in cli scripts 2018-02-04 15:14:08 -06:00
cigamit 42e8f91a44 Minor shbang update for removespikes.php 2018-02-04 15:09:15 -06:00