Commit Graph
259 Commits
Author SHA1 Message Date
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 4c5b06cc6c Correct issues from list view page 2018-08-26 10:33:47 -05:00
cigamit a520b65a4d QA: Resolve JavaScript Error
When going from tree.php edit page to the Graphs tab, you experienced
and error.
2018-08-19 16:10:49 -05:00
cigamit 15b90d52d8 Revert "Fixes issue 1717 and others (#1775)"
This reverts commit ca23733949.
2018-08-16 20:19:19 -05:00
Mark Brugnoli-Vinten ca23733949 Fixes issue 1717 and others (#1775)
* First round of changes for #1717

* Various QA fixes

* Further round of QA

* Add Content-Type to headers

* Another round of QA

* Allow full screen changepassword

* Redirect to permission denied page instead of displaying local message
2018-08-16 18:42:49 -05:00
cigamit 75189c61f9 Resolving Issue #1761
- Graph management shows bogus template names
- Additionally, allow Multi-selects to have a reasonable width
- For Non-Templated and Template Not Found, properly show those things
as select items in the filter.
2018-07-30 20:43:18 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit eea2a819b8 Resolving Issue #1581
Second commit to mass adding of graphs to reports.
2018-04-30 06:49:43 -05:00
cigamit 7d1dab24fa -issue: Graph List View was not fully responsive 2018-04-08 12:33:24 -05:00
cigamit a8cbe34bcb Resolving Issue #1507
This is a slightly different interpretation of the problem as the Graph
Template ID should not have been in the saved filter setting.
2018-04-04 19:24:23 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
cigamit 88fd10151b Correct a few formatting issues 2018-03-21 17:21:15 -05:00
cigamit e886bc35b6 QA Issues after Issue #1457
Page kept switching back to 1 due to pageset.  Also, switch to numeric
list validation type.
2018-03-18 13:28:42 -05:00
cigamit 35d1018fc9 Ensure message are displayed when viewing graphs on tree 2018-03-18 08:57:34 -05:00
cigamit 1707956caa Additional Sanitization for Issue #1457 2018-03-17 08:36:52 -05:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 7c8201f5a0 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-05 18:04:45 -06:00
cigamit c7c432bb94 Resolving Issue #1161
Graph View regex's are not preserved during automatic page refresh
2018-01-02 19:24:37 -06:00
cigamit fb6723408e Resolving Issue #1141
When viewing graphs from list view, pagination causes list view filter
to be cleared
2017-12-24 12:05:32 -06:00
cigamit 4097c0abfb Resolving Issue #1141
When viewing graphs from list view, pagination causes list view filter
to be cleared
2017-12-24 09:51:04 -06:00
cigamit 8ee60a9168 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	include/global_arrays.php
2017-12-24 08:54:22 -06:00
cigamit 8a42ab3aa7 Some pagination not translated into foreign languages 2017-12-24 08:11:25 -06:00
cigamit 251a22ecff Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
Updating feature 1.2 branch from Develop
2017-12-03 08:02:58 -06:00
netniV de304f9e84 Fix issue 1106 - Graph Filters: template filter have empty value (#1114)
he filter uses index 0 as "All Graphs and Templates" but then searches graph_local for matches against graph_template_id. However, if index 0 is passed as a variable, it is also used in the search. Now when I looked at my database, the following entry existed:

select * from graph_local where graph_template_id = 0;
+------+-------------------+---------+---------------+---------------------+------------+
| id   | graph_template_id | host_id | snmp_query_id | snmp_query_graph_id | snmp_index |
+------+-------------------+---------+---------------+---------------------+------------+
| 1837 |                 0 |       0 |             0 |                   0 |            |
+------+-------------------+---------+---------------+---------------------+------------+

Therefore, it displays an index, but can't get a name for the template since there is no template with ID 0.

select * from graph_templates where id = 0;
Empty set (0.00 sec)

Added code to check for a zero value and only search the databsae if a value is present.
2017-12-02 11:32:22 -05:00
cigamit c004b6beb4 Remove whitespace, use html_escape() 2017-11-19 15:03:04 -06:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit c44f082af0 Resolving Issue #1008
Remove developer debug warning about thumbnail validation
2017-10-11 19:16:19 -05:00
cigamit d6f6e2066e Resolving Issue #450
List View to Preview shows no results
2017-08-10 10:54:41 -05:00
cigamit 111dbe1400 Change multiselect default hight. Make a bit larger 2017-07-29 12:23:00 -05:00
cigamit 30bbf226f5 More changes for issue #861
Filters not working properly for i18n
2017-07-20 18:55:33 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit f850e57629 Freshed core filter html
In preparation for responsive filters phase II
2017-07-05 17:13:10 -05:00
cigamit b4c3c35c56 Resolving Issue #765
Validation error on Utility View page.  This issue also resolves issues
encountered on the Utility View page where Zoom was not updating CSV
output.
2017-06-04 09:39:35 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
Patrick e27a1b65da Small optimisations for threeview
- fixed several alignment issues

api_tree.php
- api_tree_rename_node() Removed 3 unused methodcalls
- api_tree_item_save() removed unused query
- api_tree_get_branch_ordering() defined fields in query

auth.php:
- defined tablenames for fields

html_tree.php
- draw_dhtml_tree_level_graphing()
  - removed unused parameter
  - moved get_allowed_graphs() call out of the foreach()

graph_view.php
- simplified the $matched queries
- typo in "update_timepsan" => "update_timespan"
2017-04-26 21:19:26 +02:00
cigamit 1c0932ce68 When updating dates, we have to feed the Cacti timespan session variables 2017-03-25 06:17:39 -05:00
cigamit 6d94ede57c Resolving four issues
- Aggregate and non-Device Graphs in list view had no Device or Title
- Re-engineer back button design to accomodate ajax and native
navigation
- Widen the jquery.multiselect text box for Graph Template selection
- Resolve some visual issues in Classic theme
2017-03-19 11:43:44 -05:00
cigamit f42de12353 Resolving Issue #450
Graph List view - No Graphs Found
2017-03-18 15:19:27 -05:00
cigamit f5eacff50d Resolving Issue #384
graph_view.php backtrace errors
2017-03-11 08:43:31 -06:00
cigamit 6f35a2e9c5 Resolve List view submit callback issue 2017-01-26 23:11:17 -06:00
cigamit bda7da40b4 Developer debug warning 2017-01-19 18:12:54 -06:00
cigamit aa97a7820e Resolving Issues #211 2017-01-16 07:45:48 -06:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit f9eb5f26ac Use less session variables
The jstree state plugin will reload the state.  This is one of two
commits to allow deep linking of URL again in Cacti.  Right now deep
linking on the tree is not functioning.  Change root tree icon to tree
icon.
2016-11-22 18:46:21 -06:00
cigamit c050b6f854 resolving bug#2791 2016-09-24 15:46:13 -05:00
cigamit d50e813867 wc3 validation, view button not functional 2016-09-01 17:16:50 -05:00