- Use the standard Cacti form logic
- Set sendmail path if it's available
Sendmail is optional, but we want to set it if it's available. So, it's
not entirely critical, but it could be. So, moving into the section of
the installer. Doing this also partially corrects an open issue as
well.
* Fixes for Issues 1781, 1782 and 1784
This patch corrects the following issues:
- #1782 During Install, changing the Theme from Modern to another theme has no
effect
- #1784 During Install, changing the Language from one to another has no
effect
- #1781 Installer does not warn when mysql optimizations not set
As part of #1781's fixes, a new warning icon is displayed instead of a thumbs
up or down. Additionally, recommendations have been revamped so that the ones
which are optionally (and some even state can be ignored) are now optional!
Also, introduced the correct calculation for innodb instances by taking the
buffer size during a previous recommendation and calculating from that. If
the buffer size is never found or the calcuation finds less than 1 instances
are recommended, a minimum of 1 is set.
The main reason for #1782 and #1784's issues were caused by renaming index.php
to install.php as part of the recent security update (see PR #1747). Updated
the javascript to use the correct install.php and then removed some extra data
that was being returned outside of StepData unnecessarily.
* Further fixes
This update corrects a number of issues with the database upgrading code, adds
the 'debug' plugin from cigamit, improves database functions to be more
consistent with errors across all functions and various installer based fixes
for the display and update of database upgrades.
It also brings a more visual response to the cli/upgrade_database.php so that
end users are not left wondering if something is happening. Also, reviewed
all upgrade scripts to ensure that an upgrade from 0.8.8 through to 1.2.0 is
possible even if a previous database upgrade have been done.
* Fix QA issue with 'path_cactilog'
Due to some code reshuffle and testing, found that the above setting was being
read via read_config_option() before there was a database open so no path was
ever detected unless the force option was used.
* Resolving issue #1689
As noted in issue #1689 (Technical Support's RRDTool version should show
detected RRD version) the version of the RRDTool is never actually displayed.
The code has now been updated to properly handle versioning and displays both
the configured and installed versions.
The setting for rrdtool_version has been updated to a proper minimum version
number so that the cacti_version_compare() function may be effectively used.
This means that the constant values of RRDTOOL_VERSION_1_3 through
RRDTOOL_VERSION_7 have now been removed from the system.
* Some QA updates
* Further QA fixes
* Feature #1588: Check that PHP can run a test file
* Feature #1628 - Allow the User to define a initial Network Discovery during Setup
* Fix QA issue with PHP 5.4
* Replace \n with PHP_EOL
* Minor changes to tabs vs. space and PHP_EOL
Will have to update packages based upon this too.
* Another minor pull where PHP_EOL was removed
* Beginning of Install via AJAX calls
* Added steps 3 & 4 to the installer system
* Add background update procedure. Still needs more upgrade code adding, like upgrading the DB
* Minor fixup during QA
* Remove debug code from lib/functions.php
* More QA fixes, add slight delay to index.php initialisation to see javascript warning (should be removed)
* beta3 - added data source profiles
* beta4 - fix some issues found in QA
* beta5 - upgrade databsae routines added, error results screen styled
* Add some colour to the thumb icons
* QA fix to remove unneeded option
* Fix for PHP 5.4 travis failure
* Remove default incorrect Spine binary path
When installating Cacti for the first time, with spine installed, the found path is (in my case) "/usr/local/spine/bin/spine/spine" instead of "/usr/local/spine/bin/spine".
* Update CHANGELOG
This is for the initial import case. Based upon QA, we have found that
if the php base level compression is different than the way the package
were created in the first place, that they are unreadable. Therefore,
this change ensures that all compression settings are consistent across
all operations including the yet unpublished package plugin.
Good catch on the bug fixes too. Hard to spot.
_______________________________________________________
* Updated Dutch translations
- Fixed i18n
* Defined fields in queries
* Fixed changelog
* Updated Dutch translations
* Various fixes
All committed files:
- true|false to lowercase
add_perms.php:
- displayGroups() was undefined
add_tree.php:
- duplicate case for '--quiet'
repair_templates.php:
- correction function call to diaplay_version()
gettext.php:
- PHP EOF unneeded
* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file
* Updated Dutch translations
- Fixed conflicts in translations
If the plugin architecture does not exist, install will fail. Also
found php function version_compare not working in PHP 5.3.x.
There were additionally issues with the upgrade functions as well.
Resolving those too.
- Fixed issue were version was not showing on results of upgrades steps
- Update CLI script to show successful results when debug enabled
- Removed empty install upgrades
- Attempted to resolve issue #671
Mark Brugnoli-Vinten