* First round of changes for #1717
* Various QA fixes
* Further round of QA
* Add Content-Type to headers
* Another round of QA
* Allow full screen changepassword
* Redirect to permission denied page instead of displaying local message
- Graph management shows bogus template names
- Additionally, allow Multi-selects to have a reasonable width
- For Non-Templated and Template Not Found, properly show those things
as select items in the filter.
- Discovered in QA
- Secpass password verification does not return meaningful error
messages
- Missing some i18n in login verification process
- Return missing function
- Correct customer error message instances to new display output
- Minor audit of functions for readability
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled
Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.
Changes made are:
auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions
auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set
user_admin.php
* Use new compat_password_xxx functions
lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions
* Update CHANGELOG
* Fixup for Issue #1122, corrects some minor issues
* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122
Update log message to be warning notj ust a normal message
* Fix issue of local auth bypas
* Update CHANGELOG
Fix up CHANGELOG issues
* Update auth.php
Fix up formatting issues
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled
Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.
Changes made are:
auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions
auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set
user_admin.php
* Use new compat_password_xxx functions
lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions
* Update CHANGELOG
* Fixup for Issue #1122, corrects some minor issues
* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122
Update log message to be warning notj ust a normal message
* Fix issue of local auth bypas
* Update CHANGELOG
Fix up CHANGELOG issues
* Update auth.php
Fix up formatting issues
This occurred due to the optimizations in pull request #1101. The
$sql_user must, in it's entirety, be enclosed in parenthesis.
Otherwise, expand host functionality breaks.
I've also added the site_id in this commit to reduce the effort in
attempting to maintain both the feature branch and the develop branch.
It's not used, but returned.
Cleanup includes some misqueues in the pull request as well as some
other miscelaneous changes associated with how we have landed on
formatting.
Chagne include:
* No soft tabs on initial tabbing
* ON clause of JOIN should be capitalized and on separate line
* AND/OR should be capitalized in SQL Queries
* Formatting of db_..() functions calls
* Use of sizeof() instead of isset() for array checks
* i18n of Secpass check return values
* Remove trailing whitespace from lines
- ToDo: Remove more having in place of WHERE clauses
* Update cacti.sql
Added 2 entry for cn_full_name and cn_email
* Update cacti.sql
Change the size to 50
* Create 1_2_0.php
Added the change on table user_domains_ldap, to provide info for full_name and email
* Update global_settings.php
Added the 2 new entry as new section for LDAP settings:
ldap_cn_fullname
ldap_cn_email
* Update auth.php
Added the email address on user_copy function
* Update ldap.php
Added the ldap_search_cn to search 2 specific CN on LDAP server
* Update auth_login.php
Added the Get user CN part for new LDAP users
* Update ldap.php
little error on ldap_search inside Getcn function
* Update user_domains.php
Add option to manage Full name and email taken from LDAP server
* Update auth_login.php
Change for multidomain authentication
* Update global_settings.php
change the name ldap_cn_xxx to just cn_xxx
* Update ldap.php
Correction to the error number and message when the CN is not find
* Update settings.php
Added the visibility of CN fields only for LDAP authentication mode
* Update ldap.php
correct on line 729 missing $ before this->cn
* Update cacti.sql
column definitions consistent with the definitions under install/upgrades/1_2_0.php
* Update auth_login.php
correct tab, as space, and add {} in if else statment
* Update ldap.php
correction on cacti_log with $output['error_text'], correction on all error_num 99 as '99'
and made some correction int tab/space
* Update auth_login.php
add missing {} on else function
Mark Brugnoli-Vinten