Commit Graph
86 Commits
Author SHA1 Message Date
Mark Brugnoli-Vinten 39efc75c49 Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939 (#1937)
* Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939

* Update import.php
2018-09-16 13:22:32 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 22d9444c31 Allow Import/Export to be hookable 2018-09-08 13:32:11 -05:00
Tom Yearke efc6b83466 Import: Fixed handling of references to objects not included in file (#1796)
* Import: Fixed handling of references to objects not included in file

When exporting an object with the "Include Dependencies" option disabled and then importing the resulting file, the import process will not complete successfully. This is because the mapping of object hashes to object IDs only tracks objects that have been included in the file.

This commit resolves the issue by first loading the mapping with all existing hashes and IDs before processing the file's objects. This results in the expected behavior when a referenced object is not in the file but is already loaded into the Cacti installation.

* Revised #1787 based on review from @cigamit

- Removed unnecessary double quotes
- Encapsulated `foreach` on possibly-empty array with size check
- Added whitespace

* Updated CHANGELOG to include #1796
2018-08-06 07:43:18 -05:00
cigamit d532a25723 Don't issue warning if zlib can not be changed. 2018-06-02 19:34:26 -05:00
cigamit bc9448b133 Resolving Issue #1559
CLI Output Issues due to over escaping
2018-04-21 18:35:19 -05:00
cigamit f59e60f9e5 Ensure compression levels are consistent
The import package function will fail when the web server has
compression enabled
2018-02-11 06:55:30 -06:00
cigamit 7199064681 Resolving Issue #1244
Errors importing templates with deprecated hashes
2018-02-11 06:55:29 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit e65c26d341 Remove debug code from import_package() function. 2017-12-31 13:40:06 -06:00
cigamit 1731dd4c46 Resolve issue with importation of packages
Additionally, update package version numbers to 1.1.29 to match the
Cacti version.
2017-12-31 13:38:38 -06:00
netniV f2790006af Fix Issue #1133 - Incorrect variable name (#1134)
* Fix Issue #1133 - Incorrect variable name

Fixed the incorrect use of $totle in place of $title resulting in database insertion errors.

* Update import.php

Fix debug display to match code.

* Update CHANGELOG
2017-12-21 07:49:03 -06:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
cigamit e961202f70 Resolving Issue #1048
Unable to import vdef's from templatesl
2017-10-27 06:52:44 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 86f719b923 Resolving Issue #989
- Spaces lost on re-import of data input method.
- Possible injection point in templates_export.php
- Minor format changes to db calls

Note that this will not 100% resolve the importation of old templates.
However, all new templates will base64_encode all input strings prior to
XML encoding, which resolves this issue ongoing.
2017-10-15 09:54:07 -05:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
John Horne 9b359d932a Trivial - removed tabbed blank line. 2017-06-02 17:12:35 +01:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
Tony Roman 27045ea52d Fixup install process to streamline releases
- Added and moved code to CACTI_VERSION constant
 - Merged cacti versions and hash codes array to have one place to add versions
 - Moved cacti version to file to facitate automation needs
 - Cleaned up cli database upgrade script
2017-05-01 08:58:29 -04:00
cigamit ab746b0e38 Add new field for graph templates to form actions
Increase the minimum import level for new templates, insure that new
templates imported with this column are saved properly, include
duplicate graph functionality, change field to a char(2)
2017-04-28 04:45:13 -05:00
cigamit 49e83d7fa1 Resolving Issued #580, #606, #608, #609
- Data collection warnings when using cmd.php
- Replace <path_php_binary> in data input methods
- Spaces adjacent to double quotes are eliminated durate data input
method import
- Horor the column setting in graph tree view mode
2017-04-24 20:40:05 -05:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
cigamit 50ecf39e24 Resolving Issue #500
Generic SNMP Device Packaged Damaged - Unix Ping Host input variable not
replaced.
2017-04-01 12:11:28 -05:00
cigamit 97f87eacdb Fully implement remove orphans from Graph Template import process
It's recommended to always remove orphans as not doing so will leave
remnants of older template versions in your Graph Templates.
2017-03-25 10:48:33 -05:00
cigamit 2a1eb67dca Resolving Issues #330 and #380
-issue#330: Import templates to non-default Data Profile
-issue#380: Cacti ignores a non-standard SNMP Port
-issue: Importing Template from old Cacti would not show Data Templates
from GUI
2017-03-11 08:29:17 -06:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
cigamit 0ba5711f09 Rework Import Functions
Move package import to lib/import.php.  Create new import_package.php
CLI script.  Make output logging an import function.
2017-01-08 11:02:03 -06:00
cigamit d0fafdbe13 Move logging to 'HIGH' level for import. 2017-01-07 13:41:52 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit 480ca77b68 Resolving #119
Please backup your database before re-runnning the upgrade script.  This
change requires rerunning the upgrade script even though it has been
tested.
2016-12-30 13:19:06 -06:00
cigamit c5e1e8a0b3 Updates for remote polling
Note that you will need to rerun you database upgrade after thsese
changes.  Some a new table and some new columns have been added to
support remote polling and if you don't make these database changes,
your Cacti system may stop operating.
2016-12-26 17:00:07 -06:00
cigamit 7269cbfd88 Committing prototype of replication api for team review
Part of multiple polling is to support either MySQL replication, or to
replicate tables requred for remote data collection.  These changes will
enable the later method, but are not complete.

The replicate_tables in lib/poller.php function is designed to handle
each of the table replecation types.  When complete, it will handle all
table replication based upon poller state.

There may be additional table schema changes to increase performance,
but those changes have not been validated yet.
2016-12-19 21:44:34 -06:00
cigamit 23ca0548c0 enable viewing new and orphaned graph items 2016-09-19 18:33:49 -05:00
cigamit 153e8df641 resolving bug#851 2016-09-19 16:37:59 -05:00
cigamit 7bbea5777f use the default profile_id on import if not specified 2016-09-10 11:50:48 -05:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote
this is required for preparation of magic_quotes_gpc.
2016-08-28 15:27:48 -05:00
Micke2k 0fef67d0a6 Attempt at fixing step and heartbeat during import
Step and heartbeat was always set to default when importing profiles with a newly created datasource_profile(example 1 minute polling profile).

Now step and heartbeat is read from the profile.

New installations and upgrades do not have a datasource_profile. $profile_id is returned as an array in that case. Not to happy about the fix for that, but it works.

Tested import with default profile, 1 minute polling profile as well as new installation import of Disk IO. Works fine.
2016-04-09 21:58:10 +04:00
cigamit 8f11b3c112 more removal of rra_id 2016-03-19 09:52:26 -05:00
Micke2k 07826332db Undefined variable: import_custom_rra_settings in import.php
Changed to import_as_new
2016-03-19 17:24:31 +04:00
cigamit 39bbb23ac5 implement data source profiles
this commit will cause your 1.0 environment to break.  to fix, please
run the script 'profile_migrate.php'.  this commit includes a major new
feature to allow your Cacti system to have multiple polling intervals
and for you to create identical graphs using multiple polling intervals
in a sane way.  this is an initial commit, one that has been tested.
however, there will be subsequent commits.  however, after migration,
this should be considered stable.
2016-03-14 06:59:54 -05:00
cigamit 2e236dcbdf big commit back porting features
back port the following features from main:

1) vdef support
2) new graph items
3) new graph options

this covers all the high points available in rrdtool today.

also change the following:

1) allow forms to include spacers
2) reorganize graph template form with spacers
3) many help wording back ports from main

for those testing, if you are going to start using this version, you
will have to implement the changes in the upgrade script or reinstall.
also note that this change may break new aggregates.
2016-03-09 20:43:52 -06:00
Linegod f31c7b6835 first spellcheck pass 2016-02-07 23:12:03 -06:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
Jimmy Conner 5bde3da972 1) Update Copyright Years Correct a few minor CY Issues
2) Allow Locking/UnLocking of Graphs
3) ToolTips
4) Correct Minor Issues with Login/Out/Permission associated with Theme JS
5) Upgrade jQuery which has Fixes for Major issue in Safari 7/8.1

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7662 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-04 01:52:50 +00:00
Jeff Pasnak 6e9f636abf #0002492 - Standardize mysql syntax - final pass
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7621 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-12-28 21:09:38 +00:00
Jimmy Conner ac6d6929cc Remove some unnecessary ending PHP closing tags
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7571 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-12-17 03:02:03 +00:00
Tony Roman 65be30ffe0 Update copyright to 2014
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7437 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-03-30 19:54:50 +00:00
Tony Roman ce40281901 Update copyright to 2013 for 0.8.8
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7386 860744bd-22fc-0310-8c96-e9fe5004b5ca
2013-07-21 23:00:42 +00:00
Tony Roman a257958a0b Update copyright to 2012
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@7016 860744bd-22fc-0310-8c96-e9fe5004b5ca
2012-02-27 07:04:37 +00:00