Commit Graph
113 Commits
Author SHA1 Message Date
TheWitness bf292d5d57 Additional update on #4035
This is based upon recommendations. to pre-sanitize the referer always and we don't want to double sanitize.
2021-01-06 12:15:22 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
kim-fitnessandTheWitness 90f2325df3 Fix issue #3828 (#3829)
* Update CHANGELOG

* Fix issue #3828

* Minor change

Co-authored-by: TheWitness <thewitness@cacti.net>
2020-09-28 21:22:51 -04:00
TheWitness 3e5a081f8a Fixing Issue #3607
Can't access log after been kicked out by timeout
2020-06-13 06:38:36 -04:00
TheWitness c1233947e6 Fixing Issue #3551
Web Basic Authentication and Template User broken in 1.2.12
2020-05-11 19:31:39 -04:00
ddb4github 4b9052b722 Fixed: #3510: Normal user can not access '$guest_account=true' pages (#3511) 2020-04-29 14:25:30 +01:00
ddb4githubandJing Chen a871a05a4f Apply 'custom_denied' hook to permission denied branch in include/auth.php (#3475)
* Add a new UI hook custom_denied like existing hook custom_login/custom_logout_message

* Update CHANGELOG for #3480 (#3475)

Co-authored-by: Jing Chen <three_chenjing@sohu.com>
2020-04-19 19:50:56 -04:00
TheWitness 9c88c4bcb3 More upgrade errors 2020-03-08 15:57:31 -04:00
cigamit c0b21c8aac Resolving Issue #32246
When processing secpass login, failed logins are not recorded
2020-02-02 11:16:24 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit d04fb8d176 Resolving Issue #2707
Some pages that have permission errors dont raise proper messages
2019-05-27 11:02:20 -05:00
netniV 787352c122 Allow remote pollers to upgrade themselves 2019-03-26 22:00:34 +00:00
netniV f1082922c9 Resolving issue #2384
If current authentication method is set to None, change to Builtin.

To achieve this, the code will look for a valid administration user that will be used to reset the password.  This is achieved by searching for the Primary Admin, and then any admin with console access.  Once an admin has been found, the must_change_password and change_password flags are set, the password is cleared and the user is automatically logged in before being forced to change the empty password.

If no admin can be located, the script will die to prevent issues and allow manual fixing of the problem.  The simpliest way to do this would be to utilise the INSERT statement that is used for the 'admin' user in the cacti.sql's user_auth table, plus the INSERT for user_id 1 into the user_auth_realm table.
2019-02-14 14:41:54 +00:00
netniV 85bc99c2a7 Resolving issue #2359
Sometimes the upgrade privileges are not automatically applied if the system version was above 1.2 already.  This version dependancy has been removed to always ensure that the privilege is granted should all administrators lose that privilege.
2019-02-08 21:56:31 +00:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit cef4bd8671 -issue: align attribute is deprecated, use class instead 2018-11-10 11:35:55 -06:00
cigamit 15b90d52d8 Revert "Fixes issue 1717 and others (#1775)"
This reverts commit ca23733949.
2018-08-16 20:19:19 -05:00
Mark Brugnoli-Vinten ca23733949 Fixes issue 1717 and others (#1775)
* First round of changes for #1717

* Various QA fixes

* Further round of QA

* Add Content-Type to headers

* Another round of QA

* Allow full screen changepassword

* Redirect to permission denied page instead of displaying local message
2018-08-16 18:42:49 -05:00
cigamit 06546bf046 Minor QA issue with guest account change 2018-08-07 19:13:37 -05:00
cigamit 2de208331f Resolving multiple issues with guest and template accounts 2018-08-07 18:22:31 -05:00
Mark Brugnoli-Vinten ed57331dfd Fixes for Issue 1729 and 1730 (#1747)
* Fixes QA issues with upgrades from older versions

* Redirect install/index.php to install/install.php

* Further QA fixes

* Ensure upgrade matches new password field length

* Add 'Installation In Progress' message

* Fix QA issues
2018-07-25 08:45:41 -04:00
Mark Brugnoli-Vinten ddddaec6ae Ajax Installer (#1586)
* Beginning of Install via AJAX calls

* Added steps 3 & 4 to the installer system

* Add background update procedure.  Still needs more upgrade code adding, like upgrading the DB

* Minor fixup during QA

* Remove debug code from lib/functions.php

* More QA fixes, add slight delay to index.php initialisation to see javascript warning (should be removed)

* beta3 - added data source profiles

* beta4 - fix some issues found in QA

* beta5 - upgrade databsae routines added, error results screen styled

* Add some colour to the thumb icons

* QA fix to remove unneeded option

* Fix for PHP 5.4 travis failure
2018-04-29 10:05:32 -05:00
cigamit 3ba47881c5 Additional Sanitization for Issue #1457 2018-03-17 08:29:13 -05:00
cigamit 9b48dfc4a8 Resolving Issue #1309
Provide meaningful authentication errors in graph_json.php and
graph_image.php
2018-02-06 19:28:29 -06:00
cigamit d3536ed321 Consolidation for Issue #1305
Code reduction by making all the header into a function.
2018-02-04 22:01:16 -06:00
cigamit 671fa2f736 Regression and QA on Issue #1305
Missing some files and settings.  We should really just have a common
header function to reduce the chances of variation.
2018-02-04 14:09:56 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit ac7b58a741 Resolve JavaScript errors on Permission Denied pages 2017-08-19 09:06:47 -05:00
cigamit 1a14cbb440 Introduce new get_cacti_version function to reduce database calls on pages 2017-05-14 12:29:30 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
Tony Roman 27045ea52d Fixup install process to streamline releases
- Added and moved code to CACTI_VERSION constant
 - Merged cacti versions and hash codes array to have one place to add versions
 - Moved cacti version to file to facitate automation needs
 - Cleaned up cli database upgrade script
2017-05-01 08:58:29 -04:00
cigamit e2243f62d2 feature: Make Cacti more tolerant of empty PHP_SELF on some web servers 2017-04-22 08:22:01 -05:00
Patrick 9499d3bcbb Small optimisations and bugfixes:
auth.php:
- placed result of get_selected_theme() in var

functions.php:
- mailer():
  - fetch date from setting by caching method
  - read_config_option('settings_from_email') unnecessary
  - 2x undefined function $mail->replyTo() (should be addReplyTo())
- calculate_percentiles()
  - Final return statement has undeclared variable; I believe this should be results instead of result, but could not reproduce

index.php:
- only fetch the fields needed for querying external_links
- 2x </td> instead of </tr>
2017-04-04 11:42:28 +02:00
cigamit 3c7ef42902 Resolving Issue #329
Also first step in resolving issue #186
2017-02-23 17:40:19 -06:00
cigamit 75c6359894 Resolving Issue #329 2017-02-22 20:03:17 -06:00
cigamit b5e8984a35 Resolving Issue #251 2017-02-01 17:17:39 -06:00
cigamit afc256c3c2 Re-add Copyright to login, with robots Meta 2017-01-27 23:16:42 -06:00
cigamit a2f20b80ea Make permission denied messages consistent. 2017-01-16 20:49:10 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit da27a9cb6d add font-awesome to additional pages 2016-12-21 21:08:25 -06:00
cigamit 3fc496bfe2 Remove version info from Login screen
Necessary for externally accessible sites
2016-10-26 21:55:46 -05:00
cigamit 81f39d4dc1 use html5 doctype 2016-09-05 13:38:14 -05:00
Browniebraun c898114219 make use of i18n function calls. 2016-03-31 19:01:05 +02:00
cigamit f2edfcbe53 update theme to a user setting 2016-02-14 10:48:34 -06:00
cigamit cf9aba7635 set $current_user for each page load
allows this global to be used by various aspects without having a
separate call.
2016-02-13 09:13:53 -06:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
cigamit a80afac086 correct typo in auth.php
correcting small typo
2016-01-17 19:20:08 -06:00
cigamit 04a7e14080 resolving Bug:2617 2016-01-17 16:33:37 -06:00
cigamit 3b33a55ca4 Correct issues with multiple domains
Plugin merge testing
2015-08-08 20:58:32 -05:00