* feature 3965, Add a value check if the input field is textbox in settings
* feature 3965, revert
* Fix#3999
* Refix issue #3999, wrap mysqldump into db_dump_data()
* Fix issue #3999, update the db_dump_data() to minimize password be caught.
Co-authored-by: yboliu <yboliu@oc8636837557.ibm.com>
This commit adds a notice when configphp is present but unreadable. It also adds the ability to display any database connection errors that occur within db_connect_real for diagnostic purposes. These notices are only presented to the end user when the appropriate flag is set as most users do not need them.
Closes#3181 and closes#3182
-issue#2590: Language selection is not working as expected
-issue#2605: When checking for tables to upgrade, undefined variable $config error occurs
-issue#2608: db_update_table() function should not require an engine type or comment
-issue#2610: Data Sources troubleshooter generates warning that each() function is deprecated
Closes#2590, 2605, 2608, 2610
Some cloud SQL providers do not make the textual default_time_zone
configurable. While a manual offset value (e.g. -04:00) can be
configured for this value, that's not too convenient in places that
observe DST.
By exposing the poller timezone configuration for all pollers, it's
possible to override this default with a textual zone name if desired.
This allows the row format to be dynamic only when the
innodb_file_format is Barracuda, and corrects a bug in detecting MySQL
vs. MariaDB in the version string.
* Correct issue with template and table selections
* More QA on Tables
* Make LDAP slowness not block sessions
* Resolving issue #2015
* Add some extra logging items for RECACHE event
This patch adds functionality to control the debugging of low level routines
via defines within the config.php file. In order to allow flexibility, if
these are defined, variables within the $config array are primed as true,
otherwise false.
These elements within the $config array are defined in uppercase to highlight
the difference between these are other ordinary configuration optios.
Should a function or program need to enable debugging of these various
options, simply setting the value to true in the $config array will enable
logging from that point. Inversely, setting it to false will stop logging
from that point.
The only option that is of limited use is DEBUG_READ_CONFIG_OPTION_DB_OPEN
that will only work up to the database being open. Setting this to true
after the database has already been opened will not automatic turn off the
companion option DEBUG_READ_CONFIG_OPTION since the db_connect_real() will
not be called again.
The list of options and their functionality are:
- DEBUG_READ_CONFIG_OPTION : record use of read_config_option()
to cacti-option.log in the system temporary folder
- DEBUG_READ_CONFIG_OPTION_DB_OPEN : Once the database has been
successfully opened, disable DEBUG_READ_CONFIG_OPTION
- DEBUG_SQL_CMD : Always write a copy of the SQL being requested
to the cacti-sql.log file in the system temporary folder
- DEBUG_SQL_FLOW : Write flow of db_xxx calls to the cacti-sql.log
in the system temporary folder.
The system temporary folder is normally set to one of the following:
- Linux, CLI: /tmp/
- Linux, WEB: Apache/Ngix's temporary folder
- Windows, CLI: %TEMP%
- Windows, WEB: Temp folder of web user or %WINDIR%\TEMP
This patch should correct some functionality issues within read_config_option()
so that settings are not incorrectly primed if the databsae is not opened yet
as noted in #1802
* Fixes for Issues 1781, 1782 and 1784
This patch corrects the following issues:
- #1782 During Install, changing the Theme from Modern to another theme has no
effect
- #1784 During Install, changing the Language from one to another has no
effect
- #1781 Installer does not warn when mysql optimizations not set
As part of #1781's fixes, a new warning icon is displayed instead of a thumbs
up or down. Additionally, recommendations have been revamped so that the ones
which are optionally (and some even state can be ignored) are now optional!
Also, introduced the correct calculation for innodb instances by taking the
buffer size during a previous recommendation and calculating from that. If
the buffer size is never found or the calcuation finds less than 1 instances
are recommended, a minimum of 1 is set.
The main reason for #1782 and #1784's issues were caused by renaming index.php
to install.php as part of the recent security update (see PR #1747). Updated
the javascript to use the correct install.php and then removed some extra data
that was being returned outside of StepData unnecessarily.
* Further fixes
This update corrects a number of issues with the database upgrading code, adds
the 'debug' plugin from cigamit, improves database functions to be more
consistent with errors across all functions and various installer based fixes
for the display and update of database upgrades.
It also brings a more visual response to the cli/upgrade_database.php so that
end users are not left wondering if something is happening. Also, reviewed
all upgrade scripts to ensure that an upgrade from 0.8.8 through to 1.2.0 is
possible even if a previous database upgrade have been done.
* Fix QA issue with 'path_cactilog'
Due to some code reshuffle and testing, found that the above setting was being
read via read_config_option() before there was a database open so no path was
ever detected unless the force option was used.
TheWitness