Commit Graph
387 Commits
Author SHA1 Message Date
browniebraun e00fee5ad1 show progress on midwinter
- new UI mode added (still alpha state)

Next commit will focus on:
- moving new UI mode from alpha to beta phase
- migrating all colors from RGB to HSL
- introduce light color mode
2021-02-09 16:38:57 +01:00
TheWitness 8b42b65634 More compatible solution to #4040 2021-01-10 09:21:50 -05:00
TheWitness 7fb8f88c26 Revert "Partof4035 (#4040)"
This reverts commit e8ed844e50.
2021-01-10 09:06:38 -05:00
YongBoLiuandyboliu e8ed844e50 Partof4035 (#4040)
* feature 3965, Add a value check if the input field is textbox in settings

* feature 3965, revert

* Fix part of #4035, XSS security issue from WebScan report

Co-authored-by: yboliu <yboliu@oc8636837557.ibm.com>
2021-01-07 06:07:45 -05:00
TheWitness bf292d5d57 Additional update on #4035
This is based upon recommendations. to pre-sanitize the referer always and we don't want to double sanitize.
2021-01-06 12:15:22 -05:00
TheWitness 84f75268e0 Additional changes around Issue #4035
XSS security issue from WebScan report
2021-01-06 09:07:48 -05:00
TheWitness cc13fca8ac Correcting 2/3 Issues in #4033
- Two of three issues resolved
- XSS security issue from WebScan report
- Data Template unable to reproduce
2021-01-05 22:00:48 -05:00
TheWitness d254477f1a Fixing Issue #4033
Change Hide Graph Action Icon's to 'Show' Action Icons
2021-01-04 22:24:04 -05:00
TheWitness bc632bc30d Fixing Issues #3945 and #4031
* Graph CSV export NaN with wrong date range if browser timezone is different with web server
* Data Collectors and Data Profiles Filter Sub-Panel Go buttons not working as expected
2021-01-04 20:25:14 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness ef10fe1c34 Fixing Issue #4019
* In a recent audit of core Cacti code, there were a few stored XSS issues that can be exposed
* Also removed a few spurious title_trims, that should no longer be a problem.
2020-12-23 16:33:27 -05:00
Datatech UK LtdandTheWitness 997f1f9245 Add ability to Hide the Graph Drilldown icons from the graph_view.php and graph.php pages (#3923)
* Update main.css

Make it more obvious that a slider is disabled.

* Update main.css

Make it more obvious that a radio slider is disabled.

* Update cacti.sql

Fixed the default value for the 30 second polling and amended the default values for the 1 minute polling for new installs

* Add ability to Hide the Graph Drilldown icons from the graph_view.php and graph.php pages
The icons are on the right hand side of the graphs and the default behaviour is to display them unless you hide them per user in the permissions tab

* Updated CHANGELOG

* Change the Realm from 2001 to 27 as 100 and above are reserved for plug-ins.

* Formatting change for neatness.

* Update CHANGELOG to reference this ticket number. Changed Drilldown to Drilldowns

Co-authored-by: TheWitness <thewitness@cacti.net>
2020-11-20 09:34:43 -05:00
TheWitness 97118412d5 Fixing Issue #3825
Unable to pass tree and leaf ID to 'graph_button' hook
2020-09-24 14:30:28 -04:00
TheWitness a37dbfabda Minor tweak to CSP for Issue #3808
Add image source extensions
2020-09-17 08:48:53 -04:00
TheWitness 6fe7d8d41e Fixing Issue #3808 - Alternate Sources for CSP
Allow Users to Specify Alternate Sources for Content-Security Policy
2020-09-16 19:32:31 -04:00
TheWitness 001e6165e8 Reworking limits solution due to inconsistent jqueryui behavior
This is related to issue #3769
2020-09-07 10:45:24 -04:00
TheWitness f49c222d36 Last bit of Fixing for Issue #3769
* Use display:table for cactiContent to properly display tables
* Remove include for fontawesome.css in place of all.css recommended in fontawesome 5.14
* Add permissions setting for relaxing table snap (hScroll)
* Remove some duplicated CSS for some classes
* Ensure that we are properly setting overflow for each typ of event
* Ensure that table resizing works as expected and that graph pages allow enough room for action icons.
2020-08-30 09:11:31 -04:00
TheWitness e78e05f482 Finalize Issue #3769
This makes the hScoll changes avaiable from you table filters.  Change fontawesome to also use all.css, which is correct for version 5.14.
2020-08-29 20:27:13 -04:00
TheWitness 89d069e7fd Fixing Issue #3769
Some users prefer to see all columns on the screen and do not wish that they be hidden despite the page size
2020-08-26 21:31:44 -04:00
JeffandMark Brugnoli-Vinten 99d3bf86b8 Streamline Spikekill options (#3716)
Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
2020-07-23 16:16:09 +01:00
TheWitness a8e43b12f2 Fixing Issues #3663, #3655, #3651, #3681, #3668, #3669 (#3680) 2020-07-12 00:55:18 +01:00
TheWitness 039ee7684b Fixing Issue #3624
Cacti v1.2.12 In preview mode graphs sometimes fail to Draw
2020-06-17 21:09:05 -04:00
TheWitness 47f111ccb3 Fixing Issue #3598
When editing graphs and graph templates, back button results in broken page
2020-06-07 13:10:29 -04:00
TheWitness 8d5fbc48de Fixing Issue #3549
Several XSS Vulnerabilities
2020-05-11 20:27:15 -04:00
TheWitness 7f1d670759 Raise Cacti lighthouse accessibility score above 90%
Some of the lighthouse audit results are invalid.  The main console has a score of 95 now, and other pages 82, but when reviewing the results, there is only one failing test, which there is no real good solution for at the moment.
2020-04-25 13:32:56 -04:00
TheWitness dd6c20c250 Fixing Issue #3452
New Content-Security-Policy prevents External Links from Operating
2020-04-10 11:04:32 -04:00
TheWitness abaef8fa7b More testing resulting from #3402 and possible solution to #3400
* Revised 'Content-Security-Policy' tested on FF, Chrome, Edge, Opera and no issues found.
* Adding the Multiselect Filter as it's critical for some initial page loads like the Graphs page for Templates which include the 'Search' functionality.
2020-04-05 14:51:09 -04:00
TheWitness 21d54d6937 Multi-select needs to be critical related to issue #3402 2020-04-05 13:58:48 -04:00
TheWitness 696d180b62 Another tweak to #3402
Errors happen when you direct link to the Graphs page.
2020-04-04 11:42:46 -04:00
TheWitness ad2e833950 Additional testing on #3402
On a few pages, these JavaScript elements become crucial
The no-cache does not actually mean 'no-cache'.
2020-04-04 10:42:48 -04:00
TheWitness aef6bacb51 Two minor fixes as a result of auditing
For some reason, I had layout.js lazy loading.  Tablesorter is critical too.  Have to figure out why that one is.
2020-04-04 09:32:57 -04:00
TheWitness a8ea533640 Additional changes for #3402
* These changes allow some JavaScript to be loaded Async.  jQuery and jQueryUI as well as layout.js as well as the themes's main.js are critical and can not be loaded async.
* It also adds the meta description tag to increse the SEI scrore
2020-04-04 09:17:27 -04:00
TheWitness 78c8df9d7d Another update to Issue #3288
* When on Device page, pressing 'Go' on the filter caused Device New menu pick to appear
* The case that was missed was a direct link to the page.  Now that works too.
2020-04-03 12:09:44 -04:00
TheWitness 6a2d781778 Fixing Issue #3374 Cacti Cookie Domain
* Allow Setting of Cookie 'Cacti' domain edition
* This also allows the Cacti administrator to extend the content security policy to include unsafe-eval for scripts.
2020-03-24 19:12:48 -04:00
TheWitness da8038c37f Minor theme tweaking 2020-03-22 11:15:57 -04:00
TheWitness cb8711eb79 Fixing Issue #2534
Enhance the html_nav_bar() in the lib/html.php to support larger system
2020-03-16 20:20:52 -04:00
TheWitness 4f0ef757c1 Fixing Issue #3336
Plugins such as mapping plugins need to relax content security policies
2020-03-09 22:12:54 -04:00
cigamit 3465c33235 Resolving Issue #3312 for color_templates_items.php too 2020-03-08 12:23:44 -05:00
cigamit ff0511a3c1 Resolving Issue #3312
* Minor:Console menu does not auto-expand for graph item editor page
* This affects graph_items.php and graph_templates_items.php.
* In Cacti 1.3, we should remove these two files and merge the functions into the core file.
2020-03-08 12:18:41 -05:00
cigamit 533220cd17 Resolving Issue #3233
Its difficult to determine what Graph Items represent when working with a non-templated Graph
2020-02-07 18:43:50 -06:00
TheWitness 89e596571f Add blob: per issues #3195
Adding the blob: attribute to images per finding in issue #3195
2020-01-18 18:09:18 -05:00
cigamit 06b606b8d3 Resolving Issue #3142
* Chrome sets graphs tree navigation view to width 0px
* Also correct issues with CSP migration
2020-01-17 18:33:47 -06:00
TheWitness 4dfa1b1844 Fixing Issue #3193
Minimuze use of eval() in JavaScript due to emerging Content-Security-Contexts guidelines
2020-01-16 18:22:29 -05:00
TheWitness 412495aa42 One additional change to #3188
This changes prevents Cacti from being included as a frame in other applications.
2020-01-14 21:45:58 -05:00
TheWitness 1e10b9b8b8 Additionall updates for #3188
This allows Cacti's images to be rendered which include that are of type data:
2020-01-14 21:32:40 -05:00
TheWitness 3a9db45b48 Fixing Issue #3188
Cacti should add Content Security Policy to increase protection against XSS attacks
2020-01-14 21:08:32 -05:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
TheWitness 4fc2ae0fa8 Fixing Issue #3158
Classic theme show only 3 tabs on mobile device. Don't show Console menu
2020-01-02 13:54:55 -05:00
cigamit 75156ac291 Additional testing for issue #3055 2019-11-29 11:13:48 -06:00
cigamit 7371253292 Resolving Issue #3055
Installer database connection checks for remote pollers
2019-11-29 10:49:37 -06:00