Commit Graph
347 Commits
Author SHA1 Message Date
TheWitness 36269461cb Additional fixup's to #4080
This change provides additional fixups.  Though the problems is really the regular expression and beyond Cacti's control.
2021-02-07 10:47:33 -05:00
jav4andTheWitness 21adc51494 Use actual graph sizes instead of a single size (#4069)
* Use actual graph sizes instead of a single size

Loop was reusing last local_graph_id value from previous loop, instead of using actual one, so all graphs were using the same size.

* Update CHANGELOG

Co-authored-by: TheWitness <thewitness@cacti.net>
2021-01-21 19:05:44 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness ef10fe1c34 Fixing Issue #4019
* In a recent audit of core Cacti code, there were a few stored XSS issues that can be exposed
* Also removed a few spurious title_trims, that should no longer be a problem.
2020-12-23 16:33:27 -05:00
TheWitness cbff6f70f8 Fixing Issue #3868
Under some cases tree logic leads to undefined index errors
2020-10-17 11:00:11 -04:00
TheWitness 97118412d5 Fixing Issue #3825
Unable to pass tree and leaf ID to 'graph_button' hook
2020-09-24 14:30:28 -04:00
TheWitness 06cbd911fb Fixing Issue #3775 and other minor issues
* Need to redefine the applyFilter as it's still defined for the 'go' action on the graphs page.
* The base64_encode in layout.js does not encode properly for in all cases
* Prevent the validate function from being called twice on a full page refresh
* Add the rfilter to timespan actions just in case the user has set it and not hit enter to filter
2020-08-30 13:05:25 -04:00
TheWitness dc35a79b15 More fixing for issue #3549
Several XSS Vulnerabilities
2020-05-20 22:46:36 -04:00
TheWitness 60fdd2b05b Additional fixing for issue #3505
When viewing graph previews, clicking Go or Refresh prevents calendars from working
2020-05-14 08:49:59 -04:00
TheWitness 23dc0cc16a Tree searcher sizes to 0 bytes width until page resized 2020-03-14 16:12:40 -04:00
TheWitness efa566e0e5 Fixing Issue #3335
Unable to hide Device based Aggregate Graphs on Tree
2020-03-09 21:27:31 -04:00
cigamit 06b606b8d3 Resolving Issue #3142
* Chrome sets graphs tree navigation view to width 0px
* Also correct issues with CSP migration
2020-01-17 18:33:47 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 167a094812 Provide a bit more bottom space for modern 2019-11-10 16:41:37 -06:00
cigamit 93ff2bf4bb Resolving Issues #1228, #2888, and #3021
* Any tree or branch with a long name force main content off screen
* Long hostnames cause template filter to go off page
* Tree view cuts off at the bottom of page on modern theme
* Introducing new settings Min Tree Width and Max Tree Width in Settings > Visual and User Profile.
* Corrects a major slowdown in graph templates are presented due to removal of very slow textWidth() function.
2019-11-10 11:43:49 -06:00
cigamit 2d5f1ac1f9 One more update for issue #3079
* Allow for domain names to be stripped from long device descriptions
* This changes strips from the tree branch/leaf name.
2019-11-09 18:51:04 -06:00
cigamit f681eef4f0 Resolving Issues #3050 and #3053
* CMDPHP Validation Error - thumnails in Graph View
* Improper validation call prior to plugin call
2019-11-09 11:02:06 -06:00
cigamit bab6a2ec30 Resolving Issue #2973
Can not show user menu well on mobile devices
2019-09-28 14:36:48 -05:00
cigamit 84b661b5f4 Resolving Issue #2952
In tree view if device is marked down or threshold triggered mark as red
2019-09-21 11:03:35 -05:00
cigamit 89895eecdb Resolving Issue #2808
Tree margin changing during Tree navigation
2019-07-07 09:57:25 -05:00
cigamit face3064b9 Resolving Issue #2699
Login Options: "Show the page that user pointed their browser to" Not Working
2019-05-22 18:26:06 -05:00
cigamit 00d47b4e45 Resolving a number of validation errors 2019-05-22 17:39:34 -05:00
ddb4github dfc6b64595 Fixed: Resolved some PHP NOTICE about undefined variables #2650 (#2651)
* Fixed: Resolved some PHP NOTICE about undefined variables.

* Fixd previous fixing. Should add 'global $l10n' only

* Fixed: typo miss '$'

* Minor change
2019-04-27 21:26:17 +06:00
sysres-dev e7b54490b5 Resolving issues 2538,2539,2540 (#2552)
* Fix CHANGELOG (#2533)

* Update Travis information

* Resolving issue #2532

Ensure Graph ListView table is displayed in line with Management -> Graphs

* Add missing lib/graphs.php

* Improve performance on graph_view's tree_content action by reducing the number of SQL queries executed

* Resolving issues 2538,2539,2540

This commit is related to features requests 2538,2539,2540 :
2538 : new setting to change datasource behaviour when deleting graph
2539 : new setting to add permanent unlock of graphs
2540 : new setting to forget graph tree history on tab close

* tree_history description

changed description for tree_history

* Minor Cacti PSR Update

* Minor Cacti PSR Change

* Minor Cacti PSR Change

* Relocate setting and change gramar

* Minor language change

* Minor format change
2019-04-23 07:57:58 +06:00
cigamit cff644f4bb Resolving Issue #2537
Tree Mode: Site Title lags 1 refresh behind
2019-03-27 07:36:07 -05:00
sysres-dev 3e86f3c8d9 2543 graph view tree content performance (#2544)
Related to #2543.
Reduces the number of SQL queries executed in graph_view's tree_content action by populating an array with graph_template_ids in order to have just two query using IN statement instead of 2 queries by  graph_template_id.

Request completion time before commit : 12s
![loading_time](https://user-images.githubusercontent.com/45565495/54622351-bf1ed080-4a69-11e9-83c9-1f25fb01d9ae.png)

Request completion time after commit : 3s
![loading_time_post_commit](https://user-images.githubusercontent.com/45565495/54622377-cc3bbf80-4a69-11e9-81d7-6afe79d8b52e.jpg)
2019-03-21 09:24:53 +00:00
cigamit 1be402000d Resolving Issue #2525
Tree branches that includes sites which have valid devices do not appear on Graph Tree
2019-03-16 17:34:47 -05:00
cigamit 1e6161b61e Resolving Issues #1063 and #2435
* Issue encountered in modern theme "last device" is not visible in tree view in graphs
* Tree column is narrower and narrower on each click
* Plus a few additional minor visual issues
2019-03-16 14:42:05 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 46514098da Resolving Issue #2272
1.2.0 Site graphs in tree mode
2019-01-04 20:45:16 -06:00
cigamit ebf1c6c5ac Resolving Issue #2270 Realtime Graphs Taking Large Memory
Resolving this and a few other minor memory leaks.  Everything should
and have been validated to be working properly now.  There were a few
additional issues I found in performing a full regression.
2019-01-04 17:35:18 -06:00
cigamit 6d828a9bf4 Resolving Issues #2180 #2182 #2179
This changes were all missed in the flawed beta3 release.
2018-11-26 05:47:33 -06:00
cigamit cbf6f818cd Resolving Issue #2173
- Resolving issue 3) of the issues as best as can be done.
-Additionally, making the graph_template_id multiselect common for all
pages and resolving additional QA issues in all areas that were impacted
by multiselect issues.
- Lastly, resolving issues in Reports that cause excessive queries and a
bad user experience.
- There will be likely one more commit on this bug as more QA needs to
be performend on Data Source orphan API introduced.
2018-11-21 13:49:08 -06:00
cigamit 59681ce586 Resolving Issue #2173
This commit resolves sub issues 1) and 2) in issue #2173.  Sub issue 3)
is still being worked.  This change also widens multi-selects for
readability.
2018-11-20 21:16:53 -06:00
cigamit cc09288a66 Minor format change for readability 2018-11-18 17:11:36 -06:00
cigamit 010f17dbbf Minor JavaScript formatting 2018-10-12 06:27:46 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit c9b078883d Correct for undefined function 2018-09-02 11:27:54 -05:00
cigamit 5eee727f78 Resolving Issue #553
Aggregated graph does not belong to host
2018-08-19 20:13:34 -05:00
cigamit d739e8cf48 Resolving Issue #1494
Unable to Deep Link/Bookmark Trees
2018-08-09 17:08:46 -05:00
cigamit 4fcf03d280 Resolving Issue #1765
Graphs Missing when Expand Devices on and Data Query sort type.
2018-08-06 20:33:03 -05:00
cigamit 75189c61f9 Resolving Issue #1761
- Graph management shows bogus template names
- Additionally, allow Multi-selects to have a reasonable width
- For Non-Templated and Template Not Found, properly show those things
as select items in the filter.
2018-07-30 20:43:18 -05:00
cigamit 6f679e97a1 Resolving Issue #1765
Some tree graphs not rendering as they should be.
2018-07-29 11:27:11 -05:00
cigamit 04033667ac Resolve HTML validation warnings
- align attribute is deprecated in HTML5,
- JavaScript should not be inside of table body sections.
2018-07-26 20:28:57 -05:00
cigamit fc03a5edb4 Another minor change for upcoming location branches 2018-06-09 11:58:27 -05:00
cigamit 2f408b7c8b Resolving Issue #1643
Wrong graph counts showing on page
2018-05-30 06:52:57 -05:00
cigamit 85e33abdf8 More changes around site branches #122
Marking this one complete.  Will log a new issue to create Location
branches under site branches.
2018-05-12 15:37:57 -05:00
cigamit 35d9d3df75 More uQueryUI classes and form QA 2018-05-09 21:59:08 -05:00
cigamit 96f62fe610 Resolve Issue #1527
Update Fontawesome from 4.7 to 5.0.10
2018-04-22 09:24:27 -05:00
cigamit a8cbe34bcb Resolving Issue #1507
This is a slightly different interpretation of the problem as the Graph
Template ID should not have been in the saved filter setting.
2018-04-04 19:24:23 -05:00