Commit Graph
146 Commits
Author SHA1 Message Date
cigamit 4596eaf7f4 Resolving Issue #454
@pautina, all working now.  I did some tests with the following:
1) An vlan is removed
2) A new vlan is added with the old vlans index
3) The old vlan re-appears with a new index
4) Vlans that never were deleted magically get new indexes

All passed.
2018-09-29 17:05:40 -05:00
cigamit 709c532637 Resolving Issue #454
Do not test this on a production box.  It is functional, but looking for
someone to test the re-index behavior when a sort field changes.
2018-09-26 21:12:46 -05:00
cigamit a970af8c31 Misque for Issue #454
Two SQL errors should have been generated during reindexing.  Two for
each interface.
2018-09-25 17:19:11 -05:00
cigamit ac4d552599 Minor updates. 2018-09-24 20:09:50 -05:00
cigamit 34b0f716c9 Another change in search of Issue #454
This is basically a restructuring now that I have re-familiarized myself
with the code.  There are three minor changes here that may correct the
issue.
2018-09-24 18:05:21 -05:00
cigamit 905686da15 A few changes for readability 2018-09-24 06:17:05 -05:00
cigamit 9a44567ffb QA on Issue #454
This should resolve the SQL error.  Please test again.
2018-09-23 13:43:49 -05:00
Mark Brugnoli-Vinten dfbecafdf6 Resolving issue #454 (#1961)
* Resolving issue #454

* Small update for timer insertion
2018-09-22 14:23:31 -05:00
Mark Brugnoli-Vinten c011c0154c QA Language Corrections (#1960)
* QA Language Corrections

* Updated POT files/script
2018-09-22 04:07:12 -05:00
Mark Brugnoli-Vinten e4a45a3660 Resolving Issue #1921 (#1959) 2018-09-22 04:06:12 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
Tom 191e498a02 do not lose data source Index Value if a SNMP table entry disappears or changes its table index (e.g. ifTable) (#1790) 2018-08-06 06:44:56 -05:00
Tom 1d057a60b2 run_data_query: fix flipped arguments in an SQL query (snmp_query_id and host_id were flipped) (#1789) 2018-08-05 12:30:03 -05:00
cigamit 85e33abdf8 More changes around site branches #122
Marking this one complete.  Will log a new issue to create Location
branches under site branches.
2018-05-12 15:37:57 -05:00
Mark Brugnoli-Vinten c1a9675cb2 Fix for Issue #1454: When using oid_regexp_parse, filter indexes to those that match (#1509)
When using oid_regexp_parse all indexes are returned, some with their OID's correctly replaced.  If an index does not match, it's index is kept as an OID.  This is now corrected to filter indexes to just those that match.
2018-03-30 17:04:41 -05:00
Mark Brugnoli-Vinten 2b8656fc73 Feature #1489: Add ability to use parts of OID as value via regex (#1492)
Feature #1489 adds ability to use parts of OID as value via regex
2018-03-24 08:33:15 -05:00
cigamit f40b8541e6 Attempt to resolve Issue #1475
The function that is attempting to detect hex is not very reliable.
2018-03-19 06:58:58 -05:00
cigamit 827bf550c9 Resolving Issue #1461
Setting output_format on input type causes no values to be returned
2018-03-14 20:57:27 -05:00
cigamit ecf6ea4f2d Additional Changes for #1380
- Moving the function into the API
- Adding missing i18n of lib/data_query.php
2018-02-23 07:57:25 -06:00
cigamit 3a13f1c7a8 Resolving Issue #1319
FrontEnd + Remote Poller - Connection timeout issue
2018-02-08 06:59:33 -06:00
netniV 27e858e089 issue#1040: Correct sizeof() issues with get_data_query_array() and get_graph_group() results (#1299) 2018-02-03 06:59:20 -07:00
cigamit 0e9baa3432 Dont error out on upgrade from early versions
If you were at 0.8.7g- you would get an upgrade error.
2018-01-14 19:16:31 -06:00
cigamit a646bc194b Fixups for Issues #1168 and #1186
This addresses both visual and functional changes to ensure everything
is working.
2018-01-12 14:30:13 -06:00
netniV e5ae849e2c Issue #1168 - Unable to copy debug information (#1186)
* Fix for Issue #1168 - Allow copy of debug query text to clipboard
Issue #1168 - Allow debug query section to be copied to the clipboard

- Currently, whilst clipboard code is run, no text is being copied
- Various text updated to i18n calls.
- CSS still needs to be generated

* Update with working version of copy that doesn't collapse with table header

* Update copyToClipboard to copy table as HTML not just the HTML text

* Issue #1168 - Further clipboard enhancements
issue #1168 now presents a 'Copy' link on the right side of a debug header table (currently a circle)

This functionality has been extended to copy the entire debug via the "Data Query Debug Information" header
Sections are automatically expanded whilst copying to allow selection copy, non-expansion prevents this

* Further fixes for #1168
issue#1168: Now uses jQuery.dialog() for messages (a lot nicer!)

Need to find out if there is a function to retrieve Cacti language messages, ie, get data from https://cacti/messages.php?text
2018-01-12 17:42:00 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Browniebraun 114f239245 usage of get_default_contextoption 2017-11-13 15:14:27 +01:00
Patrick 928ae7de82 Various updates (#1075)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations

* fixed parameter typo in query_debug_timer_stop()

* fixed typo $_SESSION

* MibCache->install() uses MibParser->oids, but MibCache->oids has protected access instead of public

* Updated of PHPMailer to version 5.2.26
- Minor security backport from 6.0 - set Debugoutput in constructor according to SAPI in use, avoiding potential XSS in default debug output. Thanks to Bankde Eakasit for spotting it.

* Remove old autoLoad method
2017-11-12 09:39:55 -06:00
cigamit fbbcedd378 Resolving Issue #1053
- Remote Data Collector issues with https and self signed certificates.
- Some spurious backport of html_escape() calls
2017-11-04 15:36:24 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
cigamit 63b25083b7 Resolving Issue #935
Support utf8 printable in data query inserts
2017-08-27 15:06:40 -05:00
cigamit 4fd458069f Use preg_split over explode for issue #865
Plus use an additional trim on the string to prevent out of order
arguments
2017-07-26 21:33:34 -05:00
cigamit afa98439b6 Resolving Issue #865
Escape Data Query arguments to prevent issues with special characters
2017-07-26 21:24:14 -05:00
John Horne 633812f4c5 Ensure the rewrite_index field is handled and checked correctly. 2017-05-19 23:15:04 +01:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
cigamit 62f6d88c29 Resolving Issue #470
Enhance Cacti's SNMP function and Data Query XML syntax.  Add
<output_format>hex|string|guess</output_format> tag
2017-05-14 07:34:25 -05:00
cigamit d3c29fc3fe Feature: Support input-output data query type 2017-05-13 11:12:36 -05:00
Patrick f76503b790 Bugfix for issue#687
- Replaced mysql_real_escape_string() with db_qstr()
2017-05-13 00:01:13 +02:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
patrick 1ca2ec43bf Removed unnecessary lines en applied some small optimisation and layout changes 2017-04-28 22:43:02 +02:00
Patrick 336888ebf2 Optimisations for lib/data_query.php 2017-04-28 16:47:04 +02:00
patrick ff520ea4f4 Merge remote-tracking branch 'origin/Optimisations' into Optimisations 2017-04-26 23:24:55 +02:00
cigamit 49e83d7fa1 Resolving Issued #580, #606, #608, #609
- Data collection warnings when using cmd.php
- Replace <path_php_binary> in data input methods
- Spaces adjacent to double quotes are eliminated durate data input
method import
- Horor the column setting in graph tree view mode
2017-04-24 20:40:05 -05:00
patrick 02f145af22 Optimisations for lib/data_query.php 2017-04-22 00:10:02 +02:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
cigamit cf0d4c2b0b Reformatting in search of solution to Issue #454 2017-03-26 12:32:22 -05:00
cigamit 79f59d081c Double to single quote conversion 2017-03-12 11:13:56 -05:00
earendilfr 6b0643c3af Fix the error in merge request #352 :
* the $index_recache string already contains the / separator. I don't need to add in preg_match function
* some errors in the methods to take in count the storage of the modified value
* a cosmetic change that permit to clean the debug value in debug_log_return function after the display
* a change in poller function that fixe an error when your index field in the XML file is a fake index oid
2017-03-07 22:50:06 +01:00
cigamit 135b9906cb Don't reindex device 0 2017-03-06 22:27:17 -06:00
Jimmy Conner 677e491c0b Revert "Add the following hability to the walk method for data_query :" 2017-03-06 22:12:32 -06:00