Commit Graph
80 Commits
Author SHA1 Message Date
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit dfc60cb4b7 Resolve four QA issues found while testing
-issue: basename function undefined during upgrade to 1.0.x
-issue: Storage API and translations required for Change password
function
-issue: ALTER IGNORE still throws an error when attempting to drop the
primary key
-issue: Data Source profile form API generates error when system is half
upgraded
2017-12-29 10:21:11 -06:00
netniV 979373fea4 Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled (#1129)
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled

Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.

Changes made are:

auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions

auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set

user_admin.php
* Use new compat_password_xxx functions

lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions

* Update CHANGELOG

* Fixup for Issue #1122, corrects some minor issues

* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122

Update log message to be warning notj ust a normal message

* Fix issue of local auth bypas

* Update CHANGELOG

Fix up CHANGELOG issues

* Update auth.php

Fix up formatting issues
2017-12-23 12:58:03 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
cigamit 1a14cbb440 Introduce new get_cacti_version function to reduce database calls on pages 2017-05-14 12:29:30 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit e2243f62d2 feature: Make Cacti more tolerant of empty PHP_SELF on some web servers 2017-04-22 08:22:01 -05:00
cigamit e5793b284b Adding more mobile features
Preparing for fullScreenMode support and more responsive fixes.
2017-04-12 17:34:51 -05:00
patrick 4d5bb9facb get_selected_theme()
- result of get_selected_theme() stored in vars
2017-04-06 18:00:38 +02:00
cigamit cea503a4d2 Resolving Issue #434
password_verify not compatible with php5.4-
2017-03-15 17:29:49 -05:00
Otis Lin 390f0f9045 Use password_verify instead of password_hash @ php5.5+ 2017-03-07 15:13:33 +08:00
cigamit 3c7ef42902 Resolving Issue #329
Also first step in resolving issue #186
2017-02-23 17:40:19 -06:00
Browniebraun 80d283762e Referring to an issue mentioned at the bottom of #320
Invalid wildcard set.
2017-02-23 13:15:40 +01:00
cigamit 75c6359894 Resolving Issue #329 2017-02-22 20:03:17 -06:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
cigamit e1b40143b5 Resolving Issue #182 2017-01-09 17:11:25 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit d70f9718dc resolve login redirect loops
Corner case where you have forced a password change, but have not
granted that permission to the user.  We are also now blocking the save
when the user tries to make this setting.

We need better interactions with the login screen under certain failure
modes.  But for now this is good enough.
2016-12-19 18:18:05 -06:00
cigamit 93007bc347 add jquery-migrate to work around issues 2016-09-20 20:04:27 -05:00
cigamit 81f39d4dc1 use html5 doctype 2016-09-05 13:38:14 -05:00
Browniebraun 769a02ece2 Force edge mode for IE
fix broken layout in IE11
2016-09-05 14:53:06 +02:00
cigamit 80b483b559 more prepared statements
preparing for turning off magic quotes
2016-08-27 17:26:53 -05:00
cigamit 63f80ec9d6 formatting 2016-05-22 10:16:08 -05:00
cigamit 37dfdb2edc change password redirection not working 2016-05-09 19:36:18 -05:00
Browniebraun 61d9812fbb i18n updates 2016-04-26 21:59:46 +02:00
Micke2k 9cf968a76c Fix for addparser error in auth_changepassword 2016-03-23 22:24:09 +04:00
cigamit 4451d8fb2a support strong password when changing passwords
correct a few spacing issues as well
2016-03-20 14:19:57 -05:00
Micke2k 0fe822a949 Added tooltip to changepassword
Fixed "ok" message when changing passwords.

Somethings that still needs to be looked at

1. can i read the friendly_name of the array with read_config_option? I want to read it from the array instead of typing it:

                    "Require Mix Case: " .read_config_option('secpass_reqmixcase') . "<br>" .

2. Because this function it still forces you to use a new password even to secpass_history default is set to 0. Change secpass_history default to 1 and remove it?

    if ($user['password'] == md5(get_nfilter_request_var('password'))) {
        $bad_password = true;
        $errorMessage = "<span color='#FF0000'>Your new password can not be the same as the old password.  Please try again.</span>";
    }

3. I had to add font-awesome since it wasn't referenced anywhere in themes. Better way to do it?

Any input is welcome!
2016-03-19 20:23:52 +04:00
cigamit f2edfcbe53 update theme to a user setting 2016-02-14 10:48:34 -06:00
cigamit 26053b7527 replace deprecated get_request_var_post() with get_nfilter_request_var()
replace the deprecated calls and also start developer mode injection
checking
2016-02-11 16:46:14 -06:00
cigamit 2387bd4a08 removing many $_GET, $_REQUEST, and $_POST variable usage
There are still three steps to go in this overall.  The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized.  Note, at this point the
develop branch should be thought of as slightly unstable
2016-02-07 12:51:49 -06:00
Linegod 8dadf2d9a9 first pass of _POST to get_request_var_post 2016-02-06 10:44:05 -06:00
Linegod dabfabf219 replace ['action'] with set_default_action 2016-02-06 09:57:05 -06:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
cigamit 253b34c591 Remove <strong> tags where prudent 2015-09-07 21:30:04 -05:00
cigamit 4547bdafc0 Resolving issues with password management
Create a 'Change Password' user option in user_auth table
Don't show 'Change Password' unless user is in Local realm and has
permission
Move $auth_realms function to a library call
Add message when a user attempts to access auth_changepassword.php
incorrectly
2015-08-08 22:28:37 -05:00
cigamit f49357c71b HTML5 Support
changes to support html5
2015-05-15 22:29:42 -05:00
Jimmy Conner 5bde3da972 1) Update Copyright Years Correct a few minor CY Issues
2) Allow Locking/UnLocking of Graphs
3) ToolTips
4) Correct Minor Issues with Login/Out/Permission associated with Theme JS
5) Upgrade jQuery which has Fixes for Major issue in Safari 7/8.1

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7662 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-04 01:52:50 +00:00
Jimmy Conner 3cc4018310 Integrate Secpass plugin into the core
Add function to installer to allow easy adding of columns, just like plugins have

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7633 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-12-30 05:53:31 +00:00
Jimmy Conner 5646c33484 A little bit of cleanup
Change double quotes to single quotes where possible
Move to prepared statements were possible
Fix line endings on a few files

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7609 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-12-25 07:00:57 +00:00
Jimmy Conner f15161aba2 1) Correct change password redirect loop.
2) Remove 'legacy_menu_nav' option in settings
3) Add 'placeholder' as a form option
4) Fix undefined variable when logging in using authentication tokens
5) Convert Cacti to use PHPMailer Class
6) Add option to send emails through secure connections SSL/TLS
7) Minor form Cleanup
8) Add SMTP Ping Function for Quick Tests
9) Minor CSS change in Classic mode

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7607 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-12-24 19:55:18 +00:00
Jimmy Conner a3424967e4 1) Reverted cacti login image (attached)
2) Change password now requests current password too
3) Place 'Change Password' link on page if auth_method==1.  Thinking that this should be a user_profile.php page instead....


git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7585 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-12-22 01:56:46 +00:00
Tony Roman 65be30ffe0 Update copyright to 2014
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7437 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-03-30 19:54:50 +00:00
Tony Roman ce40281901 Update copyright to 2013 for 0.8.8
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7386 860744bd-22fc-0310-8c96-e9fe5004b5ca
2013-07-21 23:00:42 +00:00
Tony Roman a257958a0b Update copyright to 2012
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@7016 860744bd-22fc-0310-8c96-e9fe5004b5ca
2012-02-27 07:04:37 +00:00
Tony Roman 2d039dd7db Merge PIA into 0.8.7 branch
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@7006 860744bd-22fc-0310-8c96-e9fe5004b5ca
2012-02-27 01:14:45 +00:00
Tony Roman 4ea04c2d1a Fix issue with forced password change not working corrrectly Bug:1998
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@6380 860744bd-22fc-0310-8c96-e9fe5004b5ca
2011-06-06 01:52:46 +00:00
Reinhard Scheck d94dbd9850 -bug#0001967: Reflected XSS on Cacti 0.8.7g
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@6355 860744bd-22fc-0310-8c96-e9fe5004b5ca
2011-03-27 08:11:30 +00:00