-issue: basename function undefined during upgrade to 1.0.x
-issue: Storage API and translations required for Change password
function
-issue: ALTER IGNORE still throws an error when attempting to drop the
primary key
-issue: Data Source profile form API generates error when system is half
upgraded
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled
Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.
Changes made are:
auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions
auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set
user_admin.php
* Use new compat_password_xxx functions
lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions
* Update CHANGELOG
* Fixup for Issue #1122, corrects some minor issues
* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122
Update log message to be warning notj ust a normal message
* Fix issue of local auth bypas
* Update CHANGELOG
Fix up CHANGELOG issues
* Update auth.php
Fix up formatting issues
Corner case where you have forced a password change, but have not
granted that permission to the user. We are also now blocking the save
when the user tries to make this setting.
We need better interactions with the login screen under certain failure
modes. But for now this is good enough.
Fixed "ok" message when changing passwords.
Somethings that still needs to be looked at
1. can i read the friendly_name of the array with read_config_option? I want to read it from the array instead of typing it:
"Require Mix Case: " .read_config_option('secpass_reqmixcase') . "<br>" .
2. Because this function it still forces you to use a new password even to secpass_history default is set to 0. Change secpass_history default to 1 and remove it?
if ($user['password'] == md5(get_nfilter_request_var('password'))) {
$bad_password = true;
$errorMessage = "<span color='#FF0000'>Your new password can not be the same as the old password. Please try again.</span>";
}
3. I had to add font-awesome since it wasn't referenced anywhere in themes. Better way to do it?
Any input is welcome!
There are still three steps to go in this overall. The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized. Note, at this point the
develop branch should be thought of as slightly unstable
Create a 'Change Password' user option in user_auth table
Don't show 'Change Password' unless user is in Local realm and has
permission
Move $auth_realms function to a library call
Add message when a user attempts to access auth_changepassword.php
incorrectly
2) Allow Locking/UnLocking of Graphs
3) ToolTips
4) Correct Minor Issues with Login/Out/Permission associated with Theme JS
5) Upgrade jQuery which has Fixes for Major issue in Safari 7/8.1
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7662 860744bd-22fc-0310-8c96-e9fe5004b5ca
Add function to installer to allow easy adding of columns, just like plugins have
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7633 860744bd-22fc-0310-8c96-e9fe5004b5ca
Change double quotes to single quotes where possible
Move to prepared statements were possible
Fix line endings on a few files
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7609 860744bd-22fc-0310-8c96-e9fe5004b5ca
2) Remove 'legacy_menu_nav' option in settings
3) Add 'placeholder' as a form option
4) Fix undefined variable when logging in using authentication tokens
5) Convert Cacti to use PHPMailer Class
6) Add option to send emails through secure connections SSL/TLS
7) Minor form Cleanup
8) Add SMTP Ping Function for Quick Tests
9) Minor CSS change in Classic mode
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7607 860744bd-22fc-0310-8c96-e9fe5004b5ca
2) Change password now requests current password too
3) Place 'Change Password' link on page if auth_method==1. Thinking that this should be a user_profile.php page instead....
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7585 860744bd-22fc-0310-8c96-e9fe5004b5ca