Commit Graph
1401 Commits
Author SHA1 Message Date
netniV 657ccf14a9 Fix for issue#1202 and #629: Fix backspace functionality on filter input boxes (#1204)
issue#1202 and #629: Fix backspace functionality on filter input boxes

Note, this does NOT add backspace functionality to other stanard input boxes
2018-01-15 06:21:21 -06:00
cigamit 8411dc6e2b Resolving Color Import Issue
issue: Named colors were not importing on install/upgrade.
2018-01-14 21:40:23 -06:00
cigamit e61ab91dee Enhance SNMP GUI Support
When a user chooses '[None]' for SNMP Auth/Privacy, hide/clear
passphrases.  Also, put protocols ahead of passphrases.
2018-01-13 17:19:44 -06:00
cigamit ff7d25506b Wrong issue # ins the CHANGELOG 2018-01-13 14:13:19 -06:00
cigamit 6458747ada Resolving Issue #1022 and Backport
Resolving Issue #1022 and backporting Refresh dropdown on Automation
Networks page.
2018-01-13 14:12:32 -06:00
cigamit d4edcf8737 Resolving Issues #1189, #1191, and Pull Request #1192
This change utilizes the new API to resort the tree based upon the
filter buttons available.  It is essentially pull request #1192 just
handled a slightly different way.
2018-01-13 12:31:06 -06:00
cigamit 35923c0474 Enhancement to allow developer to add more buttons buttons to header
Cacti has moved to using both fontawesome and table glyphs for actions
instead of text.  This enhancement will allow developers to add
adiditional actions to the title.  The actions that will be included by
default are clear, import and export so long as those buttons have the
appropriate title.
2018-01-13 12:10:28 -06:00
cigamit a18b7ea2c9 Resolving Issue #1190
When Enabling, Disabling, Uninstalling plugins, you should refresh page
Also spurious html_escape() conversion
2018-01-11 14:28:12 -06:00
cigamit d8758778f0 Resolving Issue #1185
Layout issue with Graphs having large number of data columns
2018-01-11 14:18:36 -06:00
cigamit a4023f787e Resolving Issue #1175
When session timeouts occur, logout gracefully
Some spurious conversion to html_escape()
2018-01-06 17:04:28 -06:00
cigamit e6f62e4395 Resolving Issue #1182
Support noAuthNoPriv for SNMPv3 in Cacti
2018-01-06 18:12:25 -06:00
Tony Roman bfee1c86d2 issue#1179: Warn during installation if installing moving to older version
- Also cleaned up lingering debug
2018-01-06 09:29:24 -05:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Tony Roman 6519da6c3f Update copyright in documentation 2018-01-06 08:55:12 -05:00
cigamit c7ba275a8a Resolving Issue #1164
Additional issues with cacti_version_compare function
2018-01-05 18:37:20 -06:00
netniV 29de0b50c0 Issue #1166 - Further language fixes for detection/configuration (#1177)
* Fix Issue #1166 - Further language fixes
Issue #1166 - Further language fixes for detection/configuration.

- User default now defaults to system default if not set.
- Language detection now tries multiple methods of language detection rather than just the first one if that language isn't supported.

* Add missing CHANGELOG and correct minor code format issues
2018-01-05 18:13:41 -06:00
netniV 708a3f8e8f Fix issue #1166 - Incorrect default language (#1167)
When editing a user, default language became first in the list rather than English
2018-01-03 06:45:27 -06:00
cigamit ad8de52612 Missed change log on #1161 2018-01-02 19:24:57 -06:00
netniV 6dc3fcb811 Fix for issue #1162 - Missing error messages (#1163)
Error messages are not display when editing a user
2018-01-02 19:16:11 -06:00
cigamit 1731dd4c46 Resolve issue with importation of packages
Additionally, update package version numbers to 1.1.29 to match the
Cacti version.
2017-12-31 13:38:38 -06:00
netniV 908af73a7e Changed CLOG to use regex replacement for Device[] and DS[] (#1159)
* Changed to use regex replacement for Device[] and DS[]
Also fixes issue #1158

* Updated CHANEGLOG for issue #1158

* Fix spacing issues with Spine logs

* Correct use of db_fetch_assoc_prepared

* Fix syntax error from last commit
2017-12-30 11:34:14 -06:00
cigamit dfc60cb4b7 Resolve four QA issues found while testing
-issue: basename function undefined during upgrade to 1.0.x
-issue: Storage API and translations required for Change password
function
-issue: ALTER IGNORE still throws an error when attempting to drop the
primary key
-issue: Data Source profile form API generates error when system is half
upgraded
2017-12-29 10:21:11 -06:00
cigamit a56fc119e6 Resolving Issue #1157
Resolving issue with branch permission API
2017-12-29 09:08:16 -06:00
cigamit b7d9b4c9b1 Resolving Issue #1155
Non-secure mail setting not functional due to changes in phpmailer.
2017-12-27 08:14:39 -06:00
cigamit 758e836293 Resolving Issue #871
Allow Nth Percentile and Bandwidth Summation to respect 'Base Value' in
template
2017-12-25 14:39:25 -06:00
cigamit 4097c0abfb Resolving Issue #1141
When viewing graphs from list view, pagination causes list view filter
to be cleared
2017-12-24 09:51:04 -06:00
cigamit 8d63e6b144 Resolving Issue #1128
Resolve php warning when raising messages
2017-12-24 08:50:12 -06:00
Patrick dc3ce9dcae Paginator object not always translated (#1154)
Missed this one file.
2017-12-24 08:15:00 -06:00
cigamit 8a42ab3aa7 Some pagination not translated into foreign languages 2017-12-24 08:11:25 -06:00
netniV d89fc4c212 Installation now checks the URI path (#1152)
* Installation now checks that the URI path matches with configuration setting URL_PATH

* Update index.php

Fix up coding format
2017-12-23 12:58:49 -06:00
netniV 979373fea4 Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled (#1129)
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled

Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.

Changes made are:

auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions

auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set

user_admin.php
* Use new compat_password_xxx functions

lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions

* Update CHANGELOG

* Fixup for Issue #1122, corrects some minor issues

* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122

Update log message to be warning notj ust a normal message

* Fix issue of local auth bypas

* Update CHANGELOG

Fix up CHANGELOG issues

* Update auth.php

Fix up formatting issues
2017-12-23 12:58:03 -06:00
cigamit 899eab02b5 Zoom context menu stays open after zoom out actions 2017-12-23 11:30:22 -06:00
cigamit 586212295a Resolving issues with the cacti_version_compare()
The cacti_version_compare() function was not operating properly when
moving between second order point versions (eg 1.1.29 to 1.2.0).  This
is resolved through a minor change to the cacti_version_compare()
function and the version_to_decimal() function.
2017-12-23 09:30:48 -06:00
cigamit 5c17ad8b67 Resolving Issue #1121
Bandwidth summation not using correct locale
2017-12-23 08:20:18 -06:00
netniV a20df3817c Fix for issue #1131 - upgrade_database.php (#1151)
Make upgrade_database.php use cacti_version_compare rather than version_compare (php version) to bring inline with /install/
2017-12-23 08:06:08 -06:00
netniV 5bd73b8318 Fix for issue #1130 (#1150)
Using cacti_log() with the optional POLLER_VERBOSITY_xxx paramater resulted in mising logs if they were set to the same level as the poller log level in settings
2017-12-23 08:03:27 -06:00
Tony Roman 98008449d0 Preping for 1.1.29 release 2017-12-22 15:06:58 -05:00
cigamit 5e554e618a Resolving Issue #1143 2017-12-21 19:06:14 -06:00
netniV f2790006af Fix Issue #1133 - Incorrect variable name (#1134)
* Fix Issue #1133 - Incorrect variable name

Fixed the incorrect use of $totle in place of $title resulting in database insertion errors.

* Update import.php

Fix debug display to match code.

* Update CHANGELOG
2017-12-21 07:49:03 -06:00
Daniel Schall 7b4d33c880 Add CPU Total to 'SNMP - Get Processor Information' (#1110)
* Add CPU Total to 'SNMP - Get Processor Information'

This change adds a virtual index 'Total' to the SNMP info,
showing the average CPU utilization over all cores.

* Changing CPU Total in 'SNMP - Get Processor Information'

Making the total CPU utilization the first element in the array to avoid shifting when CPUs are added.

* Fix for issue #1111 - Issue with ldap authenication (#1118)

* Update change log for pull request #1111

* Fixes for issues #1084, #1106 and #1116 (#1117)

* Fixes for issues 1106 (Graph filters), 1084 (Tree Branch population), and 1116 (Device Template won't set to none)

* Updated changelog\nfor issues #1084, #1106 and #1116

* Cleanup after pull request #1177

Cleanup includes some misqueues in the pull request as well as some
other miscelaneous changes associated with how we have landed on
formatting.

Chagne include:
* No soft tabs on initial tabbing
* ON clause of JOIN should be capitalized and on separate line
* AND/OR should be capitalized in SQL Queries
* Formatting of db_..() functions calls
* Use of sizeof() instead of isset() for array checks
* i18n of Secpass check return values
* Remove trailing whitespace from lines

- ToDo: Remove more having in place of WHERE clauses

* Fix issue #965 - LDAP search error results (#1112)

* Fix issue #965 - LDAP search erorr results

Corrected the error number returned by "Unable to set referrrals" to the correct number.

Added a new error for finding a users DN but not finding the user from the DN.

* Updated changelog for issue #965

* Fix issue 1106 - Graph Filters: template filter have empty value (#1114)

he filter uses index 0 as "All Graphs and Templates" but then searches graph_local for matches against graph_template_id. However, if index 0 is passed as a variable, it is also used in the search. Now when I looked at my database, the following entry existed:

select * from graph_local where graph_template_id = 0;
+------+-------------------+---------+---------------+---------------------+------------+
| id   | graph_template_id | host_id | snmp_query_id | snmp_query_graph_id | snmp_index |
+------+-------------------+---------+---------------+---------------------+------------+
| 1837 |                 0 |       0 |             0 |                   0 |            |
+------+-------------------+---------+---------------+---------------------+------------+

Therefore, it displays an index, but can't get a name for the template since there is no template with ID 0.

select * from graph_templates where id = 0;
Empty set (0.00 sec)

Added code to check for a zero value and only search the databsae if a value is present.

* Fix issue 1109 - Opening graph links by unlogged user - validation error (#1115)

* Fix issue 1109 - Opening graph links by unlogged user - validation error

Referer variable needs to be checked to ensure that it doesn't already have parameters applied.  If it does, then it needs to use the & rather than ? to join onto the URL.

* Updated changelog for issue #1109

* Fix spelling issue

* Minor updates to pull request 1109.

* Resolving Issue #1104

Different Timestamps in Cacti log when in Developer Debug

* Fix issue #1119 - ss_host_cpu.php pulling back too much data (#1120)

* As per the discussion on #1110 it would appear that ss_host_cpu is pulling back everything from the hrProcessorTable rather than just the processor usage. There appears to be a field named 'hrProcessorFrwID' being defined in the database which is actually the index field not the firmware ID

* Added CHANGELOG for issue #1119

* Fix for issue #1111 - Issue with ldap authenication (#1118)

* Update change log for pull request #1111

* Fixes for issues #1084, #1106 and #1116 (#1117)

* Fixes for issues 1106 (Graph filters), 1084 (Tree Branch population), and 1116 (Device Template won't set to none)

* Updated changelog\nfor issues #1084, #1106 and #1116

* Cleanup after pull request #1177

Cleanup includes some misqueues in the pull request as well as some
other miscelaneous changes associated with how we have landed on
formatting.

Chagne include:
* No soft tabs on initial tabbing
* ON clause of JOIN should be capitalized and on separate line
* AND/OR should be capitalized in SQL Queries
* Formatting of db_..() functions calls
* Use of sizeof() instead of isset() for array checks
* i18n of Secpass check return values
* Remove trailing whitespace from lines

- ToDo: Remove more having in place of WHERE clauses

* Fix issue #965 - LDAP search error results (#1112)

* Fix issue #965 - LDAP search erorr results

Corrected the error number returned by "Unable to set referrrals" to the correct number.

Added a new error for finding a users DN but not finding the user from the DN.

* Updated changelog for issue #965

* Fix issue 1106 - Graph Filters: template filter have empty value (#1114)

he filter uses index 0 as "All Graphs and Templates" but then searches graph_local for matches against graph_template_id. However, if index 0 is passed as a variable, it is also used in the search. Now when I looked at my database, the following entry existed:

select * from graph_local where graph_template_id = 0;
+------+-------------------+---------+---------------+---------------------+------------+
| id   | graph_template_id | host_id | snmp_query_id | snmp_query_graph_id | snmp_index |
+------+-------------------+---------+---------------+---------------------+------------+
| 1837 |                 0 |       0 |             0 |                   0 |            |
+------+-------------------+---------+---------------+---------------------+------------+

Therefore, it displays an index, but can't get a name for the template since there is no template with ID 0.

select * from graph_templates where id = 0;
Empty set (0.00 sec)

Added code to check for a zero value and only search the databsae if a value is present.

* Fix issue 1109 - Opening graph links by unlogged user - validation error (#1115)

* Fix issue 1109 - Opening graph links by unlogged user - validation error

Referer variable needs to be checked to ensure that it doesn't already have parameters applied.  If it does, then it needs to use the & rather than ? to join onto the URL.

* Updated changelog for issue #1109

* Fix spelling issue

* Minor updates to pull request 1109.

* Resolving Issue #1104

Different Timestamps in Cacti log when in Developer Debug

* Fix issue #1119 - ss_host_cpu.php pulling back too much data (#1120)

* As per the discussion on #1110 it would appear that ss_host_cpu is pulling back everything from the hrProcessorTable rather than just the processor usage. There appears to be a field named 'hrProcessorFrwID' being defined in the database which is actually the index field not the firmware ID

* Added CHANGELOG for issue #1119

* Add CPU Total to 'SNMP - Get Processor Information'

This change adds a virtual index 'Total' to the SNMP info,
showing the average CPU utilization over all cores.

* Changing CPU Total in 'SNMP - Get Processor Information'

Making the total CPU utilization the first element in the array to avoid shifting when CPUs are added.

* Update CHANGELOG
2017-12-03 08:59:22 -05:00
netniV 4a98f50491 Fix issue #1119 - ss_host_cpu.php pulling back too much data (#1120)
* As per the discussion on #1110 it would appear that ss_host_cpu is pulling back everything from the hrProcessorTable rather than just the processor usage. There appears to be a field named 'hrProcessorFrwID' being defined in the database which is actually the index field not the firmware ID

* Added CHANGELOG for issue #1119
2017-12-02 12:43:15 -05:00
cigamit a47d713d7b Resolving Issue #1104
Different Timestamps in Cacti log when in Developer Debug
2017-12-02 11:16:14 -06:00
netniV a5cb7b4c87 Fix issue 1109 - Opening graph links by unlogged user - validation error (#1115)
* Fix issue 1109 - Opening graph links by unlogged user - validation error

Referer variable needs to be checked to ensure that it doesn't already have parameters applied.  If it does, then it needs to use the & rather than ? to join onto the URL.

* Updated changelog for issue #1109

* Fix spelling issue
2017-12-02 11:37:41 -05:00
netniV 1025bd4a7f Fix issue #965 - LDAP search error results (#1112)
* Fix issue #965 - LDAP search erorr results

Corrected the error number returned by "Unable to set referrrals" to the correct number.

Added a new error for finding a users DN but not finding the user from the DN.

* Updated changelog for issue #965
2017-12-02 11:30:58 -05:00
netniV 563e1ae09c Fixes for issues #1084, #1106 and #1116 (#1117)
* Fixes for issues 1106 (Graph filters), 1084 (Tree Branch population), and 1116 (Device Template won't set to none)

* Updated changelog\nfor issues #1084, #1106 and #1116
2017-12-02 10:57:08 -05:00
Tony Roman 3174c344d7 Update change log for pull request #1111 2017-11-30 20:32:57 -05:00
Tony Roman f3673b4686 New Graph pagenation and filter reset 2017-11-22 12:32:48 -05:00
Tony Roman 3f437bac3b Update change log for release 2017-11-19 08:19:05 -05:00
cigamit b1e412604e Resolving Issue #1074
Boost records get stuck in archive tables
2017-11-18 10:48:06 -06:00
cigamit 9a0baff5c8 Resolving Issue #1086
Rerun data queries in automation process has no effect
2017-11-18 10:35:23 -06:00