Commit Graph
2825 Commits
Author SHA1 Message Date
cigamit 0e9baa3432 Dont error out on upgrade from early versions
If you were at 0.8.7g- you would get an upgrade error.
2018-01-14 19:16:31 -06:00
cigamit bdf047c182 Make snmp variables more consisten
This change includes:
1) Using common setSNMP() global function
2) Rename snmp_readstring to snmp_community
3) One i18n Issue in automation_snmp.php
4) Reorder SNMP Form to be consistent with remainder of Cacti
5) Add SNMP security_level to the form

There remains some additional QA to do including inclusion of the SNMP
Engine ID which is not consisten accross all interfaces as well as an
issue in settings related to the pages JavaScript.
2018-01-14 17:49:40 -06:00
cigamit e413c6a54a Make the snmpagent more consistent
The snmpagent plugin labeled snmp_password as snmp_auth_password and
snmp_priv_passphrase as snmp_priv_password.  This change aligns the
column names in the database between features.

Additionally, for most of Cacti, with the inclusion of noAuthNoPriv, the
snmp_auth_protocol needed to be expanded to 6 characters from 5.
2018-01-14 17:10:13 -06:00
cigamit 35923c0474 Enhancement to allow developer to add more buttons buttons to header
Cacti has moved to using both fontawesome and table glyphs for actions
instead of text.  This enhancement will allow developers to add
adiditional actions to the title.  The actions that will be included by
default are clear, import and export so long as those buttons have the
appropriate title.
2018-01-13 12:10:28 -06:00
cigamit a646bc194b Fixups for Issues #1168 and #1186
This addresses both visual and functional changes to ensure everything
is working.
2018-01-12 14:30:13 -06:00
netniV e5ae849e2c Issue #1168 - Unable to copy debug information (#1186)
* Fix for Issue #1168 - Allow copy of debug query text to clipboard
Issue #1168 - Allow debug query section to be copied to the clipboard

- Currently, whilst clipboard code is run, no text is being copied
- Various text updated to i18n calls.
- CSS still needs to be generated

* Update with working version of copy that doesn't collapse with table header

* Update copyToClipboard to copy table as HTML not just the HTML text

* Issue #1168 - Further clipboard enhancements
issue #1168 now presents a 'Copy' link on the right side of a debug header table (currently a circle)

This functionality has been extended to copy the entire debug via the "Data Query Debug Information" header
Sections are automatically expanded whilst copying to allow selection copy, non-expansion prevents this

* Further fixes for #1168
issue#1168: Now uses jQuery.dialog() for messages (a lot nicer!)

Need to find out if there is a function to retrieve Cacti language messages, ie, get data from https://cacti/messages.php?text
2018-01-12 17:42:00 -06:00
cigamit 59c4f1b186 Additional check for logout relatedd to issue #1175 2018-01-06 20:57:45 -06:00
cigamit a4023f787e Resolving Issue #1175
When session timeouts occur, logout gracefully
Some spurious conversion to html_escape()
2018-01-06 17:04:28 -06:00
cigamit e6f62e4395 Resolving Issue #1182
Support noAuthNoPriv for SNMPv3 in Cacti
2018-01-06 18:12:25 -06:00
Tony Roman bfee1c86d2 issue#1179: Warn during installation if installing moving to older version
- Also cleaned up lingering debug
2018-01-06 09:29:24 -05:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit c35739e1a1 Fix for #1178 - Be more consistent with disabling plugins in CactiShutdownHandler and CactiErrorHandler 2018-01-05 23:34:42 -06:00
cigamit c7ba275a8a Resolving Issue #1164
Additional issues with cacti_version_compare function
2018-01-05 18:37:20 -06:00
cigamit b8954a3a28 Missed one update for issue #1121 2018-01-03 17:06:30 -06:00
cigamit c7c432bb94 Resolving Issue #1161
Graph View regex's are not preserved during automatic page refresh
2018-01-02 19:24:37 -06:00
cigamit e65c26d341 Remove debug code from import_package() function. 2017-12-31 13:40:06 -06:00
cigamit 1731dd4c46 Resolve issue with importation of packages
Additionally, update package version numbers to 1.1.29 to match the
Cacti version.
2017-12-31 13:38:38 -06:00
cigamit 0115d50d2f Resolving two QA problems from RHEL6.9 testing 2017-12-31 13:08:46 -06:00
netniV 908af73a7e Changed CLOG to use regex replacement for Device[] and DS[] (#1159)
* Changed to use regex replacement for Device[] and DS[]
Also fixes issue #1158

* Updated CHANEGLOG for issue #1158

* Fix spacing issues with Spine logs

* Correct use of db_fetch_assoc_prepared

* Fix syntax error from last commit
2017-12-30 11:34:14 -06:00
netniV 2fe2b63e2d Fix for Issue #1157 (#1160)
SQL Statements have now been corrected to prevent erroring during COUNT() and when using different auth method
2017-12-30 08:42:36 -06:00
cigamit a56fc119e6 Resolving Issue #1157
Resolving issue with branch permission API
2017-12-29 09:08:16 -06:00
cigamit b7d9b4c9b1 Resolving Issue #1155
Non-secure mail setting not functional due to changes in phpmailer.
2017-12-27 08:14:39 -06:00
cigamit 4158be6b63 Resolving Issue #871
Finalize the internationalization of RRDtool commands.  This version
will also fix Nth percentile calculations which require the C LANG
variable to be set to the correct value with PHP.  Tested with RRDtool
1.7, but may work with earlier RRDtool versions.  Does not work with
RRDtool 1.4.x which comes with RHEL7/CENTOS7.
2017-12-26 08:15:39 -06:00
cigamit 758e836293 Resolving Issue #871
Allow Nth Percentile and Bandwidth Summation to respect 'Base Value' in
template
2017-12-25 14:39:25 -06:00
cigamit 3002c035b9 Issue with version_to_decimal() function 2017-12-24 12:04:58 -06:00
cigamit dbc9a04c7c Attempt to resolve Issue #1128
Locale not correct for graph output.
2017-12-24 11:06:31 -06:00
cigamit 8a42ab3aa7 Some pagination not translated into foreign languages 2017-12-24 08:11:25 -06:00
cigamit 475b2f408d Minor format issues after merge of #1129 2017-12-23 13:50:56 -06:00
netniV 979373fea4 Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled (#1129)
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled

Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.

Changes made are:

auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions

auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set

user_admin.php
* Use new compat_password_xxx functions

lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions

* Update CHANGELOG

* Fixup for Issue #1122, corrects some minor issues

* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122

Update log message to be warning notj ust a normal message

* Fix issue of local auth bypas

* Update CHANGELOG

Fix up CHANGELOG issues

* Update auth.php

Fix up formatting issues
2017-12-23 12:58:03 -06:00
cigamit 586212295a Resolving issues with the cacti_version_compare()
The cacti_version_compare() function was not operating properly when
moving between second order point versions (eg 1.1.29 to 1.2.0).  This
is resolved through a minor change to the cacti_version_compare()
function and the version_to_decimal() function.
2017-12-23 09:30:48 -06:00
cigamit 5c17ad8b67 Resolving Issue #1121
Bandwidth summation not using correct locale
2017-12-23 08:20:18 -06:00
netniV 5bd73b8318 Fix for issue #1130 (#1150)
Using cacti_log() with the optional POLLER_VERBOSITY_xxx paramater resulted in mising logs if they were set to the same level as the poller log level in settings
2017-12-23 08:03:27 -06:00
Tomasz Chiliński d0468112c0 CHILAN: allow to select many lines by interval determined by previously clicked line and lately clicked line with shift key pressed (continuation of work started in pull request #1132) (#1148) 2017-12-22 09:53:38 -06:00
netniV f2790006af Fix Issue #1133 - Incorrect variable name (#1134)
* Fix Issue #1133 - Incorrect variable name

Fixed the incorrect use of $totle in place of $title resulting in database insertion errors.

* Update import.php

Fix debug display to match code.

* Update CHANGELOG
2017-12-21 07:49:03 -06:00
cigamit 139ec68a70 Be more consistent with feature 1.2 branch.
Note that this does not break functionality in 1.1.x.
2017-12-03 09:07:09 -06:00
cigamit 801d4e0b70 Resolve SQL/permission issues with get_allowed_graph_templates
This occurred due to the optimizations in pull request #1101.  The
$sql_user must, in it's entirety, be enclosed in parenthesis.
Otherwise, expand host functionality breaks.

I've also added the site_id in this commit to reduce the effort in
attempting to maintain both the feature branch and the develop branch.
It's not used, but returned.
2017-12-03 08:59:01 -06:00
cigamit a47d713d7b Resolving Issue #1104
Different Timestamps in Cacti log when in Developer Debug
2017-12-02 11:16:14 -06:00
netniV 1025bd4a7f Fix issue #965 - LDAP search error results (#1112)
* Fix issue #965 - LDAP search erorr results

Corrected the error number returned by "Unable to set referrrals" to the correct number.

Added a new error for finding a users DN but not finding the user from the DN.

* Updated changelog for issue #965
2017-12-02 11:30:58 -05:00
cigamit 708be5b19f Cleanup after pull request #1177
Cleanup includes some misqueues in the pull request as well as some
other miscelaneous changes associated with how we have landed on
formatting.

Chagne include:
* No soft tabs on initial tabbing
* ON clause of JOIN should be capitalized and on separate line
* AND/OR should be capitalized in SQL Queries
* Formatting of db_..() functions calls
* Use of sizeof() instead of isset() for array checks
* i18n of Secpass check return values
* Remove trailing whitespace from lines

- ToDo: Remove more having in place of WHERE clauses
2017-12-02 10:26:34 -06:00
netniV 563e1ae09c Fixes for issues #1084, #1106 and #1116 (#1117)
* Fixes for issues 1106 (Graph filters), 1084 (Tree Branch population), and 1116 (Device Template won't set to none)

* Updated changelog\nfor issues #1084, #1106 and #1116
2017-12-02 10:57:08 -05:00
Patrick 50b358a194 Small rewrite/optimisation for auth query in issue #1091 (#1101) 2017-11-26 08:47:06 -06:00
Tony Roman f3673b4686 New Graph pagenation and filter reset 2017-11-22 12:32:48 -05:00
cigamit b1e412604e Resolving Issue #1074
Boost records get stuck in archive tables
2017-11-18 10:48:06 -06:00
cigamit 17398b886d Be cognizant of other charsets when perfoming html_escape operations 2017-11-18 09:57:04 -06:00
cigamit 7a47e7d470 Correct minor WC3 Validation issue in graph preview filter 2017-11-18 09:55:31 -06:00
cigamit 889ea4c5fd Resolving Issue #1088
Remote Data collector polling has no timeout setting
2017-11-18 09:54:38 -06:00
cigamit 6cc3baa1d2 Poller output not empty not processed corretly on Log tab
Some minor formatting changes as well.
2017-11-18 07:18:46 -06:00
cigamit 7a5d171711 Resolving Issue #1079
- Undefined index in lib/snmpagent.php
- Remove trailing whitespace from file
- Reformat some sql statements.
2017-11-16 06:26:11 -06:00
cigamit 96d793f33e Resolving Issue #1066
Made the dropdown logic consistent between clog and utilities as well.
2017-11-14 06:26:02 -06:00
Browniebraun 114f239245 usage of get_default_contextoption 2017-11-13 15:14:27 +01:00