This change includes:
1) Using common setSNMP() global function
2) Rename snmp_readstring to snmp_community
3) One i18n Issue in automation_snmp.php
4) Reorder SNMP Form to be consistent with remainder of Cacti
5) Add SNMP security_level to the form
There remains some additional QA to do including inclusion of the SNMP
Engine ID which is not consisten accross all interfaces as well as an
issue in settings related to the pages JavaScript.
The snmpagent plugin labeled snmp_password as snmp_auth_password and
snmp_priv_passphrase as snmp_priv_password. This change aligns the
column names in the database between features.
Additionally, for most of Cacti, with the inclusion of noAuthNoPriv, the
snmp_auth_protocol needed to be expanded to 6 characters from 5.
Cacti has moved to using both fontawesome and table glyphs for actions
instead of text. This enhancement will allow developers to add
adiditional actions to the title. The actions that will be included by
default are clear, import and export so long as those buttons have the
appropriate title.
* Fix for Issue #1168 - Allow copy of debug query text to clipboard
Issue #1168 - Allow debug query section to be copied to the clipboard
- Currently, whilst clipboard code is run, no text is being copied
- Various text updated to i18n calls.
- CSS still needs to be generated
* Update with working version of copy that doesn't collapse with table header
* Update copyToClipboard to copy table as HTML not just the HTML text
* Issue #1168 - Further clipboard enhancements
issue #1168 now presents a 'Copy' link on the right side of a debug header table (currently a circle)
This functionality has been extended to copy the entire debug via the "Data Query Debug Information" header
Sections are automatically expanded whilst copying to allow selection copy, non-expansion prevents this
* Further fixes for #1168
issue#1168: Now uses jQuery.dialog() for messages (a lot nicer!)
Need to find out if there is a function to retrieve Cacti language messages, ie, get data from https://cacti/messages.php?text
* Changed to use regex replacement for Device[] and DS[]
Also fixes issue #1158
* Updated CHANEGLOG for issue #1158
* Fix spacing issues with Spine logs
* Correct use of db_fetch_assoc_prepared
* Fix syntax error from last commit
Finalize the internationalization of RRDtool commands. This version
will also fix Nth percentile calculations which require the C LANG
variable to be set to the correct value with PHP. Tested with RRDtool
1.7, but may work with earlier RRDtool versions. Does not work with
RRDtool 1.4.x which comes with RHEL7/CENTOS7.
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled
Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.
Changes made are:
auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions
auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set
user_admin.php
* Use new compat_password_xxx functions
lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions
* Update CHANGELOG
* Fixup for Issue #1122, corrects some minor issues
* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122
Update log message to be warning notj ust a normal message
* Fix issue of local auth bypas
* Update CHANGELOG
Fix up CHANGELOG issues
* Update auth.php
Fix up formatting issues
The cacti_version_compare() function was not operating properly when
moving between second order point versions (eg 1.1.29 to 1.2.0). This
is resolved through a minor change to the cacti_version_compare()
function and the version_to_decimal() function.
Using cacti_log() with the optional POLLER_VERBOSITY_xxx paramater resulted in mising logs if they were set to the same level as the poller log level in settings
* Fix Issue #1133 - Incorrect variable name
Fixed the incorrect use of $totle in place of $title resulting in database insertion errors.
* Update import.php
Fix debug display to match code.
* Update CHANGELOG
This occurred due to the optimizations in pull request #1101. The
$sql_user must, in it's entirety, be enclosed in parenthesis.
Otherwise, expand host functionality breaks.
I've also added the site_id in this commit to reduce the effort in
attempting to maintain both the feature branch and the develop branch.
It's not used, but returned.
* Fix issue #965 - LDAP search erorr results
Corrected the error number returned by "Unable to set referrrals" to the correct number.
Added a new error for finding a users DN but not finding the user from the DN.
* Updated changelog for issue #965
Cleanup includes some misqueues in the pull request as well as some
other miscelaneous changes associated with how we have landed on
formatting.
Chagne include:
* No soft tabs on initial tabbing
* ON clause of JOIN should be capitalized and on separate line
* AND/OR should be capitalized in SQL Queries
* Formatting of db_..() functions calls
* Use of sizeof() instead of isset() for array checks
* i18n of Secpass check return values
* Remove trailing whitespace from lines
- ToDo: Remove more having in place of WHERE clauses