Commit Graph
383 Commits
Author SHA1 Message Date
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 4158be6b63 Resolving Issue #871
Finalize the internationalization of RRDtool commands.  This version
will also fix Nth percentile calculations which require the C LANG
variable to be set to the correct value with PHP.  Tested with RRDtool
1.7, but may work with earlier RRDtool versions.  Does not work with
RRDtool 1.4.x which comes with RHEL7/CENTOS7.
2017-12-26 08:15:39 -06:00
cigamit 758e836293 Resolving Issue #871
Allow Nth Percentile and Bandwidth Summation to respect 'Base Value' in
template
2017-12-25 14:39:25 -06:00
cigamit dbc9a04c7c Attempt to resolve Issue #1128
Locale not correct for graph output.
2017-12-24 11:06:31 -06:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
cigamit e8088bb659 Resolving Issue #1057
- Potential vulnerability in RRDtool functions
- Adding validation to both dirpath and filepath, also verification of
executable status to files in RRDtool function.
- Spurious htmlspecialchars() to html_escape() calls
- Minor SQL formatting for readability
2017-11-04 14:52:09 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
Tony Roman ceee4f3fd4 Remove translation of log messages (for now). 2017-10-07 12:12:01 -04:00
cigamit 83e90d8b3c More attempts at issue #952
Don't perform the escape for the browser unless you have to.
2017-09-04 09:41:45 -05:00
cigamit b9f558a675 Add additional checks on Linux versions that avoid the use of True Type Font functions 2017-07-11 07:43:48 -05:00
cigamit f617c7121c Introduce new DATE_TIME_FORMAT constant resolving issue #829
Addresses issues with 500 messages when in developer debug mode.  Also,
make certain that the navigation variables exist before using them.
2017-06-29 17:37:32 -05:00
Patrick 031598f56b Fix for #757 2017-06-01 20:54:27 +02:00
Arjan Oosting 0f00018c1d Fix invalid 'Poller has not created structured path' warning. 2017-05-30 16:35:40 +02:00
patrick ef69094b5e CLOG Enhancements
-feature: CLOG timestamp is now formatted as defined in settings
-feature: CLOG can show loginformation from rotated logfiles
-Added GDC_DOT to global_constants.php and global_arrays.php, and refactored the usage of global $datechar
2017-05-29 13:44:31 +02:00
cigamit 3f2d15565f Another crack at issue #599
Well, the errors are gone, but see if it's what you were expecting.
2017-05-27 11:44:00 -05:00
Jimmy Conner aea8ddc7bd Merge pull request #702 from reboot1983/strlen
Cool stuff
2017-05-17 22:13:11 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
Patrick 56e02d75f2 Optimisations
- Optimisations of query calls and function calls in loops
- Removed unused function calls and variables
- Refactored large if statements into switch statements
- Applied early return
- Fixed alignments and removed unnecessary parentheses
2017-05-16 11:33:23 +02:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
patrick da32ae2f46 RRD optimisations
- Optimised loop
2017-05-02 12:14:44 +02:00
patrick 19e7d6640a RRD optimisations
- Removed unused globals
- Optimised rrdtool_function_create()
- Optimised rrdtool_cacti_compare()
- Fixed small bug (== instead of =) in rrdtool_cacti_compare()
- Fixed parameters in html_header() calls. Function accepts only 2 parameters (4 given).
2017-05-02 12:00:27 +02:00
patrick d000013aff RRD optimisations
- Added missing globals
- Removed unused globals
- Optimised rrdtool_function_create()
2017-05-02 10:20:20 +02:00
cigamit ff4922ca1b Resolving additional Aggregate corner cases
Also removing arrays enclosed in curly braces.
2017-04-23 07:59:20 -05:00
cigamit b2d949f6f9 Resolving issue with Aggregate graphs
Additionally reformatting some array enclosures
2017-04-22 14:25:31 -05:00
Patrick 623611cd16 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed unnecessary reset() calls used for resetting pointers of an array before iterating by a foreach() loop
2017-04-18 14:40:29 +02:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
cigamit abb7a13712 Resolving Issue #530
Resolving for VDEF case on normal GPRINT
2017-04-09 22:35:03 -05:00
cigamit 86e3af372b Proper escaping for tic object 2017-04-09 15:22:02 -05:00
cigamit d0ddc739ea Resolving Issue #530
Undefined function get_vdef in lib/rrd.php
2017-04-07 21:00:44 -05:00
cigamit 997e46fd36 Resolving Issue #525
Cacti not escaping LAST gprint type
2017-04-06 17:45:43 -05:00
cigamit 2513d891fd Resolving corner case in HRULE rendering 2017-04-05 22:39:47 -05:00
cigamit 87643fd7ef One more crack at Issue #465
I noted that the various functional blocks are escaping differently,
which is a clear sign you need to modularize that section of the code.
Project for another day though.
2017-03-23 06:23:24 -05:00
cigamit c863f29663 Additional testing on Issue #465 2017-03-22 19:46:22 -05:00
cigamit 6ee0bdd67b Additional testing on Issue #465 2017-03-22 19:40:07 -05:00
cigamit 42f9b68878 Resolving Issue #465
Less than sign inside items and labels of graph break graph
2017-03-22 19:17:36 -05:00
cigamit a7b8c6fb20 Resolving Issue #407
The RRDfile does not exist message is misleading
2017-03-18 13:31:20 -05:00
cigamit 21d3fd993d Resolving Issue #376
Structured RRD path permission issues
2017-03-17 17:20:44 -05:00
cigamit 0a27775f48 Resolving Issue #385
Allow special characters in graph title
2017-03-13 06:27:14 -05:00
cigamit e6551385f5 Resolving Issue #406
HRULE Text Format special characters not escaped.
2017-03-11 18:21:21 -06:00
Arjan Oosting f1f425972e Add misplaced join condition 2017-02-26 13:18:17 +01:00
Arjan Oosting 439e7daaa5 Simplify this as a data_source_profiles_rra is associated with one
data_source_profile
2017-02-26 13:09:38 +01:00
Arjan Oosting 8a9493b4ed remove empty line 2017-02-26 13:09:22 +01:00
Arjan Oosting fca8663310 Fix the selection of timestan based on local_graph_id and rra_id 2017-02-26 13:09:05 +01:00
cigamit cfd85d6783 Resolving Issue #298 2017-02-22 19:23:48 -06:00
cigamit 46a8b42798 Remove all aspects of RRDtool 1.2 support
Team decision is to remove all support due to dependencies on RRDtool
1.3+ options.
2017-02-11 13:21:09 -06:00
cigamit f6f056d687 Resolving Issue #290 2017-02-10 21:16:18 -06:00
cigamit f0ae12d9b9 Remove --pango-markup for all of RRDtool 1.2.x
Resolving Issue #273
2017-02-07 05:42:13 -06:00
cigamit 3c9d442c99 Resolving Issue #257 2017-02-02 20:31:16 -06:00
cigamit 2d0978d763 Resolving Issue #258 2017-02-02 06:09:42 -06:00