Commit Graph
227 Commits
Author SHA1 Message Date
TheWitness be018f1fe8 QA: Correct two performance problems rendering report items on large systems 2022-02-22 10:09:02 -05:00
TheWitness 6b0879b531 Fixing Permission Change Detection for #4545
This one renames a Javascript function and properly checks the session for permission changes.
2022-02-07 20:05:27 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness c515bb50f8 Fixing Issue #4545 Reports User is always an admin
- Reports Tab always shows 'Administration' despite a users permissions
- Improves the caching of permissions to include both true and false to reduce page query load.
- Also short circuits is_realm_allowed() for CLI's
- The user and admin realms where flipped.
2022-02-05 21:54:08 -05:00
TheWitness 30efc6622c Cacti using the wrong function to test variable
This issue is highly PHP version dependent.  Came up today for me.
2022-01-31 18:19:52 -05:00
TheWitness d809a368d7 Adding three minor features associated with user management
* Allow the get_template_account() function to be hookable by third party plugin
* Allow The User Management interface to be filterable by Realm
* Prevent Template User Accounts from being Removed
* Move the get_guest_account() and get_template_account() functions into lib/auth.php
2022-01-30 11:57:18 -05:00
TheWitness a108a6ec16 Fixing Issue #4536 - Basic Auth Issues
* After authenticating via Web Basic Authentication, user always mapped as guest.
* This is a slight redesign to make provide a better flow.  It will require rework to merge back to develop.
* deprecated use of display_custom_error_message()
* Add custom error message for basic authentication
* Fix some display issues on the settings page related to new settings.
* Make it clear in the cacti.log that LOGIN messages are failed or otherwise.
2022-01-29 15:03:44 -05:00
TheWitness 26e2dbacf2 Fixing Issue #4530 - Reports Interface Unusable
Cacti's Reporting Interface is NOT Usable on Large Systems
2022-01-23 19:47:01 -05:00
TheWitness 2c5224f042 Issue #4425 - Cache time not saved
The cache was loaded, but the last loaded date was not set.
2021-10-26 10:51:32 -04:00
TheWitness 65e63dfea4 One more performance bottleneck around #4425
The simple permissions would not take affect due to many calls to get_allowed_devices() not including the user, for example `tree.php?action=edit`
2021-10-26 10:13:46 -04:00
TheWitness e514a54c27 Remove duplicate database turn for #4425
This is the last optimization related to this bug fix.
2021-10-21 21:09:35 -04:00
TheWitness fad85312d4 Additional performance tuning on #4425 2021-10-20 21:45:12 -04:00
TheWitness de8b1d3896 Additional QA on #4425
It turns out that SELECT DISTINCT is very expensive vs. SELECT something, COUNT(*) AS something ... GROUP BY something
2021-10-16 11:08:22 -04:00
TheWitness a343a06485 Additional change around #4425
This adds a faster permission check for Graph Templates
2021-10-16 10:08:14 -04:00
TheWitness 96bca87b9f Fixing Issue #4425 - Permission Caching
Rendering large trees slowed due to lack of permission caching
2021-10-16 09:04:58 -04:00
TheWitness 8af84e4b11 Fixing #4228 - Redirect ssues after login
- Redirection issues after login under specific circumstances
2021-04-13 08:35:19 -04:00
TheWitness 87576d7a3a Fixing Issue #4190 - Augmenting roles inconsistent
- Augmenting roles can incorrectly map realms to roles in select cases
2021-03-22 10:03:52 -04:00
TheWitness fcae2c51e7 Adding Simple Device to #4177 Resolution 2021-03-19 19:54:04 -04:00
TheWitness 8a708579db Minor SQL Issue around #4177 2021-03-19 08:45:40 -04:00
TheWitness 0435b44c3a Fixing Issue #4177
On large sites, getting authorized graphs and graph templates is slow
2021-03-18 19:58:29 -04:00
TheWitness bf292d5d57 Additional update on #4035
This is based upon recommendations. to pre-sanitize the referer always and we don't want to double sanitize.
2021-01-06 12:15:22 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 0f3c1fe57b Fixing Issue #3933
When changing permissions, if those permissions are from the current user, they dont take effect till next login
2020-11-21 10:45:00 -05:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code
* Some insances in the vendor directory have not been handled to maintain pedigree.
2020-10-21 08:27:42 -04:00
TheWitness 8e7754a7cf Fixing Issue #3781
Cacti V1.2.14 php backtraces on Auth.php errors upon login
2020-09-06 19:52:24 -04:00
netniV 1cf6f42e43 Fix issue with #3551
Closes #3551
Closes #3564
2020-05-19 21:00:04 +00:00
TheWitness c1233947e6 Fixing Issue #3551
Web Basic Authentication and Template User broken in 1.2.12
2020-05-11 19:31:39 -04:00
TheWitness 6a2d781778 Fixing Issue #3374 Cacti Cookie Domain
* Allow Setting of Cookie 'Cacti' domain edition
* This also allows the Cacti administrator to extend the content security policy to include unsafe-eval for scripts.
2020-03-24 19:12:48 -04:00
TheWitness ec0d1f8422 Regression related to automatic logout and guest account for issue #3343 2020-03-24 18:13:16 -04:00
TheWitness 68b2dac89e Fixing Issue #1990
Plugin Realm should have a 'role' to help maintain changes between plugins
2020-03-19 18:54:34 -04:00
TheWitness 469ab1dfaa More upgrade testing 2020-03-15 10:26:29 -04:00
TheWitness 25abe64483 Fixing Issue #3343 and outstanding issue with #3342 2020-03-13 18:49:28 -04:00
cigamit 072466f582 Resolving Issue #3226
* When processing secpass login, failed logins are not recorded
* Adding Client Address
2020-02-03 20:15:21 -06:00
cigamit 5e9be7fd17 Resolving Issue #3226
* When processing secpass login, failed logins are not recorded
* This change adds Cacti log function calls
* Some code cleanup and improve internal logging
2020-02-03 19:54:18 -06:00
cigamit c0b21c8aac Resolving Issue #32246
When processing secpass login, failed logins are not recorded
2020-02-02 11:16:24 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 55c17d4f0e Resolving Issue #3079
Allow for domain names to be stripped from long device descriptions
2019-11-09 18:44:53 -06:00
cigamit 591da66827 Resolving Issue #3066
This was merged into develop, but due to it being security related, we will include it in the 1.2.8
2019-11-09 08:54:23 -06:00
cigamit b1837b6ff9 Resolving Issue #2704
Make device and template cache global
2019-05-24 08:19:05 -05:00
cigamit 50cb89e208 Resolving Issue #2679
Force Complexity Upon Old Passwords issue
2019-05-11 12:30:53 -05:00
cigamit 614bc3ebbc Resolving Issue #2644
Aggregate Graph is being shown more than once, leading to layout/display issues
2019-05-05 11:06:28 -05:00
netniV d81746b81c When user/group permissions are reset, this is not reflected immediately to the end user
Closes #2584
2019-03-29 11:57:14 +00:00
netniV 49cb30e5b0 Resolving issue #2532
Ensure Graph ListView table is displayed in line with Management -> Graphs
2019-03-18 14:16:43 +00:00
cigamit 1be402000d Resolving Issue #2525
Tree branches that includes sites which have valid devices do not appear on Graph Tree
2019-03-16 17:34:47 -05:00
cigamit d3bec2352c Resolving Issue #2466
Manual data source creation is broken
2019-02-28 07:01:07 -06:00
cigamit 190bddf51b Missing i18n on Devices ajax 2019-01-26 14:09:57 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit 5388211a8d Removing a Device or Graph Template can not be seen till next login 2019-01-06 18:30:12 -06:00
cigamit 46514098da Resolving Issue #2272
1.2.0 Site graphs in tree mode
2019-01-04 20:45:16 -06:00
netniV 5711fb82f7 Resolving issue #2264
This applies a correction to the #2259 fix where the row count SQL is using a field that no longer exists.
2019-01-03 20:27:00 +00:00