Commit Graph
985 Commits
Author SHA1 Message Date
jsgh 127c4589d8 Fixing Cacti/cacti#5490 - Avoid infinite recursion and crash in cacti_log (#5498)
when database connection is lost.
2023-09-27 19:00:43 -04:00
TheWitness e14345f66a QA: Fixing #5469 bad use of trim
Trimming a null string is deprecated
2023-09-06 19:41:43 -04:00
TheWitness 3ff8c5abab Fixing #5467 - Cacti Log issues in certain circumstances
Cacti logging throws error when attempting to generate a log message from empty log string in PHP 8.x
2023-08-24 08:20:34 -04:00
Petr Macek 3bbdd8dc3c extend settings_user (#5445) 2023-08-11 09:05:04 -07:00
Petr Macek 4a0288250d extending setting table column name (#5443) 2023-08-11 05:36:01 -07:00
Jing Chen a38016b98b Fixed: create a new function cacti_unserialize to cover all raw unserialize function compatible usage (#5438) 2023-08-10 19:19:38 -04:00
TheWitness ea7763c890 Fixing #5417 - BCC contents in Cacti.log
Cacti mailer log message misses 'bcc' addresses in log notification
2023-07-23 13:20:57 -04:00
Mark Brugnoli-Vinten 4703805708 Fix validation issues (#5411)
Closes #5411
2023-07-22 14:38:26 +01:00
TheWitness 6687eef2d3 Fixing #5403 - Regular Expression Negation
Cacti Log regular expression filters can not calculate 'does not match' properly
2023-07-15 12:42:18 -04:00
TheWitness f47b6b3f93 Porting #5324 - Multiple XSS issues in Cacti
This is resolved just a bit differently than the original #5324 post.
2023-06-17 17:49:17 -04:00
TheWitness a46b3e09a2 Fixing #5317 - Data Source Info Issues
Data Source Info Mode produces invalid recommendations
2023-06-17 17:07:43 -04:00
TheWitness a55abadba6 Fixing #5342 and #5368 - Keyup delay on tree search
Increase keyup delay when searching the tree

For 1.3.x, also adds a setting and switches all keyup events that
make ajax calls to use delayKeyup instead of manually defining
each timer.

Closes #5368
2023-06-12 03:54:55 +01:00
netniV 0b06b0a49b Plugin missing functions warning should be debounced (#5360) 2023-06-12 03:02:50 +01:00
TheWitness e76ff3bde1 More corrections for #5169 - Fail date logic
Host table status_fail_date and status_rec_date can appear wrong
2023-06-12 02:36:48 +01:00
TheWitness 79a1941a0d Fixing #5169 - Recovery date wrong
Host table status_fail_date and status_rec_date can appear wrong
2023-06-12 02:36:45 +01:00
Matthew Mathur bef85436c1 Merge pull request from GHSA-77rf-774j-6h3p
* Use sanitized unserialize function in managers.php

* Add validation of string contents prior to unserialization
2023-06-06 00:52:58 +01:00
Mark Brugnoli-Vinten f49bed3b5b Fix issue with array_rekey 2023-06-01 00:41:26 +01:00
Petr Macek d44e0a7cf2 function read_config_option returns null sometimes (#5339) 2023-05-31 08:22:30 +01:00
Mark Brugnoli-Vinten 972d46d0d0 Some minor QA fixes to make VSC happy 2023-05-29 11:33:48 +01:00
TheWitness 16e2344b1e Fixing #5294 - Setting to log 'Ignored Errors'
Allow Ignored Errors to be Logged such as 'No Route to host'
2023-04-30 16:49:36 -04:00
TheWitness 4ff8e19768 Resolve #5309 - Log file generating 'undefined index'
This modification modifies the user of variable incrementation using the standard form and addressed the undefined index properly.
2023-04-29 16:52:37 -04:00
TheWitness 2de8a4f089 Fixing #5309 - Periodic Errors
1.3.0 - QA Cacti Log Periodically Getting Errors associated with tailing log file
2023-04-23 10:57:33 -04:00
TheWitness 19a71ccb96 Phase 1 of #412 - Adding hashes
To support Export, we need to first create hashes for tables.
2023-04-22 13:21:14 -04:00
TheWitness 900a66a0cc Fixing Issue #3048 - Different log levels for pollers
Allow different log settings for remote pollers
2023-04-17 06:59:03 -04:00
TheWitness 00f4f678d0 Fixing #5231 - Show Uptime/Instate when Editing Device
When editing a Device show in state/uptime as a date in the header
2023-04-17 06:33:32 -04:00
TheWitness df0e718747 QA: Fixing #5301 - Casting issues with get_daysfromtime()
1.3.0 - QA Function get_daysfromtime() truncates result through invalid use of (int) cast
2023-04-11 21:51:40 -04:00
TheWitness 8b06303719 QA: More precise resource check and backoff debugging 2023-04-08 10:13:11 -04:00
TheWitness 2ce9a9c3f6 QA: Add more checks to is_resource_writable() 2023-04-08 10:08:45 -04:00
TheWitness 9da4dc5d94 QA: Add additional error handler string for DNS failures
* Temporary DNS failures log a warning, catch it.
* Also move errors to the General section that are not DNS related, and indicated why there are there.
2023-04-08 08:21:10 -04:00
TheWitness c8abd5b187 Fixing #5294 - No route to host errors
1.3.0 - QA Error Message **No route to host** should be masked
2023-04-07 10:57:05 -04:00
TheWitness 71ecf0f59b Fixing #5292 - is_resource_writeable() errors in Cacti log
Also DNS check error checking.
2023-04-07 10:23:01 -04:00
Browniebraun 09a7c76eed fix small typo 2023-04-03 18:42:27 +02:00
TheWitness 3b171273cb QA: Minor fix to version compare 2023-04-02 21:49:04 -04:00
TheWitness 8ce8577d4b QA: Fix issue where the user theme was not respected 2023-04-02 11:55:28 -04:00
TheWitness 90537275e9 Fixing #5263 Warnings in Cacti log when re-indexing devices
Warnings in Cacti log when re-indexing devices
2023-04-01 12:42:51 -04:00
TheWitness 2fd8c25c41 Porting #5283 - Undefined offset error 2023-04-01 11:35:54 -04:00
TheWitness ca7a352286 QA: Porting 1.2.24 Changes back to the Develop Branch (#5246) 2023-02-24 03:48:31 +00:00
TheWitness 5fc2ace695 Porting #5186 - Fatal Error
Array intersect does now work when the second parameter is null
2023-01-22 16:48:24 -05:00
TheWitness 90edc500e3 Porting #5169 - host times
Host table status_fail_date and Status_rec_date can appear wrong
2023-01-22 16:25:00 -05:00
TheWitness c2a5e2df47 Revert "Porting #5160 - device time status'"
This reverts commit 9c198da5c5.
2023-01-22 16:24:21 -05:00
TheWitness 9c198da5c5 Porting #5160 - device time status'
Host table status_fail_date and Status_rec_date can appear wrong
2023-01-22 16:23:32 -05:00
TheWitness b6526b8597 Fixing #5163 & #5165 DSStats Enhancements
* Adds multiple percentile data to the Data Source Statistics tables
* Converts the Hourly Cache to InnoDB
* Some normalization rrdtool_function_graph() calling params outside of plugins
* Fix issues with variance and standard deviation calculations in graph_variables.php
2023-01-15 22:17:16 -05:00
Mark Brugnoli-Vinten 9fc81a0c65 QA on language and PSR 2023-01-14 15:13:12 +00:00
Mark Brugnoli-Vinten 545a786483 Update styling locations for themes 2023-01-08 22:07:10 +00:00
Mark Brugnoli-Vinten 5a24569532 Some message QA 2023-01-08 19:25:59 +00:00
Mark Brugnoli-Vinten 777a9b38e0 Hidden by the mist 2023-01-08 16:24:53 +00:00
Mark Brugnoli-Vinten febbbf6252 QA fix some minor messaging issues 2023-01-08 14:22:47 +00:00
TheWitness 068912dce9 QA: Strict typing has downsides
Force level (aka selective by file) should only return a value if the level is forced, otherwise control returns to the main function where it's further processed to determine the effective level.

Therefore, defaulting the level results in the selective log level function prevents the parent function for performing further inspection and determination of the final log level.
2023-01-08 09:14:33 -05:00
Mark Brugnoli-Vinten 681e0960ce Some minor QA on message handling 2023-01-08 11:45:04 +00:00
Mark Brugnoli-Vinten 6ad0512b45 Some light function documentation and src alignment 2023-01-08 00:59:25 +00:00