Commit Graph
718 Commits
Author SHA1 Message Date
cigamit 027d701f1b Resolving Issue #2925
Problem with consolidation function after upgade to 1.2.6
2019-09-04 23:44:56 -05:00
cigamit b673aaafe2 Resolving Issue #2912
Resolve navigation caching array to string conversion issues
2019-08-29 07:26:11 -05:00
netniV 245a34063e Mailer incorrectly reports it is sending to noone
Closes #2902
2019-08-16 12:29:37 +00:00
netniV 9e1e58c240 When path is blank, is_resource_writable() will generate 'Uninitialized string offset: -1'
Closes #2820
2019-07-13 13:57:30 +00:00
cigamit 28088b47f8 Resolving Issue #2816
Two issues about page navigation under "Logs" tab
2019-07-12 07:44:41 -05:00
netniV 79ffee4ead Installation wizard does not detect RRDtool version correctly
Closes #2282
2019-07-10 22:28:49 +00:00
cigamit 390ded9f10 Additional Resolution on Issue #2805 2019-07-07 15:21:12 -05:00
cigamit b08f8030fc Resolving Issue #2783
Cacti title_trim() function does not work with UTF-8 or Multi Byte strings
2019-06-30 11:30:06 -05:00
cigamit 1ee746965d Resolving Issue #2742
Resolve a number of QA issues in various files
2019-06-22 09:04:37 -05:00
netniV 2c25435cef In PHP strict standards mode, rrdtool_function_graph() generates ByRef message for HRULE items
Closes #2724
2019-06-09 13:09:54 +00:00
cigamit d04fb8d176 Resolving Issue #2707
Some pages that have permission errors dont raise proper messages
2019-05-27 11:02:20 -05:00
cigamit 3d1252b579 Minor update to issue #2662 2019-05-13 02:24:48 -05:00
cigamit d0c3ab0daf Resolving Issue #2662
* HRULE objects broken in some cases
* Also two missed escapeshell* change
2019-05-12 06:48:22 -05:00
netniV a2d3fd8776 Revert "WIP: php argument composition (#2653)"
This reverts commit 8a23ca33e3.
2019-04-29 12:43:03 +00:00
David Runge 8a23ca33e3 WIP: php argument composition (#2653)
* Moving all argument composition for backgrounded calls of php to 'assemble_php_args()' in /lib/functions.php.

* lib/functions.php: Explicitely prepending all assembled arguments.

* lib/functions.php: Removing an accidental appending of the initial args in assemble_php_args().
2019-04-29 13:38:17 +01:00
cigamit f002bdf58a Resolving Issue #2523
Test email failure on PHP 7.3
2019-04-16 21:22:32 -05:00
netniV 013c8eb644 Resolves multiple issues:
-issue#2590: Language selection is not working as expected
-issue#2605: When checking for tables to upgrade, undefined variable $config error occurs
-issue#2608: db_update_table() function should not require an engine type or comment
-issue#2610: Data Sources troubleshooter generates warning that each() function is deprecated

Closes #2590, 2605, 2608, 2610
2019-04-04 11:49:59 +00:00
cigamit 239d759de6 Remove trailing spaces from names
This happens during the presentation of the breadcrumbs.
2019-03-27 07:15:25 -05:00
NotAProfessionalDeveloper c3195c1be2 Remove grocer's apostrophes (#2546)
https://blog.oxforddictionaries.com/2011/02/04/random-apostrophization/
2019-03-22 15:58:43 +00:00
cigamit 046590909b Resolving Issue #2282
Install Wizard does not Detect RRDtool Version on Windows
2019-03-10 16:00:41 -05:00
netniV cade16849a Fix up incorrect variable name when checking for bad navigation items 2019-03-01 15:39:55 +00:00
netniV 6581274835 Resolving issue #2472
Bad navigation items cause Array to string conversion errors
2019-03-01 10:06:42 +00:00
cigamit 350678d3ce Resolving Issue #2450
Undefined index: in file lib/rrd.php when viewing new graph
2019-02-24 07:16:49 -06:00
netniV 173df04100 Make get_timefromdays() handle multiple formats 2019-02-23 22:55:57 +00:00
cigamit 2743fe6dc2 Make the SQL and the get_timeinstate() function consistent 2019-02-23 13:41:32 -06:00
cigamit 4f6a393f12 Compensate for 'Unknown' Device status 2019-02-23 13:04:25 -06:00
cigamit 3daad8c6f0 Minor tweak after testing 2019-02-23 12:29:53 -06:00
cigamit 778131a45f Correct issue with time in state calculation
This will correct time in state calculations for devices that do not
have an availability/reachability check.
2019-02-23 12:21:41 -06:00
netniV 52a6add2e0 Correct issue with days more than 99 2019-02-21 15:13:51 +00:00
netniV 19b14d7f64 Correct dyslexic naming of function call in last commit 2019-02-21 15:01:38 +00:00
netniV 52ea4a8f91 Correct issues with uptime display 2019-02-21 14:58:47 +00:00
cigamit 0370dfea49 Clearn up messaging and add ContentType 2019-02-20 20:48:48 -06:00
cigamit 9314d946f2 Add get_uptime function and fix mailer text email option 2019-02-19 20:13:33 -06:00
netniV ef64170ab0 Previous commit missed a change 2019-02-19 13:39:40 +00:00
netniV e6e8c2d922 Resolving issue #2431
Default value is text for which mail method to use, should be integer
2019-02-19 13:37:31 +00:00
netniV 299f3298b6 Resolving issue #2419
Host state time was not correctly calculated if snmp_sysUptimeInstance was used.  The lib/functions.php was dividing the value by 100 but the SQL statement was not, resulting in invalid sort orders.

Additionally, the get_timeinstate() function was updated to utilise the 'instate' element if it exists in the $hosts variable.
2019-02-19 10:09:21 +00:00
Morten Stevens 125cb4d329 Fix selinux issues with cacti.log write check (#2420)
See https://github.com/Cacti/cacti/issues/2416
2019-02-15 18:14:39 +00:00
cigamit e9800f0316 Resolving Issue #2352
- snmp_sysDescr field contains mangled data
- This is another attempt at resolving snmp descrepancies
2019-02-03 13:14:55 -06:00
cigamit cd14f260dd Resolving Issues #599 and #2365
This is a major bug fix to Aggregate.  Also found a bug in rrdtool that
we will have to work around.
The upside of the bug fix for #2365 is that it appears to have fixed
#599 and also an issue with legend alignment.  Legends should always
align nicely now.
2019-02-01 18:22:28 -06:00
Georgi D. Sotirov 74e489d9fb Allow dash in domain name (#2351)
Additional fix for issue #2339
2019-01-27 11:04:27 -06:00
cigamit 38f7ac3063 Resolving Issue #2339
MAILER WARNING: Mail failed from ... Message: You must provide at least
one recipient email address.
2019-01-26 08:38:41 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
netniV d0024b963b Installer will now identify when PHP can not call shell_exec() or exec() 2019-01-19 19:06:32 +00:00
cigamit 3e1b1cc924 Make it more obvious why we are doing the check. 2019-01-19 10:23:16 -06:00
cigamit e00027af9d Better php version fatal error logging
Make the PHP 5.4 + json fatal error message more clear.  Allow RHEL6 at
the incorrect PHP level to reach the point where users can be notified
that they are at the wrong PHP version or that php-json is missing from
the install.
2019-01-19 10:01:25 -06:00
cigamit f9dc7dcd9e -issue: Data Debug was not logging
Fixed a few additional UI and usability bugs
2019-01-13 09:53:13 -06:00
cigamit 6f96ed1c26 Properly handle snmp timeouts
Additionally address value output format issues.
2019-01-12 13:55:39 -06:00
cigamit 32d39a1b44 Resolving Issue #2303
- Problem with "Notify Primary Admin of Issues" function
- Removing debug code
- Changing formatting for readability
2019-01-12 11:50:55 -06:00
Nuno Silva 59a563c437 fix a bunch of typos in lib/functions.php (#2276)
* fix typo in variable name (database_log)

* fix a bunch of comment typos in lib/functions.php
2019-01-07 07:32:20 -06:00
cigamit a471713433 Correct warning from session management 2018-12-27 12:13:54 -06:00