Commit Graph
66 Commits
Author SHA1 Message Date
cigamit 57ef005ed3 Resolving Issue #2877
Problems sending reports
2019-08-15 22:38:23 -05:00
cigamit e4b8770855 Revert "Resolving Issue #2786"
This reverts commit 02e8c75e3b.
2019-07-01 17:46:28 -05:00
cigamit 02e8c75e3b Resolving Issue #2786
A non-numeric value encountered in \lib\plugins.php on line 930
2019-07-01 17:33:46 -05:00
cigamit 492b3f8919 Resolving Issue #2744
Undefined index: password_change in auth_changepassword.php
2019-06-23 10:17:13 -05:00
Petr Macek 0710d27bc5 fix MySQL (8.0.1) reserved word function (#2736)
* fix mysql (8.0.1) reserved word function

* resolving issue #2736
2019-06-22 21:31:55 +08:00
netniV 6108e8759d Further resolve #2513 2019-03-13 16:35:57 +00:00
netniV 086b5c78df Resolving issue #2513
When a plugin INFO file is malformed or missing elements, plugin_load_info_file() should fill missing elements with defaults which are now defined as:

'name'      => directory holding info file
'requires'  => blank
'longname'  => directory holding info file (first letter is uppercased)
'status'    => 0
'version'   => 0.0
'author'    => 'Unknown'
'homepage'  => If webpage is set, use that otherwise 'Not Stated'
'directory' => directory holding info file

This will ensure consistency and that any attempts to use a key such as requires will be present.
2019-03-13 13:17:15 +00:00
cigamit 7b6e3a403e Resolving Issue #2326
Due to issues reported in the thold plugin
2019-02-09 09:32:59 -06:00
cigamit edc736d871 Additional fixes for Issue #2326
This allows the row format to be dynamic only when the
innodb_file_format is Barracuda, and corrects a bug in detecting MySQL
vs. MariaDB in the version string.
2019-01-26 09:42:37 -06:00
cigamit 683a1de0c4 Partial resolution to Issue #2326
Upgrade errors due to key length.  We will have to mandate a minimum to
implement these changes.
2019-01-26 09:01:31 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit b596e2f235 Resolving Issue #2322
Modifying relam registration files and description not supported in
plugin api
Additionally removing 'Management' from plugins since we have it removed
everywhere else.
2019-01-19 12:57:25 -06:00
cigamit 75ef8b4d5c -issue: timestamp columns with CURRENT_TIMESTAMP cant be created
Additional bracketing for readability
2019-01-18 18:03:32 -06:00
netniV 7924828016 Resolving issue #2319
Primary admin account not always given access to a plugin when that plugin is enabled as previously it was hardcoded to 'admin'
2019-01-17 18:13:46 +00:00
cigamit 0f33a46473 -issue: Plugin dependency handling inconsistent
Additionally, display of dependent plugins non conforming.
2019-01-10 06:38:35 -06:00
cigamit 7b05a6a6f3 Resolving Issue #2250
[1.2.0 Beta 4] Database creation functions do not support charset or
partial indexes
2018-12-31 12:11:19 -06:00
YongBoLiu 87ab0e8554 Fix SQL errors when default value has function. For example, should be default current_timestamp(), not default 'current_timestamp()'. (#2112) 2018-10-23 08:25:40 -04:00
Mark Brugnoli-Vinten a3ce9918a3 Latest QA fixes (#1992)
* Sort required modules for easier reading during installation

* QA fix for template package details

* Correct issue with plugin hooks SQL failing

* Rejig some the layout of Installer class and add some comments

* Some minor QA fixes

* Correct typo with com_dotnet module

* Add more information about collation change
2018-09-29 06:28:15 -05:00
cigamit e0330adfa2 Allow plugin hooks to automatically be enabled
There is a case where you need to register a new hook during an upgrade.
In this case, in the upgrade function, if the plugin is already enabled,
the new hooks will also automatically be enabled.
2018-09-26 21:11:32 -05:00
Mark Brugnoli-Vinten 39efc75c49 Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939 (#1937)
* Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939

* Update import.php
2018-09-16 13:22:32 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 67163f6303 Resolving Issue #1437
Plugin install hover message sometimes shows line breaks rather than
formatted text
2018-05-11 17:48:07 -05:00
netniV 5b69de6d3f Feature #1399: Allow 'requires' to include version against a plugin (#1436)
* feature #1399: Allow 'requires' to include version against a plugin

* Remove debug code

* Remove more debug code
2018-03-03 12:56:02 -06:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 8f6ccf4bc6 Resolving Issue #1388
Realm permissions can be duplicated due to develop branch
lib/plugins.php logic issue
2018-02-22 05:50:21 -06:00
cigamit 160a42c1e6 Resolving Issue #1384
When installing/enabling plugins, current user and admin should get
permissions
2018-02-21 18:33:13 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 99d19d5312 Correct whitespace and formatting issues
Whitespace and formatting in lib
2017-11-19 14:35:17 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
cigamit 1f23fa798a Perform optimization in both functions for PR840 2017-07-07 17:50:24 -05:00
patrick 2b6afd56ff Fixed query after PR #840 2017-07-07 23:28:53 +02:00
Pavel Levin 4c2ca5ccce Remove extra parameter from SELECT
Id parameter was not used
2017-07-06 18:20:28 +03:00
cigamit 6cce1dfafc feature: Provide Non Compatible explanation when a plugin is not compatible 2017-07-03 08:59:01 -05:00
cigamit 27f30f498f Resolve upgrade issues from Cacti 0.8.7
If the plugin architecture does not exist, install will fail.  Also
found php function version_compare not working in PHP 5.3.x.

There were additionally issues with the upgrade functions as well.
Resolving those too.
2017-06-04 19:56:52 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit 8316f865af Make plugin register functions idempotent
Step 1 to making plugin upgrades easier
This will allow a plugin to re-run its install function during updates
to correct hooks that have changed functions / filenames.
2017-04-10 23:46:46 -05:00
cigamit 913a893c31 Fix issue #240
SQL error when install plugin
2017-01-31 11:15:21 -06:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
cigamit 593e635496 Resolving Routerconfigs issue
https://github.com/Cacti/plugin_routerconfigs/issues/5
2017-01-07 08:19:52 -06:00
cigamit ad714ea21b Plugin hooks not firing properly 2017-01-05 07:50:23 -06:00
cigamit fc8e23810f Allow Dependency Checks when Installing Plugins 2017-01-04 17:49:04 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit db98b5a5e8 Multiple changes for Remote Data Collectors
1) Remove legacy plugin_hooks (pia 1.0) support
2) Online run certain hooks if the plugin supports them from the Remote
Data collector
3) Remove some unused variables and change formatting slightly
4) Add several new functions for remote data collection interrigation

Optimally, the plugin should be able to check the status of the Data
Collector and do the right thing, but for now, we will force things.
This only impacts the Remote Data Collectors.
2017-01-01 11:50:57 -06:00
cigamit 748a6b783e Roughing in some functions for pluign capabilities
These functions are not active yet, but will be soon.  We are using an
array today, but I could see the capabilities matrix in a database.  For
now, these are some of the important ones for the 1.0 release.
2016-12-31 17:05:06 -06:00
cigamit 476d295d53 resolve issue installing plugins with mysql 5.7 2016-09-19 07:54:08 -05:00
cigamit 440f1fbfde Add ErrorHandler
We now catch and log all PHP Errors.  If a FATAL PARSE / COMPILE error
is detected in a plugin, we will automatically disable that plugin so
that Cacti does not stop working.
2016-08-22 20:51:45 -05:00
cigamit 3d0b663d44 protect issue that can be caused by empty id 2016-06-30 18:24:21 -05:00
cigamit 63a4c54429 ALTER IGNORE removed from MySQL 5.7 2016-06-25 07:43:43 -05:00