Commit Graph
1736 Commits
Author SHA1 Message Date
cigamit ebf8fb2ee8 Updates after final QA of SNMP security_level feature 2018-01-14 16:28:36 -06:00
cigamit 39be1f395e Pass the default protocols in through global_session.php 2018-01-14 15:50:42 -06:00
cigamit 75eb754235 Move SNMP functions into core
This will reduce the liklihood of bugs from duplicated code.
2018-01-14 15:40:39 -06:00
cigamit 56f07bc77b Minor Tweaks to SNMP v3 Security Levels
Handle jQueryUI selectmenu refresh and reorder the settings form to flow
the same as host and manager edit.
2018-01-14 10:53:07 -06:00
cigamit 97583420f2 Tweak visibility and default
Debugging and for backward compatibility.
2018-01-14 10:38:21 -06:00
cigamit 7dcc0160cd More snmpv3 security level work
This change adds the security level to the forms, but not the database
as it generates the least amount of effort.
2018-01-14 10:23:39 -06:00
cigamit e61ab91dee Enhance SNMP GUI Support
When a user chooses '[None]' for SNMP Auth/Privacy, hide/clear
passphrases.  Also, put protocols ahead of passphrases.
2018-01-13 17:19:44 -06:00
cigamit c90702c408 Remove debug code 2018-01-13 12:33:06 -06:00
cigamit 35923c0474 Enhancement to allow developer to add more buttons buttons to header
Cacti has moved to using both fontawesome and table glyphs for actions
instead of text.  This enhancement will allow developers to add
adiditional actions to the title.  The actions that will be included by
default are clear, import and export so long as those buttons have the
appropriate title.
2018-01-13 12:10:28 -06:00
cigamit 55704f2ec9 The makeFiltersResponsive() function to aggressive
Adding the .not() will exclude the data query debug. Section which does
not need to be responsive.  However, we should be converting the debug
information to standard div based tables.  This commit is relative to
issues #1168 and #1186.
2018-01-13 09:07:13 -06:00
cigamit a646bc194b Fixups for Issues #1168 and #1186
This addresses both visual and functional changes to ensure everything
is working.
2018-01-12 14:30:13 -06:00
cigamit e06a91f430 Updates for Issues #1168 and #1186
These updates provide the i18n of the various strings.
2018-01-12 11:25:49 -06:00
netniV e5ae849e2c Issue #1168 - Unable to copy debug information (#1186)
* Fix for Issue #1168 - Allow copy of debug query text to clipboard
Issue #1168 - Allow debug query section to be copied to the clipboard

- Currently, whilst clipboard code is run, no text is being copied
- Various text updated to i18n calls.
- CSS still needs to be generated

* Update with working version of copy that doesn't collapse with table header

* Update copyToClipboard to copy table as HTML not just the HTML text

* Issue #1168 - Further clipboard enhancements
issue #1168 now presents a 'Copy' link on the right side of a debug header table (currently a circle)

This functionality has been extended to copy the entire debug via the "Data Query Debug Information" header
Sections are automatically expanded whilst copying to allow selection copy, non-expansion prevents this

* Further fixes for #1168
issue#1168: Now uses jQuery.dialog() for messages (a lot nicer!)

Need to find out if there is a function to retrieve Cacti language messages, ie, get data from https://cacti/messages.php?text
2018-01-12 17:42:00 -06:00
cigamit b68449521c Resolving Issue #1194
Undefined 'data' in check for logout function.
2018-01-11 23:50:25 -06:00
cigamit 6b05fee0e2 Another round of bugs for issue #1175 2018-01-06 21:42:17 -06:00
cigamit 59c4f1b186 Additional check for logout relatedd to issue #1175 2018-01-06 20:57:45 -06:00
cigamit d9d8cc9b76 Resolving minor formatting and two errors in new function 2018-01-06 20:50:09 -06:00
cigamit a4023f787e Resolving Issue #1175
When session timeouts occur, logout gracefully
Some spurious conversion to html_escape()
2018-01-06 17:04:28 -06:00
cigamit e6f62e4395 Resolving Issue #1182
Support noAuthNoPriv for SNMPv3 in Cacti
2018-01-06 18:12:25 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
netniV 29de0b50c0 Issue #1166 - Further language fixes for detection/configuration (#1177)
* Fix Issue #1166 - Further language fixes
Issue #1166 - Further language fixes for detection/configuration.

- User default now defaults to system default if not set.
- Language detection now tries multiple methods of language detection rather than just the first one if that language isn't supported.

* Add missing CHANGELOG and correct minor code format issues
2018-01-05 18:13:41 -06:00
Tony Roman 4d14245ac8 Preparing for 1.1.30 release 2018-01-03 12:38:13 -05:00
netniV 708a3f8e8f Fix issue #1166 - Incorrect default language (#1167)
When editing a user, default language became first in the list rather than English
2018-01-03 06:45:27 -06:00
cigamit c7c432bb94 Resolving Issue #1161
Graph View regex's are not preserved during automatic page refresh
2018-01-02 19:24:37 -06:00
cigamit 0115d50d2f Resolving two QA problems from RHEL6.9 testing 2017-12-31 13:08:46 -06:00
cigamit dfc60cb4b7 Resolve four QA issues found while testing
-issue: basename function undefined during upgrade to 1.0.x
-issue: Storage API and translations required for Change password
function
-issue: ALTER IGNORE still throws an error when attempting to drop the
primary key
-issue: Data Source profile form API generates error when system is half
upgraded
2017-12-29 10:21:11 -06:00
cigamit 8d63e6b144 Resolving Issue #1128
Resolve php warning when raising messages
2017-12-24 08:50:12 -06:00
cigamit 899eab02b5 Zoom context menu stays open after zoom out actions 2017-12-23 11:30:22 -06:00
Tony Roman 98008449d0 Preping for 1.1.29 release 2017-12-22 15:06:58 -05:00
Tomasz Chiliński d0468112c0 CHILAN: allow to select many lines by interval determined by previously clicked line and lately clicked line with shift key pressed (continuation of work started in pull request #1132) (#1148) 2017-12-22 09:53:38 -06:00
Tomasz Chiliński e2b8e20047 CHILAN: allow to select many data queries by interval determined by previously clicked row and lately clicked row with shift key pressed (#1132) 2017-12-21 19:17:29 -06:00
cigamit a47d713d7b Resolving Issue #1104
Different Timestamps in Cacti log when in Developer Debug
2017-12-02 11:16:14 -06:00
cigamit 083c59cd74 Resolving Issue #1085
Call to undefined function html_log_input_error in debug mode
2017-11-17 07:43:18 -06:00
DavidLiedke f6fce8ae59 Update to screenfull.js to 3.3.2 (#1081)
..from 3.3.1
2017-11-16 06:15:07 -06:00
DavidLiedke 8b7ba2f063 Update phpseclib to 2.0.7 (#1080) 2017-11-16 06:14:39 -06:00
Patrick 928ae7de82 Various updates (#1075)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations

* fixed parameter typo in query_debug_timer_stop()

* fixed typo $_SESSION

* MibCache->install() uses MibParser->oids, but MibCache->oids has protected access instead of public

* Updated of PHPMailer to version 5.2.26
- Minor security backport from 6.0 - set Debugoutput in constructor according to SAPI in use, avoiding potential XSS in default debug output. Thanks to Bankde Eakasit for spotting it.

* Remove old autoLoad method
2017-11-12 09:39:55 -06:00
cigamit eecc365bf6 Minor paw theme update
This is to improve visibility when pages are viewed in responsive mode.
2017-11-11 07:58:12 -06:00
cigamit a179e8092d Resolving Issue #1066
Resolve second half of Issue #1066 which is CVE-2017-16661.
2017-11-11 07:39:13 -06:00
DavidLiedke 6c2ae1d7c4 Update Chart.js (#1054)
Thanks David!
2017-11-04 09:14:57 -05:00
cigamit e8088bb659 Resolving Issue #1057
- Potential vulnerability in RRDtool functions
- Adding validation to both dirpath and filepath, also verification of
executable status to files in RRDtool function.
- Spurious htmlspecialchars() to html_escape() calls
- Minor SQL formatting for readability
2017-11-04 14:52:09 -05:00
cigamit e21919937f Another approach to Issue #1039
Correction to XSS issue page refresh.  This approach makes a small
alteration to the existing sanitize_uri() function to sanifize the url.
2017-10-28 15:25:30 -05:00
Tony Roman 1ead8f9ec7 Preping for 1.1.28 release 2017-10-27 19:00:58 -04:00
cigamit aac679f476 Let Travis live! 2017-10-26 22:12:39 -05:00
cigamit b44eb529e0 Another crack at issue #1039
Prevent possible XSS attack
2017-10-26 20:56:06 -05:00
Tony Roman 8bc7450164 Preping for 1.1.27 release 2017-10-22 10:33:54 -04:00
cigamit 054aa82de0 Resolving Issue #1039
Use strip_tags() over html_escape due to double escaping not working as
expected.
2017-10-17 23:45:25 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 8e2a5fd806 Resolving Issue #986
Resolving minor visual issue with Modern theme
2017-10-15 08:29:49 -05:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
cigamit 4f87256e63 Resolving Issue #1028
Auto log page refresh broken.  Reworking CVE fix from Issue #1010
2017-10-11 20:57:33 -05:00