Commit Graph
528 Commits
Author SHA1 Message Date
cigamit a646bc194b Fixups for Issues #1168 and #1186
This addresses both visual and functional changes to ensure everything
is working.
2018-01-12 14:30:13 -06:00
netniV e5ae849e2c Issue #1168 - Unable to copy debug information (#1186)
* Fix for Issue #1168 - Allow copy of debug query text to clipboard
Issue #1168 - Allow debug query section to be copied to the clipboard

- Currently, whilst clipboard code is run, no text is being copied
- Various text updated to i18n calls.
- CSS still needs to be generated

* Update with working version of copy that doesn't collapse with table header

* Update copyToClipboard to copy table as HTML not just the HTML text

* Issue #1168 - Further clipboard enhancements
issue #1168 now presents a 'Copy' link on the right side of a debug header table (currently a circle)

This functionality has been extended to copy the entire debug via the "Data Query Debug Information" header
Sections are automatically expanded whilst copying to allow selection copy, non-expansion prevents this

* Further fixes for #1168
issue#1168: Now uses jQuery.dialog() for messages (a lot nicer!)

Need to find out if there is a function to retrieve Cacti language messages, ie, get data from https://cacti/messages.php?text
2018-01-12 17:42:00 -06:00
Tony Roman bfee1c86d2 issue#1179: Warn during installation if installing moving to older version
- Also cleaned up lingering debug
2018-01-06 09:29:24 -05:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit c35739e1a1 Fix for #1178 - Be more consistent with disabling plugins in CactiShutdownHandler and CactiErrorHandler 2018-01-05 23:34:42 -06:00
cigamit c7ba275a8a Resolving Issue #1164
Additional issues with cacti_version_compare function
2018-01-05 18:37:20 -06:00
cigamit c7c432bb94 Resolving Issue #1161
Graph View regex's are not preserved during automatic page refresh
2018-01-02 19:24:37 -06:00
cigamit 0115d50d2f Resolving two QA problems from RHEL6.9 testing 2017-12-31 13:08:46 -06:00
cigamit b7d9b4c9b1 Resolving Issue #1155
Non-secure mail setting not functional due to changes in phpmailer.
2017-12-27 08:14:39 -06:00
cigamit 3002c035b9 Issue with version_to_decimal() function 2017-12-24 12:04:58 -06:00
cigamit 586212295a Resolving issues with the cacti_version_compare()
The cacti_version_compare() function was not operating properly when
moving between second order point versions (eg 1.1.29 to 1.2.0).  This
is resolved through a minor change to the cacti_version_compare()
function and the version_to_decimal() function.
2017-12-23 09:30:48 -06:00
netniV 5bd73b8318 Fix for issue #1130 (#1150)
Using cacti_log() with the optional POLLER_VERBOSITY_xxx paramater resulted in mising logs if they were set to the same level as the poller log level in settings
2017-12-23 08:03:27 -06:00
cigamit a47d713d7b Resolving Issue #1104
Different Timestamps in Cacti log when in Developer Debug
2017-12-02 11:16:14 -06:00
cigamit 889ea4c5fd Resolving Issue #1088
Remote Data collector polling has no timeout setting
2017-11-18 09:54:38 -06:00
Browniebraun ecd34627e6 new function get_default_contextoption added
define a new function to consolidate the different setup options of default (file) streams. introduce a new hook to ensure that custom plugins are able to add their own header flags for authentication cookies and so on.
2017-11-13 14:58:53 +01:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
cigamit 51932c6835 Resolving Issue #959
- Resolving issues viewing email reports due to email client decoder
issues.
- Also, make some format changes for readability of code
2017-10-29 09:27:16 -05:00
cigamit e21919937f Another approach to Issue #1039
Correction to XSS issue page refresh.  This approach makes a small
alteration to the existing sanitize_uri() function to sanifize the url.
2017-10-28 15:25:30 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit cc242b8aa8 Resolving Issue #966
- SMTP Security set to None, but TLS still being used
- Backport more html_escape() changes for convenience
- Backport charset check for convenience
2017-09-23 07:04:34 -05:00
cigamit 190b8c4abd Audit of ping methods tcp, udp, and icmp. Better support for IPv6
The udp and tcp ping method should start working for PHP 5.5.4+, but
this has not been confirmed yet.
2017-08-26 09:56:29 -05:00
cigamit 7a63e0127c Correct undefined variable warning 2017-08-11 23:25:20 -05:00
cigamit 12cb7abc65 Resolving Issue #673
Downtime/Recovery time/date is set incorrectly
2017-08-09 10:15:30 -05:00
cigamit cc45ede3ef Resolving Issue #819
Allow saving customized timespan for Graph page.  This functionality was
removed accidentally from Cacti 1.x.  For people who have upgraded
already, there is a function that finds what is the best timespan.  If
this is not acceptable, and the Data Source Profiles are Read only, you
may have to hand alter the tables to enter the 'preferred' Timespan.
2017-08-05 15:41:09 -05:00
cigamit 63fd0feb24 Resolving Iissue #880
Device drop down is limited to 20 devices and lacks a scroll bar
2017-07-29 13:30:11 -05:00
Tomasz Chilinski e4073284ae allow to send single part plain text mails
(cherry picked from commit 172485853e)
2017-07-23 20:10:36 -04:00
cigamit b9f558a675 Add additional checks on Linux versions that avoid the use of True Type Font functions 2017-07-11 07:43:48 -05:00
cigamit f617c7121c Introduce new DATE_TIME_FORMAT constant resolving issue #829
Addresses issues with 500 messages when in developer debug mode.  Also,
make certain that the navigation variables exist before using them.
2017-06-29 17:37:32 -05:00
cigamit 5594afbdf9 Resolving Issue #779 2017-06-28 07:12:44 -05:00
patrick 90e1a468e8 issue: Fix date separator character 2017-06-14 17:45:44 +02:00
cigamit d155a03aee Resolve potential corner case around time in state and lack of snmp support. 2017-06-11 18:12:22 -05:00
cigamit 37a5a7791a Resolving Issue #779
- Resolve randome apache segfault due to recursion.
- Also, remove additional references to export user
- Change the way the guest_account id is gathered.
- Change elseif format
- Remove trailing white-spaces
2017-06-08 07:42:22 -05:00
Tony Roman e7174c4046 Fix issue#788
- Fixed up invalid function call
 - Added default operator to cacti_version_compare function
2017-06-04 23:24:43 -04:00
Tony Roman ca8c8cd123 Move cacti_version_compare into main functions lib to be used
in non-install code
2017-06-04 21:33:15 -04:00
cigamit 27f30f498f Resolve upgrade issues from Cacti 0.8.7
If the plugin architecture does not exist, install will fail.  Also
found php function version_compare not working in PHP 5.3.x.

There were additionally issues with the upgrade functions as well.
Resolving those too.
2017-06-04 19:56:52 -05:00
Patrick 031598f56b Fix for #757 2017-06-01 20:54:27 +02:00
Patrick ae9acfd0f9 CLOG Enhancements
-Fixed CLOG paginator
-Fixed automatic page refresh
-Logfile writes rows with preferred timestamp
2017-05-30 10:20:05 +02:00
patrick ef69094b5e CLOG Enhancements
-feature: CLOG timestamp is now formatted as defined in settings
-feature: CLOG can show loginformation from rotated logfiles
-Added GDC_DOT to global_constants.php and global_arrays.php, and refactored the usage of global $datechar
2017-05-29 13:44:31 +02:00
cigamit f6699ed23d feature: add function to obtain the current execution user 2017-05-23 07:52:05 -05:00
cigamit 622f180cb6 Resolving Issue #662
Sending test Email should optionly bypass ping
2017-05-17 22:44:58 -05:00
Jimmy Conner aea8ddc7bd Merge pull request #702 from reboot1983/strlen
Cool stuff
2017-05-17 22:13:11 -05:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
Patrick 56e02d75f2 Optimisations
- Optimisations of query calls and function calls in loops
- Removed unused function calls and variables
- Refactored large if statements into switch statements
- Applied early return
- Fixed alignments and removed unnecessary parentheses
2017-05-16 11:33:23 +02:00
cigamit 1a14cbb440 Introduce new get_cacti_version function to reduce database calls on pages 2017-05-14 12:29:30 -05:00
cigamit 8a695b113c Resolving Issue #658
Scheduled Reports (type "tree") not working.
2017-05-14 11:15:11 -05:00
cigamit c862851b7e Optimizations around data input methods
No functional changes
2017-05-13 11:08:34 -05:00
Patrick 40baee32b0 Bugfix for issue#680
- Fixed sorting; is now same as in data_source_profiles.php?action=edit
2017-05-13 00:18:47 +02:00
cigamit 7f9a808e56 Resolving Issue #657
Error in log when host is dow, using icmp ping and using cmd.php on
FreeBSD
2017-05-07 16:50:10 -05:00
Patrick f435138f44 Merge remote-tracking branch 'upstream/develop' into CLOGFix_651_Unable_to_view_cacti_log
# Conflicts:
#	install/upgrades/1_1_6.php
2017-05-07 18:06:01 +02:00
Patrick 23c95d0808 - Feature#106 Paginated CLOG and log administration
- Added missing docblock to new function
- Added configurable max_display_rows to settings panel
- Applied max_display_rows to code instead of MAX_DISPLAY_ROWS
- Removed define MAX_DISPLAY_ROWS
2017-05-07 18:00:21 +02:00