Commit Graph
243 Commits
Author SHA1 Message Date
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
netniV 6dc3fcb811 Fix for issue #1162 - Missing error messages (#1163)
Error messages are not display when editing a user
2018-01-02 19:16:11 -06:00
netniV 979373fea4 Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled (#1129)
* Fix issue #1122 - Local user login fails with Multi/Single LDAP enabled

Code was not consistent with how it was generating the password hashes and comparing them. To fix this, added compat_password_xxx functions that check for the availability of the newer password_xxx functions and if not present revert back to the md5 version.

Changes made are:

auth_changepassword.php:
* Break out of switch when error message set
* Reduce duplication of code when checking passwords
* Use local variables rather than constantly pulling in request ones
* Use new compat_password_xxx functions

auth_login.php:
* Added some debug logging to identify login issues
* Allow local login even if using ldap
* Use new compat_password_xxx functions
* Remove password from SQL search as hash can change and we don't know what it would have been at the time it was set

user_admin.php
* Use new compat_password_xxx functions

lib\auth.php:
* Added compat_password_verify, compat_password_hash and compat_password_rehash to check for PHP 5.7+ compatible functions other use MD5
* Reduced SQL query to just required user in secpass_login_process()
* Fixed password check in secpass_check_history()
* Fixed return value check of secpass_check_pass() in secpass_login_process()
* Use new compat_password_xxx functions

* Update CHANGELOG

* Fixup for Issue #1122, corrects some minor issues

* Merge branch 'Issue-1122' of https://github.com/netniV/cacti into Issue-1122

Update log message to be warning notj ust a normal message

* Fix issue of local auth bypas

* Update CHANGELOG

Fix up CHANGELOG issues

* Update auth.php

Fix up formatting issues
2017-12-23 12:58:03 -06:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 92e90783de Taking actions on users does not use callbacks
Minor GUI issue.
2017-08-21 19:53:01 -05:00
cigamit 166950b95e issue: Design of Sunrise requires all checkboxes have their css updated, and include labels. 2017-08-06 14:20:05 -05:00
cigamit cc47688d35 Resolving Issue #875
When modifying Realm permissions, realms that are listed multiple times
don't stay in sync.
2017-07-25 20:04:28 -05:00
cigamit 30bbf226f5 More changes for issue #861
Filters not working properly for i18n
2017-07-20 18:55:33 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit f850e57629 Freshed core filter html
In preparation for responsive filters phase II
2017-07-05 17:13:10 -05:00
cigamit 37a5a7791a Resolving Issue #779
- Resolve randome apache segfault due to recursion.
- Also, remove additional references to export user
- Change the way the guest_account id is gathered.
- Change elseif format
- Remove trailing white-spaces
2017-06-08 07:42:22 -05:00
John Horne e42eb706b2 Correct the graph template count for user permissions. 2017-06-01 13:38:22 +01:00
patrick 16e2b7c052 Replaced all if statements and inline if statement with $variable != '' where strlen($variable) was used to determine if a string was empty or not 2017-05-18 01:14:15 +02:00
cigamit f013fb88c7 User Admin page reported wrong permissions at Tree level and missed some i18n 2017-05-14 13:28:56 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit 6fff84f201 Remove manual aria controls from pages 2017-04-30 18:04:29 -05:00
cigamit ff125d01cb Update all pages to include div based forms
This requires a CSS change which is going to be committed next and
separately to call out the changes required there.
2017-04-30 13:15:58 -05:00
cigamit b28f44a9d9 Add escaping to filter values prior to request.
Handles the sepecial case of a pound sign causing issues.
2017-04-23 07:35:01 -05:00
Patrick 40dbc3e57b Alignment fixes
Alignment fixes for PHP7.2 compatibility changes of yesterday.
2017-04-22 15:53:05 +02:00
patrick d2185c98b1 PHP7.2 changes:
- Replaced deprecated each() for foreach()
2017-04-21 22:12:55 +02:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
browniebraun 35d89c5891 fix broken user permission layout occurring if no external links have been defined yet
Signed-off-by: browniebraun <browniebraun@outlook.com>
2017-04-12 23:13:43 +02:00
cigamit 8f6fa03d8d Resolving Issue #533
User settings not cleared after saving profile
2017-04-07 17:26:28 -05:00
cigamit 429d00bc6f Mark realms that are not available with the current ldap setting as such.
This differentiates between LDAP and Multiple LDAP
2017-03-20 18:08:49 -05:00
cigamit 56e630ffa6 Minor layout change. 2017-03-19 16:27:20 -05:00
cigamit 01da9b11d6 Resolving Issue #436
Restricted user does not see graphs in tree view.  Also caught some
issues in the Tree Permissions section of both user and User Group's,
and additional Tree permissions when reproducing the users environment.
2017-03-19 13:18:48 -05:00
cigamit f22c9694e4 Add multiple column sort and glyph API's
Convert all core pages to use multiple column sort.  There may still be
some pages around automation that are required to be migrated.  However,
they will continue to operate as is.
2017-03-17 17:19:03 -05:00
cigamit e77531201e Resolving Issue #275 2017-02-06 17:05:39 -06:00
cigamit 73d0100349 Resolving visual issues with row counts. 2017-01-29 13:08:32 -06:00
cigamit 5eaab96735 Resolved Issue #235
Also resolving some missing i18n migrations and prepared statement
formatting.
2017-01-28 15:32:15 -06:00
cigamit aa212655a9 Resolving Issue #214 2017-01-18 17:51:12 -06:00
cigamit a560987bd5 Resolving the second part of Issue #214 2017-01-16 17:42:33 -06:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit d70f9718dc resolve login redirect loops
Corner case where you have forced a password change, but have not
granted that permission to the user.  We are also now blocking the save
when the user tries to make this setting.

We need better interactions with the login screen under certain failure
modes.  But for now this is good enough.
2016-12-19 18:18:05 -06:00
cigamit 99f21a253d resolving display issues with user and group realms 2016-09-01 06:17:27 -05:00
cigamit 1aa80816f2 standardize not found messaging 2016-08-31 16:23:20 -05:00
cigamit 2bae3e0365 resolving bug#2346 2016-08-28 15:57:13 -05:00
cigamit b523f1dea5 remove addslashes, prepared statements, wc3 validation, double to single quote
this is required for preparation of magic_quotes_gpc.
2016-08-28 15:27:48 -05:00
cigamit ce4f00acc9 rolling out new filter_value() function to all pages
additionally fixed several minor filtering bugs in many pages
2016-08-22 13:31:06 -05:00
cigamit 7f936441a6 change external link wording 2016-07-12 17:45:38 -05:00
cigamit 39af17cca8 adding external link support to cacti 2016-07-10 19:02:09 -05:00
cigamit 54d97035a2 large commit, separate table pager from tables
this change impacts all plugins and css.  css changes are included in
this commit.  plugin changes will be forthcoming.
2016-07-09 12:44:37 -05:00
cigamit 6e90fe2427 minor syntax fixes 2016-06-23 17:59:45 -05:00
cigamit 35993291a9 control the vertical size on a single action page 2016-06-18 15:19:35 -05:00
cigamit 34b5d19ce8 minor filter changes 2016-06-18 12:13:27 -05:00
cigamit ac9fbda633 adding some aria labels for accessibility 2016-05-23 09:22:58 -05:00
cigamit ea51a91e2e i18n user_admin.php 2016-05-22 15:54:15 -05:00
cigamit 666be85a66 unable to save email address 2016-04-29 20:53:36 -05:00
cigamit c399664082 rows selector consistency 2016-04-27 12:41:02 -05:00
cigamit 685e98fe23 add validation to the tab variable 2016-04-11 08:12:54 -05:00