Commit Graph
159 Commits
Author SHA1 Message Date
cigamit 866fc9340c Resolving Issue #1610
Script STDERR logging
2018-05-12 09:56:49 -05:00
cigamit d805be03d3 Resolving Issue #1521
Force boost to be enabled when there are Remote Data Collectors
2018-05-11 18:09:25 -05:00
cigamit 8d19c5a06b Allow ASCII filepath paths to not be found on settings save
This was reported in 1.1.x and now is solved by distinguishing betwen
binary, which must exist, and ascii, which can be empty as they may be
created later.
2018-05-10 17:57:34 -05:00
cigamit c96d59c043 Additional minor change to #1504
Was getting jQueryUI errors otherwise.
2018-03-30 12:36:42 -05:00
cigamit a438816b0e Resolving Issue #1504
Withholding the CHANGELOG changes in this commit.  This commit does
remove some functionality from the Graph Template Item edit.  This is
not a big issue though.
2018-03-30 11:43:23 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
cigamit a12e548c77 Resolving Issue #1443
Partial Save warnings under Settings -> Mail/Reporting/DNS
2018-03-08 12:31:20 -06:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 31de2802f4 Resolving Issue #1397
Distinguish between plugin tabs and core tabs in settings
2018-02-24 22:33:49 -06:00
cigamit f9ca6a4ff9 issue: Reduce horizontal space used by settings tab
This will allow more plugins to use this space.
2018-02-21 20:07:58 -06:00
cigamit b58ae81192 Make directory and file errors more understandable
issue: Separate directory path and file path error messages for
readability
2018-02-19 21:32:03 -06:00
cigamit 8726ec90fe Reduce load time of settings page
Reduce the number of dom parses to draw the settings page to decrease
the amount of time required to draw the page.
2018-02-19 19:03:04 -06:00
cigamit 366f136ee8 Correcting multiple issues with filters, settings and page refresh
Per the CHANGELOG:
-issue: Allow multiple errors to be returned from save operations
-issue: Optimize filter visibility functions and make html consistent
-issue: Allow error fields to be highlighted on the settings page
-issue: Some error fields not showing when saving under Settings > Paths
-issue: When refreshing some pages using F5, header would be removed
2018-02-19 17:23:14 -06:00
cigamit 7e70e27940 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	include/themes/modern/main.css
#	tree.php
2018-02-18 16:26:26 -06:00
cigamit 08c87d47da Resolving Issue #1359
Settings page can generate error if expected tab not found
2018-02-15 19:15:04 -06:00
cigamit 10a8e523f7 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	cacti.sql
#	data_sources.php
#	docs/CHANGELOG
#	graphs.php
#	host.php
2018-01-26 19:31:47 -06:00
netniV 6039e847fc Fix for Issue #1256 / #1268 - RFILTER and display corrections (#1269)
* Fix for Issue #1256 and #1268
This patch fixes issues with both the display of the error messages and with RFILTER variables not properly being primed as discussed on issue #1256 and issue #1268

* Update CHANGELOG

* Fix issue number
2018-01-26 17:56:24 -07:00
cigamit 09f8bf273e Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	install/index.php
#	settings.php
2018-01-15 17:42:18 -06:00
cigamit f44592a001 Missed one change for the settings page around version modality 2018-01-15 16:04:24 -06:00
cigamit 9274f014ca Updates after final QA of SNMP security_level feature 2018-01-14 16:29:02 -06:00
cigamit ebf8fb2ee8 Updates after final QA of SNMP security_level feature 2018-01-14 16:28:36 -06:00
cigamit 1f1f05408d Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	host.php
#	managers.php
#	settings.php
2018-01-14 15:46:15 -06:00
cigamit 75eb754235 Move SNMP functions into core
This will reduce the liklihood of bugs from duplicated code.
2018-01-14 15:40:39 -06:00
cigamit a00e9bf8f8 Correct jQuery Syntax Issue 2018-01-14 11:10:22 -06:00
cigamit 4c41cdf821 Correct jQuery Syntax Issue 2018-01-14 11:08:37 -06:00
cigamit 6469e879c1 Calculate the default security level for legacy
Without this, legacy behavior might break.
2018-01-14 11:05:57 -06:00
cigamit 82061ec5fd Calculate the default security level for legacy
Without this, legacy behavior might break.
2018-01-14 11:05:34 -06:00
cigamit 5d38d596e7 Minor Tweaks to SNMP v3 Security Levels
Handle jQueryUI selectmenu refresh and reorder the settings form to flow
the same as host and manager edit.
2018-01-14 10:53:29 -06:00
cigamit 56f07bc77b Minor Tweaks to SNMP v3 Security Levels
Handle jQueryUI selectmenu refresh and reorder the settings form to flow
the same as host and manager edit.
2018-01-14 10:53:07 -06:00
cigamit 1edbf5b667 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	host.php
#	include/global_settings.php
#	managers.php
#	settings.php
2018-01-14 10:41:31 -06:00
cigamit 97583420f2 Tweak visibility and default
Debugging and for backward compatibility.
2018-01-14 10:38:21 -06:00
cigamit 998f7ebcfb More snmpv3 security level work
This change adds the security level to the forms, but not the database
as it generates the least amount of effort.
2018-01-14 10:24:12 -06:00
cigamit 7dcc0160cd More snmpv3 security level work
This change adds the security level to the forms, but not the database
as it generates the least amount of effort.
2018-01-14 10:23:39 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 0530aae041 Correct syntax error in settings.php 2017-11-25 11:53:45 -06:00
cigamit 2c00d59b35 Resolving Issue #1097
Template user issues including:
- All template users should be disabled by default
- When a user is copied, enable that user by default
2017-11-23 12:30:56 -06:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
cigamit a179e8092d Resolving Issue #1066
Resolve second half of Issue #1066 which is CVE-2017-16661.
2017-11-11 07:39:13 -06:00
cigamit e8088bb659 Resolving Issue #1057
- Potential vulnerability in RRDtool functions
- Adding validation to both dirpath and filepath, also verification of
executable status to files in RRDtool function.
- Spurious htmlspecialchars() to html_escape() calls
- Minor SQL formatting for readability
2017-11-04 14:52:09 -05:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
Arno Streuli cedc671eaa Feature/1.2.x (#979)
* Update cacti.sql

Added 2 entry for cn_full_name and cn_email

* Update cacti.sql

Change the size to 50

* Create 1_2_0.php

Added the change on table user_domains_ldap, to provide info for full_name and email

* Update global_settings.php

Added the 2 new entry as new section for LDAP settings:
ldap_cn_fullname
ldap_cn_email

* Update auth.php

Added the email address on user_copy function

* Update ldap.php

Added the ldap_search_cn to search 2 specific CN on LDAP server

* Update auth_login.php

Added the Get user CN part for new LDAP users

* Update ldap.php

little error on ldap_search inside Getcn function

* Update user_domains.php

Add option to manage Full name and email taken from LDAP server

* Update auth_login.php

Change for multidomain authentication

* Update global_settings.php

change the name ldap_cn_xxx to just cn_xxx

* Update ldap.php

Correction to the error number and message when the CN is not find

* Update settings.php

Added the visibility of CN fields only for LDAP authentication mode

* Update ldap.php

correct on line 729 missing $ before this->cn

* Update cacti.sql

column definitions consistent with the definitions under install/upgrades/1_2_0.php

* Update auth_login.php

correct tab, as space, and add {} in if else statment

* Update ldap.php

correction on cacti_log with $output['error_text'], correction on all error_num 99 as '99'
and made some correction int tab/space

* Update auth_login.php

add missing {} on else function
2017-09-16 15:51:56 -05:00
cigamit 3a8d4f7ff9 Use html_escape() over htmlspecialchars() for consistency and security 2017-09-04 21:26:27 -05:00
cigamit 111dbe1400 Change multiselect default hight. Make a bit larger 2017-07-29 12:23:00 -05:00
cigamit 0673e3c725 Resolving Issue #861
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
2017-07-19 20:16:27 -05:00
cigamit 0de5c781f2 Resolving Issue #818
Unable to unselect all SpikeKill templates under settings
2017-06-27 19:57:51 -05:00
cigamit 37a5a7791a Resolving Issue #779
- Resolve randome apache segfault due to recursion.
- Also, remove additional references to export user
- Change the way the guest_account id is gathered.
- Change elseif format
- Remove trailing white-spaces
2017-06-08 07:42:22 -05:00
cigamit f7f025e6ae Finish resolution of Issue #756
Translation Issues
2017-06-03 20:15:52 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00