TheWitness
9355593845
Turn on Data Source Validation function when Data Source Trace is enabled
...
Also getting some of the comments in proper phpDocumentation style. I feel I've been here before.
2021-07-01 13:02:09 -04:00
netniV
c414764767
Restore DSV_LOG, remove random prints, fix script output
2021-06-27 19:11:04 +00:00
TheWitness
b05b547c51
Fixing Issue #4273 - Device CLI generating errors
...
There were multiple fixes to this file, but this corrects issues with the Script Server script testing.
2021-06-25 17:25:02 -04:00
netniV
43cc617d02
Fix up for #4309 , following on from #4250
2021-06-17 23:06:21 +00:00
netniV
8f6637c292
Remove erroroneous trace logging
2021-06-14 14:14:19 +00:00
netniV
c5c088d2d1
Further fix of test_data_source() [ #4250 ]
2021-06-11 20:05:00 +00:00
netniV
5a2d51c02f
Further fix of test_data_source() [ #4250 ]
2021-06-09 14:00:59 +00:00
netniV
9c5720137b
Unable to create graphs due to Data Source verification failure ( #4250 )
...
Closes #4250
2021-06-05 20:32:01 +00:00
TheWitness
b1686206a3
Correct two minor issues, one unchecked variable and one with a forced zone issue
2021-04-21 19:21:56 -04:00
TheWitness
6bbcb538a6
More fixes around issue #645 - Test Data Source
...
This change allows for testing of data source from the Graphs New page to reduce the likelihood of graphs being created that will never be rendered
2021-04-02 18:36:16 -04:00
TheWitness
65d77ac9e2
Minor fix related to issue #4182
...
SNMP Query based graphs should render now.
2021-03-29 21:36:35 -04:00
TheWitness
0dc4a93cca
Update around issues #645 and #4182
2021-03-25 17:45:43 -04:00
TheWitness
dceee19d6f
Update around issues #645 and #4182
2021-03-25 07:40:00 -04:00
TheWitness
8ab093d20a
Continuation of making cmd.php DST immune
2021-03-24 20:18:36 -04:00
TheWitness
b22dff2e9d
Fixing Issues #645 - Check Data Sources before Graph Create
...
So, this is not 100% finished yet as it does not currently work with the Remote Agent. However needed some testers.
This change also deprecates Script Server calls being called without the proc_open() command which was a requirement from the early 2000's for a PHP version I don't even remember.
The change also improves logging when creating graphs via automation.
Lastly, marking #3572 as resolved as it was resolved in another fix over the weekend.
2021-03-23 22:09:53 -04:00
TheWitness
44a557445d
Fixing Issue #4195 - filter_value() quoting
...
filter_value() function does not work as expected when search includes # character
2021-03-23 19:42:03 -04:00
TheWitness
07b95c6cbc
Fixing Issue #4184 - Error logging in cmd.php
...
- cmd.php error response logging is not properly following the detailed/summary logging setting
- This is basically a rewrite of the cmd.php that makes it much easier to read, and actually makes it 2x faster than previous versions.
- Change the 'tics' behavior to not loop so hard watching for signals.
- Makes the snmp session data passing more reasonable
- Like spine, if a host times out when attempting to fetch and OID, the remainder of the host will be skipped, resulting in a more reliable performance as well.
2021-03-20 11:15:30 -04:00
TheWitness
4ca57f0590
Fixing Issue #4180 - Web Basic Logout
...
- When using 'basic' authentication, there should be no logoff link as it's not possible
2021-03-19 19:52:48 -04:00
TheWitness
3398d8c5d5
Fixing Issue #4127
...
Tree Editing used get_graph_title() function which results in unexpected behavior
2021-02-15 08:16:18 -05:00
kim-fitness
e32997db9e
Fix issue #4100 ( #4101 )
...
* Update CHANGELOG
* Update functions.php
* Update functions.php
Remove the redundant function array_key_exists, it can be covered by function isset
2021-01-27 19:19:27 -05:00
TheWitness
557f89bd67
Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x"
...
This reverts commit 0b597f61cb , reversing
changes made to b062b2bb57 .
2021-01-26 19:48:30 -05:00
browniebraun
20e6223f6d
Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x"
...
This reverts commit 7e0da80345 , reversing
changes made to 3ee16196ef .
2021-01-26 19:09:33 +01:00
TheWitness
e6258b6d8b
Two additional boost optimizations
...
- Do not overcall the plugin hook DB calls, or checking for rrdtool version in a single script instantiation repeatedly
2021-01-25 12:54:36 -05:00
TheWitness
c4ba292b49
Fixing Issue #4075
...
- LDAP Settings lead to confusion when setting up LDAP authentication
- This is a fairly large consolidation of code blocks.
2021-01-21 18:59:25 -05:00
Datatech UK Ltd and TheWitness
234f90cbab
Only show sensitive graph information to Template Editors in the List View screen ( #4049 )
...
* Update main.css
Make it more obvious that a slider is disabled.
* Update main.css
Make it more obvious that a radio slider is disabled.
* Update cacti.sql
Fixed the default value for the 30 second polling and amended the default values for the 1 minute polling for new installs
* Add ability to Hide the Graph Drilldown icons from the graph_view.php and graph.php pages
The icons are on the right hand side of the graphs and the default behaviour is to display them unless you hide them per user in the permissions tab
* Updated CHANGELOG
* Change the Realm from 2001 to 27 as 100 and above are reserved for plug-ins.
* Formatting change for neatness.
* Update CHANGELOG to reference this ticket number. Changed Drilldown to Drilldowns
* Only show sensitive graph information to Template Editors in the List View screen
* Removed duplicate line from CHANGELOG
* Update CHANGELOG to reference this ticket number.
* Updated cacti.pot as requested
Co-authored-by: TheWitness <thewitness@cacti.net >
2021-01-17 14:11:56 -05:00
mr_me
f92e9860c4
Patch for get_client_addr ( #4060 )
...
* Update CHANGELOG
* Updated get_client_addr
When calling get_client_addr REMOTE_ADDR is always returned
* Update CHANGELOG
2021-01-17 12:21:32 -05:00
TheWitness
df54a4a3f3
Updating copright years
2021-01-01 20:28:58 -05:00
kim-fitness and TheWitness
5d24cfee9b
Update lib/functions.php and include/global_arrays.php ( #4020 )
...
* Update functions.php
* Update global_arrays.php
* Update CHANGELOG
* Update CHANGELOG
Co-authored-by: TheWitness <thewitness@cacti.net >
2020-12-24 05:59:10 -05:00
TheWitness
7b7b713604
Fixing Issue #4008
...
This is a partial rollback of issue #3808 due to negative impact it has on both GUI and Data Collector performance.
2020-12-15 21:27:36 -05:00
TheWitness
1a58f59deb
Fixing Issue #3960
...
Improve warning you get when attempting to view a log file you don't have access to
2020-11-27 09:53:29 -05:00
TheWitness
68a25e9ae5
Correct three issues with PHP7.4
2020-11-22 22:43:46 -05:00
TheWitness
2b69a59f71
Correct three issues with PHP7.4
2020-11-22 22:36:13 -05:00
TheWitness
7d5f2144b3
Correct three issues with PHP7.4
2020-11-22 21:55:14 -05:00
TheWitness
f103cf078b
Fixing Issue #3910
...
Banners are not showing up
2020-11-08 12:35:46 -05:00
TheWitness
52bb6ffda7
Remove all remaining instances to "sizeof(" or "count(" in code
...
* Some insances in the vendor directory have not been handled to maintain pedigree.
2020-10-21 08:27:42 -04:00
TheWitness
bb2e3f6433
Fixing Issue #3815
...
Issues with Cacti login when session_autostart is configured in php.ini
2020-09-28 21:34:50 -04:00
kim-fitness
129150fbbc
Fix issue #3793 ( #3803 )
...
* Update CHANGELOG
* Update functions.php
2020-09-15 08:26:54 -04:00
TheWitness
55da4167c3
Fixing Issue #3768
...
When using the Paw, Paper-plan, and Sunrise themes, there is no way to remind the user who is logged on
2020-08-26 13:04:29 -04:00
netniV
67c8e72e7e
LDAP Authentication succeeds, but login fails due to bad session handling ( #3576 )
...
Also applying a QA fix on poller maintenances logrotation function
Closes #3576
2020-06-28 19:12:36 +00:00
TheWitness
8870e84cdf
Properly handle session closure.
2020-06-27 21:31:24 -04:00
TheWitness
0c9a29cf37
Fixing Issue #3601
...
When devices down, instate can show wrong time
2020-06-13 12:05:40 -04:00
TheWitness
4e062fb6aa
Use Cacti functions for session handling where possible.
2020-05-19 12:29:54 -04:00
TheWitness
9a100d6035
Fixing Issue #3506
...
"Login as Regular User" always forward to "Automatic Logout....timeout"
2020-04-26 11:11:43 -04:00
TheWitness
a360f1a3ef
Fixing Iseue #3450
...
Cacti can not be supported on XAMPP and PHP7.4
2020-04-09 20:32:36 -04:00
TheWitness
a8ea533640
Additional changes for #3402
...
* These changes allow some JavaScript to be loaded Async. jQuery and jQueryUI as well as layout.js as well as the themes's main.js are critical and can not be loaded async.
* It also adds the meta description tag to increse the SEI scrore
2020-04-04 09:17:27 -04:00
TheWitness
d65f40d2bf
Abstract Cacti session handler
2020-03-29 19:08:29 -04:00
TheWitness
e2a6a034f6
Minor update due to note on issue #3380
2020-03-29 12:30:49 -04:00
TheWitness
aac7dcd9b9
Minor changes to attachment handling to cover all cases.
2020-03-29 10:31:22 -04:00
TheWitness
a0100843ba
Missed update to email attachment handling
2020-03-28 18:39:52 -04:00
TheWitness
dd2d455362
Fixing Issue #3380
...
php error when trigger threshold sendmail
2020-03-27 12:56:11 -04:00