Commit Graph
131 Commits
Author SHA1 Message Date
TheWitness 9f5fe10646 QA on new Filter Option 2022-02-21 09:15:18 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
netniV 283c2ab76f Fixes for #4324, #4325, #4326
issue#4324: Date/Time format of replacement fild on graph cannot be changed
issue#4325: Make identifying rows when editing graph items easier
issue#4326: When using large lists, selection is visible in dropdown menus
2021-06-27 20:43:13 +00:00
TheWitness ea61668934 Fixing Issue #4188 - Prefix Replacement Hard to Find
- For Aggregate Graphs and Templates the replacement value available are difficult to find
- There is one additional fix: |host_hostname| should be |host_description|
2021-03-21 15:26:01 -04:00
TheWitness bf292d5d57 Additional update on #4035
This is based upon recommendations. to pre-sanitize the referer always and we don't want to double sanitize.
2021-01-06 12:15:22 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 4301092c83 Additional fixes to #3553
undefined error when directly visit a none-exist graph
2020-05-20 23:08:39 -04:00
TheWitness e4e09d80cb Fixing Issue #3553
undefined error when directly visit a none-exist graph
2020-05-14 09:06:31 -04:00
ddb4githubandJing Chen 8b26c35565 Fixed: Same fix as for #2859 for deprecated curly braces (#3469)
Co-authored-by: Jing Chen <three_chenjing@sohu.com>
2020-04-17 17:11:21 -04:00
cigamit 4cbb045e03 Resolving Issue #3191
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit a4b1a35ad4 Resolve a regression around #3027
* Aggregate Graph re-ordering does not work
* In order to fix the regression had to add one additional column to the aggregate tables.
2019-11-30 19:40:21 -06:00
netniV 4cecb19f6b PHP Fatal error: Uncaught Error: Cannot pass parameter 5 by reference in graph_json.php:158
Closes #3104
2019-11-27 23:09:59 +00:00
ddb4github d5f98679a0 Fixed #3049(due to #2964) to add missed argv for most rrdtool_function_graph caller (#3087)
* Fixed: #2964 to add missed argv for all rrd_function_graph caller

* Fixed #2964: Apply security solution to aggregate graph preview and graph impage page
2019-11-17 14:15:41 -06:00
cigamit 17d4819622 Resolving Issue #3078
File not found warnings when viewing graph debug from remote data collector
2019-11-09 20:08:51 -06:00
cigamit cb3961fb46 Correct for undefined variable in aggregate_graphs.php 2019-11-09 15:02:12 -06:00
netniV 9fbb0621f2 When viewing Aggregate Graphs, an error due to undefined referrer may occur
Closes #3045
2019-10-21 21:43:40 +00:00
cigamit 2770fd21b8 Resolving Issue #2847
Permanently convert an Aggregate to a regular graph
2019-08-11 17:42:32 -05:00
cigamit b87747c38b Resolving Issue #2839
Non regular expression search filters don't support international characters
2019-07-24 18:05:17 -05:00
cigamit d097e1e818 Resolving Issue #2787
* Aggregate Preview Tab is missing
* No changelog as this was introduced between releases.
2019-07-01 17:36:08 -05:00
cigamit 75e2453284 Resolving Issue #2768
Aggregate Graphs showing wrong row count
2019-06-29 15:02:38 -05:00
cigamit 09074a55ce Resolving Issue #2766
Modifying Aggregate Templates not cascading to Graph
2019-06-28 18:14:32 -05:00
cigamit 4f3e341a7f Resolving Issue #2763
migrate aggregate graph using aggregate graph tempate has error
2019-06-25 06:46:43 -05:00
cigamit da469e52fe Resolving Issue #2762
Can not create aggregate graph with unknown RRD tools error
2019-06-25 06:39:22 -05:00
cigamit 00d47b4e45 Resolving a number of validation errors 2019-05-22 17:39:34 -05:00
ddb4github dfc6b64595 Fixed: Resolved some PHP NOTICE about undefined variables #2650 (#2651)
* Fixed: Resolved some PHP NOTICE about undefined variables.

* Fixd previous fixing. Should add 'global $l10n' only

* Fixed: typo miss '$'

* Minor change
2019-04-27 21:26:17 +06:00
cigamit 02d68f3100 Resolving Issue #2598
Create aggregate without aggregate graph tempate, rrdtools error
2019-04-11 10:47:37 -05:00
cigamit 8548a9e13c Resolving Issue #2593
Can not migrate aggregate to use a template
2019-04-10 11:43:06 -05:00
cigamit e662582ab5 Resolving Issue #2463
Zombie data sources without graphs
2019-03-12 22:21:19 -05:00
cigamit cd14f260dd Resolving Issues #599 and #2365
This is a major bug fix to Aggregate.  Also found a bug in rrdtool that
we will have to work around.
The upside of the bug fix for #2365 is that it appears to have fixed
#599 and also an issue with legend alignment.  Legends should always
align nicely now.
2019-02-01 18:22:28 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit d45f6f5a60 Additional visibility issue 2019-01-12 14:42:43 -06:00
cigamit efc061578c More "No XXX Found" format issues 2019-01-12 10:26:25 -06:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit cef4bd8671 -issue: align attribute is deprecated, use class instead 2018-11-10 11:35:55 -06:00
cigamit f18860f3cd Alphabetize includes add missing lib/poller.php where applicable
This is required for properly having data follow devices, graphs, and
data sources on change.
2018-10-13 13:03:22 -05:00
cigamit 44190227f4 Resolving Issue #1926
This is easy enough.  Not a major change actually.
Some line ending fixes as well
2018-09-24 20:52:19 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
cigamit ccdc937d72 Allow adding a Non-Existing Data Source to an Existing Graph when the Template is Updated 2018-08-19 19:22:22 -05:00
Mark Brugnoli-Vinten 51ee26ce1a Resolving issue #1689 (#1779)
* Resolving issue #1689

As noted in issue #1689 (Technical Support's RRDTool version should show
detected RRD version) the version of the RRDTool is never actually displayed.
The code has now been updated to properly handle versioning and displays both
the configured and installed versions.

The setting for rrdtool_version has been updated to a proper minimum version
number so that the cacti_version_compare() function may be effectively used.
This means that the constant values of RRDTOOL_VERSION_1_3 through
RRDTOOL_VERSION_7 have now been removed from the system.

* Some QA updates

* Further QA fixes
2018-08-02 18:01:25 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
cigamit a02f223f4e Additional sanitization for XSS for Issue #1457
- Also additional formatting and cleanup of some code
2018-03-17 08:20:29 -05:00
Tony Roman 1ce66b5fde Merge branch 'develop' into feature/1.2.x 2018-02-25 20:12:19 -05:00
cigamit 5d7bb410e0 Some pages missing colspan's for no rows found
Issue with message text wrapping when no rows found on some pages
2018-02-24 17:43:48 -06:00
cigamit 10a8e523f7 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	cacti.sql
#	data_sources.php
#	docs/CHANGELOG
#	graphs.php
#	host.php
2018-01-26 19:31:47 -06:00
netniV 6039e847fc Fix for Issue #1256 / #1268 - RFILTER and display corrections (#1269)
* Fix for Issue #1256 and #1268
This patch fixes issues with both the display of the error messages and with RFILTER variables not properly being primed as discussed on issue #1256 and issue #1268

* Update CHANGELOG

* Fix issue number
2018-01-26 17:56:24 -07:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00