Commit Graph
331 Commits
Author SHA1 Message Date
TheWitness e68f7fc416 Fixing Issue #4716 - Data Source Edit PHP 8 issues
Can't Edit Data Source of Graph
2022-04-14 06:36:17 -04:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness c60c60ba33 Fixing Issue #4420 - Data Source Edit
Data Sources page shows no name when Data Source has no name cache
2021-10-10 13:42:55 -04:00
TheWitness 75c147b704 Fixing Issue #4187 - Navigating from Graph to Data Source
This fixes issue #4187 and also a bug recently introduced where creating an Graph from Graphs new would not properly accept 'overriden' values.
2021-03-21 12:24:22 -04:00
TheWitness 2b1a0f4969 Another modification for #4143
- This makes both the Graph and Data Sources UI consistent and speeds up the Orphan Detection by orders of magnitude.
2021-02-22 13:25:27 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness ef10fe1c34 Fixing Issue #4019
* In a recent audit of core Cacti code, there were a few stored XSS issues that can be exposed
* Also removed a few spurious title_trims, that should no longer be a problem.
2020-12-23 16:33:27 -05:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code
* Some insances in the vendor directory have not been handled to maintain pedigree.
2020-10-21 08:27:42 -04:00
ddb4github b437321c4f Fixed #3563: Correct errors due to orphan column (#3709)
* Fixed #3563: lots of "Error: Duplicate column name 'orphan'" from parallel process 'poller_reindex_hosts.php':
 - Add column 'orphan' during 1.2.13 upgrade
 - Remove function 'add_orphan_support'

* Fixed#3563: change upgrade script from 1.2.13 to 1.2.14

* Fixed#3563: change upgrade script from 1.2.13 to 1.2.14

* Fixed#3563: add new column into cacti.sql and audit_schema.sql
2020-08-02 22:18:49 +01:00
TheWitness a719f64eb4 Fixing Issue #3563
Current orphan handling disrupts graphing transient indexes.
2020-05-18 02:43:14 -04:00
TheWitness 1f122e9ef9 Fixing Issue #3533
Start date for RRDfile is different between RRDfile in a Cacti install
2020-05-04 21:20:10 -04:00
TheWitness c9799025af Light audit realted to Issue #3381 2020-03-27 14:05:41 -04:00
TheWitness e4fc8d77be Partial fixing to issue #2937
* We should not be perfomring includes in the base of any library file.
2020-01-22 08:17:47 -05:00
cigamit 4cbb045e03 Resolving Issue #3191
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 89f344e143 Resolving Issue #2754
Allow Devices, Graphs and Data Sources to be searched by ID
2019-06-23 18:32:57 -05:00
cigamit 5ac586f591 Resolving Issue #2564
* Filtering for Orphan Data Sources is Unreliable
* Closes #2564
2019-03-23 19:17:19 -05:00
cigamit 856f595b0b Resolving Issue #2463
* This should help resulve the issue experienced in #2463
* Fix two i18n issues
* Fix some filter hints
2019-03-23 11:08:07 -05:00
cigamit e662582ab5 Resolving Issue #2463
Zombie data sources without graphs
2019-03-12 22:21:19 -05:00
cigamit 0964412f19 Resolving Issue #2502
Unable to have a min or max value for RRDfile at zero '0'
2019-03-10 10:17:21 -05:00
cigamit cce82eab7d Minor fixups
* Allow more memory for data debug
* Properly align the recommendations
2019-03-08 19:18:09 -06:00
cigamit 5554d9366e Resolving Issue #2466
Manual data source creation is broken
2019-03-02 11:29:19 -06:00
netniV 8d59d43c46 Adds data source enable/disable to the data source edit screen 2019-02-19 13:02:33 +00:00
cigamit bdc4ed9c05 Resolving Issue #2357
- Poller issuing WARNING with little way to diagnose
- This change will remove bad items first from the poller cache
- It adds a new option to filter Data Sources with a Status of Bad Index
- It issues a waring every few hours of the prescense of Bad Index in
the system.

The warning threshold may be excessive.  Will have to see as in large
installs indexes can get bad all the time.
2019-02-02 11:49:04 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit e1dad073ba Properly display "No XXX Found" rows 2019-01-12 09:48:29 -06:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit 543a2e3f47 Resolving Issue #2173
The orphan identification issue is not resolved at both the Graphs and
Data Sources level.
2018-11-21 14:10:02 -06:00
cigamit cbf6f818cd Resolving Issue #2173
- Resolving issue 3) of the issues as best as can be done.
-Additionally, making the graph_template_id multiselect common for all
pages and resolving additional QA issues in all areas that were impacted
by multiselect issues.
- Lastly, resolving issues in Reports that cause excessive queries and a
bad user experience.
- There will be likely one more commit on this bug as more QA needs to
be performend on Data Source orphan API introduced.
2018-11-21 13:49:08 -06:00
cigamit ed7c538afc More work on translations
There are a few more to come and another pass to pick up missing
translations.
2018-11-17 14:58:44 -06:00
cigamit 2ceb063dc2 Resolve 4 translation issues 2018-11-17 11:48:14 -06:00
cigamit 44dc17d73f Related to issue #2070 Change Device for Data Sources 2018-10-14 14:50:34 -05:00
cigamit b1ceea271b Code cleanup relatedd to issue #2070
The code before had lot's of duplicate sql calls and would result in a
higher probability of bugs.
2018-10-14 07:13:20 -05:00
cigamit d8966bbf9f The db_close() function is causing errors 2018-10-13 14:11:16 -05:00
cigamit 10248cd012 The variable $cnn_id is dangerous due to legacy behavior 2018-10-13 13:54:33 -05:00
cigamit 5c7a3fbb2f Resolving Issues #2068 and #2058
- [1.2.0 Beta 1] When saving, modifying, removing devices and graphs,
sync this data automatically
- [1.2.0 Beta 1] New CLI Script remove_device.php Orphans Graphs and
Data Sources
2018-10-13 13:36:22 -05:00
cigamit 04eee59570 Resolving Issue #2050
[1.2.0 Beta 1] Search in Graphs with error
2018-10-11 06:28:55 -05:00
cigamit fbdbcaef29 Resolving Issue #2042 and #1981
This should fix the issues.  Consolidated logic here as well as the
graph and data source suggested names were using different code paths
2018-10-10 03:32:59 -05:00
cigamit 0b991958fd Resolving Issue #1982
Certain hooks should occur within api functions rather than UI functions
2018-09-28 04:49:59 -05:00
cigamit 64d5fe0176 On the Data Sources page, if there is no filtered Device and a Data Source is edited, device association is lost
Some query cleanup as well.
2018-09-28 04:26:19 -05:00
cigamit 44190227f4 Resolving Issue #1926
This is easy enough.  Not a major change actually.
Some line ending fixes as well
2018-09-24 20:52:19 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 2b8097c060 Resolving Issue #1882
Bypass output validation in select cases
2018-08-30 19:29:27 -05:00
cigamit b92a62816a Correct Syntax Error in data_sources.php 2018-07-28 21:31:58 -05:00
cigamit f07c6da88c Small issue with invalid Edit Device URL location 2018-07-28 20:37:15 -05:00
cigamit 01870a1c14 Resolving Issue #1744
Realtime graphs not working.
2018-07-25 20:18:26 -05:00
cigamit efb3101cfd Resolving Issue #1658
Devices drop down should be filtered by Site
2018-06-17 13:40:21 -05:00
cigamit 86641b1be2 Pre-apply jQueryUI styles to input objects 2018-05-09 20:58:37 -05:00
cigamit 96f62fe610 Resolve Issue #1527
Update Fontawesome from 4.7 to 5.0.10
2018-04-22 09:24:27 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00