Commit Graph
428 Commits
Author SHA1 Message Date
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 708fda9995 Fixing Issue #4363 - Duplicate Graph Template Item Bug
Duplicate entries in graph_templates_item - mabye an aftermath of the template edit bug
2021-11-28 13:53:44 -05:00
TheWitness 03c6687949 Merge branch 'master' into 1.2.x 2021-08-29 11:43:21 -04:00
TheWitness 1b6f51589b Double Commit of #4341
This was already committed to the master branch.  Committing here too.
2021-08-28 18:42:01 -04:00
netniV 37c0b85465 Missing sequence field leads to errors in system logs (#4341) 2021-07-09 11:16:42 +00:00
netniV 283c2ab76f Fixes for #4324, #4325, #4326
issue#4324: Date/Time format of replacement fild on graph cannot be changed
issue#4325: Make identifying rows when editing graph items easier
issue#4326: When using large lists, selection is visible in dropdown menus
2021-06-27 20:43:13 +00:00
TheWitness ea61668934 Fixing Issue #4188 - Prefix Replacement Hard to Find
- For Aggregate Graphs and Templates the replacement value available are difficult to find
- There is one additional fix: |host_hostname| should be |host_description|
2021-03-21 15:26:01 -04:00
TheWitness 75c147b704 Fixing Issue #4187 - Navigating from Graph to Data Source
This fixes issue #4187 and also a bug recently introduced where creating an Graph from Graphs new would not properly accept 'overriden' values.
2021-03-21 12:24:22 -04:00
TheWitness 4739ad5969 Fixing Issue #4175
- Syncing Templates can results in False 'Damaged Graph' notification on Graph Management page
- Also corrects a few spurious errors when working with orphans and Change Template
2021-03-17 23:11:55 -04:00
TheWitness 2b1a0f4969 Another modification for #4143
- This makes both the Graph and Data Sources UI consistent and speeds up the Orphan Detection by orders of magnitude.
2021-02-22 13:25:27 -05:00
TheWitness 2160be7c6e Fixing Issue #4143
- Cacti's Graph Orhan detection is too aggressive leading to false positives
2021-02-22 10:27:33 -05:00
TheWitness b062b2bb57 Fixing Issue #4098 - Large System Performance
Graphs and Data Sources page almost unusable on very large systems
2021-01-26 19:28:32 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness aa41751d20 Fixing Issue #3936
Aggregate Graph that has been converted to a normal graph breaks when edited
2021-01-01 13:10:55 -05:00
58c4909775 Merge 3943 and 3513 from develop to 1.2.x (#3970)
* feature 3965, Add a value check if the input field is textbox in settings

* feature 3965, revert

* merge feature 3943 and 3513 from develop to 1.2.x

* Update CHANGELOG

* Update CHANGELOG

Co-authored-by: yboliu <yboliu@oc8636837557.ibm.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2020-12-02 07:24:08 -05:00
Jimmy Conner 5f1c90d3fa Fix issue with 'Change Graph Templates' showing on first load
It should be hidden until you select a Template
2020-09-29 18:29:44 -05:00
ddb4github b437321c4f Fixed #3563: Correct errors due to orphan column (#3709)
* Fixed #3563: lots of "Error: Duplicate column name 'orphan'" from parallel process 'poller_reindex_hosts.php':
 - Add column 'orphan' during 1.2.13 upgrade
 - Remove function 'add_orphan_support'

* Fixed#3563: change upgrade script from 1.2.13 to 1.2.14

* Fixed#3563: change upgrade script from 1.2.13 to 1.2.14

* Fixed#3563: add new column into cacti.sql and audit_schema.sql
2020-08-02 22:18:49 +01:00
TheWitness a719f64eb4 Fixing Issue #3563
Current orphan handling disrupts graphing transient indexes.
2020-05-18 02:43:14 -04:00
TheWitness 74c011ba86 Additional Fix to #3549
Several XSS Vulnerabilities.  This resolves Case 6
2020-05-13 22:09:00 -04:00
ddb4githubandJing Chen 8b26c35565 Fixed: Same fix as for #2859 for deprecated curly braces (#3469)
Co-authored-by: Jing Chen <three_chenjing@sohu.com>
2020-04-17 17:11:21 -04:00
F-i-f 75e2e3b08a Fixing Issue #3457 (#3465)
Allow graph right_axis scale to be negative.
Negative scales are supported by rrdtool.
Also improve the regular expression used for matching numbers.
2020-04-15 22:40:57 -04:00
cigamit 533220cd17 Resolving Issue #3233
Its difficult to determine what Graph Items represent when working with a non-templated Graph
2020-02-07 18:43:50 -06:00
FrontierLiu b70eeae3cb Update graphs.php (#3239) 2020-02-07 18:22:33 -06:00
TheWitness 4506a75db2 Fixing Issue #3206
Converted aggregate graph cannot be edited
2020-01-22 19:47:27 -05:00
cigamit 4cbb045e03 Resolving Issue #3191
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
netniV 4cecb19f6b PHP Fatal error: Uncaught Error: Cannot pass parameter 5 by reference in graph_json.php:158
Closes #3104
2019-11-27 23:09:59 +00:00
ddb4github d5f98679a0 Fixed #3049(due to #2964) to add missed argv for most rrdtool_function_graph caller (#3087)
* Fixed: #2964 to add missed argv for all rrd_function_graph caller

* Fixed #2964: Apply security solution to aggregate graph preview and graph impage page
2019-11-17 14:15:41 -06:00
cigamit 17d4819622 Resolving Issue #3078
File not found warnings when viewing graph debug from remote data collector
2019-11-09 20:08:51 -06:00
cigamit fe10b102f0 Resolving Issue #3013
Allow legends to be modified for Aggregate Graphs
2019-11-09 12:56:11 -06:00
cigamit cfb0733597 Fixing Issue #2964 Differently
* CVE-2019-16723 Security issue allows to view all graphs
* Thischange restores the check inside of lib/rrr.php and updates all but on calling of the graph function to include the user.
2019-10-19 08:01:39 -05:00
cigamit d6dc48503b Resolving Issue #3025
SQL Injection in graphs.php
2019-10-12 14:48:02 -05:00
cigamit 518800fdb0 Resolving Issue #2926
Cacti 1.2.6 failed to update graph
2019-09-05 20:41:27 -05:00
cigamit 5a13e98ed6 Resolving Issue #2869
Creating Aggregates from Graphs pages not fully functional due to JavaScript issues
2019-08-11 15:30:20 -05:00
cigamit 2e65c727a7 Resolving Issue #2794
Graph template not saved on graph edit
2019-07-24 19:16:33 -05:00
cigamit 3e7e8e5f09 Missed update to graphs.php
This was supposed to be committed as a part of the empty graph remediation but somehow missed.
2019-06-29 08:30:31 -05:00
cigamit 89f344e143 Resolving Issue #2754
Allow Devices, Graphs and Data Sources to be searched by ID
2019-06-23 18:32:57 -05:00
cigamit 8a6d100dd9 Resolved Issue #2741
Resolve a number of QA issues in various files
One additional fix for data debug as to default debug state
2019-06-22 09:23:29 -05:00
sysres-dev e7b54490b5 Resolving issues 2538,2539,2540 (#2552)
* Fix CHANGELOG (#2533)

* Update Travis information

* Resolving issue #2532

Ensure Graph ListView table is displayed in line with Management -> Graphs

* Add missing lib/graphs.php

* Improve performance on graph_view's tree_content action by reducing the number of SQL queries executed

* Resolving issues 2538,2539,2540

This commit is related to features requests 2538,2539,2540 :
2538 : new setting to change datasource behaviour when deleting graph
2539 : new setting to add permanent unlock of graphs
2540 : new setting to forget graph tree history on tab close

* tree_history description

changed description for tree_history

* Minor Cacti PSR Update

* Minor Cacti PSR Change

* Minor Cacti PSR Change

* Relocate setting and change gramar

* Minor language change

* Minor format change
2019-04-23 07:57:58 +06:00
cigamit 856f595b0b Resolving Issue #2463
* This should help resulve the issue experienced in #2463
* Fix two i18n issues
* Fix some filter hints
2019-03-23 11:08:07 -05:00
netniV 49cb30e5b0 Resolving issue #2532
Ensure Graph ListView table is displayed in line with Management -> Graphs
2019-03-18 14:16:43 +00:00
cigamit e662582ab5 Resolving Issue #2463
Zombie data sources without graphs
2019-03-12 22:21:19 -05:00
cigamit cd14f260dd Resolving Issues #599 and #2365
This is a major bug fix to Aggregate.  Also found a bug in rrdtool that
we will have to work around.
The upside of the bug fix for #2365 is that it appears to have fixed
#599 and also an issue with legend alignment.  Legends should always
align nicely now.
2019-02-01 18:22:28 -06:00
cigamit 1f8f8898dc Resolving Issue #2365 and multipl Aggregate issues
- Graphs included in aggregate that are removed are not managed properly
- The associate and disassociate functions were not following proper API
rules, they were leveraging request variables and redirecting using
header().
- Aggregate was not properly handling nth percentile.  It's now handling
that correctly, though still has an issue with the actual value.  This
will be fixed separately.
- Adding new convert to stacked line options for graph readability
- Totalling when using Print showing legend items was also showing graph
items, which is not correct.
- When totalling, Aggregate was attempting to show a blank line, but due
to an SQL format error, no blank line was displayed.
- Typo in one aggregate function was not properly handling the GPRINT
MIN graph item type
2019-01-31 07:39:09 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit e1dad073ba Properly display "No XXX Found" rows 2019-01-12 09:48:29 -06:00
cigamit be2bcb5cb5 When going to the graphs.php page, SQL errors can occur 2019-01-10 17:30:39 -06:00
cigamit 80c2a88fb2 Resolving Issues #2213, #2214, #2215 and Additional
Multiple XSS vectors associated with un-escaped strings.  Introduce new
function, audit all calls, remove inline styles for classes, some i18n
missed.
2018-12-16 09:54:11 -06:00
cigamit 27f6882d7b One additonal fixup for Orphan detection 2018-11-22 12:13:34 -06:00
cigamit 543a2e3f47 Resolving Issue #2173
The orphan identification issue is not resolved at both the Graphs and
Data Sources level.
2018-11-21 14:10:02 -06:00