Commit Graph
205 Commits
Author SHA1 Message Date
TheWitness 29bede5fe5 Fixing issue # 4587 - Settings performance
This change will cause a caching of items to reduce various page times.  That is the expectation
2022-02-28 21:11:19 -05:00
netniV 40ec4d8c39 QA: Fix display of DB error messages 2022-02-19 22:50:55 +00:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 110ddb8647 More robust resolution to #4403
This solution should address all the current oddball timezones.
2021-09-19 16:00:20 -04:00
TheWitness 29a21899b6 partial resolution to #4403 timezone detectinon
This is only a partial fix in that the PHP zone support does not provide a good body of GMT option including the 30 and 45 minute past types.
2021-09-19 15:29:27 -04:00
TheWitness a031c5b20a Fixing #4283 - CSS Alternate support to include worker-src
Cacti Plugin Authors need to extend $alternates support to include 'worker-src' for services like Google Map API on newer browsers
2021-06-25 15:46:58 -04:00
TheWitness 82004e1261 Change logic so that remote data collectors properly accumulate data #4215 2021-04-11 20:43:51 -04:00
TheWitness c21d0ba91b Final resolution to #4215
This change modifies logic slightly as follows:

1) Retry only twice for a connection (speed up the GUI in offline mode)
2) Don't update resource cache when in offline or recovery, you could downgrade yourself
3) Don't flush_boost() function if you are not a remote data collector
4) Better logging for automation to indicate offline or remote
2021-04-11 20:04:58 -04:00
TheWitness ba4e34beda Fixing Recovery mode which was broken in the 1.2.x branch 2021-03-18 21:07:39 -04:00
TheWitness 713e1ff9e4 Fixing Issue #4162
Cacti has weakness when running in fault tolerant environments
2021-03-09 16:51:45 -05:00
TheWitness 84bfcead0d Improve Issue #3945 based on feedback
- Graph CSV export NaN with wrong date range if browser timezone is different with web server
- This will ensure that the times in the browser match the backend too.
2021-01-06 13:34:19 -05:00
TheWitness c6e889addf Fixing issue #4036
Issue after last commit
2021-01-06 13:24:59 -05:00
TheWitness bf292d5d57 Additional update on #4035
This is based upon recommendations. to pre-sanitize the referer always and we don't want to double sanitize.
2021-01-06 12:15:22 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 78905b1d7d Fixing issue #4002
* Poller Recovery is not predictable
* The checking for recovery needs to come earlier in the call stack to for the logic below it to be reliable
* Fixing some alignment of variables for readability
2020-12-19 12:31:26 -05:00
TheWitness a37dbfabda Minor tweak to CSP for Issue #3808
Add image source extensions
2020-09-17 08:48:53 -04:00
TheWitness 6fe7d8d41e Fixing Issue #3808 - Alternate Sources for CSP
Allow Users to Specify Alternate Sources for Content-Security Policy
2020-09-16 19:32:31 -04:00
TheWitness aa97332b1d Fixing Issue #3639 and #3635
- Backtrace Errors attempting to run AUTOM8 to Remote Data Collector
- Duplicate Entry error when updating Device
- This missed a new option to limit device sync to single, or multiple hosts
2020-06-27 12:12:29 -04:00
TheWitness dd580967ec Undo hack related to issue #3526
Can no longer login.  This issue like exacorbated by a vain attempt to implement same-site cookies before they were officially supported in PHP 7.3.
2020-05-22 17:34:52 -04:00
TheWitness dd6c20c250 Fixing Issue #3452
New Content-Security-Policy prevents External Links from Operating
2020-04-10 11:04:32 -04:00
TheWitness abaef8fa7b More testing resulting from #3402 and possible solution to #3400
* Revised 'Content-Security-Policy' tested on FF, Chrome, Edge, Opera and no issues found.
* Adding the Multiselect Filter as it's critical for some initial page loads like the Graphs page for Templates which include the 'Search' functionality.
2020-04-05 14:51:09 -04:00
TheWitness ad2e833950 Additional testing on #3402
On a few pages, these JavaScript elements become crucial
The no-cache does not actually mean 'no-cache'.
2020-04-04 10:42:48 -04:00
TheWitness ced9f430f4 Partial resolution to low lighthouse score for performance #3402
* Cacti scores low on performance audit on lighthouse audit
* This change enables generic caching of pages, but with a very short age for RRDtool generated graphics.
* It increses the SEO score through the use of specialty tags on anchors leveraging the _blank target attribute value
* It removes and unnecessary tooltip on the document element

There may be additional changes forthcoming.  However, these changes raised the score from 0 to the mid twenties.

Some of the changes, like minification of JavaScript we do not do due to the nature of the project, but could be done by customers.  Once the page is first rendered, it's in the browsers memory and cached for a good time, so this is not a big deal.
2020-04-04 09:09:58 -04:00
TheWitness d65f40d2bf Abstract Cacti session handler 2020-03-29 19:08:29 -04:00
TheWitness 6a2d781778 Fixing Issue #3374 Cacti Cookie Domain
* Allow Setting of Cookie 'Cacti' domain edition
* This also allows the Cacti administrator to extend the content security policy to include unsafe-eval for scripts.
2020-03-24 19:12:48 -04:00
TheWitness f8b9483094 Minor update for PHP7 compatability
Was not working in PHP7.3 for sure.  The SameSite option was being rejected.
2020-03-22 10:31:08 -04:00
TheWitness 68831cd01e Fixing #1566
Need to change to $config due to old PHP5.
2020-03-21 14:53:17 -04:00
TheWitness 265ebc27ea Fixing Issue #1566
* Add SameSite support for cookies
* Add some light formatting for readability
2020-03-21 14:40:17 -04:00
TheWitness bb3fcabdd1 Fixing Issue #3349
Variable max_input_vars is read only.  Attempting to change it adds no value
2020-03-16 18:49:21 -04:00
TheWitness 107bfecebf Fixing Issue #3342
CSRF at Admin Email
2020-03-12 18:56:29 -04:00
TheWitness 4f0ef757c1 Fixing Issue #3336
Plugins such as mapping plugins need to relax content security policies
2020-03-09 22:12:54 -04:00
TheWitness 435bfdebce Add lib/poller.php to global include
This will reduce the likelihood of issues with various plugins.
2020-02-23 13:41:13 -05:00
netniV 3f836d97b8 Upgrade can stall when checking permissions on csrf-secret.php
Major mods to the CSRF library (which have been submitted upstream but as there's been no activity for a year,
may not get merged)

    - Installer now correctly only checks permissions if csrf-secret is set.

    - Created new csrf include to make configuration process easier to identify

    - Logging can be enabled now for CSRF to debug it
2020-02-23 02:48:43 +00:00
netniV f3f6115004 Improve program path detection by using system path and PHP_BINDIR
Closes #3184
2020-01-20 13:14:53 +00:00
TheWitness 56a04c612f Fixing Issue #3195
Add Full Content-Security-Policy to the global header.
2020-01-19 09:41:27 -05:00
cigamit 06b606b8d3 Resolving Issue #3142
* Chrome sets graphs tree navigation view to width 0px
* Also correct issues with CSP migration
2020-01-17 18:33:47 -06:00
netniV 1a61e1f0ef Fix issues when config.php is unreadable
This commit adds a notice when configphp is present but unreadable.  It also adds the ability to display any database connection errors that occur within db_connect_real for diagnostic purposes.  These notices are only presented to the end user when the appropriate flag is set as most users do not need them.

Closes #3181 and closes #3182
2020-01-12 12:22:15 +00:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 0382b5b35a Relative to #3067, redirect must come sooner
This way the cookie does not set sent insecurely.
2019-11-09 10:27:54 -06:00
cigamit 591da66827 Resolving Issue #3066
This was merged into develop, but due to it being security related, we will include it in the 1.2.8
2019-11-09 08:54:23 -06:00
netniV ef271a16ef When URL_PATH is blank, it should assume that it is '/'
Closes #2908
2019-08-22 11:30:47 +00:00
cigamit 24145c5e53 Resolving Issue #2878
PHP 7.4 Function get_magic_quotes_gpc() is deprecated
2019-08-11 13:39:45 -05:00
netniV e95eb61cef When testing remote poller connections during install, undefined variable warning can occur
Closes #2860
2019-08-01 12:45:02 +00:00
netniV 900c747ffa Further resolve #2638 2019-04-28 18:57:20 +00:00
Matthew Horan 59b58671aa Support disabling PHP SNMP extension (#2638)
Re-purpose the existing php_snmp_support config value to allow
administrators to disable the built-in SNMP extension.

It can be desirable to force use of the Net-SNMP in some configurations,
particularly when IPv6 is in use. This allows the administrator to set
$php_snmp_support = false in config.php, which will then force use of
the Net-SNMP binaries tools.
2019-04-23 07:58:40 +06:00
netniV 6c7b2ab95e Missing configuration defaults prevent installations/upgrades without showing reason
Closes #2555
2019-03-23 11:04:57 +00:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
netniV 89f0a06216 Resolving issue #2304 and #2311
This commit corrects a previous unseen issue where the PHP environment at command line level is being populated with environment variables normally only seen when called from a web server.

issue#2304: Installation progress stays at 0%
issue#2311: Unable to update PHP location during installation due to incorrect CLI environment

The new check uses the php_sapi_name() function to verify that we are indeed at 'cli' level.  All other values returned by php_sapi_name are considered non-cli including 'cli-server' which is for client/server scenarios.

Most checks have now been replaced by a single defintion ('CACTI_CLI') to define whether in CLI mode.  If a script is only to be called from CLI it must either defined 'CACTI_CLI_ONLY' or include include/cli_check.php instead of include/global.php.
2019-01-15 13:57:50 +00:00
netniV 27e7674f7b Remove and reset BETA versioning number 2019-01-03 02:10:03 +00:00
cigamit 5c8ebf0a6a Preparing Beta4 2018-11-26 05:48:31 -06:00