Commit Graph
4465 Commits
Author SHA1 Message Date
TheWitness 105a4cb47d Fixing #4705 and #4719 - Remember me and Zone Cookies
- Browsers to begin rejecting CactiTimeZone and CactiDateTime cookies due to SameSite Requirements
- Remember me not working after upgrade to 1.2.20 from 1.2.19
2022-04-14 08:24:26 -04:00
TheWitness f6306f427b Fixing Issue #4687 - Poller Output Table Not Empty
Poller output not empty all the time
2022-04-13 21:09:56 -04:00
netniV 82d475ef48 Re-correct dependancy search 2022-04-13 13:12:33 +00:00
TheWitness 7c45b6654f PHP-Doc Updates and rename two variables 2022-04-12 18:53:50 -04:00
Petr MacekandTheWitness 7b8726cf1d fix few login issues (missing/wrong messages) (#4703)
* fix few login issues (missing/wrong messages)

* Minor update

* Minor edits

* Update auth.php

Co-authored-by: TheWitness <thewitness@cacti.net>
2022-04-12 18:29:55 -04:00
Petr MacekandTheWitness 26bbbf965a fix incorrect message about remote poller when device saving (#4702)
* fix incorrect message about remote poller when device saving

* Slight modification to correct logic

Co-authored-by: TheWitness <thewitness@cacti.net>
2022-04-12 18:07:34 -04:00
TheWitness f70ee121a7 Fixing Issue #4685 and reverting #4695
The packages included in this commit should fix all the issues encountered from the release.
It also reverted #4695 that reserved the order of array_search() by accident.
2022-04-12 09:04:05 -04:00
Jing Chen e20a7136c3 Fixed: wrong usages about $ignorable_type_code_hashes during import package (#4695) 2022-04-11 11:11:15 +01:00
Petr MacekandTheWitness 12627b34f5 fix undefined variable $font_file (#4684)
* fix undefined variable $font_file

* update

Co-authored-by: TheWitness <thewitness@cacti.net>
2022-04-09 14:41:15 -04:00
Jing ChenandTheWitness 328e2d9bc1 Fix two syntax error for PHP 5.4 (#4688)
* Fix two syntax error for PHP 5.4

* Update CHANGELOG for PR#4688, and remove a duplicate item

* Update CHANGELOG

Co-authored-by: TheWitness <thewitness@cacti.net>
2022-04-09 14:39:14 -04:00
netniV 8c2a6c3c7d When adding device, errors may be reported whilst updating templates (#4683) 2022-04-06 19:24:46 +00:00
TheWitness 14b10a0c63 Update Cacti i18n base file and correcting on typo found during QA (#4662) 2022-04-02 17:54:14 +01:00
TheWitness 0b54ab0973 Fixing Issue #4659 - Moving device onto or from a down poller issues (#4661) 2022-04-02 14:08:43 +01:00
TheWitness 2cf0848a91 Fixing the Automation Issue #4649 (#4653) 2022-03-29 14:05:21 +01:00
TheWitness 02602d0455 Fixing Issue #4645 (#4646) 2022-03-28 15:48:32 +01:00
TheWitness d28f948aef Another fix to #4618
The strpos() function will return the position of the first instance of a string which in PHP is 0.  So, you have to check for "false" insted.  Also, switching to non-case sensitive search for good measure.
2022-03-21 07:07:53 -04:00
TheWitness 58dda2ca03 Fixing Issue #4637 - FontAwesome MultiSelect
Have Cacti's MultiSelect CheckAll and UnCheckAll use Font-Awesome
2022-03-20 15:21:43 -04:00
TheWitness 84a9ecfef2 Fixing Issue #4636 Latest jQueryMultiselect
jQueryMulti-select 3.0.1 includes i18n upgrade to it
2022-03-19 16:16:04 -04:00
TheWitness e22df02e3a Fixing Issue #4630 - Session restart issues
Session decode errors appearing in Cacti log periodically
2022-03-16 18:17:20 -04:00
TheWitness d382e9b672 Fixing Issue #4629 - poller overruns
When removing large numbers of Graphs and Data Sources you can get poller overruns
2022-03-16 18:09:33 -04:00
TheWitness f9f60e9e84 Fixing Issue #4549 - boost debug issues
Invalid path for Boost logging stops Boost update process without notification
2022-03-15 21:27:43 -04:00
TheWitness 76e095be1b QA: Auto-disable from error too severe 2022-03-15 20:49:13 -04:00
TheWitness 786c0693b5 Fixing Issue #4620 - Remote CLI Issues
- Remote Data Collector CLI scripts connect to the local database instead of the main database even when online
- Add PHP Doc style documentation to lib/database.php
- Add missing $log and $db_conn to one function
2022-03-15 17:36:32 -04:00
TheWitness a777a75080 QA: Unable to install plugins due to replicate issues 2022-03-14 10:21:19 -04:00
TheWitness 91e3220fd8 Fixing Issue #4618 - Max runtime disable plugin
Plugins automatically disabled on cacti release when they exceed their maximum allowed runtime
2022-03-14 08:58:32 -04:00
TheWitness bcddab8447 QA: Per comments on #4614
- Relocating the $plugin parameter to the end
- Adding a warning if someone is using it externally
2022-03-14 08:38:21 -04:00
TheWitness b561568852 Fixing Issue #4617
Dropping remote tables not supported in plugin API
2022-03-13 19:43:01 -04:00
TheWitness 5b49db4586 Fixing Iseue #4616 - Plugin Replication Issues
- When performing plugin actions from the Cacti UI, replication should be forced to Remote Collectors
- max_packet was not being calculated correctly.
- Cacti log function logging on verbosity NONE
2022-03-13 19:32:01 -04:00
TheWitness 107227a263 Don't cache in config_local.php 2022-03-13 17:43:25 -04:00
TheWitness 60baee04d9 Removing obsolete poller_command_args hook check 2022-03-13 16:18:01 -04:00
TheWitness 3ac42ebe46 Fixing Issue #4614
- Cacti can not differentiate between execution remotely between the main poller loop vs. poller bottom
- Also QA including, better logging
- One Hooks in wrong section 'cacti_stats_update'
- I've noticed two hooks that are no longer in Cacti.  Need to see when they were removed 'poller_output' and 'poller_command_args'.
2022-03-13 16:14:09 -04:00
TheWitness a5b94c2183 Fixing Issue #4613 - Replicate Out Issues
Cacti replication can not correct table structure changes in newer versions of MySQL/MariaDB
2022-03-13 16:00:55 -04:00
Jing Chen 7d48258e1f Use OS provided DejaVu font for RHEL/CentOS/SLES/Ubuntu(PR#4594) (#4594) 2022-03-12 13:16:58 -05:00
TheWitness 3829317c8b Fixing Issue #4612 - SameSite Secure Issue
Cacti's cacti_remembers Cookie does not include the secure attribute required for Same Site support
2022-03-12 13:12:07 -05:00
TheWitness b327a329cb Fixing Issue #4611 - Replicate Out Hook Defective
- Cacti's current replicate_out hook is insufficient for plugin use
- Additionally, correct issues with the current replication function to handle two exceptional case
- PHP Doc Format for several, but not all functions
- Remove a function and hook that do nothing
2022-03-12 11:13:01 -05:00
TheWitness 5619a17fb9 Fixing Issue #4610 - Hide Disabled Issues
The end user setting Hide Disabled Devices does not appear to be 100% functional
2022-03-11 16:40:51 -05:00
TheWitness a8dce7beb5 QA: Audit of set_config_option()
If you change your default login method, it is not replicated to the data collectors
2022-03-11 12:12:08 -05:00
TheWitness 96352c87bd Fixing Issue #4597 - Select Device Debug Remotes
Selective Device Debug does not work with Remote Data Collectors
2022-03-11 11:59:14 -05:00
TheWitness ae854665f9 Fixing Issue #4607 - Replicate in config.php
Cacti's config.php file is improperly moved into the resource cache
2022-03-11 11:17:33 -05:00
TheWitness 6702241373 QA: One more missed DSTRACE log messages 2022-03-10 19:29:34 -05:00
TheWitness 97af6943b0 QA: Missed 'DSTRACE' log type attribute 2022-03-10 19:24:33 -05:00
TheWitness 84b4ca9e9f Additional QA on $4551 2022-03-10 17:22:19 -05:00
TheWitness cbe82ca4b2 Fixing Issue #4602 - undefined function get_guest_account
Had to move these two functions back to lib/functions.php due to the loading order.  No way to get around it.
2022-03-10 08:30:56 -05:00
TheWitness da4b7ba0f8 Second attempt at #4598 - Offline Tabs 2022-03-10 08:01:40 -05:00
TheWitness 335575c5a4 Fixing Issue #4598 - Remote Tab Visibility
Plugin tab does not stay visible when main poller is offline
2022-03-09 21:09:25 -05:00
TheWitness 0e07d2d677 The correct fix was to shorten the name 2022-03-02 19:53:20 -05:00
TheWitness 5cac1596e8 QA: Allow hyphens in Device Package Name 2022-03-02 19:31:52 -05:00
TheWitness 04e10221fc QA: Import Issue #4570
Import giving errors on hash
2022-03-02 18:48:07 -05:00
TheWitness 15fe88aacf Audit of general log finds more variables #4587
These additional variables turned up in overnight polling of the system.  Some are general, many are for polling primarily.
2022-03-02 17:22:33 -05:00
TheWitness 06a2d429d2 Fixing Issue #4593 - Auth Tokens don't use realm
Cacti 'remember-me' does not work with identical usernames from different realms
2022-03-02 17:15:55 -05:00