Commit Graph
127 Commits
Author SHA1 Message Date
netniV 82d475ef48 Re-correct dependancy search 2022-04-13 13:12:33 +00:00
TheWitness f70ee121a7 Fixing Issue #4685 and reverting #4695
The packages included in this commit should fix all the issues encountered from the release.
It also reverted #4695 that reserved the order of array_search() by accident.
2022-04-12 09:04:05 -04:00
Jing Chen e20a7136c3 Fixed: wrong usages about $ignorable_type_code_hashes during import package (#4695) 2022-04-11 11:11:15 +01:00
TheWitness 84b4ca9e9f Additional QA on $4551 2022-03-10 17:22:19 -05:00
TheWitness 04e10221fc QA: Import Issue #4570
Import giving errors on hash
2022-03-02 18:48:07 -05:00
TheWitness 3a30fad7fb QA: Fixing issue #4582
This is caused by removal of Caching API
2022-02-28 19:33:17 -05:00
TheWitness df42b81c9b Minor change to undo shorthand logic 2022-02-13 09:56:18 -05:00
TheWitness 31928420c7 Fixing Issue #4551 - PHP 8.1 Deprecation Errors
Thanks for this one.  See if you can find more.  Let me know that these are fixed too of course.
2022-02-12 16:48:45 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
05198029e6 Fix#4289: Display color style instead of color_id or blank for new coloer. (#4416)
* Fix#4289: Display color style instead of color_id or blank for new coloer.
          Remove html_escape for import->result->differences display to avoid double escape

* Fixed: Update CHANGELOG for #4289

* Fomatting

* Formatting

Co-authored-by: Jing Chen <jingchen@cn.ibm.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2021-10-08 09:02:02 -04:00
TheWitness 5a1de9efdf Fixing Issue #4409 - Test Data Sources Optional
* When creating a Graph, make testing the Data Sources optional by Template
* Release preparation steps
2021-09-25 14:13:40 -04:00
TheWitness 7efe8c5a37 Fixing Issue #4378 - Unmet dependencies warnings
* Legacy Template importation with invalid 'snmp_port' hashes lead to unmet dependency warnings
* Also minor double to single quote changes in code.
2021-09-25 10:44:46 -04:00
TheWitness f314dbe3a9 Regression on import
This change was between 1.2.16 and 1.2.17 so no  CHANGELOG entry.
2021-02-20 12:57:59 -05:00
TheWitness ffffc13aa1 Fixing Issue #4131
A design flaw makes importing new Graph Template slow on large systems
2021-02-16 20:47:25 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 862538860a Fixing Issue #4008
PHP8 support: Debian test suites shows lots of PHP Errors and Warnings with PHP8
2020-12-12 17:28:03 -05:00
TheWitness b953148af1 Second attempt at issue #3871
This should fix the remainder of the issues.
2020-10-19 13:06:25 -04:00
TheWitness f7f6ee4b21 Fixing Issue #3871
Import DataQuery show PHP Error: ERROR PHP NOTICE: Undefined index: fname
2020-10-19 12:58:04 -04:00
netniV 39458efcd5 Improper escaping of error message leads to XSS during template import preview (#3723)
Closes #3723
2020-07-26 23:40:44 +00:00
TheWitness 20a1b07342 Fixing Issue #3596
When importing template, resources aren't checked properly
2020-06-13 10:08:44 -04:00
TheWitness 80ec47b08a Issue #3549
Several XSS Vulnerabilities
2020-06-13 09:43:27 -04:00
TheWitness 030506b820 Missing closing the package file if it is not readable 2020-04-09 20:33:08 -04:00
TheWitness 75580b386e Fixing Issue #3313
Installing cacti 1.2.10 in debian and ubuntu stopped at 41%
2020-03-21 13:26:42 -04:00
TheWitness 9d38ca43cb Fixing Issue #3348
Remove Orphans and Sync Graphs not working as expected
2020-03-15 15:43:53 -04:00
cigamit 47408aafcb Improve import warnings
Prior patch did not work as expected.  This makes the import more sensible.
2020-02-02 09:55:34 -06:00
cigamit 72279f131c Minor change for issue #3225
* Unable to Import Templates in Cacti 1.2.9+
* This change address another instance found of an snmp_port being added to a data input method.
2020-02-01 12:18:09 -06:00
cigamit b71ec3dc11 Resolving Issue #3225
Unable to Import Templates in Cacti 1.2.9+
2020-02-01 09:38:43 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 33ed3079bb Partial resolution to issue #3164
* Array and string offset access syntax with curly braces is deprecated in php 7.4
* As mentioned by @netniv, this will be a 1.3 project, but resolving what was identified in the mean tiem.
* I have verified that multiple plugins are also impacted by this change.
2020-01-08 07:33:36 -06:00
cigamit ba21617bb7 Resolving Issue #2712
The hard code of set memory_limit need to be removed
2019-05-30 07:51:12 -05:00
cigamit 07ad04c576 Resolving Issue #2578
Import package will not write a file if it's new
2019-03-27 20:30:15 -05:00
cigamit c24ff59446 Allow compare to function properly
When importing a pre 1.2.3 template, don't confuse the users with warnings about the compare failing.
2019-03-26 18:42:34 -05:00
cigamit 65e777fc18 Resolving Issue #2527
Package installation can fail if the Cacti hash version code is ahead of installed Cacti
2019-03-16 10:38:43 -05:00
cigamit 64a7c81ca1 Bug in system test on issue #2502
Need to use version compare
Unable to have a min or max value for RRDfile at zero '0'
2019-03-11 07:27:52 -05:00
cigamit 0964412f19 Resolving Issue #2502
Unable to have a min or max value for RRDfile at zero '0'
2019-03-10 10:17:21 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 7cb00f6e96 Resolving Issue #2240
SNMP system Data Input Methods should not be modified on import
2018-12-29 10:46:42 -06:00
cigamit db96c65335 Missing raise message in a few import areas 2018-12-23 14:37:35 -06:00
cigamit a3a0fb6926 Resolving Issue #2223
[1.2.0 Beta 4] : fakepath for import
2018-12-23 14:24:56 -06:00
netniV 451476031f Resolving issue #2103 2018-10-27 07:53:09 +00:00
cigamit 76ae351222 Resolving Issue #1936
[1.2.0] Upgrade fails to import templates properly
2018-09-25 18:11:58 -05:00
Mark Brugnoli-Vinten 39efc75c49 Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939 (#1937)
* Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939

* Update import.php
2018-09-16 13:22:32 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 22d9444c31 Allow Import/Export to be hookable 2018-09-08 13:32:11 -05:00
Tom Yearke efc6b83466 Import: Fixed handling of references to objects not included in file (#1796)
* Import: Fixed handling of references to objects not included in file

When exporting an object with the "Include Dependencies" option disabled and then importing the resulting file, the import process will not complete successfully. This is because the mapping of object hashes to object IDs only tracks objects that have been included in the file.

This commit resolves the issue by first loading the mapping with all existing hashes and IDs before processing the file's objects. This results in the expected behavior when a referenced object is not in the file but is already loaded into the Cacti installation.

* Revised #1787 based on review from @cigamit

- Removed unnecessary double quotes
- Encapsulated `foreach` on possibly-empty array with size check
- Added whitespace

* Updated CHANGELOG to include #1796
2018-08-06 07:43:18 -05:00
cigamit d532a25723 Don't issue warning if zlib can not be changed. 2018-06-02 19:34:26 -05:00
cigamit bc9448b133 Resolving Issue #1559
CLI Output Issues due to over escaping
2018-04-21 18:35:19 -05:00
cigamit f59e60f9e5 Ensure compression levels are consistent
The import package function will fail when the web server has
compression enabled
2018-02-11 06:55:30 -06:00
cigamit 7199064681 Resolving Issue #1244
Errors importing templates with deprecated hashes
2018-02-11 06:55:29 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00