admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-11-09 14:02:54 +09:00
Code Issues Packages Projects Releases Wiki Activity
12,382 Commits 81 Branches 85 Tags
fddd136a382a280f3c8555275ae2d4eb33698564
Commit Graph
152 Commits
Author SHA1 Message Date
TheWitness 97af6943b0 QA: Missed 'DSTRACE' log type attribute 2022-03-10 19:24:33 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness 80948a9834 Fixing Issue #4522 - New Graphs Header Issues 
* When Creating New Graphs some visible 'Custom Input' values lack a table header
* Also did some cleanup on the custom input functions for consistency.
 2022-01-03 12:53:37 -05:00
TheWitness 586628f88c Additional boundary check on #4509 
This one ensures that you have a valid Graph Template  with Graph Template items before you attempt to instantiate graphs
 2021-12-21 17:26:03 -05:00
TheWitness 902afe5548 Additional QA on #4509 - Graph Template Edit 2021-12-21 09:01:56 -05:00
TheWitness 562a0e2aea QA on #4509 - Missed one variable removal 2021-12-21 08:03:52 -05:00
TheWitness af4911fc5b Fixing Issue #4509 - Slow Template Editing 
* Graph Templating is quite slow on very large systems
* Update ChangLog for #4500 and #4495 as well
 2021-12-20 22:08:16 -05:00
TheWitness e4ef0b52ab Correct Mistake ARound #4480 
* The host_id is a special case where it should not be check, but it also should should continue to be read only/disabled.  Other host level type codes should be able to be changed at the data source level.
* Change also includes light PSR to remove shortcut syntax when mixed with SQL.
 2021-12-19 17:59:10 -05:00
TheWitness 3233c78896 Fix Second Syntax Error Related to #4480 
This case should never happen, but just to be safe.
 2021-12-10 13:25:30 -05:00
TheWitness 9bdad24ce0 Fix Syntax Error Related to #4480 2021-12-10 11:04:21 -05:00
Petr Macek 6187babad3 fix prepared sql command (#4497) 2021-12-09 08:59:52 -05:00
TheWitness a5d2587da1 Additional QA on #4363 
In this commit I moved the repair into the repair_database.php script as well as added a new option for a Quick Sync which will only focus on Graph's that have a differing number of Graph Items from the Template.
 2021-11-30 16:26:53 -05:00
TheWitness c57f8a7c00 QA on Issue #4480 
Broke this in the first commit
 2021-11-28 14:06:18 -05:00
TheWitness 708fda9995 Fixing Issue #4363 - Duplicate Graph Template Item Bug 
Duplicate entries in graph_templates_item - mabye an aftermath of the template edit bug
 2021-11-28 13:53:44 -05:00
TheWitness 6c9efff4c3 Another minor tweak to #4480 2021-11-27 15:44:29 -05:00
TheWitness 8d7fb340c6 More updates around issue #4480 
Many special type codes can be over wrote in the template, there are a few that should not.  Open those type codes slightly so that they can be over wrote.
 2021-11-27 14:32:08 -05:00
TheWitness 5eee1a5760 Fixing #4480 - Avoid Breaking Data Sources 
Saving a Data Template can damage Data Sources if the Data Template is not constructed properly

This is the first of two commit's on this bug.  The second commit will provide a repair during upgrade.
 2021-11-27 10:11:29 -05:00
TheWitness c129d865aa Fixing #4437 & #4438 Cache and Spinner 
* Graph Template Cache is nullified too often when Graph Automation is running
* When Adding a Data Query to a Device, no Progress Spinner is shown
 2021-10-21 19:51:14 -04:00
TheWitness 33506cd2c0 Fixing Issue #4352 Undefined Indexes 
Second attempt after testing
 2021-09-14 20:53:35 -04:00
TheWitness 4028c85e5e Fixing Issue #4352 Undefined Indexes 
Undefined indexes experienced when attempting to create graph from template
 2021-09-14 20:44:55 -04:00
netniV 06e46f4d6b Fix display message on data query graph add failure 2021-06-27 19:13:06 +00:00
netniV c5c088d2d1 Further fix of test_data_source() [#4250] 2021-06-11 20:05:00 +00:00
TheWitness f1272b046b Minor wording change to save space 2021-04-10 10:56:40 -04:00
TheWitness 6bbcb538a6 More fixes around issue #645 - Test Data Source 
This change allows for testing of data source from the Graphs New page to reduce the likelihood of graphs being created that will never be rendered
 2021-04-02 18:36:16 -04:00
TheWitness 75c147b704 Fixing Issue #4187 - Navigating from Graph to Data Source 
This fixes issue #4187 and also a bug recently introduced where creating an Graph from Graphs new would not properly accept 'overriden' values.
 2021-03-21 12:24:22 -04:00
TheWitness 4739ad5969 Fixing Issue #4175 
- Syncing Templates can results in False 'Damaged Graph' notification on Graph Management page
- Also corrects a few spurious errors when working with orphans and Change Template
 2021-03-17 23:11:55 -04:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
ddb4githubandTheWitness 85ba8f4e2e More fixing about #2704 for Graph Preview-->Filter-->Template (#3924) 
* Fixed: More fixing about #2704 for GraphPreview-->Filter-->Template, mark timestamp 'cache last changed' after new graph created.

* Update CHANGELOG for #3924

Co-authored-by: TheWitness <thewitness@cacti.net>
 2020-11-20 08:42:20 -05:00
ddb4github b437321c4f Fixed #3563: Correct errors due to orphan column (#3709) 
* Fixed #3563: lots of "Error: Duplicate column name 'orphan'" from parallel process 'poller_reindex_hosts.php':
 - Add column 'orphan' during 1.2.13 upgrade
 - Remove function 'add_orphan_support'

* Fixed#3563: change upgrade script from 1.2.13 to 1.2.14

* Fixed#3563: change upgrade script from 1.2.13 to 1.2.14

* Fixed#3563: add new column into cacti.sql and audit_schema.sql
 2020-08-02 22:18:49 +01:00
TheWitness aadc855395 Fixing Issue #3574 
Saving Graph Template Items take a long time on large systems
 2020-05-24 10:41:17 -04:00
TheWitness 65aa1cbcf7 Additional Fixes To #3563 
Current orphan handling disrupts graphing transient indexes
 2020-05-20 23:12:40 -04:00
TheWitness dc35a79b15 More fixing for issue #3549 
Several XSS Vulnerabilities
 2020-05-20 22:46:36 -04:00
TheWitness 9d38ca43cb Fixing Issue #3348 
Remove Orphans and Sync Graphs not working as expected
 2020-03-15 15:43:53 -04:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 8872d5c710 Resolving Issue #2761 
* Table does not exist
* Some minor formatting too.
 2019-06-25 06:13:13 -05:00
cigamit fdb2bc50a4 Resolving Issue #2719 
Empty graphs being created automatically but we can't delete them
 2019-06-22 13:20:56 -05:00
cigamit f7cfca22f0 Resolve Issue #2364 
Resolving this by making a special case for Traffic stats to allow not
duplicating the data source.  All other cases, there will be
duplication.

Additionally, opening a feature request to handle if the data source
should be duplicated as the current UI permit's this bad behavior.
 2019-02-10 08:13:56 -06:00
cigamit 4f3383ae7e Additional QA Around #2355 and 2372 
Found a few more issues and correct.  This should completely resolve
these two issues.
 2019-02-09 10:54:06 -06:00
cigamit 904e2baf92 Improve trace logging 2019-01-30 07:56:22 -06:00
cigamit 4722db1e37 Minor change to #2355 
Should use cacti_sizeof() function here.
 2019-01-30 07:35:53 -06:00
cigamit 6f7c82fd02 Resolving Issue #2355 
- Duplicated Data Sources created when Custom Data is specified
- Additionally adding a trace option to trace Data Source creation flow
 2019-01-29 18:52:06 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
cigamit 9b1aa6a6a7 Resolve call to undefinedd function reported by user 2018-12-27 20:48:57 -06:00
cigamit fbdbcaef29 Resolving Issue #2042 and #1981 
This should fix the issues.  Consolidated logic here as well as the
graph and data source suggested names were using different code paths
 2018-10-10 03:32:59 -05:00
cigamit 3731477fb3 Another crack at issue #1921 
Just adding some doco and some safer checks.
 2018-10-09 07:19:33 -05:00
cigamit a660af58b7 Correct two re-index and graph create issues 
- Don't clear indexes for old data sources
- Don't duplicated a data source unless you have to
 2018-10-07 20:16:17 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922) 
* Resolving issue #1920

* Minor QA issue
 2018-09-14 20:59:52 -05:00
cigamit 9cdd347e58 Moving some functions into api calls 
This will help resolve and issue that was raised during the resolution
of issue #948.
 2018-08-20 19:06:06 -05:00
cigamit d800ac2595 Resolving Issue #948 
Every time when creating new graph Cacti creates new datasource
 2018-08-19 20:57:22 -05:00
cigamit 0cc7ae91a0 Minor format change in lib/template.php 2018-06-09 12:08:33 -05:00