admin/cacti
1
0 Fork 0
mirror of https://github.com/Cacti/cacti.git synced 2026-11-09 14:02:54 +09:00
Code Issues Packages Projects Releases Wiki Activity
12,382 Commits 81 Branches 85 Tags
fddd136a382a280f3c8555275ae2d4eb33698564
Commit Graph
266 Commits
Author SHA1 Message Date
TheWitness 0b54ab0973 Fixing Issue #4659 - Moving device onto or from a down poller issues (#4661) 2022-04-02 14:08:43 +01:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
TheWitness f10e92bec3 Fixing Issue #4508 - Changing Device Settings not Update Poller Items 
Changing SNMP settings on a bunch of device via 'choose an action' is not applied
 2022-02-05 13:09:23 -05:00
TheWitness e4ef0b52ab Correct Mistake ARound #4480 
* The host_id is a special case where it should not be check, but it also should should continue to be read only/disabled.  Other host level type codes should be able to be changed at the data source level.
* Change also includes light PSR to remove shortcut syntax when mixed with SQL.
 2021-12-19 17:59:10 -05:00
TheWitness 5063efaa52 Minor wording update on #4426 - Database tuning 2021-10-18 21:02:23 -04:00
TheWitness 4e200ffcc2 Correct one spelling error 2021-10-16 14:33:59 -04:00
TheWitness e6a9704c3e Fixing Issue #4426 
MariaDB recommendations need some tuning for recent updates
 2021-10-16 14:32:21 -04:00
TheWitness b22dff2e9d Fixing Issues #645 - Check Data Sources before Graph Create 
So, this is not 100% finished yet as it does not currently work with the Remote Agent.  However needed some testers.
This change also deprecates Script Server calls being called without the proc_open() command which was a requirement from the early 2000's for a PHP version I don't even remember.
The change also improves logging when creating graphs via automation.
Lastly, marking #3572 as resolved as it was resolved in another fix over the weekend.
 2021-03-23 22:09:53 -04:00
TheWitness 8b7152f797 Fixing Issue #4076 
System utilities Mariadb tuning doc points to a dead URL
 2021-01-21 19:28:04 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
Mischa ter Smitten a6224b8977 Fix: call to undefined function api_data_source_cache_crc_update() (#3984) 
* Fix: call to undefined function api_data_source_cache_crc_update()

* Add CHANGELOG entry
 2020-12-04 17:22:12 -05:00
ddb4github 79ea02a5c7 Fixed: Technical Support-->PHP Info removed all hyperlink (#3982) 
* Fixed: keep non-section-title <a> tag, and remove empty <div> if <div> content is removed by other preg_replace function

* Fixed a typo
 2020-12-04 07:46:04 -05:00
TheWitness 93dc93c9e4 Fixing Issue #3931, #3916 
- Recache due to failed to get OID but SNMPWALK works
- Certain Device actions cause the removal of poller items from the remote data collector
 2020-11-21 00:35:23 -05:00
TheWitness e869a0f980 Fixing Issue #3884 
Improve MySQL Settings Recommendations for Character Set and Colation
 2020-10-28 16:50:24 -04:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code 
* Some insances in the vendor directory have not been handled to maintain pedigree.
 2020-10-21 08:27:42 -04:00
TheWitness a9f182c98c Fixing Issue #3678 
More or Equal incorrect highlighting max_heap_table_size and tmp_table_size
 2020-08-01 16:13:28 -04:00
TheWitness 67caccb26f Removing recommendation of buffer_pool_instances for MariaDB 10.5 
- This recommendation is not longer valid for MariaDB 10.5.
 2020-06-27 12:53:52 -04:00
TheWitness a360f1a3ef Fixing Iseue #3450 
Cacti can not be supported on XAMPP and PHP7.4
 2020-04-09 20:32:36 -04:00
netniV 72fba23739 Minor QA on recent commits 2020-02-22 12:00:27 +00:00
netniV 675223a1ff When PHP memory limit is set to -1, recommendation value fails 
Closes #3250
 2020-02-21 23:36:29 +00:00
netniV aa1f827ceb PHP Memory is not correctly identified when value is not in megabytes 
Closes #3159
 2020-01-17 10:47:42 +00:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit c29c587012 Resolving Issue #2894 
Database Information and Recommendations Incorrect when viewed from Remote Data Collectors
 2019-09-15 11:59:28 -05:00
cigamit b1214e4454 Minor change around issue #2903 
This change will prevent additional warnings from being generated from bad recommendation arrays being passed to the function.
 2019-08-29 07:44:43 -05:00
netniV 97dc663fe6 PHP recommendations can generate a warning causing json issues 
Closes #2903
 2019-08-19 10:51:05 +00:00
cigamit 348962b6a0 Partial Fix to #2836 
Upgrader to raise error condition when innodb_large_prefix is not set
 2019-07-24 18:26:21 -05:00
cigamit 87b6cb105b Resolving Issue #2825 
"innodb_doublewrite = off" possibly dangerous recommendation
 2019-07-19 07:55:31 -05:00
cigamit 393e5860ee Resolving Issue #2814 
Anchor Tags Escaped on Utilities Page
 2019-07-09 07:01:13 -05:00
netniV 51a01bb947 When the path_php_binary location is invalid, this should be notified during installation when checking modules 
Closes #2748
 2019-07-01 21:47:09 +00:00
netniV 7f2a94b8d3 Undefined variable message raised by push_out_host() in lib/utility.php 
Closes #2723
 2019-06-09 12:51:53 +00:00
cigamit af945e0706 Resolved two corners cases related to #2690 
Thse two issues were discovered by user new to Cacti.
 2019-05-19 07:49:06 -05:00
cigamit 29f00f8c46 Resolving Issue #2672 
Cacti Install on Windows Fails
 2019-05-07 22:30:41 -05:00
netniV a0950bf10e Revert "Honor php.ini when php is used in exec() and shell_exec() calls (#2652)" 
This reverts commit 33641a9abb.
 2019-04-29 12:45:02 +00:00
netniV 1c6139f667 Revert "Correct a few misqueues on #2652" 
This reverts commit 3e3ba86f23.
 2019-04-29 12:44:53 +00:00
netniV a2d3fd8776 Revert "WIP: php argument composition (#2653)" 
This reverts commit 8a23ca33e3.
 2019-04-29 12:43:03 +00:00
David Runge 8a23ca33e3 WIP: php argument composition (#2653) 
* Moving all argument composition for backgrounded calls of php to 'assemble_php_args()' in /lib/functions.php.

* lib/functions.php: Explicitely prepending all assembled arguments.

* lib/functions.php: Removing an accidental appending of the initial args in assemble_php_args().
 2019-04-29 13:38:17 +01:00
cigamit 3e3ba86f23 Correct a few misqueues on #2652 2019-04-27 11:48:57 -05:00
David Runge 33641a9abb Honor php.ini when php is used in exec() and shell_exec() calls (#2652) 
* Introducing the prepending of the current php.ini file, if any, to the extra arguments of backgrounded php calls (used with exec_background).
This enables the backgrounded process to stay in the same environment as the main one and not default back to a system wide default configuration file (which might or might not have configurations setup properly).

* Prepending the current php.ini in use (if any) to any exec() or shell_exec() call, that is doing a backgrounded call of the php executable.

* graph_realtime.php: Fixing missing whitespace between executable and first argument.
 2019-04-27 21:32:32 +06:00
netniV b8322d4d6a Resolving issue #2551 
When checking MySQL configuration values, consider ON/OFF to be equal to 1/0.

Closes #2551
 2019-03-21 10:33:30 +00:00
cigamit 805ec48f74 Update recommendations for MySQL/MariaDB 
These recommendations are for utf8mb4 to support larger indexes that some users have in their plugins.
 2019-03-17 09:40:12 -05:00
cigamit 5cf7d42dfe Resolving Issue #2509 
Installer is not consistent between MySQL Settings checking and final step Warning
 2019-03-16 15:08:49 -05:00
netniV 5c70c32eed Make gettext an optional module 2019-03-15 00:12:06 +00:00
cigamit da6df4c060 Update recommendations for flash/ssd 2019-03-10 12:25:24 -05:00
cigamit e370a83cb9 Resolving Issue #2434 
Enable/disable Data Source generates warnings when snmp_index is bad
(blank).
 2019-02-20 21:52:35 -06:00
cigamit 7698645e8f Resolving Issue #2436 
Unknown column 'dl.snmp_index' in 'where clause'
 2019-02-20 21:42:12 -06:00
netniV d6f6ea2e16 Allow CLI checker to self-increase memory without affecting utility's detection of memory limit 2019-02-15 17:19:21 +00:00
cigamit bdc4ed9c05 Resolving Issue #2357 
- Poller issuing WARNING with little way to diagnose
- This change will remove bad items first from the poller cache
- It adds a new option to filter Data Sources with a Status of Bad Index
- It issues a waring every few hours of the prescense of Bad Index in
the system.

The warning threshold may be excessive.  Will have to see as in large
installs indexes can get bad all the time.
 2019-02-02 11:49:04 -06:00
cigamit edc736d871 Additional fixes for Issue #2326 
This allows the row format to be dynamic only when the
innodb_file_format is Barracuda, and corrects a bug in detecting MySQL
vs. MariaDB in the version string.
 2019-01-26 09:42:37 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
netniV 00524d4a10 Further resolve #2315 
Correct a couple of minor issues, now make PHP version limit an error.
 2019-01-16 20:15:10 +00:00