Commit Graph
258 Commits
Author SHA1 Message Date
TheWitness 8956e34be2 Fixing Issue #4641 - Save total snmp_ports into settings table for spine
This change, when combined with a to be committed spine change will help improve performance of spine on very busy systems where the default snmp port is the only one in use.
2022-03-22 00:32:32 -04:00
TheWitness 3ac42ebe46 Fixing Issue #4614
- Cacti can not differentiate between execution remotely between the main poller loop vs. poller bottom
- Also QA including, better logging
- One Hooks in wrong section 'cacti_stats_update'
- I've noticed two hooks that are no longer in Cacti.  Need to see when they were removed 'poller_output' and 'poller_command_args'.
2022-03-13 16:14:09 -04:00
TheWitness 0801ec38fc At 30 second data collection in PHP 8.1.2 PHP reports a loss of precision in poller.php 2022-02-13 10:41:05 -05:00
TheWitness 82b229db9e Updating Copyright to 2022. 2022-02-06 17:16:20 -05:00
netniV 17e2240656 Correct type in fix for #4460 2021-11-20 13:06:03 +00:00
netniV bafe82e8f9 Polling does not complete as expected on larger systems (#4460)
Closes #4460
2021-11-18 23:13:07 +00:00
netniV 87b28c8c33 Remote pollers may not get settings when system-wide polling is turn off (#4451)
Closes #4451
2021-11-07 01:38:18 +00:00
TheWitness f0735eed3e Fixing Issue #4414 - Poller Performance
Improve performance of Cacti poller on heavily loaded systems
2021-09-30 07:48:51 -04:00
TheWitness 4105f15dd8 Correcting issues related to #4396
Moving this to a common function.  We still need discussion on when it's best to perform table maintenance for tables like the `poller_output` table, that when this table is InnoDB, it can become fragmented, though empty and that free space can not be released without an optimize operation, which for InnoDB tables can take some time.
2021-09-15 07:28:29 -04:00
Jian JinandTheWitness 65b2620641 Fix issue #4396 (#4397)
* Update CHANGELOG

* Update poller.php

* Minor spaces to tabs formatting change

Co-authored-by: TheWitness <thewitness@cacti.net>
2021-09-10 08:32:48 -04:00
TheWitness 7ea616b73c Fixing issue #4391 - Boost errors
When system level polling is disabled Boost shows poller crashed errors and creates many arch tables
2021-09-07 10:56:44 -04:00
Sean Mancini d422969a47 add addiitonal admin email notifications (#4385) 2021-09-02 00:54:03 +01:00
TheWitness 7646e44af7 Fixing Issue #4375 - Remove lingering poller_output items from main poller
When poller_output table is filling over time on the main poller, it can wind up into a critical situation blocking boost
2021-08-27 16:13:30 -04:00
netniV 1a23052e11 Incomplete Poller items from a previous run may be updated twice #4266 2021-05-17 09:08:05 +00:00
netniV a2febc0115 When poller first runs, time since last run produces an error (#4254)
When a poller first runs, there is no previous run timestamp but the code was trying to round on the default value which is a string.

Closes #4254
2021-05-08 10:53:24 +00:00
TheWitness 7345225cf7 Fixing issue #4227 and move flush to end of poller
When remote poller is in offline mode data is written to poller_output as well as poller_output_boost
2021-04-12 21:37:47 -04:00
TheWitness c21d0ba91b Final resolution to #4215
This change modifies logic slightly as follows:

1) Retry only twice for a connection (speed up the GUI in offline mode)
2) Don't update resource cache when in offline or recovery, you could downgrade yourself
3) Don't flush_boost() function if you are not a remote data collector
4) Better logging for automation to indicate offline or remote
2021-04-11 20:04:58 -04:00
TheWitness c25ab9c99d Fixing Issue #4185 - Signal Handling Best Practices
- Cacti signal handling is not following best practices in PHP 7
2021-03-20 19:28:44 -04:00
TheWitness da77da10c0 Remove instrumentation from last commit
#4149
2021-02-27 16:58:55 -05:00
TheWitness 30ba42edeb Fixing Issue #4149
poller_items gets re-calculated with every poll when 1-minute and 5-minute data sources are mixed
2021-02-27 16:56:05 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 5a5cc8d1e4 Update file permissions 2020-11-22 16:59:23 -05:00
TheWitness cdab3933b4 Match spine thread time behavior 2020-11-21 00:35:59 -05:00
TheWitness a392ce8e96 Use LSB shebang notation for cli scripts 2020-11-06 07:02:37 -05:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code
* Some insances in the vendor directory have not been handled to maintain pedigree.
2020-10-21 08:27:42 -04:00
TheWitness a8e43b12f2 Fixing Issues #3663, #3655, #3651, #3681, #3668, #3669 (#3680) 2020-07-12 00:55:18 +01:00
TheWitness c2aaa7d67d Fixing Issue #3632 and restructuring maintenance for #3629
- Some database conditions lead to warnings in the Cacti log
- Restructuring the poller maintenances into function blocks to simplify code flow.
2020-06-21 09:17:51 -04:00
TheWitness 77b0afde35 Fixing Issue #3386
Second data collector shows as running when its not when no items to gather
2020-03-28 19:44:52 -04:00
TheWitness efa46bbcf6 More upgrade QA
* Upgrading from pre 1.x should properly work now with little or no errors.
2020-03-15 11:17:12 -04:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 7bae47230f Resolving Issue #3177
Remove legacy plugin hook that presents potential 3rd party security issues
2020-01-10 19:24:45 -06:00
TheWitness da2bdbeb42 Fixing Issue #3161
If for some reason the poller_output_boost table is missing, recreate it before a poller run
2019-12-31 11:21:38 -05:00
cigamit f3ba511936 Log the automatic enablement of boost 2019-12-01 19:23:37 -06:00
cigamit 176400bfc5 Resolving Issue #3124
When a second data collector is added to Cacti, boost is not enabled automatically
2019-12-01 15:53:45 -06:00
cigamit 1a6ba586e3 Resolving Issue #3101
Poller.php polling... too fast?!
2019-11-26 20:14:36 -06:00
netniV 93391cd1a3 Poller overrun warning message is badly worded
Closes #2901
2019-08-16 12:32:36 +00:00
cigamit 81701f3b5a Resolving Issue #2866
Add poller ID to subject for admin notifications
2019-08-11 15:02:21 -05:00
cigamit 405ef92a36 Resolving Issue #2884
Disable replication not working
2019-08-11 13:11:03 -05:00
cigamit e52708eefa Resolving Issue #2727
Warning issued when poller is set to cmd.php and DSStats is enabled
2019-06-09 19:42:54 -05:00
cigamit ba21617bb7 Resolving Issue #2712
The hard code of set memory_limit need to be removed
2019-05-30 07:51:12 -05:00
cigamit 29f00f8c46 Resolving Issue #2672
Cacti Install on Windows Fails
2019-05-07 22:30:41 -05:00
cigamit 3312d9e03a Properly set the poller for Recache Stats 2019-03-10 15:31:43 -05:00
netniV 6ea486a00a Merge branch 'develop' for release 1.2.2 2019-02-24 13:37:05 +00:00
netniV cc9cd24f76 Resolving issue #2433
Bad SNMP Index warning despite all data sources disabled
2019-02-19 15:33:15 +00:00
cigamit 36635a4958 Resolving #2383
[develop 1.2.2] - error message bad_index_check()
2019-02-08 07:14:39 -06:00
cigamit bdc4ed9c05 Resolving Issue #2357
- Poller issuing WARNING with little way to diagnose
- This change will remove bad items first from the poller cache
- It adds a new option to filter Data Sources with a Status of Bad Index
- It issues a waring every few hours of the prescense of Bad Index in
the system.

The warning threshold may be excessive.  Will have to see as in large
installs indexes can get bad all the time.
2019-02-02 11:49:04 -06:00
cigamit cd6b789bb0 Resolving Issue #2317
Poller time table running out of auto increment keys
Also correct two copyright years
2019-01-26 10:23:42 -06:00
cigamit af3ba2a39a Resolving Issue #2317
Poller time table running out of auto increment keys
2019-01-26 09:55:26 -06:00
netniV b8c579b129 Update copyright notices for 2019 2019-01-25 08:06:11 +00:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00