Commit Graph
405 Commits
Author SHA1 Message Date
TheWitness f823276030 Fixing #4194 - Upgrade errors 2021-03-25 17:52:13 -04:00
TheWitness 25c6dbd06c Fixing #4194 - Upgrade errors
SQL error when saving device
2021-03-24 20:35:21 -04:00
TheWitness 045d40423b Fixing Issue #4193 - Reindex Disabled Devices
- Script poller_reindex_hosts.php | Try to Reindex disabled devices
- Added better verbose output when using --debug option
- Moved query to prepared statements for security
- Report orphan and item counts too
2021-03-22 22:12:36 -04:00
TheWitness afcb13bb8d Fixing Issue #4105 - Builk Walk Repetition size detection
- Issue with SNMP Bulkwalk Repetitions Size
- This enhancement adds a new column to the host table for bulk walk size us
- Detection can happen on each re-index, set manually, or detected and set one time.
- Changed Max OID's to a dropdown
- Max Repetitions is also a dropdown now
- This setting was also carried to the Automation portion of Cacti and the Add Device CLI
2021-03-21 14:32:47 -04:00
TheWitness 782986545e Fixing Issue #4174
Cacti's analyze_database.php script should skip binary logging if replication is being used
2021-03-17 22:20:21 -04:00
TheWitness 4a2ec55e42 Fixing Issue #4136
The Cacti repair_database.php script has no option to skip table checks and force Data Source repair
2021-02-18 07:16:34 -05:00
TheWitness 557f89bd67 Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x"
This reverts commit 0b597f61cb, reversing
changes made to b062b2bb57.
2021-01-26 19:48:30 -05:00
browniebraun 20e6223f6d Revert "Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x"
This reverts commit 7e0da80345, reversing
changes made to 3ee16196ef.
2021-01-26 19:09:33 +01:00
TheWitness 264067ce50 Make Travis happy 2021-01-25 21:00:30 -05:00
TheWitness ec977ce802 Another minor fix. Too much Cacti for a single weekend. 2021-01-24 20:48:28 -05:00
TheWitness 640b45f474 Test before commit next time on #4092 2021-01-24 20:43:02 -05:00
TheWitness 0635e79288 Fixing Issue #4092
- On large systems several Cacti integer value will overflow
2021-01-24 19:32:13 -05:00
TheWitness 302ccc9014 Fixing Issue #4079 - Audit Database
- audit_database.php compatibility enhance for current_timestamp() and CURRENT_TIMESTAMP
2021-01-23 10:59:55 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
YongBoLiuandyboliu a3319e80ce Fix3999 (#4000)
* feature 3965, Add a value check if the input field is textbox in settings

* feature 3965, revert

* Fix #3999

* Refix issue #3999, wrap mysqldump into db_dump_data()

* Fix issue #3999, update the db_dump_data() to minimize password be caught.

Co-authored-by: yboliu <yboliu@oc8636837557.ibm.com>
2020-12-30 18:03:11 -05:00
TheWitness c420e388b5 Fixing issue #4012
Provide CLI script to renew the CSRF security key for CSRF protection
2020-12-17 20:33:47 -05:00
ddb4github fd97a5da3c Fixed: audit_database.php set macro IN_PLUGIN_INSTALL for plugin upgrade (#3997)
* Fixed: audit_database.php Invalid parameter number: no parameters were bound

* Fixed: audit_database.php set macro IN_PLUGIN_INSTALL to skip cache of db_column_exists function
2020-12-09 08:59:30 -05:00
ddb4github 2bbd3f857f Fixed: audit_database.php Invalid parameter number: no parameters were bound (#3996) 2020-12-09 08:08:23 -05:00
TheWitness 1c9f332794 Fixing Issue #3977
Cacti CLI upgrade_database.php misses constant IN_CACTI_INSTAL which may result in upgrade failures
2020-12-03 08:34:54 -05:00
TheWitness 909bcbf7c5 Two minor typos 2020-11-26 14:03:49 -05:00
TheWitness f888a845e6 Correct last remaining issues and more messaging 2020-11-26 10:13:04 -05:00
TheWitness 83b52e1138 Fixing Issue #3942
* The audit_database.php script will only modify columns, and add indexes, it does not add column
* There will likely be one more update to this before it's done.  There are a few cases not working 100% yet.
2020-11-26 08:32:16 -05:00
TheWitness 968b212465 Correct three issues with PHP7.4 2020-11-22 22:41:03 -05:00
TheWitness a4e5976b8e Update file permissions 2020-11-22 16:58:46 -05:00
TheWitness 15539fec9f Fixing Issue #3909
The cli script install_cacti.php does not exit with not zero exit code when errors occur
2020-11-06 07:12:53 -05:00
TheWitness a392ce8e96 Use LSB shebang notation for cli scripts 2020-11-06 07:02:37 -05:00
Christopher PereiraandTheWitness ee8348a05e Fixed wrong error message (#3881)
* Fixed wrong error message

Script was throwing "ERROR: no filename specified" when file was not readable.

* Update CHANGELOG

* Update CHANGELOG

Co-authored-by: TheWitness <thewitness@cacti.net>
2020-10-24 09:43:02 -04:00
TheWitness 52bb6ffda7 Remove all remaining instances to "sizeof(" or "count(" in code
* Some insances in the vendor directory have not been handled to maintain pedigree.
2020-10-21 08:27:42 -04:00
netniV e12af7e62d Remove Devices shows undefined variable error (#3782)
Closes #3782:
2020-10-06 15:40:16 +00:00
Jeff 9969e58277 Update removespikes.php (#3671) 2020-07-09 09:19:27 +01:00
Richard LaagerandTheWitness 3376792b58 Print the DS ID (#3650)
Closes: #3647
Signed-off-by: Richard Laager <rlaager@wiktel.com>

Co-authored-by: TheWitness <thewitness@cacti.net>
2020-06-30 16:10:46 -04:00
Richard Laager 5181b7979a Fix missing include (#3649)
Closes: #3646
Signed-off-by: Richard Laager <rlaager@wiktel.com>
2020-06-30 16:09:08 -04:00
TheWitness 9121e3a2b4 Fixing Issue #3478
Data Query Re-Index is not optimal causing very long Re-Index times
2020-04-19 15:39:13 -04:00
ddb4githubandJing Chen 8b26c35565 Fixed: Same fix as for #2859 for deprecated curly braces (#3469)
Co-authored-by: Jing Chen <three_chenjing@sohu.com>
2020-04-17 17:11:21 -04:00
netniV 913724efe8 Minor: PHP CLI help inconsistent with filename
Closes #3388
2020-04-01 17:14:14 +00:00
TheWitness 75580b386e Fixing Issue #3313
Installing cacti 1.2.10 in debian and ubuntu stopped at 41%
2020-03-21 13:26:42 -04:00
ddb4githubandSouth Park Neo 144847be45 Improve sqltable_to_php.php to support charset output (#3280)
* Improve sqltable_to_php.php to support charset output

* Minor edit for readability

Co-authored-by: South Park Neo <thewitness@cacti.net>
2020-02-22 06:43:24 -05:00
cigamit 181cbcaeea Resolving Issue #3224
Add '--all' option to remove_graphs.php and issue an error if command would result in all graphs being removed and --all not specified
2020-02-02 10:00:38 -06:00
netniV 29366df32b Update splice_rrd.php to correct year for copyright 2020-01-27 21:15:27 +00:00
TheWitness e4b179bd35 Fixing Issues #2937 and #3209
* Devices still show in cacti despite being deleted
* PHP Error when Creating New Graphs through Automatically Added Devices using Sync Device Template
2020-01-22 19:08:59 -05:00
TheWitness e4fc8d77be Partial fixing to issue #2937
* We should not be perfomring includes in the base of any library file.
2020-01-22 08:17:47 -05:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 222baa1365 Maek the cli based installer work again
* This change further pollutes the vendor csrf library.
* We may want to jub put it in the base as a fork in 1.3.
2020-01-11 18:58:35 -06:00
cigamit 728bcba068 Resolving Issue #3168
sqltable_to_php.php script does not pick up row_format
2020-01-04 21:46:54 -06:00
netniV c3972f212d Make audit_database report one line per column for better differencing 2019-12-17 14:05:30 +00:00
cigamit 950351c1b2 Re-resolving Issue #2793
Large installation - replication issue
2019-12-10 18:35:18 -06:00
cigamit c1bffdcf20 Relative to #3060 Don't Skip IF
If the --dynamic flag is set, and the table is Compact, don't skip converting.
2019-11-29 14:10:02 -06:00
cigamit f4267f5885 Resolving Issue #3118
When upgrading Cacti the convert_tables.php script should use dyanmic row format
2019-11-29 12:05:27 -06:00
cigamit 668affab82 Resolving Issue #3111
When updating an old Cacti version, the add_device.php will fail due to a bad snmp-version column
2019-11-28 09:07:30 -06:00
ddb4github c1d0622580 Fixed use single quto for column data type in sql-table-php-array, and support single quot in data type, e.g. enum type (#3096) 2019-11-17 14:17:36 -06:00