Files
TheWitnessandTheWitness 3ab4c69fb7 PHPStan Level 8 - Phase 1 Conversion (#8135)
* PHPStan Level 8 - Phase 1 Conversion

Reduces the real (no-baseline) PHPStan level 8 error count from ~2,724 to 425
and regenerates phpstan-baseline.neon accordingly (8,941 -> 1,921 lines).

Core type-safety changes
- lib/database.php: narrow db_fetch_row()/db_fetch_row_prepared() to return
  array (was bool|array) and db_fetch_assoc()/db_fetch_assoc_prepared() to
  return array (was mixed); the _prepared workers coerce the connection-failure
  path to an empty array so the declared type is honest. empty()/cacti_sizeof()
  checks are unaffected.
- lib/database.php: narrow $db_conn guards from is_object() to instanceof PDO in
  the transaction/quote/insert-id helpers so the PDO calls resolve.
- lib/mib_cache.php: the fluent MibCache methods mib()/object()/table()/row()
  now return self instead of a bare object so chained calls type-check.

Type-safety casts and guards (mechanical, behaviour-preserving)
- Cast string|false/|null builtin results feeding string parameters
  (json_decode, base64_encode, trim, htmle, preg_replace, explode, etc.).
- Cast int|string / int|false values feeding int id/pid parameters.
- Guard resource|false fopen()/popen() handles before fwrite/fclose/fread, and
  wrap foreach over array|false/list|false results with `?: []`.

Genuine bugs found and fixed
- cli/add_tree.php / lib/api_tree.php: site tree nodes could not be created via
  the CLI - the --site-id option was never parsed, $nodeTypes had no 'site'
  entry (passing null to api_tree_item_save(int $type) -> TypeError), and
  api_tree_item_save() never persisted site_id. All three fixed.
- tree.php: leaves_exist() is typed : int but returned db_fetch_assoc_prepared()
  (an array of rows) for a SELECT COUNT(*); now uses db_fetch_cell_prepared()
  and returns the scalar count.
- lib/mib_cache.php: $entries_per_object was a float (division / ceil) used as
  an array key (PHP 8.1 implicit float-to-int key deprecation); now cast to int.

Config
- .phpstan.neon: add notIdentical.alwaysTrue and booleanAnd.alwaysFalse to the
  existing always-true/false ignore family (same "PHPStan gets confused"
  dynamic-constant cause already covered by identical.alwaysTrue,
  notEqual.alwaysTrue, booleanAnd.leftAlwaysTrue, etc.).
- phpstan-baseline.neon: regenerated; the remaining 425 entries are the
  untouched long tail for Phase 2.

* Remove redundant @phpstan-ignore comments

Follow-up cleanup for the level 8 Phase 1 work. Removes 14 inline
@phpstan-ignore comments that no longer suppress any reported error:

- cli/repair_database.php: `@phpstan-ignore booleanAnd.alwaysFalse` is now
  covered by the global booleanAnd.alwaysFalse ignore added to .phpstan.neon.
- 13 others (host.php, include/global.php, include/session.php,
  lib/api_automation.php x2, lib/functions.php x2, lib/html_utility.php x2,
  lib/installer.php, lib/package.php, lib/reports.php, lib/rrd.php) no longer
  match any reported error after the type-safety fixes (e.g. the
  db_fetch_row_prepared() return-type narrowing removed the offset-assign
  errors the api_automation ignores were suppressing).

Verified with reportUnmatchedIgnoredErrors enabled: 0 unmatched ignores
remain and the full level 8 run still reports 0 errors.

* ci: satisfy validator ratchet and refresh security sink baselines

- lib/api_tree.php: give the new tree-item site_id a real numeric
  constraint ('^[-0-9]+$', matching html_reports.php) instead of an
  empty regex, so the validator constraint ratchet passes without
  bumping its baseline.
- tests/security/baselines: refresh the three sink/hotspot signatures
  whose code text changed from the (string) casts added in this branch
  (lib/poller.php setsid, cli/rrdresize.php json_encode, lib/import.php
  simplexml_load_string).

* ci(js): allow DOMPurify 3.4.16 and update sync_js pin test

The dependabot bump (#8134) moved package.json/package-lock.json to
DOMPurify 3.4.16 on develop but left tests/js/sync_js.test.mjs pinned to
3.4.15, so the PR merge commit fails the 'DOMPurify is pinned' contract.
Bring package.json/package-lock.json to 3.4.16 (matching develop) and
update the pin test to expect 3.4.16.

* test: update sql.php null-handling assertion for the (string) cast

This branch changed scripts/sql.php from trim(\ ?? '') to
trim((string) \) (the phpstan-safe form that coerces both null and
false from shell_exec()). Update SqlScriptsTest's null-return assertion
to match the new cast instead of the removed '?? ''.

* fix: address Copilot review - ownership IDs, fopen guards, mib_cache bound

- chown()/chgrp(): pass integer UID/GID from fileowner()/filegroup()
  (guarding the false lookup) instead of string-casting them, which made
  them resolve account/group names like '1001' and fail. Covers
  lib/api_device.php, lib/boost.php and poller_maintenance.php (x2).
- fopen() failure now short-circuits instead of reporting success:
  lib/package.php returns false, lib/clog_webapi.php and utilities.php
  render an error, and snmpagent_mibcachechild.php skips the cache write
  and sentinel unlink so a concurrent writer's lock is preserved.
- lib/mib_cache.php: keep the float quotient as the loop bound and cast
  only the array offset, so a non-even entries/columns split no longer
  truncates the loop and drops a cached row.

* revert: keep db_fetch_* returning false on error; baseline Level 8 instead

Per review, restoring the intentional fail-safe: db_fetch_row[_prepared]()
return bool|array and db_fetch_assoc[_prepared]() return mixed again, so a
genuine SQL error (not just a missing connection) is signalled as false and
the === false checks in cdef_is_in_use(), boost_process_* and aggregate.php
work as before. Dropped the is_array() ? : [] coercion.

Level 8 stays green by regenerating phpstan-baseline.neon to capture the
re-introduced bool|array/mixed call-site errors (the ~1,850 the narrowing
had eliminated). Tightening those callers to drop them from the baseline is
Phase 2 work.

---------

Co-authored-by: TheWitness <copilot@users.noreply.github.com>
2026-10-02 10:08:56 -04:00

248 lines
8.3 KiB
PHP

<?php
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Slim\Factory\AppFactory;
use Slim\Routing\RouteCollectorProxy;
include __DIR__ . '/../include/db_functions.php';
include __DIR__ . '/../include/arrays.php';
include __DIR__ . '/../../include/global.php';
/* Nothing below authenticates or authorises anything: no route consults a
* realm, a session or a token, so every endpoint answers whoever reaches it.
* ADR 0001 describes what this needs and is not built yet. Until it is, refuse
* to serve unless an operator has deliberately turned the scaffold on.
*
* The only thing standing in front of these routes today is that api/vendor is
* not shipped, so Slim is missing and the entry point fatals. That is an
* accident of packaging rather than a control, and it disappears the moment
* someone follows the composer install in api/README.md on a live host.
*
* 404 rather than 403: a refusal that confirms the endpoint exists is a worse
* answer than one that does not. No body and no content type either, or the
* refusal still says an API is here. */
if (read_config_option('api_enabled') !== 'on') {
http_response_code(404);
exit;
}
$client_ip = get_client_addr();
$app = AppFactory::create();
/* displayErrorDetails puts stack traces, file paths and database errors on the
* wire. That is a development convenience, so make it one. */
$api_developer_mode = (read_config_option('api_developer_mode') === 'on');
$app->addErrorMiddleware($api_developer_mode, true, true);
$app->get('/', function (Request $request, Response $response) {
$response->getBody()->write('Welcome to the Cacti API!');
return $response;
});
/**
* Validates that all provided parameters are within the allowed parameter list.
*
* This function checks each parameter key against a list of allowed parameters
* and returns an error message if any invalid parameters are found.
*
* @param array $params The parameters to validate (key-value pairs)
* @param array $allowed_params Array of allowed parameter names
* @return string|null Returns an error message if invalid parameters are found, otherwise null
*/
function validate_parameters(array $params, array $allowed_params) : string|null {
foreach ($params as $key => $value) {
if (!in_array($key, $allowed_params, true)) {
return 'ERROR: Invalid parameter passed: "' . htmlspecialchars($key) . '"';
}
}
return null;
}
// V1 API Routes Group
$app->group('/v1', function (RouteCollectorProxy $group) {
// Info endpoints
$group->group('/info', function (RouteCollectorProxy $infoGroup) {
$infoGroup->get('/hosts', function (Request $request, Response $response) {
global $allowed_hosts_filter, $client_ip;
$params = $request->getQueryParams();
$verror = validate_parameters($params, $allowed_hosts_filter);
if ($verror) {
$response->getBody()->write((string) json_encode($verror));
cacti_log($verror . ' By HOST: ' . $client_ip, false, 'API');
return $response->withStatus(400)->withHeader('Content-Type', 'application/json');
}
$json = (string) json_encode(get_hosts($params));
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$infoGroup->get('/host_templates', function (Request $request, Response $response) {
global $allowed_host_templates_filter, $client_ip;
$params = $request->getQueryParams();
$verror = validate_parameters($params, $allowed_host_templates_filter);
if ($verror) {
$response->getBody()->write((string) json_encode($verror));
cacti_log($verror . ' By HOST: ' . $client_ip, false, 'API');
return $response->withStatus(400)->withHeader('Content-Type', 'application/json');
}
$json = (string) json_encode(get_host_templates($params['template_id'] ?? 0));
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$infoGroup->get('/graph_list', function (Request $request, Response $response) {
$params = $request->getQueryParams();
$host_id = $params['host_id'] ?? 0;
$json = (string) json_encode(get_graph_list($host_id));
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$infoGroup->get('/automation_networks', function (Request $request, Response $response) {
global $allowed_automation_networks_filter, $client_ip;
$params = $request->getQueryParams();
$verror = validate_parameters($params, $allowed_automation_networks_filter);
if ($verror) {
$response->getBody()->write((string) json_encode($verror));
cacti_log($verror . ' By HOST: ' . $client_ip, false, 'API');
return $response->withStatus(400)->withHeader('Content-Type', 'application/json');
}
$json = (string) json_encode(get_automation_networks($params));
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
});
// Status endpoints
$group->group('/status', function (RouteCollectorProxy $statusGroup) {
$statusGroup->get('/poller_status', function (Request $request, Response $response) {
$params = $request->getQueryParams();
$poller_id = $params['poller_id'] ?? 0;
$hosts = get_poller_status($poller_id);
$response->getBody()->write((string) json_encode($hosts));
return $response->withHeader('Content-Type', 'application/json');
});
$statusGroup->get('/cacti_status', function (Request $request, Response $response) {
$json = (string) json_encode(get_cacti_status());
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$statusGroup->get('/cacti_db_status', function (Request $request, Response $response) {
$json = (string) json_encode(get_cacti_db_status());
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$statusGroup->get('/boost_status', function (Request $request, Response $response) {
$json = (string) json_encode(get_boost_status());
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$statusGroup->get('/dsstats', function (Request $request, Response $response) {
$json = (string) json_encode(get_dsstats_status());
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$statusGroup->get('/api_db_ping', function (Request $request, Response $response) {
$ping_result = db_fetch_row('SELECT 1 from version');
if (!$ping_result) {
$response->getBody()->write((string) json_encode(['error' => 'Database connection failed']));
return $response->withStatus(500)->withHeader('Content-Type', 'application/json');
}
$response->getBody()->write((string) json_encode(['status' => 'Database connection test successful']));
return $response->withHeader('Content-Type', 'application/json');
});
// automation status endpoint
$statusGroup->get('/automation', function (Request $request, Response $response) {
$json = (string) json_encode(get_automation_status());
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
});
// Plugin endpoints
$group->group('/plugin', function (RouteCollectorProxy $pluginGroup) {
$pluginGroup->group('/thold', function (RouteCollectorProxy $tholdGroup) {
$tholdGroup->get('/thresholds', function (Request $request, Response $response) {
global $allowed_thold_filter, $client_ip;
$params = $request->getQueryParams();
$verror = validate_parameters($params, $allowed_thold_filter);
if ($verror) {
$response->getBody()->write((string) json_encode($verror));
cacti_log($verror . ' By HOST: ' . $client_ip, false, 'API');
return $response->withStatus(400)->withHeader('Content-Type', 'application/json');
}
$json = (string) json_encode(get_thresholds($params));
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
$tholdGroup->get('/status', function (Request $request, Response $response) {
$json = (string) json_encode(get_threshold_status());
$response->getBody()->write($json);
return $response->withHeader('Content-Type', 'application/json');
});
});
});
});
$app->run();