mirror of
https://github.com/Cacti/cacti.git
synced 2026-10-23 03:27:02 +09:00
* feat(validator): add settings constraint validation pilot Routes saved settings through Symfony Validator so include/global_settings.php can declare per-setting constraints inline. The save handler runs one validator pass and surfaces violations via the existing raise_message() pattern, replacing scattered ad-hoc checks. Pilot covers 12 high-value settings; the rest stay on the existing implicit form-render checks. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * ci(infection): allow infection/extension-installer composer plugin Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * docs(validator): document must-be-posted-to-validate contract Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * fix(bootstrap): guard Symfony autoload in global_settings before use declarations Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * fix(test): remove redundant autoload require in CactiSettingsTest Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * fix(test): restore require_once for CactiSettings (not in Composer autoload) Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * feat(validator): fold helper into settings pilot * fix(validator): translate default Symfony constraint messages Default Symfony NotBlank/Length/Range/Choice/Positive messages render in English regardless of Cacti locale because the validator runs without a Symfony Translator. Pass explicit __()-wrapped message, minMessage, maxMessage, and notInRangeMessage options on each bare constraint in include/global_settings.php so violations participate in Cacti's gettext pipeline. Documents the no-Translator decision in CactiValidator so future contributors know to translate at the call site. Addresses Copilot PR #7077 review feedback. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * fix(graph): improve remote agent parsing and RRD path validation * feat(validator): migrate automation_graph_rules.php to symfony validator * refactor(validator): move automation validator helper to shared library and enhance tests * feat(validator): migrate automation_networks.php to symfony validator * feat(validator): migrate automation_snmp.php to symfony validator * feat(validator): migrate automation_templates.php to symfony validator * feat(validator): migrate automation_tree_rules.php to symfony validator * refactor(automation): move api_networks_save to shared library for testability * feat(validator): add validateInput helper and migrate color_templates.php * feat(validator): migrate host_templates.php to symfony validator * feat(validator): migrate graph_templates.php to symfony validator * feat(validator): migrate data_templates.php to symfony validator * feat(validator): migrate data_input.php to symfony validator * feat(validator): migrate data_queries.php to symfony validator * feat(validator): migrate graphs_new.php to symfony validator * feat(validator): migrate graphs.php to symfony validator * feat(validator): migrate data_sources.php to symfony validator * feat(validator): migrate user_group_admin.php to symfony validator * feat(validator): migrate managers.php to symfony validator * feat(validator): migrate package_repos.php to symfony validator * Refactor pollers.php to use CactiValidator * fix(security): close validator migration regressions * test(snmp): add spine docker harness * fix(review): address validator migration feedback * fix(deps): include validator runtime packages * chore(deps): normalize composer.json require-block indentation The validator migration introduced tab-indented entries in an otherwise space-indented require block. Re-indent the stevenmaguire/* and symfony/* lines to 8 spaces so the block is consistent. Co-Authored-By: Oz <oz-agent@warp.dev> * fix(graphs): repair graph json response branch * fix(validation): apply php cs fixer * ci(codeql): skip autobuild for interpreted scans * fix(link): satisfy phpstan path guard * chore(pr): remove branch pollution * ci(codeql): align autobuild pin with init and analyze Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * refactor(automation): use CactiValidator::validateInput, drop wrapper automation_validate_input() in lib/api_automation.php was a byte-for-byte duplicate of CactiValidator::validateInput() (identical session handling and raise_message() semantics, and it already delegated to CactiValidator::validate internally). Per review feedback, use the shared class directly everywhere instead of a parallel automation-only wrapper. - Remove automation_validate_input() from lib/api_automation.php - Replace all call sites with CactiValidator::validateInput() (automation_templates/graph_rules/tree_rules/snmp and api_networks_save) - Update the automation validator unit tests to match - Add @param/@return PHPDoc to CactiValidator specific-validator methods Co-Authored-By: Oz <oz-agent@warp.dev> --------- Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> Co-authored-by: Thomas Vincent <thomas@vincent.dev> Co-authored-by: Oz <oz-agent@warp.dev> Co-authored-by: TheWitness <thewitness@cacti.net>
107 lines
4.0 KiB
PHP
107 lines
4.0 KiB
PHP
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
| |
|
|
| This program is free software; you can redistribute it and/or |
|
|
| modify it under the terms of the GNU General Public License |
|
|
| as published by the Free Software Foundation; either version 2 |
|
|
| of the License, or (at your option) any later version. |
|
|
| |
|
|
| This program is distributed in the hope that it will be useful, |
|
|
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
| GNU General Public License for more details. |
|
|
+-------------------------------------------------------------------------+
|
|
| Cacti: The Complete RRDtool-based Graphing Solution |
|
|
+-------------------------------------------------------------------------+
|
|
| This code is designed, written, and maintained by the Cacti Group. See |
|
|
| about.php and/or the AUTHORS file for specific developer information. |
|
|
+-------------------------------------------------------------------------+
|
|
| http://www.cacti.net/ |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
require_once('./include/global.php');
|
|
|
|
$page = db_fetch_row_prepared('SELECT
|
|
id, title, style, contentfile, enabled, refresh
|
|
FROM external_links AS el
|
|
WHERE id = ?',
|
|
[gfrv('id')]);
|
|
|
|
// Prevent redirect loops
|
|
if (isset($_SERVER['HTTP_REFERER'])) {
|
|
if (strpos($_SERVER['HTTP_REFERER'], 'link.php') === false) {
|
|
$_SESSION['link_referer'] = validate_redirect_url($_SERVER['HTTP_REFERER'], 'index.php');
|
|
|
|
$referer = $_SESSION['link_referer'];
|
|
} elseif (isset($_SESSION['link_referer'])) {
|
|
$referer = sanitize_uri($_SESSION['link_referer']);
|
|
} else {
|
|
$referer = 'index.php';
|
|
}
|
|
} elseif (isset($_SESSION['link_referer'])) {
|
|
$referer = sanitize_uri($_SESSION['link_referer']);
|
|
} else {
|
|
$referer = 'index.php';
|
|
}
|
|
|
|
if (!cacti_sizeof($page)) {
|
|
raise_message('page_not_defined');
|
|
header('Location: ' . $referer);
|
|
|
|
exit;
|
|
} else {
|
|
global $link_nav;
|
|
|
|
if (is_realm_allowed($page['id'] + 10000)) {
|
|
unset($refresh);
|
|
|
|
if (!empty($page['refresh'])) {
|
|
$refresh['seconds'] = $page['refresh'];
|
|
$refresh['page'] = CACTI_PATH_URL . 'link.php?id=' . grv('id');
|
|
}
|
|
|
|
if ($page['style'] == 'TAB') {
|
|
$link_nav['link.php:']['title'] = $page['title'];
|
|
$link_nav['link.php:']['mapping'] = '';
|
|
general_header();
|
|
} else {
|
|
$link_nav['link.php:']['title'] = $page['title'];
|
|
$link_nav['link.php:']['mapping'] = 'index.php:';
|
|
top_header();
|
|
}
|
|
|
|
if (preg_match('/^((((ht|f)tp(s?))\:\/\/){1}\S+)/i', $page['contentfile'])) {
|
|
if (filter_var($page['contentfile'], FILTER_VALIDATE_URL)) {
|
|
print '<iframe id="content" src="' . htmle($page['contentfile']) . '" sandbox="allow-scripts allow-popups allow-forms" frameborder="0"></iframe>';
|
|
} else {
|
|
$message = __esc("External Link ID '%s' with Title '%s' attempted to inject an invalid URL and was blocked!", $page['id'], $page['title']);
|
|
cacti_log($message, false, 'SECURITY');
|
|
raise_message('invalid_url', $message, MESSAGE_LEVEL_ERROR);
|
|
}
|
|
} else {
|
|
print '<div id="content">';
|
|
|
|
$basepath = realpath(CACTI_PATH_INCLUDE . '/content');
|
|
$file = ($basepath !== false) ? realpath($basepath . '/' . $page['contentfile']) : false;
|
|
|
|
if ($file && is_file($file) && str_starts_with($file, $basepath . DIRECTORY_SEPARATOR)) {
|
|
require_once($file);
|
|
} else {
|
|
print '<h1>The file \'' . htmle($page['contentfile']) . '\' does not exist!!</h1>';
|
|
}
|
|
|
|
print '</div>';
|
|
}
|
|
|
|
bottom_footer();
|
|
} else {
|
|
raise_message('permission_denied');
|
|
header('Location: ' . $referer);
|
|
|
|
exit;
|
|
}
|
|
}
|