Files
cacti/poller_recovery.php
Thomas Vincent 2b6e96b23a style(php): [develop] wrap CLI and poller calls without changing execution (#8303)
* style(php): wrap CLI and poller calls without changing execution

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix(ci): review security inventories after poller wrapping

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test(boost): compare handoff source contracts by PHP tokens

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* style(php): wrap poller constant strings without changing values

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* style(php): wrap poller concatenations with token-preserving source contracts

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test(cli): assert CDEF repair queries after constant folding

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test: verify PHP formatting preserves parsed behavior

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
2026-10-14 00:01:26 -07:00

343 lines
9.8 KiB
PHP
Executable File

#!/usr/bin/env php
<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
if (function_exists('pcntl_async_signals')) {
pcntl_async_signals(true);
} else {
declare(ticks = 100);
}
ini_set('output_buffering', 'Off');
require(__DIR__ . '/include/cli_check.php');
require_once(CACTI_PATH_LIBRARY . '/poller.php');
require_once(CACTI_PATH_LIBRARY . '/boost.php');
require_once(CACTI_PATH_LIBRARY . '/dsstats.php');
// display_version - displays version information
function display_version() : void {
$version = get_cacti_cli_version();
print "Cacti Boost RRD Update Poller, Version $version " . COPYRIGHT_YEARS . "\n";
}
// display_help - displays the usage of the function
function display_help() : void {
display_version();
print "\nusage: poller_recovery.php [--verbose] [--force] [--debug]\n\n";
print "Cacti's Remote Poller Recovery Script. This poller will transfer all offline boost records\n";
print "to the Main Cacti Pollers boost table\n";
print "Optional:\n";
print " --verbose - Show details logs at the command line\n";
print " --force - Force the execution of a update process\n";
print " --debug - Display verbose output during execution\n\n";
}
function sig_handler(int $signo) : void {
switch ($signo) {
case SIGTERM:
case SIGINT:
cacti_log('RECOVERY WARNING: Recovery Poller terminated by user', false, 'POLLER');
// tell the main poller that we are done
db_execute(("REPLACE INTO settings (name, value) VALUES ('boost_poller_status', " .
"'terminated - end time:") . date('Y-m-d G:i:s') . "')");
exit;
default:
// ignore all other signals
}
}
function debug(string $string) : void {
global $debug;
if ($debug) {
print trim($string) . "\n";
}
}
/**
* Delete only rows which were acknowledged by the main collector.
*/
function recovery_delete_acknowledged_rows(array $rows, mixed $conn) : bool {
foreach (array_chunk($rows, 500) as $chunk) {
$clauses = [];
$params = [];
foreach ($chunk as $row) {
$clauses[] = '(local_data_id = ? AND rrd_name = ? AND time = ?)';
$params[] = (int) $row['local_data_id'];
$params[] = $row['rrd_name'];
$params[] = $row['time'];
}
if (db_execute_prepared('DELETE FROM poller_output_boost WHERE ' . implode(' OR ',
$clauses),
$params,
true,
$conn) === false) {
return false;
}
}
return true;
}
/**
* Transfer and acknowledge one bounded recovery chunk.
*
* @return int|false Number of transferred rows, or false on any failure.
*/
function recovery_transfer_rows(array $rows, mixed $remote_conn, mixed $local_conn) : int|false {
$sql_array = [];
foreach ($rows as $row) {
$sql_array[] = '(' . (int) $row['local_data_id'] . ',' .
db_qstr($row['rrd_name'], $remote_conn) . ',' .
db_qstr($row['time'], $remote_conn) . ',' .
db_qstr($row['output'], $remote_conn) . ')';
}
$record_count = cacti_sizeof($sql_array);
cacti_log('RECOVERY: Writing ' . $record_count . ' records to main.', false, 'POLLER');
if (!boost_flush_output_batch($sql_array, $remote_conn)) {
cacti_log('RECOVERY ERROR: Main collector did not acknowledge the Boost batch; retaining local rows.',
false,
'POLLER');
return false;
}
if (!recovery_delete_acknowledged_rows($rows, $local_conn)) {
cacti_log('RECOVERY ERROR: Unable to remove acknowledged local Boost rows; they will be retried idempotently.',
false,
'POLLER');
return false;
}
return $record_count;
}
global $local_db_cnn_id, $remote_db_cnn_id;
$recovery_pid = db_fetch_cell("SELECT value FROM settings WHERE name='recovery_pid'", '', true, $local_db_cnn_id);
// process calling arguments
$parms = $_SERVER['argv'];
array_shift($parms);
$debug = false;
$forcerun = false;
$verbose = false;
$poller_id = POLLER_ID;
if (cacti_sizeof($parms)) {
foreach ($parms as $parameter) {
if (str_contains($parameter, '=')) {
[$arg, $value] = explode('=', $parameter, 2);
} else {
$arg = $parameter;
$value = '';
}
switch ($arg) {
case '-d':
case '--debug':
$debug = true;
break;
case '-f':
case '--force':
$forcerun = true;
break;
case '--verbose':
$verbose = true;
break;
case '--version':
case '-V':
case '-v':
display_version();
exit;
case '--help':
case '-H':
case '-h':
display_help();
exit;
default:
print 'ERROR: Invalid Parameter ' . $parameter . "\n\n";
display_help();
exit;
}
}
}
// check for an invalid run location
if ($poller_id == 1 && !defined('PHP_TESTING')) {
print "ERROR: This command is only to be run on remote Cacti Data Collectors\n";
exit(1);
}
// install signal handlers for UNIX only
if (function_exists('pcntl_signal')) {
pcntl_signal(SIGTERM, 'sig_handler');
pcntl_signal(SIGINT, 'sig_handler');
}
// take time and log performance data
$start = microtime(true);
// configuration variables
$record_limit = 150000;
$transfer_chunk_size = 1000;
$sleep_time = 1;
// global counter variables
$records_inserted = 0;
$transfer_failed = false;
debug('About to start recovery processing');
if (!empty($recovery_pid)) {
/* A stored pid wider than pid_t narrows to -1 inside posix_kill(), which
reads as "someone is running" and leaves the stale row in place forever;
on PHP 8.5 the same value throws instead. Either way recovery never runs
again.
This branch reads false as "stale, clear the row and run", so it needs a
probe where a pid we cannot signal counts as stale. That is the prior
posix_kill($pid, 0) semantics, kept, with the bound added.
cacti_process_pid_exists() reports EPERM as present by contract and
cacti_process_still_running() inherits that wherever /proc cannot
answer, so neither of those fits here. */
$pid = cacti_process_signalable((int) $recovery_pid);
if ($pid === false) {
// we found a stale PID, so we delete it from the table
db_execute("DELETE FROM settings WHERE name='recovery_pid'", true, $local_db_cnn_id);
$run = true;
} else {
$run = false;
}
} else {
$run = true;
}
if ($run) {
$my_pid = getmypid();
cacti_log('RECOVERY: No pid exists, starting recovery process (PID=' . $my_pid . ')!', false, 'POLLER');
db_execute_prepared('REPLACE INTO settings
(name, value)
VALUES (\'recovery_pid\', ?)',
[$my_pid], true, $local_db_cnn_id);
// let the console know you are in recovery mode
db_execute_prepared('UPDATE poller
SET status = 5
WHERE id = ?',
[$poller_id], true, $remote_db_cnn_id);
poller_push_reindex_data_to_poller(0, 0, true);
while (true) {
cacti_log('RECOVERY: Getting max_time for ' . $record_limit . ' records.', false, 'POLLER');
$max_time = db_fetch_cell("SELECT MAX(time)
FROM (
SELECT time
FROM poller_output_boost
ORDER BY time ASC
LIMIT $record_limit
) AS rs", '', true, $local_db_cnn_id);
if (empty($max_time)) {
db_execute("DELETE FROM settings WHERE name='recovery_pid'", true, $local_db_cnn_id);
break;
} else {
cacti_log('RECOVERY: Fetching records till time: ' . $max_time . ' from poller DB', false, 'POLLER');
$rows = db_fetch_assoc_prepared(sprintf('SELECT *
FROM poller_output_boost
WHERE time <= ?
ORDER BY time ASC, local_data_id ASC
LIMIT %d', (int) $record_limit),
[$max_time], true, $local_db_cnn_id);
if (cacti_sizeof($rows)) {
$row_count = cacti_sizeof($rows);
for ($offset = 0; $offset < $row_count; $offset += $transfer_chunk_size) {
$chunk = array_slice($rows, $offset, $transfer_chunk_size);
$record_count = recovery_transfer_rows($chunk, $remote_db_cnn_id, $local_db_cnn_id);
if ($record_count === false) {
$transfer_failed = true;
break 2;
}
$records_inserted += $record_count;
}
}
sleep($sleep_time);
}
}
db_execute("DELETE FROM settings WHERE name='recovery_pid'", true, $local_db_cnn_id);
// Recovery failures are reported by the log and exit status; leaving the
// poller in status 5 would incorrectly advertise recovery indefinitely.
db_execute_prepared('UPDATE poller
SET status=2
WHERE id= ?', [$poller_id], false, $remote_db_cnn_id);
} else {
debug('Recovery process still running, exiting');
cacti_log('RECOVERY: Recovery process still running for Poller ' . $poller_id . '. PID is ' . $recovery_pid,
false,
'POLLER');
exit(1);
}
$end = microtime(true);
cacti_log('RECOVERY STATS: Time:' . round($end - $start, 2) . ' Records:' . $records_inserted, false, 'SYSTEM');
exit($transfer_failed ? 1 : 0);