mirror of
https://github.com/Cacti/cacti.git
synced 2026-10-26 13:08:09 +09:00
* PHPStan Level 8 - Phase 1 Conversion
Reduces the real (no-baseline) PHPStan level 8 error count from ~2,724 to 425
and regenerates phpstan-baseline.neon accordingly (8,941 -> 1,921 lines).
Core type-safety changes
- lib/database.php: narrow db_fetch_row()/db_fetch_row_prepared() to return
array (was bool|array) and db_fetch_assoc()/db_fetch_assoc_prepared() to
return array (was mixed); the _prepared workers coerce the connection-failure
path to an empty array so the declared type is honest. empty()/cacti_sizeof()
checks are unaffected.
- lib/database.php: narrow $db_conn guards from is_object() to instanceof PDO in
the transaction/quote/insert-id helpers so the PDO calls resolve.
- lib/mib_cache.php: the fluent MibCache methods mib()/object()/table()/row()
now return self instead of a bare object so chained calls type-check.
Type-safety casts and guards (mechanical, behaviour-preserving)
- Cast string|false/|null builtin results feeding string parameters
(json_decode, base64_encode, trim, htmle, preg_replace, explode, etc.).
- Cast int|string / int|false values feeding int id/pid parameters.
- Guard resource|false fopen()/popen() handles before fwrite/fclose/fread, and
wrap foreach over array|false/list|false results with `?: []`.
Genuine bugs found and fixed
- cli/add_tree.php / lib/api_tree.php: site tree nodes could not be created via
the CLI - the --site-id option was never parsed, $nodeTypes had no 'site'
entry (passing null to api_tree_item_save(int $type) -> TypeError), and
api_tree_item_save() never persisted site_id. All three fixed.
- tree.php: leaves_exist() is typed : int but returned db_fetch_assoc_prepared()
(an array of rows) for a SELECT COUNT(*); now uses db_fetch_cell_prepared()
and returns the scalar count.
- lib/mib_cache.php: $entries_per_object was a float (division / ceil) used as
an array key (PHP 8.1 implicit float-to-int key deprecation); now cast to int.
Config
- .phpstan.neon: add notIdentical.alwaysTrue and booleanAnd.alwaysFalse to the
existing always-true/false ignore family (same "PHPStan gets confused"
dynamic-constant cause already covered by identical.alwaysTrue,
notEqual.alwaysTrue, booleanAnd.leftAlwaysTrue, etc.).
- phpstan-baseline.neon: regenerated; the remaining 425 entries are the
untouched long tail for Phase 2.
* Remove redundant @phpstan-ignore comments
Follow-up cleanup for the level 8 Phase 1 work. Removes 14 inline
@phpstan-ignore comments that no longer suppress any reported error:
- cli/repair_database.php: `@phpstan-ignore booleanAnd.alwaysFalse` is now
covered by the global booleanAnd.alwaysFalse ignore added to .phpstan.neon.
- 13 others (host.php, include/global.php, include/session.php,
lib/api_automation.php x2, lib/functions.php x2, lib/html_utility.php x2,
lib/installer.php, lib/package.php, lib/reports.php, lib/rrd.php) no longer
match any reported error after the type-safety fixes (e.g. the
db_fetch_row_prepared() return-type narrowing removed the offset-assign
errors the api_automation ignores were suppressing).
Verified with reportUnmatchedIgnoredErrors enabled: 0 unmatched ignores
remain and the full level 8 run still reports 0 errors.
* ci: satisfy validator ratchet and refresh security sink baselines
- lib/api_tree.php: give the new tree-item site_id a real numeric
constraint ('^[-0-9]+$', matching html_reports.php) instead of an
empty regex, so the validator constraint ratchet passes without
bumping its baseline.
- tests/security/baselines: refresh the three sink/hotspot signatures
whose code text changed from the (string) casts added in this branch
(lib/poller.php setsid, cli/rrdresize.php json_encode, lib/import.php
simplexml_load_string).
* ci(js): allow DOMPurify 3.4.16 and update sync_js pin test
The dependabot bump (#8134) moved package.json/package-lock.json to
DOMPurify 3.4.16 on develop but left tests/js/sync_js.test.mjs pinned to
3.4.15, so the PR merge commit fails the 'DOMPurify is pinned' contract.
Bring package.json/package-lock.json to 3.4.16 (matching develop) and
update the pin test to expect 3.4.16.
* test: update sql.php null-handling assertion for the (string) cast
This branch changed scripts/sql.php from trim(\ ?? '') to
trim((string) \) (the phpstan-safe form that coerces both null and
false from shell_exec()). Update SqlScriptsTest's null-return assertion
to match the new cast instead of the removed '?? ''.
* fix: address Copilot review - ownership IDs, fopen guards, mib_cache bound
- chown()/chgrp(): pass integer UID/GID from fileowner()/filegroup()
(guarding the false lookup) instead of string-casting them, which made
them resolve account/group names like '1001' and fail. Covers
lib/api_device.php, lib/boost.php and poller_maintenance.php (x2).
- fopen() failure now short-circuits instead of reporting success:
lib/package.php returns false, lib/clog_webapi.php and utilities.php
render an error, and snmpagent_mibcachechild.php skips the cache write
and sentinel unlink so a concurrent writer's lock is preserved.
- lib/mib_cache.php: keep the float quotient as the loop bound and cast
only the array offset, so a non-even entries/columns split no longer
truncates the loop and drops a cached row.
* revert: keep db_fetch_* returning false on error; baseline Level 8 instead
Per review, restoring the intentional fail-safe: db_fetch_row[_prepared]()
return bool|array and db_fetch_assoc[_prepared]() return mixed again, so a
genuine SQL error (not just a missing connection) is signalled as false and
the === false checks in cdef_is_in_use(), boost_process_* and aggregate.php
work as before. Dropped the is_array() ? : [] coercion.
Level 8 stays green by regenerating phpstan-baseline.neon to capture the
re-introduced bool|array/mixed call-site errors (the ~1,850 the narrowing
had eliminated). Tightening those callers to drop them from the baseline is
Phase 2 work.
---------
Co-authored-by: TheWitness <copilot@users.noreply.github.com>
196 lines
7.0 KiB
PHP
Executable File
196 lines
7.0 KiB
PHP
Executable File
#!/usr/bin/env php
|
|
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
| |
|
|
| This program is free software; you can redistribute it and/or |
|
|
| modify it under the terms of the GNU General Public License |
|
|
| as published by the Free Software Foundation; either version 2 |
|
|
| of the License, or (at your option) any later version. |
|
|
| |
|
|
| This program is distributed in the hope that it will be useful, |
|
|
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
| GNU General Public License for more details. |
|
|
+-------------------------------------------------------------------------+
|
|
| Cacti: The Complete RRDtool-based Graphing Solution |
|
|
+-------------------------------------------------------------------------+
|
|
| This code is designed, written, and maintained by the Cacti Group. See |
|
|
| about.php and/or the AUTHORS file for specific developer information. |
|
|
+-------------------------------------------------------------------------+
|
|
| http://www.cacti.net/ |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
error_reporting(0);
|
|
|
|
// get access to the database and open a session
|
|
include(__DIR__ . '/../include/cli_check.php');
|
|
|
|
global $cacti_db_session;
|
|
|
|
$user_logins_valid = 'U';
|
|
$user_logins_invalid = 'U';
|
|
$user_counter_active = 'U';
|
|
$user_counter_sleeping = 'U';
|
|
$session_counter_active = 'U';
|
|
$session_counter_sleeping = 'U';
|
|
$session_counter_garbage = 'U';
|
|
|
|
$active_interval = 600; // Ten minutes
|
|
|
|
// determine the number of invalid/valid user logins during the last poller interval
|
|
$user_logins_valid = db_fetch_cell("SELECT COUNT(*) AS user_logins
|
|
FROM user_log
|
|
WHERE UNIX_TIMESTAMP(`time`) BETWEEN UNIX_TIMESTAMP() - $active_interval AND UNIX_TIMESTAMP()
|
|
AND user_id > 0
|
|
AND `result` IN (1, 2)");
|
|
|
|
$user_logins_invalid = db_fetch_cell("SELECT COUNT(*) AS user_logins
|
|
FROM user_log
|
|
WHERE UNIX_TIMESTAMP(`time`) BETWEEN UNIX_TIMESTAMP() - $active_interval AND UNIX_TIMESTAMP()
|
|
AND user_id = 0
|
|
AND `result` IN (0, 3)");
|
|
|
|
$active_interval_end = time();
|
|
$active_interval_begin = $active_interval_end - $active_interval;
|
|
|
|
// determine the number of active/valid sessions during the last poller interval
|
|
if ($cacti_db_session == true) {
|
|
$session_counter_active = db_fetch_cell_prepared('SELECT count(*)
|
|
FROM sessions
|
|
WHERE access >= ?',
|
|
[$active_interval_begin]);
|
|
|
|
$session_counter_sleeping = db_fetch_cell_prepared('SELECT count(*)
|
|
FROM sessions
|
|
WHERE access < ?',
|
|
[$active_interval_begin]);
|
|
|
|
// These stats have little use when using the database session
|
|
$user_counter_active = $session_counter_active;
|
|
$user_counter_sleeping = $session_counter_sleeping;
|
|
|
|
// There is no garbage users when using database sessions
|
|
$session_counter_garbage = 0;
|
|
} else {
|
|
$session_save_path = get_session_save_path();
|
|
|
|
if (file_exists($session_save_path)) {
|
|
$session_dir_handle = opendir($session_save_path);
|
|
$session_maxlifetime = ini_get('session.gc_maxlifetime');
|
|
|
|
if ($session_dir_handle) {
|
|
$user_ids_active = [];
|
|
$user_ids_sleeping = [];
|
|
$session_counter_active = 0;
|
|
$session_counter_sleeping = 0;
|
|
$session_counter_garbage = 0;
|
|
|
|
while (false !== ($filename = readdir($session_dir_handle))) {
|
|
// a real user session should be greater than 400 Bytes
|
|
if (str_contains($filename, 'sess_') && filesize($session_save_path . '/' . $filename) > 400) {
|
|
$session = file_get_contents($session_save_path . '/' . $filename);
|
|
|
|
/* first off check if we are allowed to read the session
|
|
* file. Then we are only interested in sessions of
|
|
* authenticated Cacti users
|
|
*/
|
|
if ($session !== false && str_contains($session, 'cacti_cwd') && preg_match('/sess_user_id\|s:[0-9]*:\"[0-9]*\"/', $session, $match)) {
|
|
$session_user_id = substr($match[0], strpos($match[0], ':"') + 2, -1);
|
|
// due to the fact that ATIME could be unsupported/disabled we have to use MTIME instead
|
|
$mtime = filemtime($session_save_path . '/' . $filename);
|
|
|
|
/* determine active user sessions
|
|
* Sessions with a MTIME higher than the end of the
|
|
* poller interval have to be counted too or we
|
|
* won't see real active users.
|
|
*/
|
|
if ($mtime >= $active_interval_begin) {
|
|
// increase active session counter
|
|
$session_counter_active++;
|
|
|
|
// count all active users
|
|
if (false === ($key = array_search($session_user_id, $user_ids_active, true))) {
|
|
$user_ids_active[] = $session_user_id;
|
|
}
|
|
|
|
// if the same user has more than one session and this one is active then the user is not sleeping
|
|
if (false !== ($key = array_search($session_user_id, $user_ids_sleeping, true))) {
|
|
unset($user_ids_sleeping[$key]);
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
// determine user sessions which are sleeping
|
|
if ($mtime >= ($active_interval_begin - $session_maxlifetime) && $mtime < $active_interval_begin) {
|
|
// increase sleeping session counter
|
|
$session_counter_sleeping++;
|
|
|
|
// count all sleeping users if they have no active sessions
|
|
if (!in_array($session_user_id, $user_ids_active, true) && !in_array($session_user_id, $user_ids_sleeping, true)) {
|
|
$user_ids_sleeping[] = $session_user_id;
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
// count all user session declared as garbage
|
|
if ($mtime < ($active_interval_begin - $session_maxlifetime)) {
|
|
$session_counter_garbage++;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
$user_counter_active = cacti_count($user_ids_active);
|
|
$user_counter_sleeping = cacti_count($user_ids_sleeping);
|
|
|
|
// close directory handle and destroy this session
|
|
closedir($session_dir_handle);
|
|
}
|
|
}
|
|
|
|
if (session_id()) {
|
|
session_destroy();
|
|
}
|
|
}
|
|
|
|
print 'valid:' . $user_logins_valid .
|
|
' invalid:' . $user_logins_invalid .
|
|
' active:' . $session_counter_active .
|
|
' sleeping:' . $session_counter_sleeping .
|
|
' garbage:' . $session_counter_garbage .
|
|
' uactive:' . $user_counter_active .
|
|
' usleeping:' . $user_counter_sleeping;
|
|
|
|
function get_session_save_path() : mixed {
|
|
if (session_save_path() !== '') {
|
|
// if default temp path is not in use
|
|
return realpath((string) session_save_path());
|
|
}
|
|
|
|
if (function_exists('sys_get_temp_dir')) {
|
|
// this requires PHP > 5.2.1
|
|
return realpath(sys_get_temp_dir());
|
|
}
|
|
|
|
if ($temp = getenv('TMP') | $temp = getenv('TEMP') | $temp = getenv('TMPDIR')) {
|
|
// try to use environment variables
|
|
return $temp;
|
|
} else {
|
|
// try to create a temp file
|
|
$temp = tempnam(__FILE__,'');
|
|
|
|
if (file_exists($temp)) {
|
|
unlink($temp);
|
|
|
|
return dirname($temp);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
}
|