Files
cacti/scripts/unix_users.pl
7ca0582b3c Refactor Perl scripts with Code Quality findings (#6594)
* add perl syntax checking for scripts

* Update .github/workflows/syntax.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* only show syntax errors

* Add support for ss

Fixed shell injection risk from piped netstat | grep by removing shell pipelines.
Added use strict; use warnings; and localized variables.
Added runtime fallback to ss when netstat is unavailable, with a clear failure when neither exists.

* Fix shell injection risk

apply fixes (safe open, strict/warnings, key whitelist, error handling).

* Update query_unix_partitions.pl

* Update unix_users.pl

add use strict/warnings  to flag issues
add better error handling

* Update weatherbug.pl

* add better suport for gree bsd

* Update loadavg.pl

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2026-01-31 20:25:42 -05:00

27 lines
525 B
Perl

#!/usr/bin/env perl
use strict;
use warnings;
delete @ENV{qw(PATH)};
$ENV{PATH} = '/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/local/sbin';
my $grep_string = $ARGV[0] // '';
($grep_string) = $grep_string =~ /^([\w]+)$/ if $grep_string ne '';
chomp $grep_string;
open(my $process, '-|', 'who') or exit 1;
my $count = 0;
while (my $line = <$process>) {
chomp($line);
next unless $line =~ /:/;
if ($grep_string ne '') {
next unless $line =~ /$grep_string/;
}
$count++;
}
close($process);
print $count;