Files
cacti/tests/Unit/Database/DbStringFunctionsTest.php
Sean Mancini 96033267cb refactor(tests): reorganize unit tests into domain category folders (#7733)
* refactor(tests): reorganize unit tests into domain category folders

- Consolidate per-advisory GHSA regression tests into Security/ subfolders by vuln class
- Group all 186 test files into domain folders: DataCollection/, Ui/, Core/,
  Database/, Installer/, Scripts/, Security/, Plugin/
- Strip GitHub issue/GHSA numbers from filenames; keep IDs in test descriptions
- Fix all __DIR__ relative paths to match new folder nesting depth
- Update CI workflow path triggers and phpunit XML configs for new file locations
- Update .github/copilot-instructions.md with unit test organization guidelines
- Add tests/vendor/ to .gitignore

* add gaurds

* fix up guard for unit tests

* fix redeclaration of cacti_log in tests

* fix updates to unit tests

* fix test patjhs

* fix: update test __DIR__ paths for reorganized test structure

* fix: conditionally define read_user_setting to prevent redeclaration in tests

* fix: conditionally define functions to prevent redeclaration in tests

- Wrap clean_up_lines, raise_message, cacti_debug_backtrace, and get_debug_prefix
  with function_exists() checks to prevent conflicts when test stubs are loaded
  before lib/functions.php in the same PHP process

* fix: add unit test bootstrap to prevent function redeclaration errors

- Create tests/bootstrap-unit.php to load core libraries before tests
- Ensures lib/functions.php loads before test stubs define stub functions
- Test stubs use function_exists() checks, so they detect pre-loaded functions
- Update phpunit.xml to use bootstrap-unit.php for Unit testsuite
- Fixes 'Cannot redeclare read_user_setting()' errors when tests run in same process

* fix: load test stubs before global.php in unit test bootstrap

- Reorder bootstrap to load CactiStubs.php and UnitStubs.php first
- Ensures stub functions like __() are available when global.php loads
- global.php calls get_cacti_version_text() which needs __() for translations
- Fixes 'Call to undefined function __()' error during bootstrap

* fix: remove function conflicts from test stubs

- Remove stub definitions for functions already in lib/functions.php:
  cacti_sizeof, cacti_log, cacti_strtolower, read_config_option,
  read_user_setting, cacti_count
- Keep translation function stubs (__(), __esc()) needed by global.php
- Update bootstrap to load lib/functions.php after stubs
- This prevents function redeclaration errors while maintaining test isolation

* fix: prevent constant and variable redeclaration in bootstrap

- Remove explicit PHP_TESTING and CACTI_TEST_BOOTSTRAP defines from bootstrap
  (CactiStubs.php now handles this with guards)
- Add guards to CactiStubs.php to prevent redefinition of PHP_TESTING
- Only set CACTI_TEST_BOOTSTRAP env vars if not already set
- Fixes PHP warnings about 'Constant X already defined'

* fix: remove redundant lib/functions.php load from bootstrap

include/global.php already loads lib/functions.php at lines 287-288.
The bootstrap was trying to load it again after global.php, but global.php
needs format_cacti_version() to be available on lines 293-294 to define
CACTI_VERSION and CACTI_VERSION_FULL constants.

Solution: Let global.php handle loading lib/functions.php itself, and don't
load it separately in the bootstrap.

* fix: remove more conflicting function stubs from test helpers

- Remove stubs for functions also defined in lib/functions.php:
  raise_message, clean_up_lines, cacti_debug_backtrace, get_debug_prefix
- Remove POLLER_ID constant stub (defined unconditionally by global.php)
- Keep only translation functions and test-specific helpers
- This prevents function/constant redeclaration errors

* fix: minimize test stubs to only translation functions

Remove ALL helper functions and constants from UnitStubs.php that are:
- Defined in lib/functions.php (raise_message, clean_up_lines, etc.)
- Defined in lib/html_utility.php (srv, set_request_var)
- Defined in global_constants.php (POLLER_VERBOSITY_*, MESSAGE_LEVEL_*)
- Defined in global.php (POLLER_ID)

Keep ONLY translation functions (__(), __esc()) that are:
- Called by global.php during initialization
- Not defined elsewhere
- Required for proper bootstrap sequence

This eliminates all constant and function redeclaration errors.

* fix: remove __esc stub - already defined in global_languages.php

Keep only __() translation function stub, which is needed by global.php
and not defined elsewhere in Cacti core.

* fix: handle no-arg case in __() translation stub

The __() function may be called with just a string and no format arguments.
Previously, vsprintf() would fail with 'arguments array must contain 2 items'.
Now, if no args are provided, return the text as-is.
2026-08-16 19:23:31 -07:00

109 lines
4.2 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
*/
require_once dirname(__DIR__, 2) . '/Helpers/UnitStubs.php';
require_once dirname(__DIR__, 3) . '/include/vendor/autoload.php';
require_once dirname(__DIR__, 3) . '/lib/database.php';
it('builds an IN clause from a list of values', function () {
expect(array_to_sql_or([1, 2, 3], 'col'))
->toBe("(col IN('1','2','3'))");
});
it('pops a trailing null before building the IN clause', function () {
expect(array_to_sql_or([1, null], 'col'))
->toBe("(col IN('1'))");
});
it('returns empty string for an empty input array', function () {
expect(array_to_sql_or([], 'col'))->toBe('');
});
it('returns empty string when the only element is null', function () {
expect(array_to_sql_or([null], 'col'))->toBe('');
});
it('escapes embedded quotes and semicolons via db_qstr', function () {
// No live db_conn, so db_qstr falls back to its manual escape branch:
// single quote -> backslash + quote.
expect(array_to_sql_or(["O'Brien", 'a;b'], 'name'))
->toBe("(name IN('O\\'Brien','a;b'))");
});
it('returns NULL literal for a null argument', function () {
expect(db_qstr(null))->toBe('NULL');
});
it('quotes a plain string with single quotes', function () {
expect(db_qstr('plain'))->toBe("'plain'");
});
it('escapes a single quote with a backslash (no live conn)', function () {
// Byte-exact: 27 69 74 5C 27 73 27 = ' i t \ ' s '
$expected = chr(0x27) . 'it' . chr(0x5C) . chr(0x27) . 's' . chr(0x27);
expect(db_qstr("it's"))->toBe($expected);
});
it('doubles a backslash (no live conn)', function () {
// Byte-exact: 27 61 5C 5C 62 27 = ' a \ \ b '
$expected = chr(0x27) . 'a' . chr(0x5C) . chr(0x5C) . 'b' . chr(0x27);
expect(db_qstr("a\\b"))->toBe($expected);
});
it('escapes the NUL byte with a backslash (no live conn)', function () {
// Byte-exact: 27 61 5C 00 62 27 = ' a \ NUL b '
$expected = chr(0x27) . 'a' . chr(0x5C) . chr(0x00) . 'b' . chr(0x27);
expect(db_qstr("a\0b"))->toBe($expected);
});
it('delegates to PDO->quote when given a connection', function () {
$conn = new PDO('sqlite::memory:');
// SQLite quoting doubles single quotes rather than backslash-escaping.
expect(db_qstr("it's", $conn))->toBe("'it''s'");
});
it('strips a trailing run of semicolons', function () {
// db_strip_control_chars() = trim(clean_up_lines($sql), ';').
// Two clean_up_lines() implementations may be in scope depending on
// which sibling tests have already loaded lib/functions.php:
// * the unit stub (trim whitespace),
// * the production version (collapse CR/LF runs to a single space).
// Inputs without surrounding whitespace and without embedded newlines
// produce the same result under both, so we exercise that contract.
expect(db_strip_control_chars('SELECT 1;;;'))->toBe('SELECT 1');
});
it('wraps a bare column name in backticks', function () {
expect(db_format_index_create('col'))->toBe('`col`');
});
it('keeps an index expression that already ends in ) verbatim', function () {
expect(db_format_index_create('col(10)'))->toBe('col(10)');
});
it('formats an array of mixed bare and length-prefixed columns', function () {
expect(db_format_index_create(['a', 'b(5)', 'c']))->toBe('`a`,b(5),`c`');
});
it('trims whitespace around array entries before backtick-wrapping', function () {
expect(db_format_index_create([' a ']))->toBe('`a`');
});
it('strips surrounding whitespace and stray backticks from a string index', function () {
expect(db_format_index_create(' ` col ` '))->toBe('`col`');
});