mirror of
https://github.com/Cacti/cacti.git
synced 2026-10-24 03:57:32 +09:00
* refactor(tests): reorganize unit tests into domain category folders - Consolidate per-advisory GHSA regression tests into Security/ subfolders by vuln class - Group all 186 test files into domain folders: DataCollection/, Ui/, Core/, Database/, Installer/, Scripts/, Security/, Plugin/ - Strip GitHub issue/GHSA numbers from filenames; keep IDs in test descriptions - Fix all __DIR__ relative paths to match new folder nesting depth - Update CI workflow path triggers and phpunit XML configs for new file locations - Update .github/copilot-instructions.md with unit test organization guidelines - Add tests/vendor/ to .gitignore * add gaurds * fix up guard for unit tests * fix redeclaration of cacti_log in tests * fix updates to unit tests * fix test patjhs * fix: update test __DIR__ paths for reorganized test structure * fix: conditionally define read_user_setting to prevent redeclaration in tests * fix: conditionally define functions to prevent redeclaration in tests - Wrap clean_up_lines, raise_message, cacti_debug_backtrace, and get_debug_prefix with function_exists() checks to prevent conflicts when test stubs are loaded before lib/functions.php in the same PHP process * fix: add unit test bootstrap to prevent function redeclaration errors - Create tests/bootstrap-unit.php to load core libraries before tests - Ensures lib/functions.php loads before test stubs define stub functions - Test stubs use function_exists() checks, so they detect pre-loaded functions - Update phpunit.xml to use bootstrap-unit.php for Unit testsuite - Fixes 'Cannot redeclare read_user_setting()' errors when tests run in same process * fix: load test stubs before global.php in unit test bootstrap - Reorder bootstrap to load CactiStubs.php and UnitStubs.php first - Ensures stub functions like __() are available when global.php loads - global.php calls get_cacti_version_text() which needs __() for translations - Fixes 'Call to undefined function __()' error during bootstrap * fix: remove function conflicts from test stubs - Remove stub definitions for functions already in lib/functions.php: cacti_sizeof, cacti_log, cacti_strtolower, read_config_option, read_user_setting, cacti_count - Keep translation function stubs (__(), __esc()) needed by global.php - Update bootstrap to load lib/functions.php after stubs - This prevents function redeclaration errors while maintaining test isolation * fix: prevent constant and variable redeclaration in bootstrap - Remove explicit PHP_TESTING and CACTI_TEST_BOOTSTRAP defines from bootstrap (CactiStubs.php now handles this with guards) - Add guards to CactiStubs.php to prevent redefinition of PHP_TESTING - Only set CACTI_TEST_BOOTSTRAP env vars if not already set - Fixes PHP warnings about 'Constant X already defined' * fix: remove redundant lib/functions.php load from bootstrap include/global.php already loads lib/functions.php at lines 287-288. The bootstrap was trying to load it again after global.php, but global.php needs format_cacti_version() to be available on lines 293-294 to define CACTI_VERSION and CACTI_VERSION_FULL constants. Solution: Let global.php handle loading lib/functions.php itself, and don't load it separately in the bootstrap. * fix: remove more conflicting function stubs from test helpers - Remove stubs for functions also defined in lib/functions.php: raise_message, clean_up_lines, cacti_debug_backtrace, get_debug_prefix - Remove POLLER_ID constant stub (defined unconditionally by global.php) - Keep only translation functions and test-specific helpers - This prevents function/constant redeclaration errors * fix: minimize test stubs to only translation functions Remove ALL helper functions and constants from UnitStubs.php that are: - Defined in lib/functions.php (raise_message, clean_up_lines, etc.) - Defined in lib/html_utility.php (srv, set_request_var) - Defined in global_constants.php (POLLER_VERBOSITY_*, MESSAGE_LEVEL_*) - Defined in global.php (POLLER_ID) Keep ONLY translation functions (__(), __esc()) that are: - Called by global.php during initialization - Not defined elsewhere - Required for proper bootstrap sequence This eliminates all constant and function redeclaration errors. * fix: remove __esc stub - already defined in global_languages.php Keep only __() translation function stub, which is needed by global.php and not defined elsewhere in Cacti core. * fix: handle no-arg case in __() translation stub The __() function may be called with just a string and no format arguments. Previously, vsprintf() would fail with 'arguments array must contain 2 items'. Now, if no args are provided, return the text as-is.
87 lines
4.2 KiB
PHP
87 lines
4.2 KiB
PHP
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
| |
|
|
| This program is free software; you can redistribute it and/or |
|
|
| modify it under the terms of the GNU General Public License |
|
|
| as published by the Free Software Foundation; either version 2 |
|
|
| of the License, or (at your option) any later version. |
|
|
+-------------------------------------------------------------------------+
|
|
| Cacti: The Complete RRDtool-based Graphing Solution |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
/*
|
|
* Tests for the vendor boot guard and installer refresh (#6456).
|
|
*
|
|
* A Git checkout has no include/vendor, and global.php previously died
|
|
* with a bare autoload fatal. The guard prints the composer command and
|
|
* exits before any database work. The installer additionally repairs a
|
|
* vendor tree that composer reports as purely missing packages.
|
|
*/
|
|
|
|
test('global.php guards the autoload require with instructions', function () {
|
|
$src = file_get_contents(__DIR__ . '/../../../include/global.php');
|
|
expect($src)->not->toBeFalse('Failed to read include/global.php');
|
|
|
|
// The path is now computed once into $vendor_autoload and reused by both
|
|
// the fatal-exit guard and the require below, rather than being spelled
|
|
// out inline at each call site.
|
|
$pathPos = strpos($src, "\$vendor_autoload = CACTI_PATH_INCLUDE . '/vendor/autoload.php';");
|
|
expect($pathPos)->not->toBeFalse('vendor autoload path must be computed');
|
|
|
|
$guardPos = strpos($src, "if (!is_file(\$vendor_autoload) && !defined('IN_CACTI_INSTALL'))");
|
|
expect($guardPos)->not->toBeFalse('vendor guard must exist')
|
|
->and($pathPos)->toBeLessThan($guardPos, 'path must be computed before the guard checks it');
|
|
|
|
$requirePos = strpos($src, 'require_once($vendor_autoload);');
|
|
expect($requirePos)->not->toBeFalse('autoload require must exist')
|
|
->and($guardPos)->toBeLessThan($requirePos, 'guard must run before the require');
|
|
|
|
// The require itself stays wrapped in its own is_file() check so the
|
|
// installer's IN_CACTI_INSTALL path (where vendor may legitimately not
|
|
// exist yet) never reaches a bare require() fatal either.
|
|
$requireGuardPos = strpos($src, 'if (is_file($vendor_autoload)) {');
|
|
expect($requireGuardPos)->not->toBeFalse('require must itself be guarded')
|
|
->and($requireGuardPos)->toBeLessThan($requirePos, 'require guard must precede the require');
|
|
|
|
$dbPos = strpos($src, 'db_connect_real(');
|
|
expect($dbPos)->not->toBeFalse('db connect must exist')
|
|
->and($guardPos)->toBeLessThan($dbPos, 'guard must run before any database work');
|
|
|
|
$block = substr($src, $guardPos, 800);
|
|
expect(strpos($block, 'composer install'))->not->toBeFalse('guard must name the composer command');
|
|
});
|
|
|
|
test('composer dry-run summary parsing gates the refresh correctly', function () {
|
|
$parse = function (string $check): string {
|
|
if (str_contains($check, 'Nothing to install, update or remove')) {
|
|
return 'current';
|
|
}
|
|
|
|
if (!preg_match('/Package operations: (\d+) installs?, (\d+) updates?, (\d+) removals?/', $check, $ops)) {
|
|
return 'indeterminate';
|
|
}
|
|
|
|
if ($ops[1] == 0 || $ops[2] > 0 || $ops[3] > 0) {
|
|
return 'skewed';
|
|
}
|
|
|
|
return 'repair';
|
|
};
|
|
|
|
// pristine packaged release
|
|
expect($parse('Nothing to install, update or remove'))->toBe('current');
|
|
// git checkout without vendor: observed in the docker run for this change
|
|
expect($parse('Package operations: 115 installs, 0 updates, 0 removals'))->toBe('repair');
|
|
// committed tree behind the lock file: not the installer's business
|
|
expect($parse('Package operations: 1 install, 21 updates, 0 removals'))->toBe('skewed');
|
|
expect($parse('Package operations: 0 installs, 6 updates, 79 removals'))->toBe('skewed');
|
|
// composer itself failed (missing extensions, network, bad json)
|
|
expect($parse('Your requirements could not be resolved to an installable set of packages.'))->toBe('indeterminate');
|
|
expect($parse(''))->toBe('indeterminate');
|
|
// singular forms
|
|
expect($parse('Package operations: 1 install, 0 updates, 0 removals'))->toBe('repair');
|
|
});
|